polom
 New Forum Posts: RSS Feeds - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=40984
 New Forum Posts: Calendar events listed as AM/PM, not 24 hour format? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=40985
tikiwiki: 03jonnybradley * r33794 10/trunk/ (29 files in 14 dirs): [MRG] Automatic merge, branches/7.x 33763 to 33793
polom
polom we are in an empty roooommmm (echoes :) ) 
tikiwiki: 03lindonb * r33795 10/branches/7.x/ (4 files in 3 dirs): 
tikiwiki: [FIX] Add wrapper div for smoother animation
tikiwiki: [ENH] Add arrow to indicate show/hid status and allow to set show/hide speeds
hi redflo
hi
redflo: the LDAP check for space was quietly removed in r31339: http://sourceforge.net/apps/trac/tikiwiki/changeset/31339/trunk/lib/auth/ldap.php
for Tiki 7. do you see problems this could cause?
probably check was useful for other ldap settings
dont know if a ldap attribute may contain a space
a ldap value surely may have spaces
brb
yeah
hi,
I misspelled a word in a commit comment, can this be corrected somehow?
tikiwiki: 03ripero * r33796 10/branches/7.x/ (. lib/tikilib.php): 
tikiwiki: [bp/r33677][FIX] Function check_rules corrected:
tikiwiki: * Banning by IP was broken, IP is now split into bytes before the comparisons.
tikiwiki: * Minor change: space added between the colon and the section name in the ban message.
tikiwiki: [bp/33681][FIX] Call to php function split, introduced in function check_rules at r33677, has been replaced by a call to php function explode (split deprecated in php 5.3). Thanks pkdille.
chealer: i think the check was good for the attributes, but i think it was not really necessary. If someone puts invalid attribute names there he will get errors - and it does not matter if the attribute name is invalid because of spaces or from y typo ...
ripero: no
redflo: right. so would you oppose to removing that check in the 6.x branch too?
redflo: I think also DNs can contain spaces, for example groupdn
redflo: it looks like attributes can't contain spaces, but I think quietly ignoring the value doesn't help
chealer: i think removing the check is save
redflo: thank you
chealer: np
tikiwiki: 03lindonb * r33797 10/branches/7.x/lib/wiki-plugins/wikiplugin_fade.php: Leftover unused jquery variable
chealer: sorry, but the "no" refers to the question about the misspell or to the validity of the backport commit?
ripero: I was answering your question
chealer: ok, thank you :)
tikiwiki: 03chealer * r33798 10/branches/proposals/6.x/lib/auth/ldap.php: 
tikiwiki: [FIX] LDAP: Do not ignore value of options with space. Fixes attempts to login with a password with spaces trying the empty string as a password
tikiwiki: Some options shouln't contain spaces, but quietly ignoring them can't help
tikiwiki: Ref: http://article.gmane.org/gmane.comp.cms.tiki.cvs/64174
tikiwiki: http://irc.tiki.org/irclogger_log/tikiwiki?date=2011-04-03,Sun&sel=194#l190
tikiwiki: quietly done on trunk in r31339
tikiwiki: 03ripero * r33799 10/branches/proposals/6.x/ (4 files in 3 dirs): 
tikiwiki: [bp/r33677][FIX] Function check_rules corrected:
tikiwiki: * Banning by IP was broken, IP is now split into bytes before the comparisons.
tikiwiki: * Minor change: space added between the colon and the section name in the ban message.
tikiwiki: [bp/r33681][FIX] Call to php function split, introduced in function check_rules at r33677, has been replaced by a call to php function explode (split deprecated in php 5.3). Thanks pkdille.