nkoth: what was the case - my case is broken now.... this function is really messy
sylvieg: pretty much standard trunk
this is the bindvars thing in filegallib right?
sylvieg: maybe the solution is to make a g_bindvars
what is your case, I will try and reproduce
tikiwiki: 03nkoth * r35575 10/trunk/lib/core/Tracker/Field/Rating.php: [FIX] Change from * to STARS for internal field reference because * causes js error as * cannot be used as part of class name etc...
humm .. I tried about 4 cases ... suppose I missed the one
the solution is to rewrite this function - but without tests it is hard :-(
the error is you do not do one ? with 2 bindvars
sylvieg: if I put back that line, I get error simply by going to tiki-list_file_gallery.php
i did not but .. I did not test on a fresh install
but you are right - my commit was a trick on a trick...
better to roll back and to kill the pb at the source
New Forum Posts: NO REPLY please - temporary threat to move an off-topic - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=41833
tikiwiki: 03nkoth * r35576 10/trunk/lib/trackers/trackerlib.php: [FIX] Correct typo before it causes anything bad. Right now the vars don't seem to be used after defined so should be no problem
tikiwiki: 03nkoth * r35577 10/trunk/lib/core/Tracker/Definition.php: [DOC] add useful comment
tikiwiki: 03nkoth * r35578 10/trunk/lib/core/Services/Tracker/Controller.php: [FIX] Allow 0 or empty string values in multiple entry options, as previously they get filtered off
tikiwiki: 03kstingel * r35579 10/trunk/templates/edit_file_gallery.tpl: [FIX] line 275 was "
"
tikiwiki: 03nkoth * r35580 10/trunk/ (4 files in 4 dirs): [ENH][FIX] Improve Stars field to support ratings of radio button type as well, and fix some bugs with the stars field at the same time
tikiwiki: 03nkoth * r35581 10/trunk/lib/wiki-plugins/wikiplugin_trackerlist.php: [FIX] Make trackerlist plugin support new internal field name for improved stars field
tikiwiki: 03nkoth * r35582 10/trunk/templates/tiki-admin_trackers.tpl: [DOC] Mark old feature as deprecated TODO: consider removing option...
hello
anyone can give me some way of search , to find from where comes my problem
i have blanck screen/error 500 when i create new things in tikiwiki 7.0
setup.sh was run
New Forum Posts: tracker: validation parameter for regex - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41835
tikiwiki: 03sylvieg * r35583 10/trunk/ (2 files in 2 dirs): [ENH]FILES: allow use of FILES and thumbnail in newsletters with absolute url
thaaz: just an idea - try to desactivate any search feature to see if the same
sylvieg: ok, i will try
the page tiki-list_file_gallery.php stop on line $fgid=$filegallib->replace_file_gallery($gal_info);
near line 510
when i try to validate a new gallery
Hi - try to use tiki in a subfolder with a subdomain. when I enter the subfolder all is fine - when i enter the subdomain i get an server error - any idea? Thanks!
subdomain is going to "/subfolder"
and the error is: Not found "subfolder/tiki-index.php" ????
franki: what says apache log ?
@thaaz: its a shared host - how to see it?
franki: i dont know,
:-)
i use my own server
@franki : if it's a shared host, as in a hosted provider solution, there should be a control panel or a webpanel provided for your hosting.
these usually contain an overview or a link to the apache log files
Beestje_: i will see .... thanks
Beestje_: its confixx and i cant found it ..?
can you use the confixx panel to access the folders on the webserver?
ok - there is at the Custom-Account "php-ini and there I can switch "Error-log" ON - hmmm
Beestje_: yes I can access the folders via confixx
found this post : http://serversupportforum.de/forum/confixx/29461-confixx-error-apache-log.html
aber mein Deutsch ist nicht so güt ;-)
I have a problem with my trackers after upgrading from 3.3 to 6.3, the items are all in the database. When I list the trackers it shows that it contains items, but when showing the items in a tracker, nothing is shown (0 records)
aber mein ist prima ;-) Ich habe nun auch noch confixx - Httpd Spezial - WebServer error log auf ON geschaltet - mal schaun wo das nun steht
Beestje_: did you upgrade the database too?
yep, all went fine
are the tracker IDs clear?
i ran the tiki-install.php without any issues
meaning? i see the tracker items in tiki_trk_4
how did you view the tracker items?
do you
in the database through phpmyadmin, i clicked on admin / trackers / list trackers and then click the tracker that i want to see the items of
View this trackers's items shows Items found: 0
"the items are all in the database" <--- sorry im confused now
can you see an individual item?
i don't have a direct link to a specific tracker item, i'll try to figure one out
in the database, you can find an itemId in tiki_tracker_items
and then type tiki-view_tracker_item.php?itemId=xxx
at my problem: Now I get "You don't have permission to access /Start/ on this server."
Start is the name for tiki-index.php
franki: did you setup.php on the folder to have the roght perms - readable server...?
hmm
tikiwiki: 03jyhem * r35584 10/trunk/installer/tiki-installer.php: [ENH] Make translations more manageable.
sylvieg: setup.php ? where is it?
whem i enter the subfolder directly all is fine
when
inthe tiki root
can be access via shell or via tiki-install.php
nope, you mean setup-sh?
i entered the subfolder inside the .htaccess
its just the subdomain - with the problem
@sylvieg : no. The fields show up but they don't contain data
Beestje_: do you have a backup before upgrading?
yeah, off course :-)
try to realod the tracker databases only
i updated to 7.0 first, but as i didn't have any tracker items as well, i restored the 3.3 version (trackers worked) and updated to 6.3 to see if that solved the issue
i think the tracker databases where overwritten so you can try to overwrite ONLY THEM from you sql dump?
Beestje_: as admin same problem? to check if it is a perm problem
@sylvieg : same problem : view item shows all the proper fields but no data next to it
looking in tracker 4 tiki_trk_4, the item does contain data
I got from the error-log now "Directory index forbidden by Options directive: pathxxx" - how to solve that? Thanks!
tikiwiki: 03jyhem * r35585 10/branches/experimental/annotate/ (35 files in 18 dirs): [MRG] Automatic merge, trunk 35561 to 35584
franki: hi. try editing your .htaccess file in the tiki installation at the subfolder, and uncomment de line about DocumentBase or similar....
i got it (for my problem)
franki, where it says something like:
RewriteBase "/tiki"
make it like: RewriteBase "/subfolder"
it missed package zend search lucene
Beestje_: ensure that you were not using "trackers as mirror tables" (obsolete feature, no longer supported in Tiki 6+, and probably earlier)
in your tiki3 installation
xavi: ok, thanks, i will see ....
Beestje_: tiki_trk_4 is the syntax of mysql tables written by trackers as mirror tables
and they are not supported
if you confirmed that this is the source of your issue, then, workaround is:
xavi: it is right - and when i enter the subfolder every thing runs fine - just when i enter the subdomain i have problems
export your tracker and your tracker data from the tiki 3.3 interface (not through phpmyadmin or similar), and then, after installing a blank tiki7 (or 6), import that tracker and data there in your new tiki from the tiki tracker interface also
franki: url's?
urls, I mean
ist a private site - sorry
its
sorry, then :-)
:-)
no more ideas from a kind-of-blind person, then :-)
@xavi : thanks! I indeed had mirror tables set up because the export function was not working properly in some earlier version i used and i needed to export the data from these trackers
franki: have a look at the rewrite rules (it looks like an issue with your rewrite rules from your non-standard installation of subfolders and subdomains, it seems)
franki: you can have a look at the doc page for manual multitiki installation
Beestje_: ok, follow advice, then :-)
hmm, ok, thanks
Beestje_: I know that feeling (I did the same years ago in one site with mirror tables for trackers)
cu xavi
Thanks again xavi! but i'll only :-) when it works ;-)
he he, I know that feeling also, Beestje_ :-)
franki: see this (for tips on custom local.php when using subfolders):
http://doc.tiki.org/MultiTiki+Manual+Installation
and this, for custom rewrite rules fro subfolders:
http://doc.tiki.org/Clean+URLs#Rewrite_Rules_for_MultiTiki_using_Subdirectories_as_Symlinks
hth
thanks a lot
welcome
sylvieg, did you read my messages on this channel yesterday about the issue I still have with batch send newsletters (based on a cron job)?
the content is not sent, but just almost blank email messages to the subscribers of the newsletter
however, in tiki, the new edition is created, with the content that in theory should have been sent in the email
so seems as if the email template misses to fetch teh content from the edition of the newsletter which is being resent
hi everyone
i have a question about using AD integration with tiki, if someones around? ^^
Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you!
Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you!
it's about using a special user for authentication, rather than binding the user directly - is it supported in tiki?
anonymous binding?
xavi o
no
xavi: empty email?
it is probably perms problem ....
yes, only the last line with unsubscribe info
ah...
what is the content of your newsletter?
I run that batch send newsletter with a wget command from the server
module and plugin? are anonymous able to see?
hold on... I 'll test...
in the mean time: http://irc.tiki.org/irclogger_log/tikiwiki?date=2011-07-21,Thu&sel=103#l99 (that's where I wrote a few lines for you yesterday)
is tiki-batch_sendnewsletter.php working in a browser?
content of newsletter is not a wiki page template, but content saved for that edition
http://intercanvis.net/tiki-send_newsletters.php?nlId=2&editionId=6
and it's not viewable by anons
content is something like the content in this page (viewable by anons):
http://intercanvis.net/Plantilla+Butlleti
"tiki-batch_sendnewsletter.php working in a browser?": well, I succeded to run the cron from a "wget"-type of command in the server (from the cpanel-like interface)
after editing the tiki-batch_sendnewsletter.php to cinlude the editionId as a hardcoded param inside
sorry I clocked this for security purpose...
because if pasing the editionId as an argument of that wget call, then I get error code from the cron
"clocked this"? what do you mean by "this"?
locked
this?
as I said, the email is sent (using the security controls that I took from "daily report"
control of ip of the called which has to be the ip of the server, and called locally
forget for a second the security thing (which I thing is under control using the same approach as with "daily reports"). I wonder why the content of the newsletter is not sent
sylvieg: not anonymous, as i understod, things now work in a way that php code tries to authenticate the tiki user by binding to AD/LDAP with his username/password?
Sylvie: this controls who is calling the php file:
if ( 'ip.number.comes.here' != $tikilib->get_ip_address() ) { die("This script can only be called by the server!"); }
bye
tikiwiki: 03jyhem * r35586 10/branches/7.x/modules/mod-func-months_links.php: [ENH] Memory savings: Don't load unused libraries
nkoth: ?
hi sylvieg
nkoth: I do not undersatnd the generateTxtVersion in nllib in tiki7
the function is defined in tiki-sedn_)newsletters - not in the lib
tikiwiki: 03sylvieg * r35587 10/branches/7.x/tiki-batch_send_newsletter.php: [FIX]newsletter: fix batch since the throttle add-on
sylvieg: The purpose of generateTxtVersion is to process the clipping to replace the HTML with some basic formatting (line break etc) that would fit a non-html email
yes but I do not understand why the function is decalred in tiki-send_newsletters and not in the lib as it is used in both
there is code duplication I do not uinderstand between send function and tiki-send_)newsletters
as for why it's not in the lib, probably just laziness when first written
As for the tiki-send_newsletters vs send
I think nllib->send is only the last part
sylvieg: I think the generateTxtVersion inside nllib->get_edition_mail was a later attempt to add the article clipping to sending of editions, when the article clipping when it was first written only was for the use case of clipping when at tiki-send_newsletters.php
tikiwiki: 03jyhem * r35588 10/branches/proposals/6.x/modules/mod-func-months_links.php: [bp/r35586] [ENH] Memory savings: Don't load unused libraries
tikiwiki: 03sylvieg * r35589 10/branches/proposals/6.x/lib/newsletters/nllib.php: [bp/r33224 partiel]newsletter: to have have the batch send sending a body
thanks Jyhem or Jyhem_laptop!
(whoever committed that change!)
nkoth: If I do the fix - can you test on 7. I do not have a test suite
because of the global $parsed .. not sure
I am not setup to send newsletters on tiki 7 right now (they are all tiki 6)
the bug exists also in 6
I think Bernard might have some newsletter sending...
I confirm the issue with batch send newsletter is solved with the last fix from sylvieg on proposals/6x
(I don't have any tiki7 setup with newsletters, sorry)
nor with anything
thanks sylvieg and nkoth for feedback on newsletters and fixing this issue
see you
tikiwiki: 03sylvieg * r35590 10/branches/7.x/ (lib/newsletters/nllib.php tiki-send_newsletters.php): [FIX]newsletter: move function clip as called also in nllib. TODO: check that the optim is still effitient without the global
sylvieg?
Too warm to do anything, I'll just kill code today
tikiwiki: 03marclaporte * r35591 10/branches/6.x/db/tiki-secdb_6.3_mysql.sql: cleanup
anyone?
adl: it does bind with the authenticating user
thanks :)
well, in our environment that's a big problem, because if a user uses a wrong password several times in a row, AD treats that the same way it would treat a windows login, and it locks up the persons account, disables proxy access, etc...
i was wondering would it be possible to setup - to use 1 universal user for all binding, who would retrieve the users password from AD and then compare it
we would setup that user in AD so it can't be locked, password doesn't expire, etc...
sort of an... agent?
adl: AFAIK that's not supported
chealer: yeah, but maybe it's just a few modified lines in a certain php files that make a difference? :)
should i go with this to the dev's list?
tikiwiki: 03nkoth * r35592 10/trunk/lib/wiki-plugins/wikiplugin_button.php: [ENH] Add css class param to button plugin
Hi, please where I can found which informations about users can be (are by default) stored into a LDAP Db ? Are they all users informations and more prefs ? Only identification for login ? It is not yet clear for me.
tikiwiki: 03nkoth * r35593 10/trunk/ (5 files in 3 dirs): [NEW] Wikiplugins for commenting and setting items as user favorite
tikiwiki: 03chealer * r35595 10/branches/7.x/templates/edit_file_gallery.tpl: [bp/r35579][FIX] Edit Gallery: broken display in Display Properties tab
tikiwiki: 03chealer * r35596 10/branches/proposals/6.x/templates/edit_file_gallery.tpl: [bp/r35595][FIX] Edit Gallery: broken display in Display Properties tab
I'm running 5.3 and for some reason when I am logged in as admin, the internal link editor won't load when I edit content - anything I can check?
also, is there a migration path from 5.3 to 6.4 or is it a clean install and link/upgrade the db?
New Forum Posts: Best way to insert a social networking button - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41838
xyz: Tiki 5 is no longer supported. did you see http://doc.tiki.org/Upgrade ?
Yep - okay - what version are you running?
is 7 a vast improvement over 6.4?
yes, but still a little buggy
6.4 is LTS so you can stay on 6.x until Tiki10 is released
tikiwiki: 03chealer * r35597 10/branches/7.x/installer/schema/ (2 files): [FIX] avoid error when cleaning up tiki_sefurl_regex_out UNIQUE INDEX left mess when INDEX doesn't exist
tikiwiki: 03chealer * r35598 10/branches/7.x/installer/schema/20110610_readd_sefurl_index_left_tiki.php: fix Id
Thanks
tikiwiki: 03chealer * r35599 10/branches/proposals/6.x/installer/schema/ (2 files): [bp/r35597][FIX] avoid error when cleaning up tiki_sefurl_regex_out UNIQUE INDEX left mess when INDEX doesn't exist
is there an option for the highlighter
does not work anymore in trunk for me
text wrapping is not working in a plugin call
tikiwiki: 03sylvieg * r35600 10/branches/7.x/tiki-batch_send_newsletter.php: oops: fix 35587
tikiwiki: 03nkoth * r35601 10/trunk/templates/wiki-plugins/wikiplugin_favorite.tpl: [FIX] object ID not set
tikiwiki: 03nkoth * r35602 10/trunk/lib/jquery_tiki/tiki-jquery.js: [ENH] Toggle additional css class of surrounding div for additional customization
hi, I just noticed JSON.stringify does not work in IE7
some people suggest including an external lib to solve this.
any comments?
I thought it was already included, but yes, there is a lib for that
anyone knows how to only include a js in tiki if IE7 or older?
some comment block? I think we already have some of those
actually in this case I might be better off testing for existence of JSON.stringify or something
well, you kind of need to do it in js
problem is only in IE6&7 and Safari 3.2 according to caniuse.com
oh, and ios 3.2
tikiwiki: 03nkoth * r35603 10/trunk/ (lib/jquery_tiki/json2.js tiki-setup.php): [FIX][NEW] Add json library to support JSON.stringify and JSON.parse in IE7, otherwise javascript errors when these are used
is anyone currently active in here?
trying to stay as inactive as possible with the heat
lol, you only need to reply with 2 or 3 keystrokes ;) ....
kstingel: Hello. btw, did you see my email regaring the fix in tiki-quiz_edit.php?
has Tiki 7x been rested for HTML5 compliance?
oops ... tested
kstingel: we're actively trying to remain inactive
tikiwiki: 03sylvieg * r35604 10/trunk/lib/filegals/filegallib.php: [FIX]FGAL: allow recursive on multiple galleryId
tested is a big word
nkoth: the one asking me to accept emails?
kstingel: that was mine
in Aptana, I'm seeing a heap of warnings for depreciated CSS
you mean moz- prefixes and such?
chealer: I thought so, but that's the only one I've seen recently (in past 2 days) ... rest are archived, I haven't checked yet
nope, it keeps balking at the use of "bgcolor"
ah, that's not deprecated, that's always been false
'background' is the real property
kstingel: hardly tested. this is the commit that changed to "HTML5": https://sourceforge.net/apps/trac/tikiwiki/changeset/31122
chealer, there is more to HTML5 than the doctype
kstingel: the DOCTYTPE was changed, but all changes needed to adapt were left for later
quite a few html5 elements are in use
kstingel: so you will definitely find hundreds/thousands of compliance issues
(and we already had a limited HTML compliance before)
I'm playing with a rewrite to compliant templates, I was just wondering if there was a group already working on it ... most of the issues are just basic stuff ... "suggest use of CSS instead" seems to come up a lot
really depends what you're shooting for, html5 is quite wide
if you just mean in terms of new elements like section, aside and such, it's hard to do in a generic way because it all depends a lot on how you use tiki and randomly using semantic elements for the sake of it is a nonsense
not really shooting for anything, just getting used to HTML5 vs HTML4.01 ... so I'm playing with Tiki :)
new elements generically is easy ... just add "html5.css" and set some defaults there
so what are you trying to do?
I'm having fun trying to come up with workarounds for less supportive browsers ... switching CSS dependant on compliancy
sorry to disturv kstingel, but the time limit for a quiz should be floor(ini_get('session.gc_maxlifetime') / 60) rather than ini_get('max_execution_time') right? (trunk/tiki-quiz_edit.php)
(I was going to change it but thought I should check with you 1st since you are using the feature
ini_get('max_execution_time') defaults to 30 (seconds) unless php.ini has been modified, so division by 60 would break it wouldn't it?
but quiz limit is in minutes isn't it?
nkoth: I need back the line you rollback yesterday ..... is was a fresh tiki instal?
besides I was thinking kstingel that you were wanting to get the session life time, rather than the execution time?
sylvieg: not fresh, it had one file gallery
not sure, I just added the quick fix to get the max_execution_time I haven't used quizzes yet
changi had the problem too
maybe you can put back the line, I can try and fix it someother way
that function seems funny to me anyway
tikiwiki: 03lphuberdeau * r35605 10/trunk/ (6 files in 3 dirs): [KIL] Staging leftovers
tikiwiki: 03robertplummer * r35606 10/trunk/lib/codemirror_tiki/mode/tikiwiki/ (index.html tikiwiki.css tikiwiki.js): [FIX] Fixes to the tikiwiki codemirror mode
sylvieg: 1 file gallery with categories on
roll back to before my initial edit ... last edit on that page only changed "FIXME" to "FIXED" so it stopped appearing in my todo list ....
I don't know how to do a rollback yet
kstingel: do you svn from within Aptana?
yes
nkoth: is it easy to test for you?
if I commit the same line but wuith an additional test
once I ut back the line I have fatal error always when going to the file gallery
if (is_array($galleryId) && $with_subgals) $bindvars = array_merge($bindvars, $galleryId);
so it is I suppose "easy to test"
will serve my case
galleryId as array et no subgals
oh I see
worth a try
it's like plating pass the parcel
s/plating/playing
tikiwiki: 03sylvieg * r35607 10/trunk/lib/filegals/filegallib.php: [FIX?]fgal: to have galleryId as array- second try to 35574 =- 35533
I tried to clean up the code - but can have it run for the 8 test I have now
thre is a lot of assumption - like if you do not ask with subgals .. you can not have parentname ... I do not see why?
the assumption too I took away if galleryid = array no recursivity
[sylvieg:] I have a SQL error on trunk: http://ido.ath.cx:8080/tiki/trunk/tiki-list_file_gallery.php
noticed this morning
did you do a svn up
because nelson fixed it - and I try to fix it back
sylvieg: yes, I'm on r35607
why do I niot have this case
tikiwiki: 03nkoth * r35608 10/trunk/tiki-quiz_edit.php: [ROLLBACK] rollback r35404 and 35530 because max_execution_time does not seem right, this is not the session timeout... Besides, isn't limit in minutes?
kstingel: ^, in Aptana, I use Team...Show History, and then select the revision I want to rollback to, then right click "Get Contents", then just commit again.
I am having an issue with WYSIWYG where heading one comes out 14pt, smaller than the subsequent headings. Any ideas on how you could change that?
thx chealer - was the wroing place
nkoth: thanks, will add that to my "how to ... " file (am an SVN newbie too)
tikiwiki: 03sylvieg * r35609 10/trunk/lib/filegals/filegallib.php: [FIX] another one to 35607
sylvieg: I get back the error.
chealer: can you try again
:-)
my bindvars are repeated, 1, 4, 1, 4
when visiting the Themes site, it states that templates are still being upgraded to t7 ... does that mean most of them are still @ t6x readiness?
sylvieg: with pleasure - but apparently no improvement
.. I did not do the test with with_files = true - perhaps it is the pb...
sorry about that and thx for your patience
sylvieg: yeah, no improvement on r35609
with files is true for me.
sylvieg, hoe many file gallery you have?
maybe that s the difference
sylvieg: still not working for filegal
i still have the sql error with double bindvars
changi: how many file gals you have?
2
public and private
with 1 file in each
list_file_gallery.php show an sql error
ok I think I got sylvies case now. multiple file gallerues, searching for sub objects
nkoth: if you have a patch i can test it
sorry, false alarm
:-() I have the error finally
maybe just check if $galleryId is equal to $bindvars
array_unique(array_merge($bindvars, $galleryId))
it's working for me
that is bound to give random effects
lphuberdeau: yes :)
for community tests, should I install a trunk checkout to a public location? (my testing server isn't accessible to the internet - my ISP doesn't permit it)
sylvieg: maybe using array_diff instead ?
array_merge($bindvars, array_diff($galleryId,$bindvars));
kstingel: there's no need to, it's just useful at times. but note that these ISP limitations can sometimes be worked around easily
kstingel: mine is simply blocking port 80, I just use a different port
I have unlimited space with my host, so is no great prob to install a clean tiki there ... then can just update via FTP with latest checkout
lphuberdeau: finally solved the red x tracker thing. but not sure if there is something else to fix
which one?
when hitting red X in tracker field admin, field is not deleted.
basically after the confirm... $input->confirm->boolean() is true, but $input->confirm->int() is 9
is 0
I suppose that's right. "true" becomes 0 if passed through int filter
right?
Except that boolean does not exist
tikiwiki: 03sylvieg * r35610 10/trunk/lib/filegals/filegallib.php: [another FIX sorry to 35609
so that's going to use PreventXss
oh, it needs to send 1 then, not true
oh ok, then
if people can svn up and test fgal :-)
sylvieg: fixed here
looks good here too , yay sylvieg
tikiwiki: 03nkoth * r35611 10/trunk/lib/jquery_tiki/tiki-trackers.js: [FIX] Delete of field was not happening after confirmation
thx guys - sorry about the inconvience
np sylvie: that part of code gives headaches
sylvieg: fixed here too
and now you can have {FILES(galleryId=1:2:3, recursive=y) /} ;-)
file galleries definitely give headaches (although I didn't know Jedis could have headaches)
not enuf meditation can do that to you...
lphuberdeau, I have a problem with sendCommentNotification for tracker comments. basically it does not support it yet...
anyone knows what was the old behavior anyway?
(if there was any tracker comment notification...)
yes - I am using it each days
(usually my interaction with customer is a bug tracker and comment notification)
are you familiar with where the code is?
I think it was in repalce_item_commetns
s/comment
ok in trunk this has been centralized in trunk, I will move the mailing buts
bits
tikiwiki: 03sylvieg * r35612 10/trunk/lib/wiki-plugins/wikiplugin_files.php: [ENH]fgal: param recursive and withsubgals
sylvieg: just to confirm it is the same message you get if tracker item is changed right?
(when someone commented on it)
except ther eis some text inside that says "New comment added for item...."
Because there is a new email template for comments which show the comment content also...
maybe better
sylvieg: did you see my mail on the new plugin parameter with 3 "boolean" choices you added?
"Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[35549] trunk"
tikiwiki: 03nkoth * r35613 10/trunk/ (2 files in 2 dirs): [FIX] Put back tracker comment email notifications
tikiwiki: 03nkoth * r35614 10/trunk/ (2 files in 2 dirs): [FIX] If there is only one item in items list, do not make list, since it is often used in pretty trackers inline
nkoth: sendCommentNotification is called from the controller in lib/core/Services/Comment/Controller.php
lphuberdeau, i know
I know I checked the input was the same as the function was entered, but I did not check if it worked as I don't know the behavior
i think it should be fine now. previously sendCommentNotification handled only wiki page and article object types, returning an exception otherwise
I added handling for trackeritem type
ah, should work approximately then, might be slightly different but still do something
right, I tried to approximate as close as possible...
didn't check the code, but really, approximate is a good thing to choose for considering most of the behavior was never really defined anyway
tikiwiki: 03nkoth * r35615 10/trunk/lib/core/Tracker/Field/Rating.php: [ENH] Allow rating (a.k.a. STARS) tracker field to work in single option mode, e.g. Like