***: RobertPlummer has joined #tikiwiki
RobertPlummer has quit IRC (Client Quit)
RobertPlummer has joined #tikiwiki
RobertPlummer has quit IRC (Quit: Leaving.)
RobertPlummer has joined #tikiwiki
RobertPlummer has quit IRC (Ping timeout: 250 seconds)
fabricius has quit IRC (Remote host closed the connection)
lphuberdeau has joined #tikiwiki
Caarrie|away is now known as Caarrie|sleeping CIA-50: tikiwiki: 03nkoth * r36630 10/trunk/lib/wiki-plugins/wikiplugin_customsearch.php: [FIX][ENH] In IE prior to 9 it is not possible to deliver Jquery or javascript together with the AJAX response because of crappy DOM handling. So call back script has to be executed after DOM is modified ***: goj_killedByISP has joined #tikiwiki
goj has quit IRC (Disconnected by services)
goj_killedByISP is now known as goj CIA-50: tikiwiki: 03nkoth * r36631 10/trunk/ (2 files in 2 dirs): [FIX] Items list was not showing concatenated values from other fields when specified, also do not double escape when doing so
tikiwiki: 03nkoth * r36632 10/trunk/lib/core/Tracker/Field/ItemsList.php: [FIX] trackerrender formatter in unified search not formatting items list field properly
tikiwiki: 03nkoth * r36633 10/trunk/lib/core/Tracker/Field/Url.php: [ENH] Add option to display url either as link or plain ***: nkoth has quit IRC (Quit: nkoth)
fabricius has joined #tikiwiki
fabricius has quit IRC (Ping timeout: 240 seconds)
Merbster has joined #tikiwiki Merbster: polom in the morning! CIA-50: tikiwiki: 03changi67 * r36634 10/trunk/lib/ (comments/commentslib.php userslib.php): Avoid unused parameters
tikiwiki: 03changi67 * r36635 10/trunk/lib/comments/commentslib.php: [FIX] Wrong variable
tikiwiki: 03changi67 * r36636 10/trunk/lib/comments/commentslib.php: [FIX] Wrong variable ***: fabricius has joined #tikiwiki CIA-50: tikiwiki: 03changi67 * r36637 10/trunk/lib/wiki-plugins/wikiplugin_googlemap.php: Wrong variable name + comment all functions to avoid false positive alerts in quality ***: SJ-Jay has joined #tikiwiki fabricius: polom all ***: redflo has joined #tikiwiki SJ-Jay: polom fabricius :)
sylvieg, marclaporte told me to ask you about the search box.. do you know why it doens't work with lucene search? CIA-50: tikiwiki: 03changi67 * r36638 10/trunk/lib/toolbars/toolbarslib.php: Avoid unused parameters ***: Wilkins has joined #tikiwiki
Wilkins has quit IRC (Remote host closed the connection)
GillesM has joined #tikiwiki
Wilkins has joined #tikiwiki Merbster: lphuberdeau, what is needed to make the search module work with lucene search? - is it just a matter of editing the search module to feed lucene with the correct parameters?
(I imagine SQL Search and Lucene take diff. parameters and that the serach module is simply not setup to feed lucene with the correct params compared to SQL search) ***: GillesM has quit IRC (Remote host closed the connection)
Jyhem_laptop has joined #tikiwiki Tiki|bot: New Forum Posts: How to input links at the top bar? - http://tiki.org/tiki-view_forum_thread.php?forumId=2&comments_parentId=42127 ***: xavi has joined #tikiwiki
jonnyb has joined #tikiwiki Tiki|bot: New Forum Posts: How to input links at the top bar? - http://tiki.org/tiki-view_forum_thread.php?forumId=3&comments_parentId=42128 ***: Bernard1 has joined #tikiwiki Bernard1: polom jonnyb: hi Bernard1 Bernard1: Hi jonnyb -: Bernard1 digging in CMS Submissions (possible) setting today :) ***: Bernard1 has quit IRC (Ping timeout: 260 seconds) Merbster: jonnyb, fabricius ***: Bernard1 has joined #tikiwiki Bernard1: wouaaaaa i digged too much my MBpro crashed ! :D
hi Merbster Merbster: hey Bernard1 ***: chibaguy has joined #tikiwiki
ChanServ sets mode: +o chibaguy chibaguy: polom CIA-50: tikiwiki: 03xavidp * r36639 10/trunk/templates/tiki-view_articles.tpl:
tikiwiki: [FIX]Hide 'articles' hardcoded title + 2 action buttons next to it when articles
tikiwiki: are shown through PluginArticles and actions are requested to be hidden, for
tikiwiki: better customization of articles display within a custom wiki page xavi: hi chibaguy, jonnyb, Bernard1 & Merbster ***: Caarrie|sleeping is now known as Caarrie|away Merbster: aloha xavi jonnyb: hi xavi Bernard1: hola Xavi, Konishuwa chibaguy xavi: :-) hi Bernard1: … Hola or Ola ? xavi: Merbster & Bernard1: "Hola" (in Catalan and Spanish)
Aloha in some more exotic place, I guess :-) Bernard1: lol Merbster: hehehe :P xavi: ola = wave Bernard1: ola = somthing like "hey !" in hebrew
not to be confused with the famous french "hou la la" :D CIA-50: tikiwiki: 03xavidp * r36640 10/branches/7.x/templates/tiki-view_articles.tpl:
tikiwiki: [bp/r36639][FIX]Hide 'articles' hardcoded title + 2 action buttons next to it
tikiwiki: when articles are shown through PluginArticles and actions are requested to be
tikiwiki: hidden, for better customization of articles display within a custom wiki page xavi: Bernard1: we have the same expression in Catalonia ;-) CIA-50: tikiwiki: 03xavidp * r36641 10/branches/proposals/6.x/templates/tiki-view_articles.tpl:
tikiwiki: [bp/r36639][FIX]Hide 'articles' hardcoded title + 2 action buttons next to it
tikiwiki: when articles are shown through PluginArticles and actions are requested to be
tikiwiki: hidden, for better customization of articles display within a custom wiki page Bernard1: Ahhh stop you'll make me dream of flights and holiday… i used to learn to dance and play Flamenco and i have unfinished business with Spain. :D -: Bernard1 little Mika invite me to lunch… cu l8tr Merbster: I have never flown, and it's been years since I was outside of Denmark. Bernard1: Merbster: tikidesignfeast :--}- ***: Bernard1 is now known as Bernard|lunch chibaguy: hi everybody xavi: hi Gary Merbster: hi chibaguy chibaguy: I read the dev.t.o page about Areas, and it sounds pretty good. But I think I need to play with it to really get the idea fully. xavi: chibaguy: +1 chibaguy: xavi, what do you think, compared to earlier workspace ideas, etc.?
compared to aulawiki?
Similar or complementary or something completely different? xavi: backend: sounds partially similar to me
front end: no change (we still have some gui to handle workspaces easily) chibaguy: Ah, I'm thinking the workspace or aulawiki (this is in the mods repository by the way) tie the space closely to the user, based on group, such as students in a classroom. Maybe Areas ties the Tiki object to the area, without concern for hiding|showing to users. xavi: this is like the "worksapces desktop", where you could define what will be shown when visiting one workspace: which modules, where, etc. and depending on permissions, you would see more or less content there, etc. chibaguy: That is, without filtering according to group. xavi: whenever there is some demo or profile created somewhere, it will be much easier to point what we are still missing to have easy-workspaces Merbster: chibaguy, our use case for it, has primarily to reduce "information noise" on the page. so that only things regarding to what task you are performing is shown on the wiki. (in this case the task would be "working on a project" with nr. XXXX-YY" xavi: oups... s/we still have some gui/we still miss some gui chibaguy: Does it seem like a natural integration to add the Area binding of objects or categories to perspectives on the one hand to the binding of perspectives to groups that Tiki has already? Merbster: chibaguy, groups is not enough
We tried
we need to change the perspective depending on current page's categoryid(s)
chibaguy, imagine if you are using tiki as a workflow tool. You have maybe 5 pages that each, individually complete a step in a larger process. chibaguy: I see. Merbster: if you had to specify "I am working on Case "World domination"" each time you enter a new subprocess page
you'd go crazy :P chibaguy: :-) Merbster: The reason why this is so awesome is, plugins that list "last forum post" will only show forum post for project "World domination" not the posts from from other irrelevant categories/whatever chibaguy: right Merbster: I know the code I made is no where near ready for inclusion in tikiwiki, but it solved our problem. And without this, tikiwiki would've been useless for us. CIA-50: tikiwiki: 03jonnybradley * r36642 10/trunk/templates/tiki-list_submissions.tpl: [FIX] submissions: Untidy table end chibaguy: Well, if it solves a problem that probably a lot of sites would have, then for sure it'd be good to add it to the code.
and I hope that wouldn't take too much time, etc. Merbster: I would like to look into it, but I have very little spare time atm. since we're still not fully done with our tiki based project. chibaguy: Sure, that's understandable. :-) jonnyb: can anyone work out what's going on with html encoding on the {CODE} plugin these days?
lots of pages on dev.t.o are "wrong" xavi: :-(
no idea jonnyb: https://dev.tiki.org/Database+Access seems wrong for instance, but https://dev.tiki.org/Areas is ok - what's the difference? ***: lphuberdeau has quit IRC (Ping timeout: 264 seconds) jonnyb: feature_wiki_allowhtml is off there, so that shouldn't be involved xavi: jonnyb: known issue, afaik: since http://dev.tiki.org/Tiki7#RC_1_Feedback
colors jonnyb: colors="1" - what does that mean? xavi: when highlighting is used in plugincode in 7x, this issue shows up
https://doc.tiki.org/PluginCode
^welcome to plugin code and geshi jonnyb: ah, geshi... xavi: geshi and tiki7
geshi in tiki6 is fine
and tiki5, 4, 3, ...
"regression", afaik jonnyb: aha, yes - if you use colors="php" (which is what i thought it was supposed to be) it messes up... xavi: if you enable codemirror, it might display without the issue, although the highlighter will not match the syntax used of specicifed, probably
afaik jonnyb: looks like on dev we need to use colors="1" ishtml="1" everywhere
and when colors=php ishtml has no effect
:(
cannot recreate, must be geshi - giving in... xavi: jonnyb: ishtml=1 does nothing (no change) jonnyb: it's the colors="1"m that seems to do something chibaguy: does it seem redundant to use codemirror and geshi? Is this the problem?
Or is codemirror not configurable for syntax coloring? jonnyb: codemirror is off there i think, it's too buggy in 7.x xavi: chibaguy: nope. codemirror is not on chibaguy: oh xavi: I'll do a quick test with codemirror on in dev.t.o jonnyb: it was the changes in the plugin parsing that messed it up
and there's only one person who's got any idea... :P xavi: unluckily that person seems to be busy (for weeks) with other things... ***: RobertPlummer has joined #tikiwiki xavi: jonnyb: check now :-)
hi RobertPlummer, you log in just "on time" :-) RobertPlummer: xavi polom xavi: with codemirror on (in dev.t.o) issue with colors in plugincode dissapears jonnyb: hi RobertPlummer RobertPlummer: url? jonnyb: does seem better xavi, let's leave it on for a while xavi: :-)
http://dev.tiki.org/Tiki7#RC_1_Feedback
codemirror to the rescue ;-)
thanks to RobertPlummer's work RobertPlummer: xavi, codemirror 2 works well? ***: Bernard|lunch has quit IRC (Quit: Leaving.) xavi: nope, codemirror 1 in tiki7 RobertPlummer: lol xavi: imagine if we had your latest code ;-) RobertPlummer: xavi, I know I know. -: xavi still imagines S5 fixed in 6.x
xavi still dreams also of sheets fixed in 6.x
xavi is aware that (on the contrary) codemirror can't be backported to proposals/6x while other devs consider it too bugy still
xavi stops dreaming for a while RobertPlummer: :) xavi: jonnyb, I need to know a bit more about tiki connect
your roadmap, and potential sinergy with something I requested to Jyhem to improve tiki's protection against spam
well, let me explain: not "your rodmap" as such, but to kow whether sharing data of spammer ip's could be something to be fetched somehow with tiki connect
do you know what I mean?
in a few sites we get spammers postings dozens of spam comments from differnt ip's jonnyb: i don't think it's really for that sort of thing, in fact it's specifically not that detailed xavi: and Jyhem is helping to ease the task for a tiki admin to collect the ip's from the spammers and add them to the admin baning with minimum number of clicks jonnyb: but IPs aren't that much use are they? xavi: I thought for months that someway of sharing that list of spammer ip's between tiki sites could be useful
ip's are the best effective fight against spammers, afaik jonnyb: maybe one day (after tiki 9 i guess) xavi: according to my experience, at least
yes, I was not asking for something already in trunk or for tiki8 at all... just wondering about roadmaps and potential use through connect (or a if new feature would need to be coded to share with others those lists of spaming ip's) ***: Bernard1 has joined #tikiwiki xavi: I thought some simple csv export from admin banning, and import in another tiki site would do
but of course, if we can take some "wisdom of the crowds" in between , the feature would be even better
the more people confirming that this or that ip is spamming for them also, the higher in the rank of tiki spammers, etc ***: lphuberdeau has joined #tikiwiki xavi: well, for those suffering from spam, my idea is to have coded some easy "export spammer ip list by csv" and allow "import" the equivalent in some other tiki site lphuberdeau: xavi: comment spam? xavi: yes lphuberdeau: akismet was added to tiki8 xavi: we are using stable tikis...
which means 6.x LTS so far , unluckily lphuberdeau: new features should not be going into those LTS versions ;) xavi: yes, I know :-)
however, lphuberdeau, we need also a better was to use the info from the spammers to easily ban them from tiki banning
regardless of external software or services such as akismet
low hanging fruit, you know ;-)
s/ban them from/ban them through lphuberdeau: the problem with IP blocking is that you're likely to block 1/5 of china by blocking a single address
or block a non-static address and prevent legitimate users from coming in xavi: lphuberdeau: in my case, I don't care of china being blocked (the main site receiving spam from english users is not using english at all, but Catalan and Spanish)
and we might consider the theoretical case of banning 1 legitimate user for each 100 spammer ip's
that legitimate user will be able to send us an email, etc so that we fix that case
and in the process, we would be protected against those kiddies adding rubbish to our tiki sites
RobertPlummer: btw, codemirror 1 (Tiki7) seems to miss the end of a table to finish highlighting that table properly
example: http://dev.tiki.org/tiki-editpage.php?page=Tiki7 RobertPlummer: xavi, checking.
I see what you mean.
xavi, for codemirror 2 I re-wrote the entire parser for highlighting.
It should be fixed, I will check in it now.
xavi, looks much better in 2. xavi: well, this seems to me a never ending story: whenever we add a new feature in tiki, it's in an unstable branch (which is fine, required, etc, I know). by the time when that branch is released, users notice that there are bugs... but those bugs are fixed in some new unstable branch because of code refactoring, new external libs, etc.... so stable release is buggy,e tc.
and the story is repeated again and again for years some times... RobertPlummer: One problem with codemirror that has made me pretty depressed (thanks jonnyb :() is that it doesn't support soft line breaks as of now. xavi: codemirror 2 supports them, but not codemirror 1? RobertPlummer: xavi, I think the problem is time. Do we factor in time to fix all feature or to keep pushing forward.
xavi, codemirror 2 doesn't support them, codemirror 1 does. xavi: there should be some balance lphuberdeau: stable branches could not be stable if you allowed changes on them xavi: the key is balance, not dogmatic rules (imho) RobertPlummer: xavi, I hear you, if the admins could come to a consensus. We as developers will care out those wishes.
carry lphuberdeau: I think you give too much decisional power to admins, it's not quite the way it works xavi: collective wisdom (regarding of the label of admin or not)
+1 to lphuberdeau RobertPlummer: So can we then agree on what should be back-ported in these cases and not? xavi: RobertPlummer: codemirror2 involves also using the new parser, and that's too much of a change to be backported to 7.x afaik ***: Bo has joined #tikiwiki
Bo is now known as Guest4224 RobertPlummer: xavi, agreed. xavi: but "fixes" are allowed
provided that someone wants to invest the time (and/or money) involved to have those features fixed in earlier versions
which is not always the case. And I understand that this is the way our community works, etc. We all need to focus where to invest our limited energy/time/money, etc. Fair enough, of course Guest4224: Hi, I'm having problem with the switch of editor in Tiki forum. I'm running Tiki 6.4 as well as 7.1. In 7.1 the editor seems to be stuck in WYSIWYG and vice versa in 6.4. Any syggestions? ***: Guest4224 has left jonnyb: hi Guest4224 - there's a fix in 7.x (not released yet) which might help
oh... fabricius: jump in, ask and jump off - nice one
I have again a question towards css: I have two modules mod-upcoming_events integrated on a wikipage and want to get them wider
I do not find the right selectors
and not the module Id of the specific ones xavi: fabricius: did you try with the param "nobox" (or similar)?
this way, they would fit the allocated space within the page or div where they are located in
afaik fabricius: hmmm nobox jonnyb: or you could use the style param to add whatever css you want to the element fabricius: looks different, but would not be so much an issue
ah styles param chibaguy: fabricius: every module has a unique CSS id; you can see by looking at the page source. You can make a rule to override the theme default using this id.
(i think an id or maybe a class; anyway, it's unique)
(oh, but this would mean putting the rule in the L&F custom css box or something. Using style param as jonnyb suggested would let you could add it at the module admin.) ***: Bernard1 has quit IRC (Read error: Connection reset by peer) fabricius: in the top bar I did find that - in another case in the col 2 and 3 aswell
on the wiki page I do not find
I will look in the source right now chibaguy: the module css id or class?
something like .box-My_Module_Name fabricius: both modules seem to be identical: <div id="module_ " class="box box-upcoming_events module">
only the plugin parameters are different (-> different calendar Ids) ***: radek82 has joined #tikiwiki fabricius: nobox does noteither
I try different stuff ... any idea appreciated ;-) jonnyb: doesn't the style param work? fabricius: in this modules dialogue, there is no field for entering any css jonnyb: oh, a custom module? fabricius: (it's a Tiki 7.x branches from 2 days ago)
no, a plain upcoming events module
ok, added parameters for cal Id, nextDays and such
but no fields for that either - had to go in the WYSIWYGs HTML source code and add parameters there, because the modules dialogue just has some basic fields ***: Bernard1 has joined #tikiwiki fabricius: guhaaaa
Lads, the problem was NOT to find the selctor - pretty sure I had some appropriate already (even no one with specic Id is there), BUT #role_main .module was set to a *max-with*
*max-width*
solved
thanks for support anyway jonnyb: :) fabricius: sometimes I look at what I learned in the last 1 3/4 years and am overwhelmed, what I still do NOT know - the insight, what I do not know get
becomes bigger and bigger the more I learn
but there are those simple situations like this simple thing with the width of a module, when I am staggered how much i really learned in the last few month
AND
without you all in the community, I wouldn't have got a fraction so far - Thanks to all. Tiki|bot: New Forum Posts: Editor problem in the forum feature - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=42132 ***: Bernard1 has quit IRC (Quit: Leaving.) CIA-50: tikiwiki: 03jonnybradley * r36643 10/trunk/ (lib/prefslib.php templates/prefs/shared-flags.tpl): [FIX] prefs: Remove naughty capture from shared flags and move logic into prefslib.php
tikiwiki: 03jonnybradley * r36644 10/trunk/ (lib/prefslib.php templates/prefs/shared-flags.tpl): [MOD] prefs: Swap wrench icon with application_form as everywhere else wrench means admin feature. Better icon for the menu button would be nice (same for filegals - any suggestions?) xavi: back ***: Bernard1 has joined #tikiwiki Bernard1: polom ***: nkoth has joined #tikiwiki
Merbster has quit IRC (Quit: Leaving)
SJ-Jay has quit IRC (Read error: Connection reset by peer)
chibaguy has quit IRC (Quit: Find new themes for Tiki at http://themes.tikiwiki.org.) CIA-50: tikiwiki: 03robertplummer * r36646 10/third_party/jquery/: [ENH] Changed sheet to v2 for security and ui jonnyb: RobertPlummer: i thought you'd moved sheet outside of that external (to stop ongoing nightmare), no? RobertPlummer: Give me a few minutes, I'm trying to get things in order.
I will make it look the same as the new directory.
or external I mean. jonnyb: but it's inside third_party/jquery and third_party/jquery is an external in libs
i'm already getting: svn: Failed to add directory 'lib/jquery/jquery.sheet/jquery-ui': an unversioned directory of the same name already exists RobertPlummer: jonnyb: I realize that. You going to be releasing another v6 soon?
I will have it fixed shortly. jonnyb: 6.x should be fixed on an old revision, so hopefully won't notice this Bernard1: Gooouuing ! submitting an article seams broken on 6.4 (on save ask me to leave the page and nothing is saved)… someone can confirm ? ***: chibaguy has joined #tikiwiki
ChanServ sets mode: +o chibaguy chibaguy: polomagain sylvieg: lphuberdeau: in parse_wiki_argvariable why page is set from $options and why user is set from the global. Why it is not $_GET in all the case? ***: redflo has quit IRC (Quit: Leaving.) lphuberdeau: _GET means there can be a user override, which is bad for user
the global page variable is generally unreliable
and the parser can be called from different contexts sylvieg: not sure I understand why user and page are not managed as other var....
xavi has a case: a page include that contains {include page=included} and the page included is a (trackerlist filtervalue={{page}})
I would like to pick the _GET[page] or to give the options[page=> $_GET) in the wikiplugin_include xavi: well, I was using that feature in 6.x for many months in 5.x & 6.x & proposals/&.x, until it stopped working some months ago in proposals/6x lphuberdeau: to me it just seems very normal that you can the included page
might want to look into transclude which allows to pass in arguments CIA-50: tikiwiki: 03sylvieg * r36648 10/trunk/lib/parser/parserlib.php: [FIX]{{page}}: a page with {include page=included} and the page 'included' is a (trackerlist filtervalue={{page}}), the {{Page}} must be parsed and not keep to {{page}} sylvieg: lphuberdeau: do you agree with this commit? ^^ lphuberdeau: I think it's kind of relying on undefined behaviors sylvieg: do you think it is better to change wikkiplugin_include with $parserlib->parse_wiki_argvariable($text, atrray('page'=>$_GET['page'])); lphuberdeau: certainly not with _GET sylvieg: yes but when option[page] is not defined .. you keep the {{page}} unchaged .. it is not the best too lphuberdeau: the options should be sent to the plugin as one of the arguments
better to take it from there if anything xavi: sylvieg, after sending a newsleter via cron/batch, I see: Notice: Undefined index: zend_mail_smtp_helo in /home/intercanvis/data/www/tiki6svn/lib/webmail/tikimaillib.php on line 34
it's from proposals/6x, in fact. And googling for zend_mail_smtp_helo I find nothing more than a couple of matches from tiki sites...
and I confirm that the email I received came with no subject sylvieg: xavi - I can not reproduce on my local ... it should be a setting... lphuberdeau: xavi, it does look like an undefined preference ***: chealer has joined #tikiwiki lphuberdeau: I don't see it in lib/setup/prefs.php or lib/prefs/zend.php xavi: lphuberdeau: yes, I see. I wonder why this index is undefined, and not all the others zend_mail_smtp_* used in the same line at tikimaillib.php line 34 (proposals/6x)
maybe it's somer leftover from someone's debugging ...
s/somer/some CIA-50: tikiwiki: 03sylvieg * r36649 10/trunk/lib/ (parser/parserlib.php wiki-plugins/wikiplugin_include.php):
tikiwiki: [FIX]{{page}}: rollback 36648 - still does not understand the feature - a page
tikiwiki: with {include page=included} and the page 'included' is a (trackerlist
tikiwiki: filtervalue={{page}}), the {{Page}} must be parsed and not keep to {{page}} lphuberdeau: it might not be related to the missing title issue
notices are not always causing trouble xavi: ok, thanks for feedback CIA-50: tikiwiki: 03chealer * r36650 10/trunk/lib/wiki-plugins/wikiplugin_customsearch.php: [FIX] CUSTOMSEARCH: capitalize "javascript" in callbackscript parameter
tikiwiki: 03sylvieg * r36651 10/branches/proposals/6.x/lib/wiki-plugins/wikiplugin_include.php: [bp/r 36649][FIX]{{page}}: a page with {include page=included} and the page 'included' is a (trackerlist filtervalue={{page}}), the {{Page}} must be parsed and not keep to {{page}}
tikiwiki: 03sylvieg * r36652 10/branches/7.x/lib/wiki-plugins/wikiplugin_include.php: [bp/r 36649][FIX]{{page}}: a page with {include page=included} and the page 'included' is a (trackerlist filtervalue={{page}}), the {{Page}} must be parsed and not keep to {{page}} RobertPlummer: jonnyb: Does every version of tiki use the same /lib/jquery/ ?
Less than 6
?
I need to know so that I fix the right ones. jonnyb: they all use /third_party/jquery but at different revisions
so you can't unfix 6.x/lib/jquery without the jquery version there being changed lphuberdeau: generally, no major version updates on the externals Tiki|bot: New Forum Posts: Adding horizontal menu to tiki - http://tiki.org/tiki-view_forum_thread.php?forumId=3&comments_parentId=42134 RobertPlummer: jonnyb: So shall I make the changes on 6.x or keep them on proposals? And if I work only in proposals, should I leave jquery alone, having duplicate sheet instances? jonnyb: only translations and security fixes go into branches/6.x - yes, use proposals/6.x RobertPlummer: so yes have duplicates? lphuberdeau: really not ideal jonnyb: yes, afraid so RobertPlummer: I have no problem with it, it is less than a meg. jonnyb: really not a good thing to backport lphuberdeau: my gut tells me this may just be an indication that it's too big to backport jonnyb: you'll need to do it to trunk and 7.x too first
big mess :( RobertPlummer: jonnyb, it was done it trunk
jonnyb, really not that big of a mess.
Everything is modular. jonnyb: fair enough, good luck! :) RobertPlummer: Please lets focus on the positive. 6.x is LTR, and since 7 was released with many fixes, really only the fixes in sheet and s5 should go back to 6.
but from 7, not from trunk. Trunk is unstable at best. CIA-50: tikiwiki: 03nkoth * r36653 10/trunk/ (4 files in 4 dirs): [ENH] Allow way to index forum posts (each reply) by itself and not including content of replies RobertPlummer: Stepping out for lunch be back in a few. xavi: sylvieg, I confirm that newsletters through batch/cron are sent *with* subject indeed (confirmed with latest code from proposals/6x; who knows what happened months ago)
and I also confirm some oddity in current proposals/6x: maketoc produces the table of contents *twice* in the wiki page used s template for the newsletter, when the newsletter is sent by hand
however, if that newsletter is re-sent by the batch/cron job, maketoc produces the expected single table of contents...
oddity...
you can reproduce in intercanvis.net site, with a test newsletter
I noticed the bug last month, when I sent the monthly newsletter to 1200+ users... with a defective (duplicated) toc at the top :-/
and tomorrow is the time to send the next montly newsletter for real
of course I have the option to remove the maketoc from the top of the newsletter template ***: chibaguy has quit IRC (Quit: Find new themes for Tiki at http://themes.tikiwiki.org.) CIA-50: tikiwiki: 03nkoth * r36654 10/trunk/tiki-view_forum_thread.php: [FIX] Prevent db error on negative offset
tikiwiki: 03sylvieg * r36655 10/trunk/messu-compose.php: [FIX]messu-compose: a user name is not only limitted to alnum ***: Wilkins has quit IRC (Read error: Operation timed out)
marclaporte has joined #tikiwiki
ChanServ sets mode: +o marclaporte CIA-50: tikiwiki: 03jonnybradley * r36656 10/trunk/ (8 files in 6 dirs):
tikiwiki: [REF] connect: Split connect services up into client and server, and use service actions properly (no more cmd param).
tikiwiki: Also use JitFilter input params correctly, increase guid length in database and don't delete failed or cancelled connection, just mark as deleted (thanks lphuberdeau) ***: chealer has quit IRC (Quit: Konversation terminated!) CIA-50: tikiwiki: 03marclaporte * r36658 10/trunk/templates/admin/include_trackers.tpl: Now that all tracker fields are prefs, this previous lone one is no longer needed...
tikiwiki: 03robertplummer * r36660 10/branches/proposals/6.x/ (13 files in 6 dirs): [ENH] Brought sheet to latest that was in 7.x in order to fix many outstanding issues. More to come.
tikiwiki: 03xavidp * r36661 10/branches/7.x/messu-compose.php: [bp/r36655][FIX]messu-compose: a user name is not only limitted to alnum. Thanks sylvieg
tikiwiki: 03xavidp * r36662 10/branches/proposals/6.x/messu-compose.php: [bp/r36655][FIX]messu-compose: a user name is not only limitted to alnum. Thanks sylvieg xavi: marclaporte? jonnyb: lphuberdeau: have i broken the tests? - i'm getting a couple of Smarty::loadPlugin fatal errors here marclaporte: xavi : pong xavi: :-)
I've just given a quick go to WebODF on trunk :-)
and I wonder if the user is expected to be able to edit the odt file inside tiki RobertPlummer: xavi, I'm working on it, be careful. xavi: oups, ok RobertPlummer: Lol. that is what I'm working on. xavi: :-) RobertPlummer: It is "supported" but there are a few issues I'm working with the developer on.
It is a good project though, much energy. xavi: ok, nice!
yes, and +1 to support odf files in Tiki (+100 to support standard documents) RobertPlummer: This is a nice example of being focused on positive rather than negative. xavi: :-) RobertPlummer: webodf DIDN'T support editing like we needed, and we could have dropped it because of that. xavi: ok RobertPlummer: But the developer is very nice and added methods for us to use, and now it does :).
Happily ever after.... xavi: :-) you all rock! CIA-50: tikiwiki: 03jonnybradley * r36663 10/trunk/lib/test/core/Search/Index/: [SVN] search test: ignore another test_index xavi: FLOSS rocks! CIA-50: tikiwiki: 03robertplummer * r36664 10/branches/7.x/lib/: [ENH] Moved jQuery.sheet and jQuery.s5 to their own directories to prep for deletion and migration of old locations to better help with version management. jonnyb: need to feed, bbl lphuberdeau: jonnyb: I just ran all tests and I only get 2 failures RobertPlummer: (bites nails) lphuberdeau: that was pre-update, rechecking... jonnyb: i'm getting a "PHP Fatal error: Smarty::loadPlugin(): Failed opening required ..." one (printed twice though i think)
seems to be looking for function.html_image.php
anyway - really off now... RobertPlummer: jonnyb: EAT! lphuberdeau: seems like it's local to you jonny
updated and re-ran CIA-50: tikiwiki: 03nkoth * r36665 10/trunk/lib/core/Tracker/Field/Relation.php: [FIX] Obvious breakage after r36496
tikiwiki: 03robertplummer * r36666 10/third_party/jquery/: [FIX] Removed old locations for sheet/s5
tikiwiki: 03robertplummer * r36667 10/branches/7.x/ (lib/sheet/grid.php tiki-slideshow.php): [FIX] updated dependencies for s5 and sheet
tikiwiki: 03marclaporte * r36668 10/trunk/lib/prefs/trackerfield.php: Adding links to help for tracker field prefs
tikiwiki: 03robertplummer * r36669 10/branches/7.x/lib/jquery.sheet_tiki/ (. menu.html): [FIX] Brought the external jquery.sheet_tiki for mods from trunk model
tikiwiki: 03marclaporte * r36670 10/trunk/lib/ (5 files in 2 dirs): better info for prefs RobertPlummer: Ha, nearly done with backport of s5 and sheet fixes to 6!
Woohooo!
(this was looming) marclaporte: Robert: http://demo.tiki.org/trunk/tiki-index.php?page=Sheet I have meeting at 2pm which I wanted to show this RobertPlummer: On the case! ***: marclaporte has quit IRC (Quit: See you later! http://marclaporte.com) RobertPlummer: Man marc, the stress is on! changi: RobertPlummer: Call to a member function setup_jquery_sheet() on a non-object in /home/demotw/3.0/trunk/lib/wiki-plugins/wikiplugin_trackerlist.php on line 1681 RobertPlummer: changi: I'm on it right now. changi: RobertPlummer: need help . ? RobertPlummer: 1 moment. ***: lphuberdeau has quit IRC (Read error: Connection reset by peer) RobertPlummer: changi: just something up with the lib call.
changi: Migrating over to the new way of calling libs, seems to fix. CIA-50: tikiwiki: 03robertplummer * r36672 10/trunk/lib/wiki-plugins/wikiplugin_trackerlist.php: [FIX] lib inclusion RobertPlummer: Who can update demo.t.o/trunk and test?
changi? changi: RobertPlummer: unfortunatly no, i'm not the king of demo RobertPlummer: changi: then your reputation proceeds you. changi: RobertPlummer: maybe when the new server will be online, it will move, but for now, i can't RobertPlummer: changi: :)
no worries, emailing marc CIA-50: tikiwiki: 03robertplummer * r36673 10/branches/proposals/6.x/lib/: [ENH] Added new external locations for sheet and s5
tikiwiki: 03robertplummer * r36674 10/branches/proposals/6.x/lib/ (4 files in 2 dirs):
tikiwiki: [FIX] Locations for sheet dependencies.
tikiwiki: [FIX] Brought the external jquery.sheet_tiki for mods from 7 model RobertPlummer: xavi you round? ***: chealer has joined #tikiwiki xavi: back
greaat Robert
I'll test tomorrow RobertPlummer: ok xavi: I'll be off-line in short RobertPlummer: There may still be a few fixes, in-fact I'm worknig on s5 right now.
These were needed fixes, and are taking much less time than they could if there weren't as plug-able. xavi: ok, thanks for the fixes
c u all ***: xavi has left CIA-50: tikiwiki: 03robertplummer * r36675 10/branches/7.x/templates/tiki-show_page_raw.tpl: [FIX] Locations for images in slideshow
tikiwiki: 03robertplummer * r36676 10/branches/proposals/6.x/ (4 files in 3 dirs):
tikiwiki: [FIX] Removed slideshow call from tiki-setup.php to make it less invasive
tikiwiki: [ENH] Backported slideshow fixes from 7 RobertPlummer: There jonnyb.
oh, 1 more fix. ***: Jyhem_laptop has quit IRC (Remote host closed the connection) CIA-50: tikiwiki: 03lphuberdeau * r36678 10/trunk/ (2 files in 2 dirs): [ENH] Use jquery-ui dialog buttons
tikiwiki: 03robertplummer * r36679 10/third_party/jquery/: [FIX] Reverted back to the old paths for ensuring both 6.x and proposals 6 work nice, can be dropped if we use proposals for 6. RobertPlummer: Happy day, now I can get on with my life. jonnyb: gottago - more tomorrow ***: jonnyb has quit IRC (Quit: I am going outside... I may be some time...) CIA-50: tikiwiki: 03nkoth * r36680 10/trunk/lib/core/Tracker/Field/Checkbox.php: [FIX] When getting value of linked checkbox fields or whatever field not having input, n was always shown before
tikiwiki: 03mlustenberg * r36681 10/trunk/ (lib/wiki/editlib.php tiki-auto_save.php): [FIX] wysiwyg_htmltowiki: the parsing options on editor initialization were wrong -: chealer back from Irene's outage CIA-50: tikiwiki: 03sylvieg * r36682 10/trunk/templates/tiki-edit_submission.tpl: [FIX]article: switch off need to confirm
tikiwiki: 03sylvieg * r36683 10/branches/proposals/6.x/templates/tiki-edit_submission.tpl: [bp/r36682][FIX]article: switch off need to confirm
tikiwiki: 03sylvieg * r36684 10/branches/7.x/templates/tiki-edit_submission.tpl: [bp/r36682][FIX]article: switch off need to confirm
tikiwiki: 03nkoth * r36685 10/trunk/lib/core/Search/ContentSource/ (CommentSource.php ForumPostSource.php): [FIX] Missing setting of new field to be indexed from recent MOD
tikiwiki: 03mlustenberg * r36686 10/trunk/tiki-auto_save.php: [FIX] wysiwyg_htmltowiki: editor switch from Wiki to WYSIWYG Wiki
tikiwiki: 03nkoth * r36687 10/trunk/lib/ (3 files in 3 dirs): [FIX][MOD] Clarify the 2 options for forum indexing, either replies together with root, or separately, introduced recently
tikiwiki: 03pkdille * r36688 10/trunk/styles/ (eatlon.css fivealive.css ohia/options/planet.css): Some tiny cleanups in css files
tikiwiki: 03changi67 * r36689 10/trunk/lib/accounting/accountinglib.php: [FIX] Wrong variable ***: GillesM has joined #tikiwiki CIA-50: tikiwiki: 03chealer * r36690 10/trunk/tiki-auto_save.php: [REF] remove useless ternary
tikiwiki: 03changi67 * r36691 10/trunk/lib/accounting/accountinglib.php: Fixing some wrong variable name + tikilib => this ***: gilles has joined #tikiwiki
GillesM has quit IRC (Ping timeout: 246 seconds) CIA-50: tikiwiki: 03mlustenberg * r36692 10/trunk/tiki-editpage.php: [FIX] wysiwyg_htmltowiki: fixed editor switch from WYSIWYG Wiki to Wiki
tikiwiki: 03pkdille * r36693 10/trunk/lib/imagegals/imagegallib.php: Remove empty statements
tikiwiki: 03mlustenberg * r36694 10/trunk/lib/smarty_tiki/block.textarea.php: [FIX] wysiwyg_htmltowiki: when editing html, the source view of the CKE showed wiki
tikiwiki: 03changi67 * r36695 10/trunk/lib/wiki-plugins/wikiplugin_tracker.php: Avoid unused variables
tikiwiki: 03changi67 * r36696 10/trunk/templates/tiki-admin_trackers.tpl: Restore cycle for CSS styling
tikiwiki: 03pkdille * r36697 10/trunk/lib/ (queuelib.php rss/rsslib.php): Remove empty statements
tikiwiki: 03pkdille * r36698 10/trunk/ (2 files in 2 dirs): fix svn props ***: gilles_ has joined #tikiwiki
gilles has quit IRC (Ping timeout: 240 seconds)
gilles_ has quit IRC (Ping timeout: 245 seconds) CIA-50: tikiwiki: 03changi67 * r36699 10/trunk/tiki-login_scr.php: Notice ***: Bernard1 has quit IRC (Quit: Leaving.)
Bernard1 has joined #tikiwiki
shana_ has joined #tikiwiki CIA-50: tikiwiki: 03changi67 * r36700 10/trunk/lib/queuelib.php: Syntax error shana_: Tiki 7 using Module Adsense. getting error on page "Unable to post message to http://googleads.g.doubleclick.net" and "Failed to load resource: the server responded with a status of 400 (Bad Request)" chealer: RobertPlummer: is it normal that lib/jquery/jquery.sheet/ still exists in trunk, for now? RobertPlummer: chealer: delete it and svn up, it is just there because it hasn't been auto deleted.
The only place it is duplicated now is in 6
And it will stay that way untill proposals becomes a new release. ***: lphuberdeau has joined #tikiwiki chealer: RobertPlummer: I deleted it and it came back when doing an svn up RobertPlummer: Delete jquery and then revert.
the folder /lib/jquery I mean. chealer: RobertPlummer: revert meaning? svn revert lib/jquery/ ?? RobertPlummer: chealer, right svn revert
chealer, I see it, it is duplicated.
I svn up'ed and it wasen't there and then it was. ***: arild_ has joined #tikiwiki RobertPlummer: chealer: Don't worry about it, we'll get it sorted out later. chealer: RobertPlummer: OK. yes, it came back here too RobertPlummer: I think the problem is that 6 uses it, and I reverted it earlier and it re-added it unintentionally.
It is just there, but isn't being used.
I think we should have a maintenance release in 6, at which point we can remove it.
It is just how externals are done at the moment. chealer: RobertPlummer: note that externals can be confusing. svn up could do nothing if you're inside lib/, but do something to lib if you're in the root RobertPlummer: chealer: Yea, I think that is what happened. arild_: I am having problems with the CODE plugin. It is, as I understand, not supposed to alter any text inside the plugin. However, when I add a string, e.g. "Hello world", the double quotes will be translates into their html coded equivalents when reloading the page. This makes the code almost unreadable. Any tips on how I can enter code segments without having them auto-coded by tikiwiki?
correction....not when reloading the page, but editing the page a second time chealer: RobertPlummer: I don't see how a maintenance release will help, but sure, it must not be used
arild_: which version do you use? RobertPlummer: chealer: If we do the maintenance release, the new code is based off of the new locations. arild_: 6.x RobertPlummer: The old code is not.
So we can drop the new locations just before release.
I mean old.
sorry
Typing to fast.
lol
chealer: understand now? CIA-50: tikiwiki: 03nkoth * r36701 10/trunk/comments.php: [DOC] Remove useless comments, there is a feature already for this chealer: RobertPlummer: I don't understand why we can't do that now. Can't we just remove the externals from third_party/jquery/ ? RobertPlummer: chealer, we can but then 6.x will not have the right libs.
6.x and 6 proposals (from today) are using different ones.
I think if we test it well (xavi is going to help do that), we can push another release from proposals.
Are new releases planned for 6.x?
without merging?
If not then I don't see an issue with it, anybody else? chealer: RobertPlummer: I see. so the blocker is not so much a release as some commit being accepted. RobertPlummer: chealer: exactly.
chealer: xavi really wanted it, and it seemed that it really needed to be done, so I spent the morning resolving it. chealer: RobertPlummer: I don't think there are "plans", but I suppose it will happen arild_: I made a test using 7.1 and it seems to work OK there. Typing "Hello world", using the CODE plugin, in the WYSIWYG editor in 6.3 yields: &amp;quot;Hello world&amp;quot; RobertPlummer: arild_: Any reason you wouldn't upgrade to 7.1? chealer: arild_: oh, WYSIWYG... no idea
RobertPlummer: but shouldn't "accepted" 6.x be fine if it's using a fixed revision of the third party (jquery -r31188 https://tikiwiki.svn.sourceforge.net/svnroot/tikiwiki/third_party/jquery ) arild_: Yes, the new module handling. I need the search box in the top bar, and it just doesn't seem to work properly. Easy in 6.x, just the check box in the features
The Tiki installation in question requires the use of WYSIWYG RobertPlummer: arild_: In 7 you can drag and drop your "modules" around.
search box is one of them.
correct me if I'm wrong someone. arild_: yes, so it says, but I am having too many problems trying to position the search bar in the same location as in 6.x. The note in the module editor says the functionality is still experimental...which in my eyes seems very correct. Thus I am holding back the upgrade to 7.x until the next version. Also 6.x is the LTS. RobertPlummer: arild_: agreed.
arild_: I think the problem is that WYSIWYG is just still experimental. arild_: We are have chosen TikiWiki as the "base" for a larger project due to its multitude of functionality. I am very happy with it, but there are quire a few bugs, especially with the WYSIWYG editor. We need a stable release for our integration. The LTS concept is thus very good. Hoping to see bug fixes back ported. CIA-50: tikiwiki: 03nkoth * r36702 10/trunk/ (4 files in 4 dirs): [ENH] A way to force the need for a new title for forum post replies arild_: Yes, WYSIWYG is marked as exprimental. However the wiki syntax is confusing for many users chealer: arild_: do not expect to see many non-important bug fixes backported to 6 arild_: ok. We plan to upgrade to 7.x. We need the new geotagging editor. Good work! but 7.1 still need work on the module handling RobertPlummer: arild_: There is much work going on to make the next ltr super solid.
arild_: But 8 should be very very good, best yet. arild_: I expect 8.x is the release we will actually use in our release
looking forward to it! RobertPlummer: lts, sorry
:) nkoth: tiki 7 also has the disadvantage that some of the more advanced tracker fields are not as reliable (because of the revamp after 6) but most of the bugs should be cleared by the time 8 is out. arild_: another issue I have seen is the referencial integrity handling at database level. Tiki use MyISAM tables which do not support foreign key handling. Referencial integrity is not maintained in ome cases. I see that InnoDB is planned for 9.x. However, the FK definitions are missing for all (?) tables. This handling can be inmplemented using triggers. Any plans to introduce proper refeeencial integrity handling? CIA-50: tikiwiki: 03robertplummer * r36703 10/third_party/jquery/: [FIX] Dropped externals for s5 and sheet forever chealer: arild_: where did you see that InnoDB is planned for 9? arild_: in the roadmap, I believe
it may have been a later version ***: shana_ has quit IRC (Quit: Page closed) arild_: InnoDB comment in https://dev.tiki.org/Tiki9&highlight=InnoDB. Says: Waiting for confirmation chealer: arild_: cool
arild_: I imagine there will be foreign keys after the switch to InnoDB arild_: The current table definitions in Tiki fail to explicitly define the foreign keys. MyISAM will silently ignore the FK definitions. However, if they were added they would take effect once the switch to InnoDB is done
Yes, InnoDB supports foreign keys
I would be happy to contribute to TikiWiki with bug fixes we detect along the way. However, I don't have any previous experience participating in open source projects. Signed up as a registered user to the tiki site + sourceforge and tried to doenload the code. However, it said something about that I needed "other things" to actually get it. Maybe I did something wrong. chealer: arild_: well, I doubt it will be done, but I don't see a reason not to do it if someone is motivated to do it
s/will be done/will be done before the switch to InnoDB/
arild_: hum. which operating system do you use? arild_: windows chealer: arild_: "it (said)" meaning a wiki page on dev.tiki.org?
arild_: you don't need to have previous experience with open source projects, but did you ever use version control systems? arild_: No, I have TortoiseSVN installed, and it complained chealer: arild_: hum, and what "other things" did Tortoise talk about? arild_: I don't recall exactly, but seemingly having signed up to sourceforge was not enough. Should it be? chealer: arild_: oh. there are two different kinds of checkout. anyone can do an anonymous checkout (no need to register to SF for that), but for authenticated checkout you may need to be authorized
arild_: our developer documentation *should* say something about anonymous checkouts
the difference being that with anonymous checkouts, you can't commit arild_: ok. I will play a bit more with it and see. If I am to contribute I guess I would need to commit. If I wanted to contribute with commits, any recommendations? CIA-50: tikiwiki: 03chealer * r36704 10/trunk/lib/smarty_tiki/block.textarea.php: [REF] remove useless comparison with true chealer: arild_: yes, committing means to push a code change. the above line was caused by commit number 36704 ***: Bernard1 has quit IRC (Quit: Leaving.) nkoth: http://dev.tiki.org/TikiDevNewbie http://dev.tiki.org/Commit+Code are good references arild_: I am familiar with SourceSafe and TFS. I expect the concept to be the same using SourceForce. Are you saying that having registered with tiki + sourceforge, that I should be able to download an commit Tiki code?
ok, will check out those links chealer: arild_: good. no, you need to be added to Tiki developers to commit. nkoth: any of the admins would be able to upgrade your Sourceforge account to one that can commit. There is usually one around. chealer: but you should be able to download ***: RobertPlummer has quit IRC (Ping timeout: 245 seconds) arild_: I will check out the docs a bit more first, and get back here afterwards
thanks for your help ***: radek82 has quit IRC (Quit: Leaving)
epan has joined #tikiwiki CIA-50: tikiwiki: 03nkoth * r36705 10/trunk/lib/trackers/trackerlib.php: [FIX] Prevent leading white space ***: arild_ has quit IRC (Quit: Page closed)
epan has quit IRC (Quit: Page closed) CIA-50: tikiwiki: 03nkoth * r36706 10/trunk/templates/trackeroutput/itemslist.tpl: [FIX] Prevent leading or trailing white space
tikiwiki: 03nkoth * r36707 10/trunk/templates/trackeroutput/itemslist.tpl: [FIX] Redo (same result, just cleaner) Prevent leading or trailing white space ***: dthacker has quit IRC (*.net *.split)
Caarrie|away has quit IRC (*.net *.split)
amette has quit IRC (*.net *.split)
Tiki|bot has quit IRC (*.net *.split) CIA-50: tikiwiki: 03nkoth * r36708 10/trunk/lib/core/Tracker/Field/Image.php: [FIX] Prevent error on simply viewing tracker items when fgal_match_regex isset ***: dthacker has joined #tikiwiki
amette has joined #tikiwiki
Caarrie|away has joined #tikiwiki
Tiki|bot has joined #tikiwiki
dthacker has quit IRC (*.net *.split)
Caarrie|away has quit IRC (*.net *.split)
amette has quit IRC (*.net *.split)
Tiki|bot has quit IRC (*.net *.split) CIA-50: tikiwiki: 03nkoth * r36709 10/trunk/lib/core/Tracker/Field/Image.php: [FIX] Prevent image not showing due to zero dimensions when width is not set ***: dthacker has joined #tikiwiki
amette has joined #tikiwiki
Caarrie|away has joined #tikiwiki
Tiki|bot has joined #tikiwiki
Jyhem has quit IRC (Ping timeout: 240 seconds)
Jyhem has joined #tikiwiki
Jyhem has quit IRC (Ping timeout: 258 seconds)
Jyhem has joined #tikiwiki
RobertPlummer has joined #tikiwiki