[00:05]  arildb joined #tikiwiki
[00:15]  fabricius joined #tikiwiki
[00:16]  hallo joined #tikiwiki
[00:16] hallo hallo
[00:17] hallo hallo
[00:17] hallo hallo
[00:17] hallo hallo
[00:17] hallo haloo
[00:17] fabricius hallo hallo
[00:17] hallo sry
[00:23] CIA-36 tikiwiki: 03robertplummer * r41129 10/branches/9.x/lib/core/Tracker/Field/TextArea.php: [FIX] Textarea no longer needs to be htmlspecialchar()'ed due to parser protectors
[00:40] CIA-36 tikiwiki: 03pkdille * r41130 10/branches/9.x/lib/core/Feed/ForwardLink.php: No changes - code styling only (seen on quality.tiki.org)
[00:41] CIA-36 tikiwiki: 03robertplummer * r41131 10/branches/9.x/ (4 files in 3 dirs):
[00:41] CIA-36 tikiwiki: [FIX] Changed name of class from convertPagesToTiki9 to convertToTiki9 to be
[00:41] CIA-36 tikiwiki: more fitting, added a fix to how modules are updated and how statuses are
[00:41] CIA-36 tikiwiki: updated, also added in a status updates to update_page and create_page
[01:07]  marclaporte joined #tikiwiki
[03:06]  goj_killedByISP joined #tikiwiki
[03:37]  deeku joined #tikiwiki
[03:39] deeku Polom, a quick question with tiki sheets: is this the correct syntax - =subsheet1:A1+subsheet2:A1 if I want to add the valie of A1 in subsheet1 with the value of A1 in subsheet2?
[03:41] deeku If I use =SUBSHEET1:A1+SUBSHEET2:A1, I get an error - cycle detected
[03:43] deeku RobertPlummer  please help!
[03:44] fabricius he's not there afaik, deeku
[03:44] deeku Oh, thanks for letting me know.
[03:45] fabricius I do not know the exact syntax ... would have to try myself, but it is 3:44 in the morning and I am nearly falling from the chair (already off to bed, if I would not have been falling asleep at the desk)
[03:45] deeku :-)
[03:46] deeku you had better turn in then...
[03:46] fabricius you can come back tomorrow or/and write me a msg in tiki.og (user Torsten) or maybe best aswell post in the forum
[03:47] fabricius sochances would be good that robert and a few others get the msg aswell
[03:47] deeku Ah, Torsten - we were together at the Tiki Live conference in February, perhaps you will recall.
[03:47] fabricius ... ah maybe yes
[03:48] deeku Ok, will post in the forum
[03:48] fabricius there I am with my first name and here with my lastname
[03:48] deeku thanks and good night!
[03:48] fabricius forum is good
[03:48] fabricius np, bye
[03:48] deeku v Roman name, is it not?
[04:01]  chibaguy joined #tikiwiki
[05:37]  arildb joined #tikiwiki
[07:35]  arildb joined #tikiwiki
[08:04]  dagb joined #tikiwiki
[08:04] dagb good morning
[08:06] dagb are there any known issues with fullscreen editing of spreadsheets is 8.3
[08:07] dagb When clicking fullscreen edit in a spreadsheet, I only end up with a gray page with a horisontal gradient band in the middle
[08:08] dagb tested in chrome and ff
[08:10] dagb much the same in IE9
[08:12]  fabricius joined #tikiwiki
[08:18] chibaguy dagb: I haven't seen any other reports about that, but it could be a bug. There've been quite a few regressions.
[08:20] dagb If anyone could reproduce it on the fly, I'll be happy to open a bugreport. This is my first attempt at setting up tikiwiki, so I cannot rule out PEBCAK.
[08:27] chibaguy There's probably a wiki page at dev.tiki.org about regressions and other bugs that you could add this to. You could file a bug report there also, but I'm not sure how well the reports are monitored.
[08:28] chibaguy Or post on the tikiwiki-devel mailing list.
[08:29] chibaguy bbl
[08:48] fabricius polom
[08:48]  Jenser joined #tikiwiki
[09:28]  xavi1 joined #tikiwiki
[09:29] xavi polom
[09:29] xavi anybody has any idea if there is any update to the "Tracker to Gantt Chart" Feature? http://dev.tiki.org/TrackerToGanttChart
[10:07] CIA-36 tikiwiki: 03arildb * r41132 10/branches/9.x/db/tiki.sql: [FIX] Fix syntax errors
[10:08] arildb RobertPlummer: you added a new table: tiki_db_status I believe. Should the status attributes previously added now be removed?
[10:16] CIA-36 tikiwiki: 03arildb * r41133 10/trunk/db/tiki.sql: [FIX] Fix syntax errors
[10:54]  redflo joined #tikiwiki
[11:04]  arildb joined #tikiwiki
[13:03] CIA-36 tikiwiki: 03xavidp * r41134 10/mods/trunk/ (2 files in 2 dirs): [FIX]Creation of temp folders only if they are missing (therefore removing the harmless but annoying warning when they exist already)
[13:05]  rodrigoprimo joined #tikiwiki
[13:21]  ricks99 joined #tikiwiki
[13:22] xavi btw, answering my own question from 4 h ago... TrackertoGanttChart seems to have been included in tiki many versions ago as http://doc.tiki.org/PluginTrackerTimeline with para  simile_timeline="n"
[13:22] xavi s/para/param
[13:26]  fabricius joined #tikiwiki
[13:26] fabricius polom
[13:28] ricks99 polom y'all
[13:37] fabricius polom ricks99
[13:37] fabricius off in a few minutes (in a train)
[13:38]  goj_killedByISP joined #tikiwiki
[13:44] xavi hi ricks99 and fabricius
[13:44] xavi ricks99: do you accept the first css question of the day in 9x? :-)
[13:44] xavi s/in/for
[13:47] RobertPlummer polom guys
[13:47] RobertPlummer I'm in for a bit before I have to leave.
[13:47] xavi hi RobertPlummer
[13:47] RobertPlummer hi xavi
[13:48] RobertPlummer Going to fix a few conversion problems right now.
[13:48] xavi ok
[13:48] RobertPlummer polom chealer
[13:49] xavi ok, I through my css question just in case anyone gets enlighted. Using Plugin TrackerTimeline (and simile_timeline=y) I don't know how to make the box higher
[13:49] xavi example:
[13:49] xavi [OFF]http://ueb.vhir.org/tiki-index.php?page=Simile&refresh=1
[13:49] xavi I see the class timeline-band-layer-inner set as 100%
[13:50] xavi but I know that there are more data points to display than just the ones displayed (7-8 displayed, much more to display)
[13:50] RobertPlummer xavi: Do you have a db that is either 87 or 8 that I could have to run the updater on to ensure it is being done right?
[13:50] RobertPlummer 7 or 8, woops. (butter fingers)
[13:51] RobertPlummer xavi: Preferred for both, and as well if you have a 4 and or 5, that'd be AWESOME!
[13:51] ricks99 hi xavi... sorry... i had to get coffee :)
[13:51] xavi the same data set is shown in PluginTrackerTimeline with simile_timeline=n, which displayed all data points (even if defective display)
[13:51] xavi np ricks99
[13:51] xavi so with simile_timeline=n here:
[13:51] RobertPlummer xavi: I wish I could help, I know nothing of the timeline plugin
[13:51] ricks99 gimme a sec, i'll take a look
[13:52] xavi [OFF]http://ueb.vhir.org/Gantt
[13:52] xavi np RobertPlummer, thanks ricks99 (not urgent, take your coffee please :-) )
[13:53] xavi RobertPlummer: about db,yes, I have some....
[13:53] * ricks99 sip, sip, sip
[13:53] xavi let me think...
[13:53] RobertPlummer xavi: WOOHOO!
[13:54] xavi RobertPlummer: I have some starting from Tiki 1.4 :-)
[13:54] xavi afair
[13:54] xavi but why not focusing in the issues from Tiki6?
[13:54] xavi LTS, etc
[13:55] xavi and you have already one db of mine from a production site with tiki6
[13:55] RobertPlummer I have the upgrade script working somewhat well, but in the end the double encoding from 7 and 8 needs to be detected for this thing to work right.
[13:56] xavi ok, tell me if you don't have enough with this db from tiki6 that you already have
[13:56] RobertPlummer xavi: I think it is a good starting point, but either a db from 7 or 8 I think would be good when you get a chance.
[13:56] ricks99 xavi: looks like your contstraining the overall height to 250px in <div id="ttl_timeline"....
[13:57] ricks99 thats why you're not seeing all data points
[13:57] dagb I'll hit this again: anyone else seeing issues with fullscreen editing of spreadsheets in 8.3?
[13:57] xavi thks ricks99. I wonder why I couldn't detect this with firebug...
[13:58] * xavi needs to learn more about how to master firebug
[13:58] RobertPlummer dagb: There are some backports that need done, it is fixed in 9 now.
[13:58] * ricks99 using ie :-) dev toolket
[13:59] xavi :-D brrrrr, those closed source alternatives :-)
[13:59] RobertPlummer anyone feel a chill?
[13:59] dagb RobertPlummer: wonderful. Is 9 expected soonish?
[13:59] ricks99 xavi: try turning on the overflow in one of the inner divs. this way you could scroll down through all data points
[13:59] RobertPlummer :)
[13:59] RobertPlummer dagb: It is expected in may, we are working toward it right now.  There is a problem with encoding that is being fixed right now.
[13:59] * ricks99 will one day get his unix box up and running
[14:00] xavi :-)
[14:00] xavi ricks99: whenever we meet in person (one day? :-) ) I'll be honored to guide you in that process as much as you need
[14:02] RobertPlummer ricks99: Install ubuntu on your box, it takes just a few minutes.
[14:02] RobertPlummer ricks99: I did it, and have not looked back.
[14:02] RobertPlummer ricks99: ubuntu installs as a virtual machine, so you can delete it if you don't like it.
[14:02] ricks99 RobertPlummer: got on old pc (win 95). weekend project to wipe and linux-ize it. was thinking red hat, tho
[14:02] RobertPlummer Wubi I think is what it is called, it is an installer that puts it on windows.
[14:03] RobertPlummer ricks99: Just do ubuntu, you will be guided much easier.
[14:03] ricks99 xavi: next time you're in NC, USA, first round of beer on me.
[14:03] RobertPlummer ricks99: The upgrade process in ubuntu is much more streamlined, and the transition is less painful.
[14:03] ricks99 cool. will check it out. tx RobertPlummer
[14:03] RobertPlummer ricks99: If you like, try Linux Mint, which aims for a windows replacement.
[14:04] RobertPlummer ricks99: I was expecting it to take a long time (like it does in windows) 15 minutes is all it takes.
[14:04] xavi ricks99: for sure (never been there)
[14:04] * ricks99 been a windoze guy since *foreer*
[14:05] ricks99 *for ever*
[14:05] * ricks99 wonders if his old, ancient, original IBM PC is still in the attic somewhere...
[14:05] xavi bbl
[14:06] CIA-36 tikiwiki: 03jonnybradley * r41135 10/branches/9.x/lib/cache/memcachelib.php: [FIX] memcache: Emegency fix to make memcache multi-tiki aware as now the class gets instantiated on every page load even if the feature is off (can that be right? re: r41017)
[14:07] RobertPlummer ricks99: Windows is outdated.  ntfs is a horrid stack of pain.  ext doesn't ever need defragged.
[14:08] xavi btw, ricks99, keep in mind that very old pc's will not run (or deadly slow) current linues
[14:08] RobertPlummer xavi: That is a good point, but ubuntu remains backward compatible with many older pcs.
[14:08] xavi if possible, and very old pc, check requirements for "Lubuntu", which is the equivalent of the ubuntu gnu/linux family for extremely old pcs
[14:08] chibaguy hi guys
[14:08] chibaguy xavi, did you get a fix for the css problem?
[14:09] xavi ricks99: if lubuntu is too much for your old pc's, then go with the "puppylinux" distro
[14:09] xavi thks chibaguy, still in process of testing (and many things going in parallel in our office right now)
[14:09] xavi plus late lunch in short fro our whole team
[14:09] xavi bbl
[14:10] ricks99 i wont debate the win vs linux issue. :)
[14:10] chibaguy I see an "element.style {height: 250px;} in firebug. that means it's set in the html. you can probably override with a div#ttl_timeline {height: 400px /*or whatever*/ !important} in a stylesheet.
[14:10]  Jenser left #tikiwiki
[14:10] RobertPlummer ricks99: yes, it is like apples vs oranges.
[14:12] * ricks99 likes to think hes done a bit of good for tiki... on a windoz pc :-)
[14:13] RobertPlummer ricks99: You are right, I digress.  I'm in an aggressive mood today for bug smashing.
[14:13] ricks99 chibaguy: y, thats what I told xavi ^^^. Or, to turn on the overflow for one of the inner divs, if he wants overall size to remain consistent
[14:13] * ricks99 cheers on RobertPlummer to smash more bugs
[14:14] chibaguy ricks99: ok, that's good.
[14:14] RobertPlummer anybody know a text editor that can handle huge files?
[14:14]  Jenser_ joined #tikiwiki
[14:14] * chibaguy was an Amiga user in days of olde
[14:15] * ricks99 dreamed of an amiga while on his coco
[14:16] chibaguy :-)
[14:17] RobertPlummer I think gvim is the answer.
[14:17] RobertPlummer (found it myself)
[14:17] RobertPlummer doh!
[14:18] RobertPlummer xavi, you still around?
[14:26] arildb RobertPlummer: If you have access to Windows, I think TextPad can handle very large files
[14:26] RobertPlummer very good
[14:41] RobertPlummer out for a bit
[15:20] * chibaguy has to walk the dog and get to sleep.
[15:22] xavi back
[15:24] xavi ricks99 (and chibaguy through telephaty at his dreams..., well, I'd beter not so that he can sleep well :-) :  it seems the 250 is hardcoded in wikiplugin_trackertimeline.php (line 291:
[15:24] xavi $out = '<div id="ttl_timeline" style="height: 250px; border: 1px solid #aaa"></div>';
[15:24] xavi ricks99: how to change that so that it can be customized via css?
[15:25] xavi $out = '<div id="ttl_timeline" class="foo"></div>';
[15:25] xavi ? ^
[15:25] xavi and foo=ttl_timeline_box or similar ?
[15:26] ricks99 should b able to override w/ css:
[15:27] ricks99 #ttl_timeline.foo {height:500px !important}
[15:27] ricks99 no need to change code
[15:28] xavi ricks99: don't get me wrong, there is no class defined yet
[15:28] xavi but just:
[15:28] xavi $out = '<div id="ttl_timeline" style="height: 250px; border: 1px solid #aaa"></div>';
[15:29] ricks99 then just #ttl_timeline {height:500px !important}
[15:29] xavi ok, thks
[15:30] xavi or #ttl_timeline {height:auto !important}
[15:30] xavi I guess
[15:30] xavi I'll try
[15:30] xavi thks
[15:30] xavi bbl (meeting at work)
[15:30] ricks99 k
[16:57]  chealer joined #tikiwiki
[16:57]  chealer joined #tikiwiki
[17:21]  jonnyb joined #tikiwiki
[17:21] jonnyb long time no polom - back!
[17:26]  rodrigoprimo joined #tikiwiki
[17:30] CIA-36 tikiwiki: 03jonnybradley * r41136 10/branches/9.x/lib/wiki/wikilib.php: [FIX] aliases: missing global
[17:59] xavi welcome back, jonnyb! :-)
[17:59] xavi oh well, it's my time to disconnect, however :-)
[17:59] jonnyb hi xavi
[17:59] xavi see you later
[17:59]  xavi left #tikiwiki
[18:00] ricks99 welcome back jonnyb
[18:01] jonnyb hi ricks99, thanks
[18:08] CIA-36 tikiwiki: 03Jyhem * r41137 10/branches/9.x/lib/wiki-plugins/wikiplugin_tracker.php: [ENH] Add user-friendly way of creating many tracker items fast
[18:15] Jyhem Oh, jonnyb !! Welcome back. Are you all tanned and relaxed ? :-)
[18:15] jonnyb hi Jyhem - not particularly tanned (i just burn) but quite relaxed, thanks
[18:18]  Dr{Who} joined #tikiwiki
[18:20] Jyhem Thanks for the options for the indexing. The default version gives exactly the same indexing time as before, which is expected. Now all I have to do is find the right options, but I had more pressing stuff to do, and I wait for Jiamcatt.org to end before experiments which kick up the CPU usage to 100%
[18:22] Jyhem I did get some insight on the indexing performance, though: some simple usage of tpls in a tracker output field raised the time from 1h30 to 4h30. so we might have another path for performance
[18:43] chealer long time no polom indeed, jonnyb :-)
[18:44] chealer I had even forgotten about poloming
[18:44] chealer I'm here RobertPlummer
[18:44] jonnyb hi chealer, how's things?
[18:46] chealer jonnyb: not bad. but I didn't follow development a lot recently
[18:48] chealer hi Jyhem, ricks99, xavi :-)
[18:48] jonnyb me too, as you know - bad timing for a vacation i guess...
[18:49] Jyhem Hi chealer
[18:49] Jyhem jonnyb: vacations are always badly timed, I found, so you just have to take them :-)
[18:50] jonnyb indeed, that's what i tought!
[18:50] jonnyb thought
[18:55]  eromneg joined #tikiwiki
[19:08] * Jyhem needs food, badly
[19:13] jonnyb bon appetit, Jyhem
[19:29] RobertPlummer ok guys im here.
[19:30] RobertPlummer *expecting to get beat up by jonnyb for creating a new class for the converter and fixing the parser with new object variables*
[19:31] RobertPlummer jonnyb: polom sir
[19:31] jonnyb hi robert :D
[19:32] RobertPlummer polom chealer
[19:32] jonnyb been stepping through your code - all looks pretty good to me, of course
[19:32] RobertPlummer ok, jonnyb I tried to abstract the code that you did and convert existing plugins BUT ONLY because it may be needed in other parts of tiki.
[19:32] jonnyb just investigating the wysiwyg args thing
[19:32] RobertPlummer jonnyb: Yes, that is a tricky mess.
[19:33] RobertPlummer jonnyb: But should be a bit more easy to fix with the parser.
[19:33] RobertPlummer did you see what I did to the parser?
[19:33] jonnyb it was just a shame it all happened in the "stable" branch, but at least it's still pre-alpha
[19:33] RobertPlummer I know I know jonnyb, but I couldn't see another way to get it "fixed".
[19:33] jonnyb the new parser? no, focussing on tiki 9.0
[19:33] RobertPlummer jonnyb: No no, not the new one, the old one.
[19:34] jonnyb the new converter class? yes, been looking at that
[19:34] jonnyb not sure what's changed with the plugin arg parsing tho...
[19:34] RobertPlummer jonnyb: I created a method to protect certain special characters for parsing, so no html encoding happens to them, and yet they are output correctly.
[19:34] jonnyb unprotectSpecialChars?
[19:35] RobertPlummer jonnyb: Yup
[19:35] jonnyb only gets applied to plugin body data though, not args
[19:35] RobertPlummer We protect special characters for a time, and unprotect them when they are ready to be used so nothing is encoded, and that they are output correctly.
[19:36] RobertPlummer Does it need to be?
[19:36] jonnyb still - i'm stepping through that bit now - gimme 5
[19:36] jonnyb yes, seems the args fail when wrapped in &quot; at some point
[19:36] RobertPlummer I think you are right
[19:37] RobertPlummer I had a few plugins that were not being converted correctly, that is probably the bug.
[19:37] RobertPlummer jonnyb: The one thing I'm most proud of with the old parser isn't the conversion.....  It is that I fixed recursive toc's!  Woohoo!
[19:38] jonnyb coolio - not got on to that bit yet
[19:45] chealer re
[19:49] RobertPlummer chealer: polom buddy.
[20:02] RobertPlummer jonnyb: I do run it on the params.
[20:03] jonnyb oh? doesn't seem to happen for me (in plugin_execute)
[20:03] RobertPlummer I but it is outside of the parser, I run that in WikiParser_PluginArgumentParser
[20:03] jonnyb adding $args = preg_replace(array('/^&quot;/','/&quot;$/'),'',$args); seems to fix if for me here, but is a bit hacky
[20:03] jonnyb still investigating...
[20:04] RobertPlummer jonnyb: It isn't fixed in the converter.
[20:04] RobertPlummer I just spotted it.
[20:04] jonnyb seems your bit doesn't get called when doing convert_plugin_for_ckeditor
[20:04] RobertPlummer We check for double encoding in the body
[20:04] jonnyb i don't think it's a converter issue
[20:04] RobertPlummer jonnyb: no that needs html encoded.
[20:05] RobertPlummer I dont know if there is a good answer with entities on that side at least for the special ones.
[20:05] RobertPlummer jonnyb: That needs html encoded because it is nested html as an attribute.
[20:05] RobertPlummer either that or it needs urlencoded, but I couldn't sort that out.
[20:05] RobertPlummer the wysiwyg is very very difficult to break down for me.
[20:06] jonnyb but to produce the plugin "preview" content the args need to work here
[20:06] jonnyb adding that preg_replace shouldn't harm anything, it's very specific
[20:06] RobertPlummer Right, I think the issue is that they aren't decoded in the converter.
[20:06] jonnyb but just working on another issue...
[20:07] RobertPlummer I know it doesn't hurt anything, but if it is a converter issue, it should be in the coverter.
[20:07] jonnyb i thought that's what it did do? at least that's what my version did (only)
[20:07] RobertPlummer see line 1459 of lib/wiki/wikilib.php
[20:07] RobertPlummer Does $plugin contain the whole plugin with the atributes?
[20:07] RobertPlummer or just the body?
[20:08] RobertPlummer That part of the converter is what you coded, I think I added &amp; to detect another issue I found.
[20:08] jonnyb the whole thing
[20:08] jonnyb pretty certain i was protecting the body part of the plugin, just decoding the args
[20:09] RobertPlummer You are right.
[20:09] RobertPlummer So why isn't it being detected there?
[20:09] jonnyb but if you're dealing with double encoding it's probably the whole thing...
[20:09] RobertPlummer Or perhaps it is triple encoded (LOL).
[20:09] jonnyb it's not a converter issue (wysiwyg plugins borked)
[20:10] RobertPlummer ah ok.
[20:10] jonnyb the body is still protected there, so should be fine
[20:10] jonnyb seemed to work on my tests
[20:10] RobertPlummer jonnyb: I think the htmlspecialchars call in parserlib in that ckeditor plugins fn needs html encoded.
[20:10] RobertPlummer Or rather url encoded.
[20:11] jonnyb seems to break before that - in the ajax call to convert to html format
[20:12] jonnyb the plugin source is correctly encoded to show on the page but plugin_execute isn't expecting that
[20:12] RobertPlummer Right, we don't rid outself of the issue of html encoding,we need to find a way to urlencode urldecode and not let the parser or wysiwyg handle that.
[20:12] RobertPlummer Right so you get into encode decode encode decode again.
[20:12] RobertPlummer that spells corrupt data.
[20:13] RobertPlummer urlencode is the base way to handle this stuff, but I needed you too figure that stuff out, I spent a day on it and got basically nowhere.
[20:13] RobertPlummer The problem was that when I urlencoded is broke everything else because I couldn't find where those attributes were being turned into objects.
[20:14] jonnyb hmm, this was all done pre html5 - should all be data attributes now (for 9.1 maybe)
[20:14] RobertPlummer jonnyb: Where are those attributes converted into obejcts in javascript?
[20:15] jonnyb in the tiki ck plugin
[20:15] RobertPlummer I searched and searched and searched.  The problem is that browsers don't make it easy for ckeditor, ckeditor doesn't make it easy to easily extend, and tiki is by nature tightly integrated.
[20:15] jonnyb no, it's hard going - agreed
[20:16] jonnyb i'm trying not to change that now - just work round what's changed in parselib
[20:16] jonnyb r
[20:16] RobertPlummer Yea but you do something funny, you take what you got from the parser, and you send it back to the parser.
[20:16] RobertPlummer Shouldn't it just be loaded what was needed from the parser first go around?
[20:17] jonnyb that's what i'm looking at now
[20:17] RobertPlummer So html encoding becomes a nightmare at that point, you don't always know what you thought to get.
[20:18] RobertPlummer encode, decode, encode, decode, madness!
[20:19] RobertPlummer I do not want hacking to be a part of 9, I want to sort this issue asap before 9.
[20:19] jonnyb changes of that kind should be done in an experimental branch, imho - too dangerous even for trunk
[20:19] RobertPlummer What do you mean?
[20:19] RobertPlummer urlencode?
[20:19] RobertPlummer urldecode?
[20:21] jonnyb i mean redesigning the way wysiwyg works now - i don't think it's just a matter of changing htmlentities to urlencode
[20:21] RobertPlummer I disagree if you are talking about urlencode, I think the htmlencode-decode is the issue, if the developers can't understand it, what hope do we have that it will be sorted out in the future.
[20:22] RobertPlummer Right, I just want to fix it.
[20:22] RobertPlummer so what can i do to help you right now?
[20:23] jonnyb check back in 30 mins or so? i think i'm near to a usable fix - but just got stuck on something else (actually those edit page icons in the img plugin! ;) )
[20:23] RobertPlummer jonnyb: ok
[20:24] jonnyb somehow ~np~stuff~/np~ is getting parsed...
[20:24] RobertPlummer what!?!?!
[20:24] jonnyb indeed
[20:24] RobertPlummer WOOHOO! Go jonnyb go!
[20:25] RobertPlummer That explains A LOT.
[20:26] RobertPlummer I feel that should be handled like every other opentag closetag thing in tiki, the problem is that it is like an organic closure thingy.
[20:26] RobertPlummer like every other opentag closetag thing in the world really.
[20:27] RobertPlummer lol
[20:27] jonnyb yes, oddly it's one of those - a '' empty attribute in the img tag gets parsed to <em>
[20:27] RobertPlummer jonnyb: I can fix that in parser if needed.
[20:29] jonnyb aha, $options['parsetoc'] :)
[20:31] RobertPlummer awesome!
[20:32] RobertPlummer we need preg_replace_callback for em tags.
[20:33] RobertPlummer check for "=" just before '' make it optional.  Then the callback if = is set, skip otherwise, replace with wrapped in em.
[20:36] jonnyb hmmm, seems a load of parsing happens after the $noparse blocks get reinserted... was it always like that?
[20:36] jonnyb parserlib.php line 1570 onwards
[20:36]  redflo joined #tikiwiki
[20:37] jonnyb sry - ignore - that's $noparsedlinks
[20:39] RobertPlummer I don't think I changed any of that.
[20:39] RobertPlummer Just the htmlencode bits.
[20:39] RobertPlummer and a few syntax issues.
[20:39] jonnyb think i found it - i'm using $noparseplugins, which means the noparse bits don't get taken out
[20:40] jonnyb i'm wondering now why i am re-parsing the $plugin_result (must be a reason....)
[20:56] RobertPlummer That is what I couldn't figure out.
[20:56] RobertPlummer But if you remove it, the whole thing breaks.
[20:56] jonnyb RobertPlummer: i seem to be getting html pages saved with all entities encoded - ew
[20:56] RobertPlummer Or at least that is what I rmemember.
[20:57] RobertPlummer Perhaps because they come from wysiwyg like that?
[20:57] jonnyb well some plugins will have wiki syntax in their body
[20:57] RobertPlummer jonnyb: At the very end of lib/setup/editmode.php I tried to fix that, but perhps it is double encoding?
[20:58] RobertPlummer $_REQUEST['edit'] = html_entity_decode($_REQUEST['edit'], ENT_QUOTES, 'UTF-8');
[20:58] RobertPlummer It comes from wysiwyg as encoded I think.
[21:00] jonnyb ok, thanks - checking...
[21:02] Jyhem polom
[21:03] * Jyhem happy that RobertPlummer & jonnyb caught up together
[21:05] CIA-36 tikiwiki: 03robertplummer * r41138 10/branches/9.x/lib/parser/parserlib.php: [FIX] Prevent italics when just after a '=', which is probably an html object attribute that is empty.
[21:05] RobertPlummer Jyhem one big happy developer family.
[21:07] RobertPlummer jonnyb: <obj attribute='' attribute='' /> is no longer parsed as italics, woohoo!
[21:08]  arildb joined #tikiwiki
[21:08] RobertPlummer before <obj attribute=<em> attribute=</em> /> is what would happen before from the above.
[21:08] jonnyb nice, thanks :)
[21:08] jonnyb that was only for the ckeditor plugin converter bit though, still working in there...
[21:09] jonnyb i think...
[21:09] RobertPlummer jonnyb: If you haven't run the update script make sure you do, and make sure that 999999991 schema is removed from your db so it'll run again.
[21:10] RobertPlummer jonnyb: We really need to rename that to the date when it is fixed.
[21:10] RobertPlummer when it is fixed
[21:10] RobertPlummer (lol)
[21:11] jonnyb the reason it's got a 9999999 name is to force it to execute last, otherwise setup_base can fail :(
[21:11] RobertPlummer jonnyb: Are you sure?  We were having a ton of issues with setup_base in command line so I had to rework much of how it accessed libs.
[21:11] RobertPlummer It may not fail now.
[21:12] jonnyb 7 things at a time please, let's get the basics done first :P
[21:13] RobertPlummer right right.
[21:13] RobertPlummer it is too bad that while developing along the same lines we can't collaborate in a debug environment.
[21:18] RobertPlummer jonnyb: keep in mind that jQuery(data).find('data').text() will decodehtmlentities, we need to do some sort of replace on & to &amp; so &amp will show up in the editor, but even in those cases I was getting odd results.
[21:19] RobertPlummer & and &amp; and &amp;amp; were all showing up & & &
[21:20] jonnyb seems to be the problem is this ~REAL_LT~ stuff in $parserlib->plugins_replace (it gets replaced encoded)
[21:21] jonnyb in update_page()
[21:22] RobertPlummer I bet it is the html purifier. I HATE THAT THING!
[21:23] jonnyb you're not passing on the $is_html param there
[21:23] RobertPlummer jonnyb: If I go to http://doc.tiki.org/tiki-pagehistory.php?page=HTMLentities&source=0 and I past it into wysiwyg, I get is saved correctly I think, then when it reloads, it is all messed up.
[21:23] RobertPlummer Ah, there you go.
[21:23] jonnyb happens on any html wysiwyg page afaik
[21:24] RobertPlummer so quick fix aye?
[21:25] jonnyb any such thing (regarding this)? ;)
[21:26] jonnyb hmm, maybe i need to do my TODO on line 189 of parserlib now...
[21:27] RobertPlummer jonnyb: Is it broken?
[21:28] jonnyb saving wysiwyg pages (very broken)
[21:28] RobertPlummer But doesn't that just remove plugins?
[21:28] RobertPlummer plugins_remove
[21:29] jonnyb by calling parse_first which now does all sorts of other stuff
[21:29] RobertPlummer I see what you are saying.
[21:29] jonnyb unprotectSpecialChars needs to know if it's html or now
[21:29] jonnyb now/not
[21:30] jonnyb all rather precarious i think... but seems to work here now
[21:30] RobertPlummer options should be a class var not a function var.
[21:30] RobertPlummer If we fixed that I think the overhead would go way down on things like this.
[21:31] RobertPlummer $parser->setOptions()->parser_data();
[21:31] jonnyb indeed
[21:31] RobertPlummer It would be an easy fix ;)
[21:31] jonnyb (but not now, right?)
[21:31] RobertPlummer Would it prevent you from rewriting your todo?
[21:32] RobertPlummer I think that is the answer.
[21:32] jonnyb i didn't rewrite that because it would break the stable branch freeze - fixes only, no?
[21:32] jonnyb can wait for 9.1
[21:33] RobertPlummer jonnyb, you want to create a new function (which violates freeze) to fix how options are set (which violates freeze)?
[21:33] RobertPlummer either way, you are in violation.
[21:33] jonnyb no
[21:34] jonnyb i've had to add a new param to an existing function to fix regressions caused by recent new code...
[21:34] RobertPlummer Sometimes a fix can be a bit of a refactor.
[21:35] RobertPlummer Which fixed 90% of the failing other parts of the conversion of html entities.
[21:35] jonnyb no - refactoring is for when not in a release state (imho) otherwise you'll never release (and you'll end up with impossible merging issues with trunk)
[21:36] RobertPlummer I won't argue it.  I violated the freeze, but it wasen't to integrate anything new.  It was because I didn't know how to fix it any other way.
[21:36] RobertPlummer And now the result?  Something that is understandable and debugable.
[21:36] RobertPlummer Oh well, I'm sorry for the trouble.
[21:37] jonnyb i know - i feel ever so guilty for leaving you with all that (although i'm quite glad not to be able to share the pain! :) )
[21:38] jonnyb but i think we should focus now on serious identifyable bug fixing only - we have plenty
[21:38] RobertPlummer ok
[21:39] jonnyb x.0 releases are never perfect but need to be released before x.1 etc - and we won't get eyeballs on it until there's at least a decent beta available.
[21:40] jonnyb once 9.0 is out we can (try and) apply all we've learnt recently and smooth all the rough edges over, so as long as the main bits are ok, polishing can happen later (i reckon)
[21:42] RobertPlummer jonnyb: very good
[21:43] RobertPlummer So based off that, does it fix the issues with wysiwyg?  I look forward to testing!
[21:43] jonnyb i do think what you've done is great code - it certainly needed cleaning up - just a pity we didn't uncover all this before we branched (but such is life, such is Tiki!)
[21:43] jonnyb just reviewing - commits coming soon :)
[21:43] RobertPlummer Woohoo!
[21:45] jonnyb smallest first... :)
[21:46] CIA-36 tikiwiki: 03jonnybradley * r41139 10/branches/9.x/lib/wiki-plugins/wikiplugin_img.php: [FIX] img: use same quote style as rest of tag for draw edit icon style (caused issues with wysiwyg plugin renderer)
[21:51] CIA-36 tikiwiki: 03jonnybradley * r41140 10/branches/9.x/lib/parser/parserlib.php:
[21:51] CIA-36 tikiwiki: [FIX] parser: Remove &quot;s around plugin params which occur when using wysiwyg causing them to fail.
[21:51] CIA-36 tikiwiki: Also add an is_html param to plugins_replace() as unprotectSpecialChars needs to know (deployments to come)
[21:52] CIA-36 tikiwiki: 03jonnybradley * r41141 10/branches/9.x/lib/tikilib.php: [FIX] update_page: Use is_html=true in plugins_replace() after HTMLPurifying (wysiwyg pages were being saved with all entities encoded)
[21:54] jonnyb hey - not much in the end - 4+ hours and just 6 lines changed, which i like - hope it works for eromneg :)
[21:55] RobertPlummer :)
[21:55] RobertPlummer svn upping,
[21:55] * jonnyb waits in a crouching position for the inevitable edge-case failures
[21:57]  redflo1 joined #tikiwiki
[22:08] arildb jonnyb and RobertPlummer: I just tried the latest 9.x fixes, and my wysiwyg base test now works OK
[22:08] RobertPlummer WOOOOHOOOOO!
[22:09] RobertPlummer jonnyb: chest bump!
[22:09] jonnyb super, tusen tak arildb
[22:09] jonnyb :)
[22:09] arildb :-) Takk til dere
[22:10] arildb you may want to merge trunk, if you have a chance
[22:10] RobertPlummer (maybe it was the beer)
[22:10] RobertPlummer jonnyb:
[22:11] jonnyb thanks yes - RobertPlummer you been merging recently?
[22:11] RobertPlummer We need to now start testing with v6 databases.
[22:11] RobertPlummer I have but the past week I've not done to many, I wanted the dust to settle with this conversion thing/
[22:11] jonnyb fair 'nuff
[22:12] jonnyb i tried an upgrade from a v5 and a v6 database and they seemed ok (apart from the wysiwyg bits)
[22:12] CIA-36 tikiwiki: 03robertplummer * r41142 10/branches/9.x/lib/jquery_tiki/tiki-jquery.js:
[22:12] CIA-36 tikiwiki: [FIX] Fixed table builder, was using object attributes when needed to be using
[22:12] CIA-36 tikiwiki: data attribute. Also got rid of the spaces that were added in by default and
[22:12] CIA-36 tikiwiki: moved them to be added only if needed when a cell didn't have a value and it was
[22:12] CIA-36 tikiwiki: being returned as text, also cleaned up while debugging to debug to understand
[22:12] CIA-36 tikiwiki: better what was happening.
[22:13] RobertPlummer we want to start testing upgrades if possible.
[22:13] jonnyb i stepped through the conversion process a couple of times to find out what's going on now and it looks pretty clean
[22:13] RobertPlummer as many as possible.
[22:13] RobertPlummer jonnyb: Thanks, but some plugins are still failing, not sure what is going on there.
[22:14] jonnyb wysiwyg preview is still having entity issues - fiddling with it now...
[22:14] RobertPlummer most are ok, I do remove a plugin if it exists as the new one, other wise the whole thing goes belly up.
[22:14] RobertPlummer ok
[22:14] RobertPlummer side note.... table builder works fine now.
[22:14] RobertPlummer woohoo!
[22:16] jonnyb cool (although Marc asked particularly for those spaces to be added by default - i always thought them unnecessary personally :) )
[22:17] RobertPlummer jonnyb: Well I can see why, but we will see, they look much better now.
[22:18] RobertPlummer before it would but the column chars '|' right next to each other if you removed the spaces, which would result in the end of the table.
[22:18] RobertPlummer But now I check the value and wrap the '|' in spaces if the value is blank
[22:19] RobertPlummer otherwise the value is 'value|value' blank it is ' | '
[22:19] RobertPlummer So technically I didn't take them away ;)
[22:19] RobertPlummer I'm just being stupid.
[22:20] jonnyb :P
[22:20] RobertPlummer So jonnyb, your last fix lifted the blocker?
[22:21] jonnyb haven't dared look at the blockers list yet (only 2 hours sleep, something for the weekend as we say in these parts!)
[22:22] RobertPlummer :)
[22:24]  redflo joined #tikiwiki
[22:25] jonnyb on the wysiwyg preview thing RobertPlummer, try adding a " or > char in ckeditor and do a preview - i gets double encoded but i can't see why (so far)
[22:26] RobertPlummer have you accounted for that wysiwyg already encodes it?
[22:26] RobertPlummer I mean ckeditor
[22:26] RobertPlummer the second one is probably coming from editmode.php maybe?
[22:26] RobertPlummer lib/setup/editmode.php
[22:26] jonnyb yes, it arrives in tiki-auto_save.php -> parse_data as $quot; correctly, but the & gets turned to &amp;
[22:27] jonnyb fair point - i check
[22:27] jonnyb (don;t think that gets called for preview)
[22:27] RobertPlummer does is_html get sent?
[22:27] RobertPlummer (lol)
[22:27] jonnyb yup
[22:28] RobertPlummer not sure then.  But guys, I really feel like tiki 9 is going to be just flat awesome!
[22:29] * jonnyb agrees
[22:30]  marclaporte joined #tikiwiki
[22:31] RobertPlummer it is really making me feel much better, but last week was tuff for me, this one too.
[22:33] RobertPlummer I'm sure it was tuff on others as well.
[22:33] RobertPlummer You guys have been great!
[22:34] jonnyb was fine for me (apart from occasional feelings of guilt!)
[22:34] jonnyb hey marclaporte - how's tings?
[22:35] marclaporte ok
[22:36] RobertPlummer hey marclaporte how goes it?
[22:36] RobertPlummer lol, oops alread asked.
[22:36] RobertPlummer marclaporte: table builder is fixed
[22:36] marclaporte yay!
[22:36] marclaporte brb
[22:36] RobertPlummer marclaporte: jonnyb says you want those spaces in there? Why?
[22:37] RobertPlummer ok
[22:37] Jyhem :)
[22:38] Jyhem the mysterious spaces will remain a mystery for now
[22:39] jonnyb spooky!
[22:46] * Jyhem feels Tiki could steal PERL's motto: "there's more than one way to do it"
[22:48] RobertPlummer Jyhem: "Do it your way"
[22:50] jonnyb RobertPlummer: i'm in protectSpecialChars and it looks like when in wysiwyg preview mode "&" needs protecting, as opposed to "& ", but i'm sure that would break other cases... what u think?
[22:51] RobertPlummer jonnyb: be VERY careful there.  "& " was intended for protection from "&"....  If you look in parse_htmlchar... "&" ALWAYS becomes "&amp;".
[22:51] * jonnyb thinks that for all complicated long-running software projects the motto should be "we'll do it properly next time"
[22:52] Jyhem I'm naturally undecided, I fear :-( category permissions or direct object permissions... hmm
[22:52] Jyhem :) so true, jonnyb
[22:52] jonnyb exacto, RobertPlummer - but ckeditor sends back &quot; etc when " needs to be rendered in the page
[22:53] CIA-36 tikiwiki: 03arildb * r41143 10/trunk/templates/addreference.tpl: [FIX] Added translation tags to page reference properties + fixed typo
[22:54] RobertPlummer jonnyb: If you can fix it, that'd be fine, but I had odd issues when "& " was in a page, and "&amp;" was in a page.  I think that "& " is a hack, I hate it, but it seemed to work.
[22:55] RobertPlummer perhaps we could have another key ckeditorInput and add these other items in like &quot;?
[22:56] jonnyb the double encoding actually happens on line 1506 calling parse_htmlchar() which a while back didn't get done for is_html pages
[22:56] RobertPlummer good find
[22:57] jonnyb but you changed that logic for a reason (presumably)?
[22:57] RobertPlummer let me test a couple things....
[22:58] RobertPlummer jonnyb: It looks like we can remove it, I can't remember why that is there.
[22:58] jonnyb r40945 apparently
[22:59] RobertPlummer bingo
[22:59] RobertPlummer When you are saving back to the page it changes it.
[23:00] jonnyb that simple_wiki thing should go one day...
[23:00] RobertPlummer The page is re-parsed for html purifier
[23:00] RobertPlummer and then & turns into &amp; and is saved as &amp; and re-displayed as &amp; when the page is reloaded.
[23:01] RobertPlummer so when edit, the page modifies & to &amp; and it is saved as such.
[23:01] jonnyb but it works ok when the page is saved or just displayed :(
[23:02] RobertPlummer right, I think reparsing on post-back is just wrong.
[23:02] RobertPlummer So it must be left in unfortunately.
[23:02] jonnyb indeed
[23:02]  marclaporte joined #tikiwiki
[23:02] RobertPlummer I will put a description by it
[23:04] marclaporte polom all
[23:04] jonnyb polom marclaporte
[23:05] CIA-36 tikiwiki: 03robertplummer * r41144 10/branches/9.x/lib/parser/parserlib.php: [FIX] Added description to a '& ' protection, which looks like a bug, but is actually protecting on postback the parser from turning '& ' into '&amp ' which shows up '&amp' and not '&' on a wiki page from the db.
[23:05] RobertPlummer polom marclaporte, can you give us an explanation of the spaces in the table builder, why you wanted them?
[23:06] RobertPlummer in my last commit for that I removed them and ensured they were added only when needed (when a cells value was blank)
[23:06] RobertPlummer Guys I'm getting ready to head out, family calls.
[23:06] * jonnyb wishes he hadn't mentioned the bloomin' spaces
[23:06] jonnyb ok, have fun RobertPlummer - more later
[23:08] RobertPlummer jonnyb: I have a question for you....  In your country the "b" word is like the "f" word here.   What if someone falls, skins their knee, and then they have a bloody knee?  Is that a legitimate, non foul use case?
[23:08] Tiki|bot Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you!
[23:08] Tiki|bot Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you!
[23:08] RobertPlummer jonnyb: lol, leaving on that note.
[23:08] jonnyb :D
[23:09] jonnyb in this case... yes ;)
[23:09] marclaporte RobertPlummer:  /me hunts in memory to remember what spaces are about
[23:10] jonnyb it was something to do with having some text highlighted when you're editing a new empty table, afaicr
[23:27] CIA-36 tikiwiki: 03jonnybradley * r41145 10/branches/9.x/lib/parser/parserlib.php:
[23:27] CIA-36 tikiwiki: [FIX] parser: Don't parse_htmlchar for "is_html" pages which was causing
[23:27] CIA-36 tikiwiki: entities to be encoded (displayed as source) on wysiwyg preview (*seems* to have
[23:27] CIA-36 tikiwiki: no effect on other cases but might need an extra !$options['preview_mode'] if
[23:27] CIA-36 tikiwiki: so)
[23:27] jonnyb ok, last one for today - off to veg in front of the telly now :) more tomorrow...
[23:34]  redflo joined #tikiwiki
[23:50] arildb Would be good if somebody could merge the latest updates to 9.x into trunk. WYSIWYG doesn't work too well in trunk