fabricius: joined #tikiwiki hallo: joined #tikiwiki
hallo
hallo
hallo
hallo
haloo fabricius: hallo hallo hallo: sry CIA-36: tikiwiki: 03robertplummer * r41129 10/branches/9.x/lib/core/Tracker/Field/TextArea.php: [FIX] Textarea no longer needs to be htmlspecialchar()'ed due to parser protectors
tikiwiki: 03pkdille * r41130 10/branches/9.x/lib/core/Feed/ForwardLink.php: No changes - code styling only (seen on quality.tiki.org)
tikiwiki: 03robertplummer * r41131 10/branches/9.x/ (4 files in 3 dirs):
tikiwiki: [FIX] Changed name of class from convertPagesToTiki9 to convertToTiki9 to be
tikiwiki: more fitting, added a fix to how modules are updated and how statuses are
tikiwiki: updated, also added in a status updates to update_page and create_page marclaporte: joined #tikiwiki goj_killedByISP: joined #tikiwiki deeku: joined #tikiwiki
Polom, a quick question with tiki sheets: is this the correct syntax - =subsheet1:A1+subsheet2:A1 if I want to add the valie of A1 in subsheet1 with the value of A1 in subsheet2?
If I use =SUBSHEET1:A1+SUBSHEET2:A1, I get an error - cycle detected
RobertPlummer please help! fabricius: he's not there afaik, deeku deeku: Oh, thanks for letting me know. fabricius: I do not know the exact syntax ... would have to try myself, but it is 3:44 in the morning and I am nearly falling from the chair (already off to bed, if I would not have been falling asleep at the desk) deeku: :-)
you had better turn in then... fabricius: you can come back tomorrow or/and write me a msg in tiki.og (user Torsten) or maybe best aswell post in the forum
sochances would be good that robert and a few others get the msg aswell deeku: Ah, Torsten - we were together at the Tiki Live conference in February, perhaps you will recall. fabricius: ... ah maybe yes deeku: Ok, will post in the forum fabricius: there I am with my first name and here with my lastname deeku: thanks and good night! fabricius: forum is good
np, bye deeku: v Roman name, is it not? chibaguy: joined #tikiwiki arildb: joined #tikiwiki
joined #tikiwiki dagb: joined #tikiwiki
good morning
are there any known issues with fullscreen editing of spreadsheets is 8.3
When clicking fullscreen edit in a spreadsheet, I only end up with a gray page with a horisontal gradient band in the middle
tested in chrome and ff
much the same in IE9 fabricius: joined #tikiwiki chibaguy: dagb: I haven't seen any other reports about that, but it could be a bug. There've been quite a few regressions. dagb: If anyone could reproduce it on the fly, I'll be happy to open a bugreport. This is my first attempt at setting up tikiwiki, so I cannot rule out PEBCAK. chibaguy: There's probably a wiki page at dev.tiki.org about regressions and other bugs that you could add this to. You could file a bug report there also, but I'm not sure how well the reports are monitored.
Or post on the tikiwiki-devel mailing list.
bbl fabricius: polom Jenser: joined #tikiwiki xavi1: joined #tikiwiki xavi: polom
anybody has any idea if there is any update to the "Tracker to Gantt Chart" Feature? http://dev.tiki.org/TrackerToGanttChart CIA-36: tikiwiki: 03arildb * r41132 10/branches/9.x/db/tiki.sql: [FIX] Fix syntax errors arildb: RobertPlummer: you added a new table: tiki_db_status I believe. Should the status attributes previously added now be removed? CIA-36: tikiwiki: 03arildb * r41133 10/trunk/db/tiki.sql: [FIX] Fix syntax errors redflo: joined #tikiwiki arildb: joined #tikiwiki CIA-36: tikiwiki: 03xavidp * r41134 10/mods/trunk/ (2 files in 2 dirs): [FIX]Creation of temp folders only if they are missing (therefore removing the harmless but annoying warning when they exist already) rodrigoprimo: joined #tikiwiki ricks99: joined #tikiwiki xavi: btw, answering my own question from 4 h ago... TrackertoGanttChart seems to have been included in tiki many versions ago as http://doc.tiki.org/PluginTrackerTimeline with para simile_timeline="n"
s/para/param fabricius: joined #tikiwiki
polom ricks99: polom y'all fabricius: polom ricks99
off in a few minutes (in a train) goj_killedByISP: joined #tikiwiki xavi: hi ricks99 and fabricius
ricks99: do you accept the first css question of the day in 9x? :-)
s/in/for RobertPlummer: polom guys
I'm in for a bit before I have to leave. xavi: hi RobertPlummer RobertPlummer: hi xavi
Going to fix a few conversion problems right now. xavi: ok RobertPlummer: polom chealer xavi: ok, I through my css question just in case anyone gets enlighted. Using Plugin TrackerTimeline (and simile_timeline=y) I don't know how to make the box higher
example:
[OFF]http://ueb.vhir.org/tiki-index.php?page=Simile&refresh=1
I see the class timeline-band-layer-inner set as 100%
but I know that there are more data points to display than just the ones displayed (7-8 displayed, much more to display) RobertPlummer: xavi: Do you have a db that is either 87 or 8 that I could have to run the updater on to ensure it is being done right?
7 or 8, woops. (butter fingers)
xavi: Preferred for both, and as well if you have a 4 and or 5, that'd be AWESOME! ricks99: hi xavi... sorry... i had to get coffee :) xavi: the same data set is shown in PluginTrackerTimeline with simile_timeline=n, which displayed all data points (even if defective display)
np ricks99
so with simile_timeline=n here: RobertPlummer: xavi: I wish I could help, I know nothing of the timeline plugin ricks99: gimme a sec, i'll take a look xavi: [OFF]http://ueb.vhir.org/Gantt
np RobertPlummer, thanks ricks99 (not urgent, take your coffee please :-) )
RobertPlummer: about db,yes, I have some.... -: ricks99 sip, sip, sip xavi: let me think... RobertPlummer: xavi: WOOHOO! xavi: RobertPlummer: I have some starting from Tiki 1.4 :-)
afair
but why not focusing in the issues from Tiki6?
LTS, etc
and you have already one db of mine from a production site with tiki6 RobertPlummer: I have the upgrade script working somewhat well, but in the end the double encoding from 7 and 8 needs to be detected for this thing to work right. xavi: ok, tell me if you don't have enough with this db from tiki6 that you already have RobertPlummer: xavi: I think it is a good starting point, but either a db from 7 or 8 I think would be good when you get a chance. ricks99: xavi: looks like your contstraining the overall height to 250px in <div id="ttl_timeline"....
thats why you're not seeing all data points dagb: I'll hit this again: anyone else seeing issues with fullscreen editing of spreadsheets in 8.3? xavi: thks ricks99. I wonder why I couldn't detect this with firebug... -: xavi needs to learn more about how to master firebug RobertPlummer: dagb: There are some backports that need done, it is fixed in 9 now. -: ricks99 using ie :-) dev toolket xavi: :-D brrrrr, those closed source alternatives :-) RobertPlummer: anyone feel a chill? dagb: RobertPlummer: wonderful. Is 9 expected soonish? ricks99: xavi: try turning on the overflow in one of the inner divs. this way you could scroll down through all data points RobertPlummer: :)
dagb: It is expected in may, we are working toward it right now. There is a problem with encoding that is being fixed right now. -: ricks99 will one day get his unix box up and running xavi: :-)
ricks99: whenever we meet in person (one day? :-) ) I'll be honored to guide you in that process as much as you need RobertPlummer: ricks99: Install ubuntu on your box, it takes just a few minutes.
ricks99: I did it, and have not looked back.
ricks99: ubuntu installs as a virtual machine, so you can delete it if you don't like it. ricks99: RobertPlummer: got on old pc (win 95). weekend project to wipe and linux-ize it. was thinking red hat, tho RobertPlummer: Wubi I think is what it is called, it is an installer that puts it on windows.
ricks99: Just do ubuntu, you will be guided much easier. ricks99: xavi: next time you're in NC, USA, first round of beer on me. RobertPlummer: ricks99: The upgrade process in ubuntu is much more streamlined, and the transition is less painful. ricks99: cool. will check it out. tx RobertPlummer RobertPlummer: ricks99: If you like, try Linux Mint, which aims for a windows replacement.
ricks99: I was expecting it to take a long time (like it does in windows) 15 minutes is all it takes. xavi: ricks99: for sure (never been there) -: ricks99 been a windoze guy since *foreer* ricks99: *for ever* -: ricks99 wonders if his old, ancient, original IBM PC is still in the attic somewhere... xavi: bbl CIA-36: tikiwiki: 03jonnybradley * r41135 10/branches/9.x/lib/cache/memcachelib.php: [FIX] memcache: Emegency fix to make memcache multi-tiki aware as now the class gets instantiated on every page load even if the feature is off (can that be right? re: r41017) RobertPlummer: ricks99: Windows is outdated. ntfs is a horrid stack of pain. ext doesn't ever need defragged. xavi: btw, ricks99, keep in mind that very old pc's will not run (or deadly slow) current linues RobertPlummer: xavi: That is a good point, but ubuntu remains backward compatible with many older pcs. xavi: if possible, and very old pc, check requirements for "Lubuntu", which is the equivalent of the ubuntu gnu/linux family for extremely old pcs chibaguy: hi guys
xavi, did you get a fix for the css problem? xavi: ricks99: if lubuntu is too much for your old pc's, then go with the "puppylinux" distro
thks chibaguy, still in process of testing (and many things going in parallel in our office right now)
plus late lunch in short fro our whole team
bbl ricks99: i wont debate the win vs linux issue. :) chibaguy: I see an "element.style {height: 250px;} in firebug. that means it's set in the html. you can probably override with a div#ttl_timeline {height: 400px /*or whatever*/ !important} in a stylesheet. Jenser: left #tikiwiki RobertPlummer: ricks99: yes, it is like apples vs oranges. -: ricks99 likes to think hes done a bit of good for tiki... on a windoz pc :-) RobertPlummer: ricks99: You are right, I digress. I'm in an aggressive mood today for bug smashing. ricks99: chibaguy: y, thats what I told xavi ^^^. Or, to turn on the overflow for one of the inner divs, if he wants overall size to remain consistent -: ricks99 cheers on RobertPlummer to smash more bugs chibaguy: ricks99: ok, that's good. RobertPlummer: anybody know a text editor that can handle huge files? Jenser_: joined #tikiwiki -: chibaguy was an Amiga user in days of olde
ricks99 dreamed of an amiga while on his coco chibaguy: :-) RobertPlummer: I think gvim is the answer.
(found it myself)
doh!
xavi, you still around? arildb: RobertPlummer: If you have access to Windows, I think TextPad can handle very large files RobertPlummer: very good
out for a bit -: chibaguy has to walk the dog and get to sleep. xavi: back
ricks99 (and chibaguy through telephaty at his dreams..., well, I'd beter not so that he can sleep well :-) : it seems the 250 is hardcoded in wikiplugin_trackertimeline.php (line 291:
$out = '<div id="ttl_timeline" style="height: 250px; border: 1px solid #aaa"></div>';
ricks99: how to change that so that it can be customized via css?
$out = '<div id="ttl_timeline" class="foo"></div>';
? ^
and foo=ttl_timeline_box or similar ? ricks99: should b able to override w/ css:
#ttl_timeline.foo {height:500px !important}
no need to change code xavi: ricks99: don't get me wrong, there is no class defined yet
but just:
$out = '<div id="ttl_timeline" style="height: 250px; border: 1px solid #aaa"></div>'; ricks99: then just #ttl_timeline {height:500px !important} xavi: ok, thks
or #ttl_timeline {height:auto !important}
I guess
I'll try
thks
bbl (meeting at work) ricks99: k chealer: joined #tikiwiki
joined #tikiwiki jonnyb: joined #tikiwiki
long time no polom - back! rodrigoprimo: joined #tikiwiki CIA-36: tikiwiki: 03jonnybradley * r41136 10/branches/9.x/lib/wiki/wikilib.php: [FIX] aliases: missing global xavi: welcome back, jonnyb! :-)
oh well, it's my time to disconnect, however :-) jonnyb: hi xavi xavi: see you later
left #tikiwiki ricks99: welcome back jonnyb jonnyb: hi ricks99, thanks CIA-36: tikiwiki: 03Jyhem * r41137 10/branches/9.x/lib/wiki-plugins/wikiplugin_tracker.php: [ENH] Add user-friendly way of creating many tracker items fast Jyhem: Oh, jonnyb !! Welcome back. Are you all tanned and relaxed ? :-) jonnyb: hi Jyhem - not particularly tanned (i just burn) but quite relaxed, thanks Dr{Who}: joined #tikiwiki Jyhem: Thanks for the options for the indexing. The default version gives exactly the same indexing time as before, which is expected. Now all I have to do is find the right options, but I had more pressing stuff to do, and I wait for Jiamcatt.org to end before experiments which kick up the CPU usage to 100%
I did get some insight on the indexing performance, though: some simple usage of tpls in a tracker output field raised the time from 1h30 to 4h30. so we might have another path for performance chealer: long time no polom indeed, jonnyb :-)
I had even forgotten about poloming
I'm here RobertPlummer jonnyb: hi chealer, how's things? chealer: jonnyb: not bad. but I didn't follow development a lot recently
hi Jyhem, ricks99, xavi :-) jonnyb: me too, as you know - bad timing for a vacation i guess... Jyhem: Hi chealer
jonnyb: vacations are always badly timed, I found, so you just have to take them :-) jonnyb: indeed, that's what i tought!
thought eromneg: joined #tikiwiki -: Jyhem needs food, badly jonnyb: bon appetit, Jyhem RobertPlummer: ok guys im here.
*expecting to get beat up by jonnyb for creating a new class for the converter and fixing the parser with new object variables*
jonnyb: polom sir jonnyb: hi robert :D RobertPlummer: polom chealer jonnyb: been stepping through your code - all looks pretty good to me, of course RobertPlummer: ok, jonnyb I tried to abstract the code that you did and convert existing plugins BUT ONLY because it may be needed in other parts of tiki. jonnyb: just investigating the wysiwyg args thing RobertPlummer: jonnyb: Yes, that is a tricky mess.
jonnyb: But should be a bit more easy to fix with the parser.
did you see what I did to the parser? jonnyb: it was just a shame it all happened in the "stable" branch, but at least it's still pre-alpha RobertPlummer: I know I know jonnyb, but I couldn't see another way to get it "fixed". jonnyb: the new parser? no, focussing on tiki 9.0 RobertPlummer: jonnyb: No no, not the new one, the old one. jonnyb: the new converter class? yes, been looking at that
not sure what's changed with the plugin arg parsing tho... RobertPlummer: jonnyb: I created a method to protect certain special characters for parsing, so no html encoding happens to them, and yet they are output correctly. jonnyb: unprotectSpecialChars? RobertPlummer: jonnyb: Yup jonnyb: only gets applied to plugin body data though, not args RobertPlummer: We protect special characters for a time, and unprotect them when they are ready to be used so nothing is encoded, and that they are output correctly.
Does it need to be? jonnyb: still - i'm stepping through that bit now - gimme 5
yes, seems the args fail when wrapped in &quot; at some point RobertPlummer: I think you are right
I had a few plugins that were not being converted correctly, that is probably the bug.
jonnyb: The one thing I'm most proud of with the old parser isn't the conversion..... It is that I fixed recursive toc's! Woohoo! jonnyb: coolio - not got on to that bit yet chealer: re RobertPlummer: chealer: polom buddy.
jonnyb: I do run it on the params. jonnyb: oh? doesn't seem to happen for me (in plugin_execute) RobertPlummer: I but it is outside of the parser, I run that in WikiParser_PluginArgumentParser jonnyb: adding $args = preg_replace(array('/^&quot;/','/&quot;$/'),'',$args); seems to fix if for me here, but is a bit hacky
still investigating... RobertPlummer: jonnyb: It isn't fixed in the converter.
I just spotted it. jonnyb: seems your bit doesn't get called when doing convert_plugin_for_ckeditor RobertPlummer: We check for double encoding in the body jonnyb: i don't think it's a converter issue RobertPlummer: jonnyb: no that needs html encoded.
I dont know if there is a good answer with entities on that side at least for the special ones.
jonnyb: That needs html encoded because it is nested html as an attribute.
either that or it needs urlencoded, but I couldn't sort that out.
the wysiwyg is very very difficult to break down for me. jonnyb: but to produce the plugin "preview" content the args need to work here
adding that preg_replace shouldn't harm anything, it's very specific RobertPlummer: Right, I think the issue is that they aren't decoded in the converter. jonnyb: but just working on another issue... RobertPlummer: I know it doesn't hurt anything, but if it is a converter issue, it should be in the coverter. jonnyb: i thought that's what it did do? at least that's what my version did (only) RobertPlummer: see line 1459 of lib/wiki/wikilib.php
Does $plugin contain the whole plugin with the atributes?
or just the body?
That part of the converter is what you coded, I think I added &amp; to detect another issue I found. jonnyb: the whole thing
pretty certain i was protecting the body part of the plugin, just decoding the args RobertPlummer: You are right.
So why isn't it being detected there? jonnyb: but if you're dealing with double encoding it's probably the whole thing... RobertPlummer: Or perhaps it is triple encoded (LOL). jonnyb: it's not a converter issue (wysiwyg plugins borked) RobertPlummer: ah ok. jonnyb: the body is still protected there, so should be fine
seemed to work on my tests RobertPlummer: jonnyb: I think the htmlspecialchars call in parserlib in that ckeditor plugins fn needs html encoded.
Or rather url encoded. jonnyb: seems to break before that - in the ajax call to convert to html format
the plugin source is correctly encoded to show on the page but plugin_execute isn't expecting that RobertPlummer: Right, we don't rid outself of the issue of html encoding,we need to find a way to urlencode urldecode and not let the parser or wysiwyg handle that.
Right so you get into encode decode encode decode again.
that spells corrupt data.
urlencode is the base way to handle this stuff, but I needed you too figure that stuff out, I spent a day on it and got basically nowhere.
The problem was that when I urlencoded is broke everything else because I couldn't find where those attributes were being turned into objects. jonnyb: hmm, this was all done pre html5 - should all be data attributes now (for 9.1 maybe) RobertPlummer: jonnyb: Where are those attributes converted into obejcts in javascript? jonnyb: in the tiki ck plugin RobertPlummer: I searched and searched and searched. The problem is that browsers don't make it easy for ckeditor, ckeditor doesn't make it easy to easily extend, and tiki is by nature tightly integrated. jonnyb: no, it's hard going - agreed
i'm trying not to change that now - just work round what's changed in parselib
r RobertPlummer: Yea but you do something funny, you take what you got from the parser, and you send it back to the parser.
Shouldn't it just be loaded what was needed from the parser first go around? jonnyb: that's what i'm looking at now RobertPlummer: So html encoding becomes a nightmare at that point, you don't always know what you thought to get.
encode, decode, encode, decode, madness!
I do not want hacking to be a part of 9, I want to sort this issue asap before 9. jonnyb: changes of that kind should be done in an experimental branch, imho - too dangerous even for trunk RobertPlummer: What do you mean?
urlencode?
urldecode? jonnyb: i mean redesigning the way wysiwyg works now - i don't think it's just a matter of changing htmlentities to urlencode RobertPlummer: I disagree if you are talking about urlencode, I think the htmlencode-decode is the issue, if the developers can't understand it, what hope do we have that it will be sorted out in the future.
Right, I just want to fix it.
so what can i do to help you right now? jonnyb: check back in 30 mins or so? i think i'm near to a usable fix - but just got stuck on something else (actually those edit page icons in the img plugin! ;) ) RobertPlummer: jonnyb: ok jonnyb: somehow ~np~stuff~/np~ is getting parsed... RobertPlummer: what!?!?! jonnyb: indeed RobertPlummer: WOOHOO! Go jonnyb go!
That explains A LOT.
I feel that should be handled like every other opentag closetag thing in tiki, the problem is that it is like an organic closure thingy.
like every other opentag closetag thing in the world really.
lol jonnyb: yes, oddly it's one of those - a '' empty attribute in the img tag gets parsed to <em> RobertPlummer: jonnyb: I can fix that in parser if needed. jonnyb: aha, $options['parsetoc'] :) RobertPlummer: awesome!
we need preg_replace_callback for em tags.
check for "=" just before '' make it optional. Then the callback if = is set, skip otherwise, replace with wrapped in em. jonnyb: hmmm, seems a load of parsing happens after the $noparse blocks get reinserted... was it always like that?
parserlib.php line 1570 onwards redflo: joined #tikiwiki jonnyb: sry - ignore - that's $noparsedlinks RobertPlummer: I don't think I changed any of that.
Just the htmlencode bits.
and a few syntax issues. jonnyb: think i found it - i'm using $noparseplugins, which means the noparse bits don't get taken out
i'm wondering now why i am re-parsing the $plugin_result (must be a reason....) RobertPlummer: That is what I couldn't figure out.
But if you remove it, the whole thing breaks. jonnyb: RobertPlummer: i seem to be getting html pages saved with all entities encoded - ew RobertPlummer: Or at least that is what I rmemember.
Perhaps because they come from wysiwyg like that? jonnyb: well some plugins will have wiki syntax in their body RobertPlummer: jonnyb: At the very end of lib/setup/editmode.php I tried to fix that, but perhps it is double encoding?
$_REQUEST['edit'] = html_entity_decode($_REQUEST['edit'], ENT_QUOTES, 'UTF-8');
It comes from wysiwyg as encoded I think. jonnyb: ok, thanks - checking... Jyhem: polom -: Jyhem happy that RobertPlummer & jonnyb caught up together CIA-36: tikiwiki: 03robertplummer * r41138 10/branches/9.x/lib/parser/parserlib.php: [FIX] Prevent italics when just after a '=', which is probably an html object attribute that is empty. RobertPlummer: Jyhem one big happy developer family.
jonnyb: <obj attribute='' attribute='' /> is no longer parsed as italics, woohoo! arildb: joined #tikiwiki RobertPlummer: before <obj attribute=<em> attribute=</em> /> is what would happen before from the above. jonnyb: nice, thanks :)
that was only for the ckeditor plugin converter bit though, still working in there...
i think... RobertPlummer: jonnyb: If you haven't run the update script make sure you do, and make sure that 999999991 schema is removed from your db so it'll run again.
jonnyb: We really need to rename that to the date when it is fixed.
when it is fixed
(lol) jonnyb: the reason it's got a 9999999 name is to force it to execute last, otherwise setup_base can fail :( RobertPlummer: jonnyb: Are you sure? We were having a ton of issues with setup_base in command line so I had to rework much of how it accessed libs.
It may not fail now. jonnyb: 7 things at a time please, let's get the basics done first :P RobertPlummer: right right.
it is too bad that while developing along the same lines we can't collaborate in a debug environment.
jonnyb: keep in mind that jQuery(data).find('data').text() will decodehtmlentities, we need to do some sort of replace on & to &amp; so &amp will show up in the editor, but even in those cases I was getting odd results.
& and &amp; and &amp;amp; were all showing up & & & jonnyb: seems to be the problem is this ~REAL_LT~ stuff in $parserlib->plugins_replace (it gets replaced encoded)
in update_page() RobertPlummer: I bet it is the html purifier. I HATE THAT THING! jonnyb: you're not passing on the $is_html param there RobertPlummer: jonnyb: If I go to http://doc.tiki.org/tiki-pagehistory.php?page=HTMLentities&source=0 and I past it into wysiwyg, I get is saved correctly I think, then when it reloads, it is all messed up.
Ah, there you go. jonnyb: happens on any html wysiwyg page afaik RobertPlummer: so quick fix aye? jonnyb: any such thing (regarding this)? ;)
hmm, maybe i need to do my TODO on line 189 of parserlib now... RobertPlummer: jonnyb: Is it broken? jonnyb: saving wysiwyg pages (very broken) RobertPlummer: But doesn't that just remove plugins?
plugins_remove jonnyb: by calling parse_first which now does all sorts of other stuff RobertPlummer: I see what you are saying. jonnyb: unprotectSpecialChars needs to know if it's html or now
now/not
all rather precarious i think... but seems to work here now RobertPlummer: options should be a class var not a function var.
If we fixed that I think the overhead would go way down on things like this.
$parser->setOptions()->parser_data(); jonnyb: indeed RobertPlummer: It would be an easy fix ;) jonnyb: (but not now, right?) RobertPlummer: Would it prevent you from rewriting your todo?
I think that is the answer. jonnyb: i didn't rewrite that because it would break the stable branch freeze - fixes only, no?
can wait for 9.1 RobertPlummer: jonnyb, you want to create a new function (which violates freeze) to fix how options are set (which violates freeze)?
either way, you are in violation. jonnyb: no
i've had to add a new param to an existing function to fix regressions caused by recent new code... RobertPlummer: Sometimes a fix can be a bit of a refactor.
Which fixed 90% of the failing other parts of the conversion of html entities. jonnyb: no - refactoring is for when not in a release state (imho) otherwise you'll never release (and you'll end up with impossible merging issues with trunk) RobertPlummer: I won't argue it. I violated the freeze, but it wasen't to integrate anything new. It was because I didn't know how to fix it any other way.
And now the result? Something that is understandable and debugable.
Oh well, I'm sorry for the trouble. jonnyb: i know - i feel ever so guilty for leaving you with all that (although i'm quite glad not to be able to share the pain! :) )
but i think we should focus now on serious identifyable bug fixing only - we have plenty RobertPlummer: ok jonnyb: x.0 releases are never perfect but need to be released before x.1 etc - and we won't get eyeballs on it until there's at least a decent beta available.
once 9.0 is out we can (try and) apply all we've learnt recently and smooth all the rough edges over, so as long as the main bits are ok, polishing can happen later (i reckon) RobertPlummer: jonnyb: very good
So based off that, does it fix the issues with wysiwyg? I look forward to testing! jonnyb: i do think what you've done is great code - it certainly needed cleaning up - just a pity we didn't uncover all this before we branched (but such is life, such is Tiki!)
just reviewing - commits coming soon :) RobertPlummer: Woohoo! jonnyb: smallest first... :) CIA-36: tikiwiki: 03jonnybradley * r41139 10/branches/9.x/lib/wiki-plugins/wikiplugin_img.php: [FIX] img: use same quote style as rest of tag for draw edit icon style (caused issues with wysiwyg plugin renderer)
tikiwiki: 03jonnybradley * r41140 10/branches/9.x/lib/parser/parserlib.php:
tikiwiki: [FIX] parser: Remove &quot;s around plugin params which occur when using wysiwyg causing them to fail.
tikiwiki: Also add an is_html param to plugins_replace() as unprotectSpecialChars needs to know (deployments to come)
tikiwiki: 03jonnybradley * r41141 10/branches/9.x/lib/tikilib.php: [FIX] update_page: Use is_html=true in plugins_replace() after HTMLPurifying (wysiwyg pages were being saved with all entities encoded) jonnyb: hey - not much in the end - 4+ hours and just 6 lines changed, which i like - hope it works for eromneg :) RobertPlummer: :)
svn upping, -: jonnyb waits in a crouching position for the inevitable edge-case failures redflo1: joined #tikiwiki arildb: jonnyb and RobertPlummer: I just tried the latest 9.x fixes, and my wysiwyg base test now works OK RobertPlummer: WOOOOHOOOOO!
jonnyb: chest bump! jonnyb: super, tusen tak arildb
:) arildb: :-) Takk til dere
you may want to merge trunk, if you have a chance RobertPlummer: (maybe it was the beer)
jonnyb: jonnyb: thanks yes - RobertPlummer you been merging recently? RobertPlummer: We need to now start testing with v6 databases.
I have but the past week I've not done to many, I wanted the dust to settle with this conversion thing/ jonnyb: fair 'nuff
i tried an upgrade from a v5 and a v6 database and they seemed ok (apart from the wysiwyg bits) CIA-36: tikiwiki: 03robertplummer * r41142 10/branches/9.x/lib/jquery_tiki/tiki-jquery.js:
tikiwiki: [FIX] Fixed table builder, was using object attributes when needed to be using
tikiwiki: data attribute. Also got rid of the spaces that were added in by default and
tikiwiki: moved them to be added only if needed when a cell didn't have a value and it was
tikiwiki: being returned as text, also cleaned up while debugging to debug to understand
tikiwiki: better what was happening. RobertPlummer: we want to start testing upgrades if possible. jonnyb: i stepped through the conversion process a couple of times to find out what's going on now and it looks pretty clean RobertPlummer: as many as possible.
jonnyb: Thanks, but some plugins are still failing, not sure what is going on there. jonnyb: wysiwyg preview is still having entity issues - fiddling with it now... RobertPlummer: most are ok, I do remove a plugin if it exists as the new one, other wise the whole thing goes belly up.
ok
side note.... table builder works fine now.
woohoo! jonnyb: cool (although Marc asked particularly for those spaces to be added by default - i always thought them unnecessary personally :) ) RobertPlummer: jonnyb: Well I can see why, but we will see, they look much better now.
before it would but the column chars '|' right next to each other if you removed the spaces, which would result in the end of the table.
But now I check the value and wrap the '|' in spaces if the value is blank
otherwise the value is 'value|value' blank it is ' | '
So technically I didn't take them away ;)
I'm just being stupid. jonnyb: :P RobertPlummer: So jonnyb, your last fix lifted the blocker? jonnyb: haven't dared look at the blockers list yet (only 2 hours sleep, something for the weekend as we say in these parts!) RobertPlummer: :) redflo: joined #tikiwiki jonnyb: on the wysiwyg preview thing RobertPlummer, try adding a " or > char in ckeditor and do a preview - i gets double encoded but i can't see why (so far) RobertPlummer: have you accounted for that wysiwyg already encodes it?
I mean ckeditor
the second one is probably coming from editmode.php maybe?
lib/setup/editmode.php jonnyb: yes, it arrives in tiki-auto_save.php -> parse_data as $quot; correctly, but the & gets turned to &amp;
fair point - i check
(don;t think that gets called for preview) RobertPlummer: does is_html get sent?
(lol) jonnyb: yup RobertPlummer: not sure then. But guys, I really feel like tiki 9 is going to be just flat awesome! -: jonnyb agrees marclaporte: joined #tikiwiki RobertPlummer: it is really making me feel much better, but last week was tuff for me, this one too.
I'm sure it was tuff on others as well.
You guys have been great! jonnyb: was fine for me (apart from occasional feelings of guilt!)
hey marclaporte - how's tings? marclaporte: ok RobertPlummer: hey marclaporte how goes it?
lol, oops alread asked.
marclaporte: table builder is fixed marclaporte: yay!
brb RobertPlummer: marclaporte: jonnyb says you want those spaces in there? Why?
ok Jyhem: :)
the mysterious spaces will remain a mystery for now jonnyb: spooky! -: Jyhem feels Tiki could steal PERL's motto: "there's more than one way to do it" RobertPlummer: Jyhem: "Do it your way" jonnyb: RobertPlummer: i'm in protectSpecialChars and it looks like when in wysiwyg preview mode "&" needs protecting, as opposed to "& ", but i'm sure that would break other cases... what u think? RobertPlummer: jonnyb: be VERY careful there. "& " was intended for protection from "&".... If you look in parse_htmlchar... "&" ALWAYS becomes "&amp;". -: jonnyb thinks that for all complicated long-running software projects the motto should be "we'll do it properly next time" Jyhem: I'm naturally undecided, I fear :-( category permissions or direct object permissions... hmm
:) so true, jonnyb jonnyb: exacto, RobertPlummer - but ckeditor sends back &quot; etc when " needs to be rendered in the page CIA-36: tikiwiki: 03arildb * r41143 10/trunk/templates/addreference.tpl: [FIX] Added translation tags to page reference properties + fixed typo RobertPlummer: jonnyb: If you can fix it, that'd be fine, but I had odd issues when "& " was in a page, and "&amp;" was in a page. I think that "& " is a hack, I hate it, but it seemed to work.
perhaps we could have another key ckeditorInput and add these other items in like &quot;? jonnyb: the double encoding actually happens on line 1506 calling parse_htmlchar() which a while back didn't get done for is_html pages RobertPlummer: good find jonnyb: but you changed that logic for a reason (presumably)? RobertPlummer: let me test a couple things....
jonnyb: It looks like we can remove it, I can't remember why that is there. jonnyb: r40945 apparently RobertPlummer: bingo
When you are saving back to the page it changes it. jonnyb: that simple_wiki thing should go one day... RobertPlummer: The page is re-parsed for html purifier
and then & turns into &amp; and is saved as &amp; and re-displayed as &amp; when the page is reloaded.
so when edit, the page modifies & to &amp; and it is saved as such. jonnyb: but it works ok when the page is saved or just displayed :( RobertPlummer: right, I think reparsing on post-back is just wrong.
So it must be left in unfortunately. jonnyb: indeed marclaporte: joined #tikiwiki RobertPlummer: I will put a description by it marclaporte: polom all jonnyb: polom marclaporte CIA-36: tikiwiki: 03robertplummer * r41144 10/branches/9.x/lib/parser/parserlib.php: [FIX] Added description to a '& ' protection, which looks like a bug, but is actually protecting on postback the parser from turning '& ' into '&amp ' which shows up '&amp' and not '&' on a wiki page from the db. RobertPlummer: polom marclaporte, can you give us an explanation of the spaces in the table builder, why you wanted them?
in my last commit for that I removed them and ensured they were added only when needed (when a cells value was blank)
Guys I'm getting ready to head out, family calls. -: jonnyb wishes he hadn't mentioned the bloomin' spaces jonnyb: ok, have fun RobertPlummer - more later RobertPlummer: jonnyb: I have a question for you.... In your country the "b" word is like the "f" word here. What if someone falls, skins their knee, and then they have a bloody knee? Is that a legitimate, non foul use case? Tiki|bot: Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you!
Welcome to the official Tiki Wiki CMS Groupware channel. Please ask your question directly. Don't ask to ask. Someone will reply if and when they know the answer. Welcome again and please stay a while. Thank you! RobertPlummer: jonnyb: lol, leaving on that note. jonnyb: :D
in this case... yes ;) marclaporte: RobertPlummer: /me hunts in memory to remember what spaces are about jonnyb: it was something to do with having some text highlighted when you're editing a new empty table, afaicr CIA-36: tikiwiki: 03jonnybradley * r41145 10/branches/9.x/lib/parser/parserlib.php:
tikiwiki: [FIX] parser: Don't parse_htmlchar for "is_html" pages which was causing
tikiwiki: entities to be encoded (displayed as source) on wysiwyg preview (*seems* to have
tikiwiki: no effect on other cases but might need an extra !$options['preview_mode'] if
tikiwiki: so) jonnyb: ok, last one for today - off to veg in front of the telly now :) more tomorrow... redflo: joined #tikiwiki arildb: Would be good if somebody could merge the latest updates to 9.x into trunk. WYSIWYG doesn't work too well in trunk