[01:37] DarkCalf joined #tikiwiki [01:52] marclaporte joined #tikiwiki [01:56] CIA-36 tikiwiki: 03robertplummer * r41228 10/branches/9.x/lib/core/JisonParser/ (Wiki.jison Wiki.js Wiki.php): [FIX] A few oddities with stealing newline characters, added whitespace, doubling speed again, now we are as fast or faster than the old parser with reasonable output results. [02:37] * Jyhem gives up on th tracker items categories :-( No idea how this accessors things are created. [02:38] * marclaporte sends positive waves to jyhem [02:39] * Jyhem too tired and wasted too much time. Plus, as you say, i may have misunderstood how it's meant to work [03:06] goj_killedByISP joined #tikiwiki [05:03] Tiki|bot New Forum Posts: SSL/HTTPS not working - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=43914 [05:03] Tiki|bot New Forum Posts: Error in size of text anchor links - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=3&comments_parentId=43907 [05:03] Tiki|bot New Forum Posts: User registration form with Trackers: no Username shown... - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=43885 [05:14] Tiki|bot New Forum Posts: SSL/HTTPS not working - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=43914 [05:14] Tiki|bot New Forum Posts: Error in size of text anchor links - http://tiki.org/tiki-view_forum_thread.php?forumId=3&comments_parentId=43907 [05:14] Tiki|bot New Forum Posts: User registration form with Trackers: no Username shown... - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=43885 [05:21] CIA-36 tikiwiki: 03lindonb * r41229 10/branches/9.x/templates/tiki-view_articles.tpl: Check that topic image exists first and check variables that are never set in tiki-view_articles (only set when called from plugin articles) [09:36] arildb joined #tikiwiki [10:37] Tiki|bot Recent Bug: Tracker item: #4207 - - maketoc problems on dev.tiki.org - http://dev.tiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=4207 [11:35] redflo joined #tikiwiki [12:45] CIA-36 tikiwiki: 03changi67 * r41230 10/branches/9.x/db/tiki.sql: [FIX] Correct declaration to be the same as the upgrade script [12:45] CIA-36 tikiwiki: 03changi67 * r41231 10/branches/8.x/db/tiki.sql: [BP/41230][FIX] Correct declaration to be the same as the upgrade script [12:47] ricks99 joined #tikiwiki [12:50] ricks99 polom y'all [13:40] CIA-36 tikiwiki: 03ricks99 * r41232 10/branches/9.x/templates/tiki-install.tpl: [ENH]Prompt users to subscribe to newsletter or RSS feed in order to stay up-to-date and receive notification of new releases. More details http://dev.tiki.org/Update+notifier [13:55] CIA-36 tikiwiki: 03ricks99 * r41233 10/trunk/templates/tiki-install.tpl: [ENH] forward port of r41232. Prompt users to subscribe to newsletter or RSS feed in order to stay up-to-date and receive notification of new releases. More details http://dev.tiki.org/Update+notifier [13:55] CIA-36 tikiwiki: 03changi67 * r41234 10/branches/9.x/web_config: [REL] Sync htaccess and web_config [14:02] changi|away polom [14:20] CIA-36 tikiwiki: 03changi67 * r41235 10/branches/9.x/lib/setup/twversion.class.php: [REL] Preparing 9.0alpha [14:27] CIA-36 tikiwiki: 03changi67 * r41236 10/branches/9.x/README: [REL] Update README file for 9.0alpha [14:30] CIA-36 tikiwiki: 03changi67 * r41237 10/branches/9.x/lang/ (49 files in 49 dirs): [REL] Update language.php files for 9.0alpha [14:31] RobertPlummer joined #tikiwiki [14:31] RobertPlummer polom all [14:31] changi|alpha ricks99: Changelog updated with 805 new commits (revision 41232 to 39913), excluding duplicates, merges and release-related commits. [14:31] CIA-36 tikiwiki: 03changi67 * r41238 10/branches/9.x/changelog.txt: [REL] Update changelog.txt for 9.0alpha [14:33] changi|alpha ricks99: Copyrights updated: +10 contributor(s), +2101 commit(s) [14:33] RobertPlummer changi|alpha: So the alpha is coming soon? [14:33] CIA-36 tikiwiki: 03changi67 * r41239 10/branches/9.x/copyright.txt: [REL] Update copyright.txt for 9.0alpha [14:33] changi|alpha RobertPlummer: yes, should i stop ? :) [14:33] RobertPlummer Go, go, go! [14:34] RobertPlummer changi|alpha: Don't let me stop you. [14:34] ricks99 +1 [14:36] marclaporte RobertPlummer: any idea about https://trunkdev.tiki.org/Keywords (plugins no longer validated) [14:36] changi|alpha marclaporte: and unable to be validate [14:37] RobertPlummer It doesn't validate at all? [14:38] RobertPlummer It doesn't let me login. [14:39] CIA-36 tikiwiki: 03changi67 * r41240 10/branches/9.x/db/tiki-secdb_9.0_mysql.sql: [REL] SecDB for 9.0alpha [14:39] marclaporte That is another problem I noticed, which I thought was caused by upgrade issue [14:39] RobertPlummer marclaporte: but? [14:39] marclaporte maybe there are hints in upgrade error messages [14:39] changi|alpha RobertPlummer: retry [14:40] RobertPlummer cooking... [14:40] RobertPlummer I'm in! [14:40] RobertPlummer Ok, it can be approved. [14:40] changi|alpha RobertPlummer: yes, it's working, sorry [14:40] RobertPlummer There is something not being decoded right in the installer, I'm taking a look at it right now. [14:41] CIA-36 tikiwiki: 03changi67 * r41241 10/tags/9.0alpha/: [REL] Tagging release [14:42] changi|alpha RobertPlummer: it's the one on trunkdoc that i can't approve [14:43] changi|alpha RobertPlummer: button are not displayed [14:44] marclaporte maybe because page is cached [14:46] changi|alpha _tiki.sql SUFFIX => OK [14:46] changi|alpha DROP TABLE => OK [14:46] changi|alpha STRUCTURE => OK [14:46] changi|alpha MyISAM => OK [14:46] changi|alpha CDN => OK [14:46] changi|alpha SEFURLs => OK [14:47] changi|alpha External LINKS => OK [14:48] marclaporte changi -> "eye of the eagle" ! [14:49] RobertPlummer where is that from? [14:50] changi|alpha RobertPlummer: pre check before doing a release :) [14:51] RobertPlummer I thought it might have been a reference to Rocky the movie. [14:51] RobertPlummer But then I remembered "Eye of the __Tiger__". [14:52] changi|alpha RobertPlummer: you need to sleep :) [14:53] RobertPlummer :) [14:54] changi|alpha marc is saying that because i hate database diff, especially in upgrade [14:55] RobertPlummer wow, how is that done? [14:55] RobertPlummer don't say meld, lol. [14:55] radek82 joined #tikiwiki [14:56] changi|alpha meld ? [14:57] RobertPlummer its an app in linux [14:57] changi|alpha no, it's not meld, but a mix between shell script and vimdiff [15:02] changi|alpha 9.0alpha local test => OK [15:02] changi|alpha upload in progress [15:02] RobertPlummer woohoo [15:03] RobertPlummer I'm on the conversion script. [15:03] changi|alpha upload finished, download on sf.net and test please [15:03] changi|alpha marclaporte: ! [15:03] changi|alpha RobertPlummer: ! [15:03] changi|alpha ricks99: ! [15:05] CIA-36 tikiwiki: 03changi67 * r41242 10/branches/9.x/lib/setup/twversion.class.php: [REL] Rename version for next release [15:05] changi alpha is packaged [15:07] ricks99 thanks changi! [15:07] ricks99 anyone know, what's the status of a 6.8LTS and 8.4? [15:08] * ricks99 thinks it would be useful to have one last 8.x (as 8.4) before 9.0 [15:09] changi ricks99: can do it now if you want [15:10] ricks99 +1... anyone else mind? [15:10] arildb 8.4...yes, please! [15:10] ricks99 anyone from quality team online? comments about 8.4 & 6.8LTS? [15:10] changi 1 left, and the quorum will be ok [15:11] marclaporte +1 to 8.4 [15:11] changi marclaporte: thx [15:12] marclaporte for 6.8: I what is the diff of commits between proposals and official branch? [15:12] marclaporte hahahah changi|8_4! [15:13] changi|8_4 marclaporte: i can use 8.4 so 8_4 is better than nothing :) [15:15] CIA-36 tikiwiki: 03changi67 * r41243 10/branches/8.x/lib/setup/twversion.class.php: [REL] Preparing 8.4 release [15:16] changi|8_4 s/can/can't/ [15:17] CIA-36 tikiwiki: 03changi67 * r41244 10/branches/8.x/README: [REL] Update README file for 8.4 [15:19] CIA-36 tikiwiki: 03changi67 * r41245 10/branches/8.x/lang/ (49 files in 49 dirs): [REL] Update language.php files for 8.4 [15:20] changi|8_4 ricks99: >> Changelog updated with 151 new commits (revision 41231 to 39559), excluding duplicates, merges and release-related commits. [15:20] CIA-36 tikiwiki: 03changi67 * r41246 10/branches/8.x/changelog.txt: [REL] Update changelog.txt for 8.4 [15:21] changi|8_4 ricks99: >> Copyrights updated: +7 contributor(s), +1828 commit(s) [15:21] CIA-36 tikiwiki: 03changi67 * r41247 10/branches/8.x/copyright.txt: [REL] Update copyright.txt for 8.4 [15:23] ricks99 the 9.0alpha .zip and .7z files cleanly installed for me. great work all! [15:25] CIA-36 tikiwiki: 03changi67 * r41248 10/branches/8.x/db/tiki-secdb_8.4_mysql.sql: [REL] SecDB for 8.4 [15:28] CIA-36 tikiwiki: 03changi67 * r41249 10/tags/8.4/: [REL] Tagging release [15:28] CIA-36 tikiwiki: 03arildb * r41250 10/trunk/tiki-setup_base.php: [FIX] Check if the pref ids_enabled is set before comparing, to get rid of warning [15:29] ricks99 changi|8_4: if possible, can you provide some basic stats (# of comments, # of contributors) for 8.4 and 9.0? [15:30] changi|8_4 just look in the irc logs :) [15:30] changi|8_4 you should found what you need [15:30] ricks99 ah... tx! [15:33] changi|8_4 ricks99: as usual, i now put all those information on irc to be sure you get it :) [15:35] ricks99 you da' man! [15:36] CIA-36 tikiwiki: 03lphuberdeau * r41251 10/branches/9.x/lib/wiki-plugins/wikiplugin_appframe.php: [MOD] Adding additional condition supported in appframe/cond [15:39] changi|8_4 8.4 local test => OK [15:39] changi|8_4 upload finished, download on sf.net and test please [15:40] CIA-36 tikiwiki: 03changi67 * r41252 10/branches/8.x/lib/setup/twversion.class.php: [REL] Finishing 8.4 release [15:43] ricks99 changi: i see 9.0 stats. 8.4? [15:46] RobertPlummer Ok, I think I found it guys! [15:46] RobertPlummer Woohoo! [15:47] RobertPlummer The plugin wasen't being unprotected just before the fingerprint is being generated. [15:47] changi ricks99: icks99: >> Changelog updated with 151 new commits (revision 41231 to 39559), excluding duplicates, merges and release-related commits. [15:47] changi ricks99: Copyrights updated: +7 contributor(s), +1828 commit(s) [15:47] RobertPlummer So '<' would look like '~REAL_LT~' [15:47] ricks99 thhanks again! [15:48] chibaguy joined #tikiwiki [15:48] chibaguy polom [15:50] changi RobertPlummer: how do you fix that ? [15:50] RobertPlummer working on it right now. [16:12] RobertPlummer I believe I have it, it is a 1 liner too. [16:13] RobertPlummer Restoring db for a quick re-test. [16:24] RobertPlummer hey guys, I get a white screen "An error occurred while performing the request". How do I check to see what the error is? [16:27] jonnyb joined #tikiwiki [16:28] jonnyb pol or om? It's your choice... [16:28] RobertPlummer only half today? [16:28] jonnyb feeling mean! [16:28] jonnyb get the rest tomorrow (or yesterday?) [16:29] RobertPlummer think I found the bug that is leading to some plugins not being validated. [16:29] jonnyb i found an odd one too - if you paste stuff into wysiwyg source mode, then save, it saves the parsed version! :( At least of disabled plugins... [16:30] jonnyb might be causing all sorts of trouble elsewhere i think [16:30] RobertPlummer told you, url encoding is what should be used there. [16:30] RobertPlummer as soon as you start messing with entities, it is trouble. [16:31] RobertPlummer but you know it better than me, I digress. [16:31] jonnyb not sure what that's got to do with it saving parsed stuff... but i do agree, it's just not a change to make now [16:32] RobertPlummer The problem is in the conversion I think, back and forth from the system before it can save it. [16:32] jonnyb anyway, it should be json and stuck on the data attributes now, i think - mucho safer [16:32] RobertPlummer YES! [16:33] RobertPlummer But isn't that yet another conversion? [16:33] jonnyb nope, it's my plugins_remove function to allow plugins to filter themselves... [16:33] RobertPlummer It should all be in wiki syntax and only output should be show. [16:33] jonnyb that's another big vote for me rewriting properly now [16:33] RobertPlummer what you see should be a reflection of the source, not actual. [16:34] jonnyb are you talking about tiki 10? (lost me i'm afraid) [16:34] RobertPlummer quasiwig :) [16:34] RobertPlummer Yea, just wishful thinking. [16:34] jonnyb we have wiki wysiwyg, just needs finishing some more [16:35] jonnyb done a merge recently? it'll need the version manually reverting due to the release (for which thanks changi!) [16:36] RobertPlummer I have not done one this morning. no. [16:36] jonnyb :) [16:37] RobertPlummer I'm busy restoring over and over demo.t.o on my local to fix the html entities converter [16:37] jonnyb ah, nice [16:37] jonnyb i'll do one later - btw, where is your converter? need to frob some code [16:37] RobertPlummer frob? [16:38] RobertPlummer lib/wiki/wikilib.php [16:38] jonnyb ah, thx - was in the wrong file [16:39] RobertPlummer I ran the installer after a restore of demo.t.o and users_users dir goes away, whats up with that? [16:39] jonnyb frob is sort of rob with an f in front of it which now you ask i have no idea why :) [16:39] jonnyb you mean table i guess? not good [16:39] RobertPlummer typo? [16:39] * ricks99 needs to add "frob" to his Tiki glossary :) [16:40] jonnyb hi ricks99 :) i think i originally heard it last century sometime, so i don't think it's just me - seems fitting for "borrowing" code [16:41] ricks99 hiya jonnyb [16:41] jonnyb RobertPlummer: did chasing those notices down help? (seems unlikely to me) [16:41] RobertPlummer Not looked into it. [16:42] RobertPlummer frob = find and rob? [16:42] RobertPlummer users_users is there, just on second page, whew. [16:42] jonnyb :D [16:43] RobertPlummer Yea, I know. I didn't know phpmyadmin had that for table view. [16:46] RobertPlummer Looks like it is a golden fix guys. [16:47] CIA-36 tikiwiki: 03robertplummer * r41253 10/branches/9.x/lib/parser/parserlib.php: [FIX] Html entities weren't being unprotected when plugin needed fingerprint, unprotected to fix [16:48] RobertPlummer changi: When is the next go around with trunkdev.tiki.org being restored and svn'ed up? [16:49] jonnyb well done RobertPlummer - nice catch [16:52] benoitg joined #tikiwiki [16:52] RobertPlummer jonnyb: My objections with wysiwyg editor is that it is very buggy, and I'm not sure it ever could be feasible to have it work completely with modern browsers the way they are. Html to 2 browsers is not the same on another. It causes problems when you are constantly converting back and forth from html to wiki syntax. After I make more progress with ForwardLink protocol I have funding for the new parser and quasiwig. If ther [16:52] RobertPlummer e is ample time, I would like to start migrating towards it. [16:54] RobertPlummer jonnyb: I'll say that quasiwyg is a stretch and nowhere near alpha, but please don't discount the idea that it is a migration path from wysiwyg. [16:54] jonnyb that's more or less what i thought when replacing fckeditor 2, and it ended up being so over complicated, but tiki does that sometimes [16:56] jonnyb trying to do the visual representations of plugin output was a mistake i think now - should have used a simple ckeditor "fake entity" image to represent them [16:57] RobertPlummer I understand, good point. But think about this, modern wysiwyg editors are already flawed because they rely on the browser to talk back and forth between the user and the system. In quasiwyg you tell the browser to shut up and server, nothing else. [16:57] jonnyb also it would be an idea to have the option of using other wysiwyg editors (tinymce seems a lot simpler) [16:57] RobertPlummer tinymce seems to have better documentation too. But doesn't have as good functionality(?) [16:58] jonnyb hmm, don't quite follow - the browser still has to render the html, that's all they do surely? [16:58] RobertPlummer (i don't know, I've not used it) [16:58] RobertPlummer right, the browser just renderes (or serves) the user with the output of their wiki syntax. [16:59] jonnyb werdpress uses it, but no wiki syntax - seems lighter and feels more stable [16:59] jonnyb so what's the difference with that and out current htmltowiki mode? [16:59] RobertPlummer That like saying "all the wiki, with none of the wiki". [16:59] jonnyb (apart from the html conversion to wiki being a bit lacking?) [16:59] RobertPlummer The html comes from the qysiwyg editor, no? [17:00] RobertPlummer sorry, slipped, wysiwyg [17:00] jonnyb no, ckeditor just gets html [17:00] changi RobertPlummer: 18 :) [17:00] changi RobertPlummer: i can do it now if you want [17:00] RobertPlummer But you have to convert wiki to html and then back. [17:00] RobertPlummer changi: Lets do it! [17:01] RobertPlummer I don't want to do any converting, I want wiki syntax with a real time out put of it. [17:01] jonnyb RobertPlummer: yes - i don't see how you can not if you want wiki in the database [17:01] jonnyb ckeditor does do some reformatting and sort of purifying in the browser, no way to stop it afaik [17:02] RobertPlummer jonnyb: Have you seen the demo in lib/core/JisonParser/Wiki/Demo.html? [17:02] changi RobertPlummer: in progress [17:02] changi jonnyb: hi [17:02] jonnyb hi changi [17:02] RobertPlummer Imagine the 2 controls, but rather than side by side, the output (which is on the right) on top of the textarea (on the right). [17:03] RobertPlummer The preview then becomes the edit area, the user knows no different. [17:03] RobertPlummer but when you go to save, there is no converting of anything to anything, you already have source, just grab it from the textarea. [17:04] RobertPlummer jonnyb: You follow? [17:04] RobertPlummer jonnyb: If you look at the demo, it would be much easier to understand. [17:05] jonnyb you mean lib/core/JisonParser/Wiki/Test.html? [17:05] RobertPlummer yup [17:05] RobertPlummer Right now I think line breaks aren't working, but it is just a proof of concept. [17:05] jonnyb no, still don't get it - you mean the preview can be editable? [17:06] RobertPlummer EXACTLY! [17:06] jonnyb how? [17:06] RobertPlummer Textarea is buggy, right? [17:07] jonnyb which one? block.textarea.php? [17:07] RobertPlummer We will use codemirror as a platform for integrating one with the other. [17:07] benoitg joined #tikiwiki [17:08] RobertPlummer you see textarea is buggy between browsers, it is hard to select text, find the carat, past text or remove text, but codemirror has a whole api for that. [17:08] RobertPlummer By using codemirror + a parser + some javascript to tie them together, we simplify the process of wysiwyg. [17:08] jonnyb personally i find codemirror less stable than the webkit one [17:09] jonnyb sounds worth a go i guess [17:09] RobertPlummer less stable than textarea cross browser? [17:09] RobertPlummer (that is a nasty can of worms) [17:10] RobertPlummer If there was an easier platform to modify textareas without using codemirro I'm open to it, we just need a way to modify text for the end user. [17:10] jonnyb you mean IE i guess - yes, selection tracking is a contsant thorn [17:11] RobertPlummer Anyway, that is the plan, I hope to start making progress with it by the mid year. [17:11] jonnyb not even consistent between IE versions :P [17:11] jonnyb coolio! [17:11] RobertPlummer But we will see, I have a lot to do yet with ForwardLink Protocol. [17:11] CIA-36 tikiwiki: 03lphuberdeau * r41254 10/branches/9.x/lib/wiki-plugins/wikiplugin_appframe.php: [FIX] Accordion would gather too many objects at once [17:12] RobertPlummer changi: How are things looking? [17:12] CIA-36 tikiwiki: 03lphuberdeau * r41255 10/branches/9.x/ (3 files in 3 dirs): [MOD] Adding configuration options to the tracker_input module [17:15] RobertPlummer changi: Restored yet? [17:15] arildb jonnyb and RobertPlummer: The new encoding of < and > seems to completely break the maketoc plugin in wysiwyg. [17:15] arildb The reason is that the following statements never find a header: $data = preg_replace('/<\/([a-z]+)>/im', "\n", $data); [17:15] arildb $data = preg_replace('/^\s+/im', "", $data); // headings with leading spaces [17:15] arildb $data = preg_replace('/\/>/im', "/>\n", $data); // headings after /> tag [17:16] changi RobertPlummer: trunkdev is up2date [17:16] arildb in parserlib.php line2042: private function parse_data_process_maketoc( &$data, $options, $noparsed) [17:17] jonnyb hi arildb - that sounds possible - sounds like it needs "unprotecting" before matching [17:17] jonnyb but i wonder why only in wysiwyg - possibly it happens in wiki pages with allowHtml on too? [17:18] arildb that could be [17:18] arildb the check is: if ($need_maketoc && $prefs["feature_wysiwyg"] == 'y' && $prefs["wysiwyg_htmltowiki"] != 'y') { [17:19] RobertPlummer arildb: Be careful there, that as a nasty nasty mess to get into. [17:20] * jonnyb agrees [17:20] RobertPlummer jonnyb: I honestly feel that turning off plugins inside wysiwyg would be a fix. [17:20] jonnyb i think the check should be on $is_html on the page [17:21] jonnyb you can still have html wysiwyg (or not) pages when wysiwyg_htmltowiki [17:21] jonnyb me too [17:21] RobertPlummer jonnyb: if you did that, and left the ability to click and edit, it would be a fix, because it would be more stable. [17:21] jonnyb quite a big change this late in the branch, no? [17:22] RobertPlummer I like the real time stuff, but not at the cost of stability. [17:22] RobertPlummer jonnyb: Either it needs fixed one way or the other. [17:22] jonnyb but this isn't while editing is it, arildb? [17:23] jonnyb that's why i suspect it would also fail on html wiki pages [17:23] arildb no, this is while displaying the page [17:23] jonnyb or am i wrong there? [17:23] jonnyb thought so [17:23] RobertPlummer What is the source? [17:23] jonnyb http://dev.tiki.org/tiki-pagehistory.php?page=WYSIWYG+testing&source=0 [17:23] jonnyb i'm just trying to get that page working locally to investigate [17:23] arildb see parserlib.php line 2042: private function parse_data_process_maketoc( &$data, $options, $noparsed) [17:24] jonnyb that's when i found the problem with html and disabled plugins (fix for which on it's way) [17:24] RobertPlummer jonnyb: marc told me about a few things that looked like it is being html encoded to many times and not ever decoded. [17:24] RobertPlummer draw for one doesn't look right. [17:25] jonnyb i know, he mailed me [17:25] RobertPlummer I need to head out for a bit. [17:25] RobertPlummer be back later. [17:25] jonnyb k, cu l8r [17:28] marclaporte joined #tikiwiki [17:28] CIA-36 tikiwiki: 03gta74 * r41256 10/branches/8.x/lang/de/language.php: [TRA] full translation [17:31] Tiki|bot Recent Bug: Tracker item: #4208 - - Category field does not handle 0 as Parent Category - http://dev.tiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=4208 [17:31] jonnyb wysiwyg preview seems broken again :( [17:34] arildb yes, it does jonnyb. It was working after your "session". Hopefully the just released 9.0 version is OK [17:34] jonnyb seems to be only when you stick the preview in the popup window, think i know why... [17:40] CIA-36 tikiwiki: 03jonnybradley * r41257 10/branches/9.x/lib/parser/parserlib.php: [17:40] CIA-36 tikiwiki: [FIX] parser: Change the plugin_remove function to use WikiParser_PluginMatcher instead of parse_first. [17:40] CIA-36 tikiwiki: Fixes an issue on html pages when saving markup containing disabled plugins (the "Plugin disabled" remarksbox was getting saved in the page). [17:40] CIA-36 tikiwiki: Also, will be *much* cheaper to process as parse_first executes all the plugins as well. [17:42] jonnyb changi: collation fix just ran for me locally - all seems fine, thx [17:46] changi jonnyb: nice to hear that [17:47] changi jonnyb: i was thinking limitting the table to name for those who are using shared hosting [17:47] jonnyb how do you mean? [17:48] changi limit table names to tiki_ messu_ users_ [17:49] jonnyb ah right - yes, that would be polite :) [17:49] jonnyb (not that the other charset ones do, do they?) [17:49] changi no they don't:) [17:50] changi we are little brutal with that [17:50] arildb jonnyb: in parserlib create_page, $parserlib->plugins_replace($data, $noparsed); is called after calling HTMLPurifier. Shouldn't that be $parserlib->plugins_replace($data, $noparsed, truel); ? [17:51] changi arildb: i love the truel :) [17:51] arildb :-) true..of course [17:52] jonnyb true for html you mean arildb? [17:52] arildb jonnyb: It's only called for html [17:52] jonnyb i thought it was (maybe i only fixed the update_page one) [17:52] arildb ok for update_page [17:54] arildb changi: btw. I downloaded and installed 8.4...looks good [17:55] jonnyb arildb: yes, you're right - update_page got done but not create [17:55] changi arildb: thx [17:57] nkoth|nelson joined #tikiwiki [17:57] nkoth|nelson anyone else noticed that admin panel Save Changes button has gone missing in 9.x? [17:58] jonnyb hi nkoth|nelson - what all of them? [17:58] nkoth|nelson yes, all of them [17:58] jonnyb which theme? fine in jqui [17:59] nkoth|nelson wait, ot's back [17:59] jonnyb :) [17:59] nkoth|nelson strange [17:59] arildb jonnyb: Are you fixing create_page, or should I? [18:00] jonnyb arildb: please do if you're on it, thanks [18:01] arildb will do [18:02] CIA-36 tikiwiki: 03eromneg * r41258 10/branches/9.x/ (lib/setup/error_reporting.php templates/footer.tpl): [FIX] error reporting 'leak' to main page content for particular E_USER_NOTICE. Add extra logic to error_reporting.php and additional conditions for showing the error button in footer.tpl [18:02] Tiki|bot Recent Bug: Tracker item: #4209 - - Only first-level categories can be selected for categorizing a tracker - http://dev.tiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=4209 [18:05] nkoth|nelson I see, the missing save button is onlly in Admin ...community [18:05] CIA-36 tikiwiki: 03arildb * r41259 10/branches/9.x/lib/tikilib.php: [FIX] plugins_replace must use is_html = true for create_page, when html is processed [18:06] jonnyb odd - i have one (says Change preferences) - two, in fact! [18:07] nkoth|nelson I have a css problem [18:37] CIA-36 tikiwiki: 03jonnybradley * r41260 10/branches/9.x/ (lib/ajax/autosave.js tiki-auto_save.php): [FIX] preview: Fix preview display in popup window for html/non-html pages in both editors. Also fix url_decode for page names [18:42] CIA-36 tikiwiki: 03lphuberdeau * r41261 10/branches/9.x/ (4 files in 3 dirs): [MOD] Allowing to redirect upon successful insert [18:54] CIA-36 tikiwiki: 03lphuberdeau * r41262 10/branches/9.x/lib/wiki-plugins/wikiplugin_appframe.php: [FIX] Accordion, again [18:55] ricks99 anyone.... RSS feed for tiki calendar (http://info.tiki.org/tiki-calendar_rss.php is gone :( [18:55] eromneg joined #tikiwiki [18:56] jonnyb ricks99: shouldn't it be feed://info.tiki.org/tiki-calendars_rss.php (also doesn't seem to be doing anything tho) [18:57] jonnyb ah, just slow... [18:58] ricks99 hmm... [18:58] ricks99 link from admin page is "calendar" [18:59] ricks99 info running 6.LTS [18:59] ricks99 too bad changi just built 6.8 this morning :( [18:59] ricks99 wonder if it is wong in other versions... [19:00] jonnyb stinky - probably [19:00] changi ricks99: 6.8 is not built [19:01] ricks99 ah.. [19:01] ricks99 thx [19:01] ricks99 do i commit to proposals/6? [19:01] changi ricks99: ask jonny [19:02] changi ricks99: i'm not in quality team [19:02] jonnyb good question - i think in theory the quality team is "resting", so both maybe? (and 9 and 8 ;) ) [19:02] ricks99 8 is done, right? [19:02] ricks99 done=closed. [19:02] ricks99 changi just ran the 8.4 this morning [19:03] jonnyb yes, i guess so [19:03] ricks99 k. i will commit to 6.x, 9.x, and trunk [19:03] * ricks99 surprised that it wasn't found earlier... maybe he's the only one still using RSS [19:03] jonnyb you don't need to do trunk, but if you do please make sure it's exactly the same (to avoid conflicts) [19:04] ricks99 exactly the same as... ? [19:04] changi ricks99: don't commit in trunk, easier :) [19:04] changi jonny will be pleased to merge it :) [19:04] ricks99 lol [19:04] jonnyb exactly the same including white spaces, case sensitive etc [19:05] ricks99 good thing most of my sites are all 6.x LTS :) [19:05] jonnyb i'll do a merge in a minute [19:05] CIA-36 tikiwiki: 03ricks99 * r41263 10/branches/6.x/templates/tiki-admin_include_rss.tpl: [FIX] incorrect URL link for calendar RSS from admin page [19:06] jonnyb by the way, anyone know what the policy is now on lang file conflicts (just got some) - keeping trunk version was previous behaviour, i guess it's the same [19:06] ricks99 jonnyb: ok for me to commit to 9.x? [19:06] ricks99 language, yes, keep trunk [19:06] jonnyb yes please :) [19:06] jonnyb thanks ricks99 [19:08] CIA-36 tikiwiki: 03jonnybradley * r41264 10/branches/9.x/lib/parser/parserlib.php: [FIX] wysiwyg: No longer need to encode entities for plugin output [19:08] ricks99 ahhh.. it was correct in 9 [19:08] ricks99 cool [19:08] ricks99 and... it will b in 6.8 :-) [19:08] * ricks99 happy [19:26] arildb joined #tikiwiki [19:29] changi ricks99: you don't need much to be happy [19:29] changi :) [19:31] ricks99 nope... just a working rss link. :) [19:32] changi ricks99: you want me to update info.tiki.org ? [19:33] ricks99 pls do. tx [19:33] changi ricks99: will have no effect, it's based on proposals. [19:33] changi could you commit it there ? [19:34] ricks99 sure thing... [19:34] jonnyb er... ricks99? I think we should still be doing the same discipline of backporting things to 6.x from 9.x/trunk even if we're not using proposals [19:35] jonnyb did you do it in 9.x (maybe i missed it) [19:35] jonnyb was waiting to do a merge... [19:35] CIA-36 tikiwiki: 03ricks99 * r41265 10/branches/proposals/6.x/templates/tiki-admin_include_rss.tpl: [[FIX] incorrect URL link for calendar RSS from admin page. Backport of 41263 [19:35] ricks99 jonnyb: was already correct in 9. [19:35] ricks99 was only broken in 6 [19:35] jonnyb oh right, jolly good :) [19:36] changi ricks99: done :) [19:36] jonnyb (but strange) [19:36] ricks99 possibly something that got fixed a while back, but forgot to backport. [19:36] ricks99 thnx changi [20:03] Tiki|bot Recent Bug: Tracker item: #4210 - - Plugin Lastmod - http://dev.tiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=4210 [20:04] CIA-36 tikiwiki: 03jonnybradley * r41266 10/branches/9.x/lib/parser/parserlib.php: [FIX] wysiwyg: Un, then re-protect special chars when parsing html headings for maketoc (thanks arildb) [20:10] jonnyb by the way arildb - you need to use double quotes on maketoc to get the title to work - i tried to fix the regexp for ages, couldn't get it (this time) [20:10] arildb ok. does it work OK with double quotes? [20:12] arildb there is also another bug in maketoc. (as you can see on the wysiwyg testing page). If the header contains another tag, maketoc fails to parse it. The first header contains a
. Thus missed. [20:12] arildb trying to change to double quotes [20:12] jonnyb best of luck! :) [20:13] arildb :-) ...was hoping you had time, but [20:13] jonnyb :) [20:13] arildb double quotes OK [20:35] CIA-36 tikiwiki: 03jonnybradley * r41267 10/trunk/ (100 files in 72 dirs): [20:35] CIA-36 tikiwiki: [MRG] Automatic merge, branches/9.x 41183 to 41266 [20:35] CIA-36 tikiwiki: Fixed lang file conflicts using "mine-conflict" [20:36] jonnyb by the way arildb, the line height thing is due to the body definition in most of the css files: font: 76%/1.5em - seems better with font: 76%/150% but i'm not sure about this, let's ask chibaguy when he's about? [20:37] arildb I wouldn't worry too much about that one. I am not bothered by it. It's just a part of the test. However, if there is a fix. that's better [20:37] jonnyb likewise [20:42] Tiki|bot New Forum Posts: Optimizing Search Results - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=43933 [20:47] * changi watching London Boulevard [20:47] _qP joined #tikiwiki [20:47] * jonnyb googles [20:48] jonnyb at least it has http://www.imdb.com/name/nm0461136/ in it :P [20:49] * jonnyb curses Mac OS copy and paste... [20:49] jonnyb Keira Knightley i meant [20:52] jonnyb Oh, i do like phpstorm! i just (by mistake) asked it to do a full diff preview of the last merge to trunk and it ran out of RAM, but offered me a dialog to raise it which worked like a charm (so much nicer than having to hack the ini file as in eclipse/aptana) [20:52] nkoth|nelson jonnyb: so f I have a fix is it enough that I commit only to 9.x (are you runnning the automatic merges?) [20:52] arildb_ joined #tikiwiki [20:53] jonnyb yes please - all seems to be going ok so far (famous last words ;) ) [20:57] CIA-36 tikiwiki: 03nkoth * r41268 10/branches/9.x/lib/filegals/filegallib.php: [FIX] transform image as long as there is max width or height [21:23] marclaporte joined #tikiwiki [21:24] benoitg joined #tikiwiki [21:24] jonnyb hi marclaporte here too :) [21:26] arildb jonnyb: The maketoc fix seems to work in 9.x, but not in trunk. It displays the test headers as: !head 1 !!head 2 !head 1a [21:26] CIA-36 tikiwiki: 03lphuberdeau * r41269 10/branches/9.x/lib/core/Tracker/Field/GeographicFeature.php: [FIX] Typo [21:26] arildb any idea? [21:27] CIA-36 tikiwiki: 03lphuberdeau * r41270 10/branches/9.x/lib/core/Tracker/Field/ItemLink.php: [NEW] Adding an option to index field from the remote tracker when using item link [21:27] jonnyb ik, nasty - a merge failure? [21:28] arildb I am having problems getting the full download from SVN (seems to always fail somewhere in the externals sync)...So, the error may be on my side. [21:29] arildb The source for my test is:

{maketoc}

head 1

head 2

head 1a

[21:29] arildb If you have a trunk installation maybe you have time to create a test page? [21:30] arildb Resulting display in trunk is: !head 1 !!head 2 !head 1a [21:31] jonnyb actually wrestling with a WSoD on trunk here at the moment! :) will try and check it when/if i get it working... [21:32] arildb ok, thanks [21:36] jonnyb i did notice that tags get "de-parsed" to wiki syntax in there and was a bit surprised it works at all - the maketoc code is pretty old (and mysterious) [21:45] arildb ah...maybe the html flag is missing? [21:46] RobertPlummer back [21:49] RobertPlummer jonnyb: what is the status with parser? [21:49] jonnyb looking good, i think [21:50] jonnyb could be arildb [21:50] RobertPlummer I tested up changes to the parser for plugin fingerprint, and it still looks like it might be broken. [21:50] RobertPlummer Have you had any problems? [21:51] jonnyb RobertPlummer: arildb is having fun with maketoc in html pages [21:51] RobertPlummer Having fun, or going mad? [21:52] arildb we are getting there slowly.... [21:52] RobertPlummer (from the 3rd person they can look the same) [21:52] arildb The html flags look ok [21:52] jonnyb i'm in trunk at the mo - finding IDS_Monitor causing issues [21:53] jonnyb arildb: that bit should be the same in 9.x and trunk - must be another difference somewhere [21:53] RobertPlummer ok, so I will keep working on this fingerprint issue. [21:53] arildb jonnyb: yes, I think you are right [21:53] jonnyb i'll try a diff on parserlib [21:54] RobertPlummer arildb: What is the problem with maketoc? [21:54] jonnyb no, not parserlib [21:54] arildb works ok in 9.x, but in trunk, using

{maketoc}

head 1

head 2

head 1a

...produces !head 1 !!head 2 !head 1a [21:55] jonnyb after maketoc messes with the headings get shown as wiki syntax [21:55] RobertPlummer sounds like a ~np~ issue. [22:14] CIA-36 tikiwiki: 03jonnybradley * r41271 10/trunk/ (db/ids_config.ini tiki-setup_base.php): [22:14] CIA-36 tikiwiki: [FIX] phpids: Doesn't seem to like the themegen cookie (as it can have "closed" in it?) [22:14] CIA-36 tikiwiki: Also show some sort of error message when a request has been prevented instead of a WSoD [22:22] RobertPlummer I think I see a potential issue in the plugins args, they aren't being decoded before the check of fingerprint. [22:22] RobertPlummer This is in the conversion script. [22:47] arildb_ joined #tikiwiki [22:49] RobertPlummer jonnyb: I'm trying some new stuff with the script, it just isn't working in some cases. [22:49] RobertPlummer jonnyb: I'm not sure if it is an encoding problem (!= utf8) or what. [22:50] jonnyb yum, sounds like fun (fading here, will catch up tomorrow) [22:50] RobertPlummer jonnyb: I've moved from htmlspecialchars_decode to html_entity_decode, trying an upgrade right now on demo.t.o. [22:52] redflo joined #tikiwiki [22:52] RobertPlummer jonnyb: Or maybe the first one needs to be htmlspecialchars_decode and the second one needs to be html_entity_decode [22:57] arildb I just sync'd with trunk. When trying to access Tiki, I get: "Request prevented" [22:58] jonnyb arildb: i just lost an hour or 2 with that - it's some new security stuff :( [22:58] jonnyb before r41271 you just got a white page [22:58] arildb how do I get Tiki started again? [22:58] jonnyb can you debug? [22:59] arildb so, this is an improvement :( ...yes, I can debug..will try [22:59] jonnyb you could try deleting all your cookies for a start [22:59] arildb ok [23:00] jonnyb i found the themegen cookie was triggering it, but it uses the php session so store "hits" so maybe a new session (i.e. cookie) will clear it [23:00] arildb worked !!! Thanks jonnyb [23:00] jonnyb grand [23:08] arildb_ joined #tikiwiki [23:14] RobertPlummer jonnyb: Is it possible that some plugins are 3 times html encoded? [23:16] RobertPlummer I'm forcing html double decoding and seeing if that does the trick, if it doesn't then it could be 3 times encoded. [23:21] pkdille joined #tikiwiki [23:23] pkdille joined #tikiwiki [23:28] CIA-36 tikiwiki: 03pkdille * r41272 10/branches/9.x/lib/ (parser/parserlib.php tiki-js.js): [FIX] showhide parameter of maketoc. Collateral damage of r24793