[00:11] luciash leagris: i do not think so. afaik nobody is working on that... [00:42] marclaporte joined #tikiwiki [01:00] amette_ joined #tikiwiki [01:05] marclaporte1 joined #tikiwiki [01:09] leagris Please advise. What should I do if I need new/replace string/key? [01:10] leagris should I parse all language files and remove corresponding obselete keys? [01:14] marclaporte1 leagris: can you give an example? [01:15] marclaporte joined #tikiwiki [01:17] arildb https://dev.tiki.org/ is down [01:17] arildb and back up again :) [01:18] leagris http://pastie.org/8175897 [01:18] leagris Here an example diff of tra('key') changed [01:19] leagris tiki_cdn evolve from sisngle cdn to multiple cdn [01:19] leagris form field syntax evolve from single line to multiline [01:22] marclaporte ok, look at get_strings.php [01:24] marclaporte As you are doing in trunk, just modify what you need in the code, and you don't need to worry about get_strings.php [01:25] leagris ok fine [01:30] leagris done :) [01:30] leagris Enjoy multi-cdn support [01:32] Tiki-KGB tikiwiki 03leagris r46854 10trunk/lib/ 10headerlib.php 10prefs/tiki.php 10init/smarty.php [01:32] Tiki-KGB tikiwiki [ADD] feature multi_cdn [01:37] leagris I have it working on 11.x, and it work as-is without migrating any data. If only one cdn is configured, it uses it. [01:45] goj joined #tikiwiki [02:05] Ludo- joined #tikiwiki [02:09] fabricius polom [02:10] Tiki|bot joined #tikiwiki [02:30] Anzhe joined #tikiwiki [03:11] Tiki|bot New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 [03:23] goj_killedByISP joined #tikiwiki [04:12] Anzhe here's a thought - is there a plug-in or tweak that allows the "Contact Us" form to go to more than one user? [04:44] chibaguy joined #tikiwiki [04:44] chibaguy polom [05:01] chibaguy joined #tikiwiki [05:08] Anzhe joined #tikiwiki [05:22] Anzhe can someone explain Content Templates to me for a moment? (http://doc.tiki.org/Content+Templates) [05:22] Anzhe Regarding wiki pages currently using a template [05:23] Anzhe when the template is updated, that link says the pages using the previous template version do not change [05:23] Anzhe how then does one go about updating them? [05:23] Anzhe must you manually re-apply the template to each page? is there a way to see the pages that use a given template and which are up-to-date? [05:24] chibaguy joined #tikiwiki [05:28] luciash Anzhe: the content templates are useful only as a page content starters [05:29] luciash Anzhe: once the page is written there is no way to control what other people write and change in it so re-applying the template only adds it again at the beginning or end of the existing page content [05:29] luciash chibaguy: hi [05:31] * luciash goes off [05:34] Anzhe :luciash, thank you for the tip [05:58] binarymutt joined #tikiwiki [05:58] Anzhe for Wiki History, can someone please explain to me the significance of the Keep versions for __ days config? [05:59] Anzhe if I have unlimited versions (Maximum number of versions: 0) what does keeps versions for __ days do? [06:29] chibaguy oops, hi luciash (no longer here). [07:23] Tiki|bot New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297 [07:54] Tiki|bot New Forum Posts: Wiki History config - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297 [07:54] Tiki|bot New Forum Posts: New to tiki-devel, Introducing myself to the community - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 [07:54] Tiki|bot New Forum Posts: allow multiple cdn per protocol - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279 [08:04] Tiki|bot New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297 [08:04] Tiki|bot New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 [08:04] Tiki|bot New Forum Posts: allow multiple cdn per protocol - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279 [09:24] redflo joined #tikiwiki [10:53] arildb joined #tikiwiki [10:55] Jyhem_laptop joined #tikiwiki [11:54] arildb_ joined #tikiwiki [12:16] Anzhe_m joined #tikiwiki [12:21] arildb joined #tikiwiki [12:33] jonnyb joined #tikiwiki [12:34] jonnyb poets polom [12:45] Tiki|bot New Forum Posts: Where to commit [was allow multiple cdn per protocol] - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48300 [12:51] Anzhe_m joined #tikiwiki [12:57] chibaguy joined #tikiwiki [13:10] arildb joined #tikiwiki [13:17] Tiki|bot joined #tikiwiki [13:21] arildb Hi jonnyb [13:21] jonnyb hi arildb [13:21] jonnyb been thinking about the branch and the inline stuff [13:21] arildb I updated the write-up + a couple of issued on https://dev.tiki.org/Inline+Editing#Saving_inline_changes. Also added an open question about saving inline comment. Did you have a look at it? [13:22] jonnyb thinking it might be a good time to merge soon if it seems ok to you [13:22] arildb yes, I think it's ready. [13:22] jonnyb after that i'm going to have a go (in that branch) at converting all the old hacky ajax stuff to proper services, which should make it seem all nice and clean and fresh! :) [13:23] arildb sounds good. Will you do the merge, or do you want me to do it? [13:23] jonnyb one main issue i think with getting plugins working is that it's not using the auto_save plugin, and most of the parsing etc for plugins is done by that [13:23] jonnyb i'll have a go - phpstorm seems to make that quite civilised [13:24] arildb sounds good to me :-) [13:24] jonnyb btw, i've been meaning to ask, what IDE do you use? I see whatever it is it keeps putting in stinky windows linefeeds :P [13:26] jonnyb stuff to do here, bbl [13:27] arildb I use vs.php, which is a PHP project plugin for Visual Studio. Getting the line endings right is a bit nasty. I haven't found a global setting for it :-( [13:27] jonnyb aha, thought i detected the smell of Micro$oft :D [13:27] arildb lol [13:27] jonnyb try phpstorm - we have a license for tiki use [13:27] jonnyb must go, bbl [13:27] arildb I might do...one day [13:53] jonnyb joined #tikiwiki [13:54] fabricius joined #tikiwiki [14:13] arildb Hi jonnyb. I updated the section https://dev.tiki.org/Inline+Editing#Saving_inline_changes based on your comment here on IRC [14:15] jonnyb thanks arildb - reading... [14:16] jonnyb good points about type of save - i wonder if we can guestimate it - like if more than 50 (?) chars edited then it's a major one? [14:17] arildb I have installations that "prefer" long pages. A correct use pattern becomes more important. I doubt users will follow it. [14:19] arildb btw. I added a 1000 paragraph test page: Lorem Ipsum. Good for testing large pages [14:20] arildb I don't quite understand your question [14:22] jonnyb well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation) [14:22] jonnyb we need a "you have unsaved changes" thing on leaving the page too... [14:22] jonnyb but these can happen in trunk - more eyeballs :O [14:22] arildb yes, you are right [14:23] jonnyb ok, i'm going to do merge #1 [14:23] arildb :-) [14:24] jonnyb oops, found some commits from last night :| [14:26] Tiki-KGB tikiwiki 03jonnybradley r46855 10branches/experimental/ckeditor4/tiki-setup.php [14:26] Tiki-KGB tikiwiki [FIX] Don't use inline edit when editing [14:30] Tiki-KGB tikiwiki 03jonnybradley r46856 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php [14:30] Tiki-KGB tikiwiki [FIX] textarea: Default to having the switcheditor button following logic correction in function.toolbars [14:32] Tiki-KGB tikiwiki 03jonnybradley r46857 10branches/ 10(12 files in 8 dirs) [14:32] Tiki-KGB tikiwiki [MRG] Automatic merge, trunk 46847 to 46854 [14:34] jonnyb all this merging stuff is so much better without 94,000,000 svn externals slowing everything down! :) [14:39] jonnyb also doing it in phpstorm is so much better - gives you a nice list of commits to merge, you can ignore all the ones that might cause trouble (merge conflicts etc) [14:40] arildb sounds like you have become a fan (as I think Robert was) [14:40] jonnyb for a couple of years now :) [14:41] jonnyb http://dev.tiki.org/phpstorm?highlight=phpstorm#Top_10_Reasons_to_Love_PhpStorm [14:43] arildb sounds like a good devenv. I bet it gets the line endings right, too ;-) [14:43] jonnyb :D [14:44] jonnyb i have tried about all of them over the years, nothing else comes close for php, especially for tiki (try opening up 4 branches of tiki at once in anything else!) [14:45] arildb is there a windows version? [14:46] jonnyb yes, i think it's available on everything (java based, but not so you'd notice) [14:46] jonnyb contact admin@tiki.org for a license key if you decide to continue using it (there's a 30 day trial i believe) [14:47] arildb download site is http://www.jetbrains.com/phpstorm/ it seems [14:47] jonnyb personally i use it for everything, not just open source stuff and am happy to pay them the $40 a year to keep them going, i like rewarding good programming! [14:47] jonnyb yy [14:47] arildb yes [14:48] jonnyb ok, have local merge done - checking... [14:49] jonnyb what's this fix in tiki-js-sorttable.js? just wrong branch or have i messed up? [14:50] jonnyb http://sourceforge.net/p/tikiwiki/code/46779 [14:51] jonnyb committed separately [14:52] Tiki-KGB tikiwiki 03jonnybradley r46858 10trunk/lib/tiki-js-sorttable.js [14:52] Tiki-KGB tikiwiki [bp/r46779][FIX] Declare variables to avoid JS warnings (backported from experimental/ckeditor4) [14:52] arildb It declares the valiable to avoid JS warnings [14:52] jonnyb yes, but nothing really to do with ckeditor (so merged separately) [14:53] jonnyb generally (although it's more dull) when i found non-inline-editing-based fixes i fixed them in trunk then merge into ckeditor4 [14:53] jonnyb hence it being handy to keep several tiki branches open at once :) [14:54] arildb It made breaks all the time in the debugge. I have to Firebug to debug javascript. [14:54] jonnyb yes me too - you can always click "ignore" in firebug (each session sadly) [14:55] jonnyb i think sorttable has a pref though too so could just be switched off [15:03] leagris Never took the time to set it up properly PhpStorm though I got a licence :) [15:06] arildb leagris: which platform are you usually on, Linux? [15:06] leagris I'll have to give it more attention. Shell vi, grep, perl -p -i -e 's/replace this/with this/g' file, diff, find, are all nice but sharp tools ;D [15:06] arildb yes...seems so [15:06] leagris Ubuntu Linux [15:09] jonnyb um.. is anyone else getting icons replaces by green ? in trunk? [15:10] jonnyb the green question marks are what the icon function returns along with an error "title" saying: "Error: directory '' not allowed by security setting" [15:13] jonnyb leagris: i'm just wondering if this might be connected to the recent smarty security stuff? [15:30] leagris it is [15:31] leagris jonnyb did you clear all caches? [15:31] Anzhe_m joined #tikiwiki [15:31] jonnyb yes, clearing every reload - also just did "php temp/composer.phar install" as there was a smarty update... still got little green ? everywhere [15:32] jonnyb i added a check for if (!empty($cdn)) around the trusted_uri lines, but still the same [15:32] leagris Crap, ill have to check this if no CDN :) [15:33] jonnyb often a "gotcha" when adding new stuff, testing with it turned off :) [15:33] leagris Do you have empty CDN entries? [15:33] * jonnyb needs to do that with inline editing [15:33] jonnyb yes [15:33] jonnyb and i was ending up with ##i as my trusted_uri's [15:33] jonnyb but i don't think that's it... [15:35] dhazel joined #tikiwiki [15:36] ricks99 joined #tikiwiki [15:36] jonnyb looks like line 360 of /vendor/smarty/smarty/distribution/libs/sysplugins/smarty_security.php now returns false from realpath for img dirs - as they're tikiroot relative now, instead of absolute (like template dirs are) - odd [15:37] leagris What error do you get when hover mouse on question marks? [15:38] jonnyb Error: directory '' not allowed by security setting [15:38] jonnyb so an empty path [15:38] jonnyb i can't see how your changes could be doing this - just a coincidence maybe [15:39] leagris maybe not [15:40] leagris Before my change the trusted_uri was non_existant [15:40] jonnyb mmm, i tried unsetting it if empty but no change [15:40] leagris now, when no CDN is used, it get an empty array (so array exists) [15:42] leagris Fortunately, if you add your site base http://... to cdn the error may dissapear ;D [15:42] jonnyb aha, will try... [15:42] leagris I guess I forgot to add site base URI to trusted_uri ;D [15:43] arildb I am running a composer.phar update. Updating smarty/smarty (v3.1.13 => v3.1.14). Get a question: Discard changes [y,n,v,?]? ... what should I answer? [15:44] leagris v (to see what changes) [15:44] jonnyb yes, composer meets svn weirdness - just discard usually [15:45] arildb lots of files. I can't get to the top of the listing. Here's a section ... [15:45] arildb documentation\ja [15:45] arildb documentation\ja\appendixes [15:45] arildb documentation\ja\appendixes\bugs.xml [15:45] jonnyb doesn't always work, if stubborn just remove that dir [15:45] arildb answered y [15:47] jonnyb i tried adding my localhost/tiki/etc as a can and i now get "This is a Content Delivery Network (CDN) to speed up delivery of images, CSS, and javascript files. However, PHP code is not executed." [15:48] * jonnyb goes to hack the database ;) [15:50] * jonnyb notes to self: double check the destination branch __before__ doing a two hour merge from experimental [15:52] Anzhe joined #tikiwiki [15:55] jonnyb by the way - the shelve feature in phpstorm is brilliant for this kind of thing :) [15:58] jonnyb leagris: confirmed i'm afraid - without r46854 i have icons, with it - little green question marks everywhere [15:58] jonnyb (no other changes in my trunk now) [16:04] Tiki-KGB tikiwiki 03arildb r46859 10trunk/db/tiki_convert_myisam_to_innodb.sql [16:04] Tiki-KGB tikiwiki [FIX] Add missing tables in myisam to innodb conversion [16:09] leagris jonny I made a big newbe error, working a fix ;D [16:10] jonnyb no worries - so am i, let's see if we end up with the same stuff :) [16:10] leagris reproduced your bug, so it help [16:11] leagris same bug on my multi-cdn trunk commit [16:11] jonnyb looks like it's the bit in convert_cdn in headerlib [16:11] jonnyb need to test for not empty instead of isset, i reckon [16:11] leagris it is a bug in lib/init/smarty.php [16:12] Tiki-KGB tikiwiki 03arildb r46860 10trunk/db/tiki_convert_myisam_to_innodb.sql [16:12] Tiki-KGB tikiwiki [DOC] Add comment about MySQL 5.6 or later, InnoDB then supports fulltext indexes. [16:12] leagris I initialize trusted_uri with regex even if tiki_cdn and tiki_cdn_ssl are empty [16:12] leagris It always produce a PREG if cdn empdy ;D [16:13] leagris empty [16:13] jonnyb this seems to fix it for me - http://pastebin.com/9cGFGb5a [16:15] leagris Right, need this fix in headlerlib as a simmilar fix in lib/init/smarty.php to be safe [16:16] jonnyb true [16:16] jonnyb did you see my mail about pref separators? [16:16] leagris I would not trust smarty security with trusted_uri of #$#i [16:17] jonnyb agreed, probably would spoil something somewhere [16:18] leagris Yess, seen it but did not look at it so close. [16:18] jonnyb by the way, i don't think you need that $i counter var in /lib/init/smarty.php - just doing "$this->trusted_uri[] = blahblah" will push the value onto the end of the array [16:19] leagris Ah yes the trunk version. good to know [16:19] leagris I guess PHP is nicer than COBOL with arrays ;D [16:20] jonnyb ha ha, everything is (i'd guess) [16:20] leagris DATA DIVISION (fu#@k) [16:21] leagris Well, now let me resynk of 11.x and trunk and push some fixes; D [16:21] jonnyb never done COBOL myself - have a friend who had to learn it for a (legacy) job - he called it "Jurassic Code" :) [16:22] Tiki-KGB tikiwiki 03lphuberdeau r46862 10branches/11.x/lib/filegals/filegallib.php [16:22] Tiki-KGB tikiwiki [FIX] Uploading as an other user should not be possible by anyone [16:22] * jonnyb is glad this went into trunk rather than stable after all ;) [16:22] leagris Had to learn GAP2 (IBM36) and then found COBOL a civilized language ;D [16:23] jonnyb :D [16:25] leagris IBM36 such a large impressive gandma furniture cabinet with this surprisingly so small and crappy power switch ;D [16:25] leagris Much like the WOPR in WarGames, without the fancy blinking led pannels [16:28] Tiki-KGB tikiwiki 03lphuberdeau r46863 10trunk/lib/filegals/filegallib.php 10trunk [16:28] Tiki-KGB tikiwiki [MRG] Automatic merge, branches/11.x 46846 to 46862 [16:33] Anzhe joined #tikiwiki [16:35] marclaporte joined #tikiwiki [16:40] Tiki-KGB tikiwiki 03lphuberdeau r46864 10trunk/ 10lib/core/Services/File/VimeoController.php 10lib/filegals/vimeolib.php 10templates/vimeo/upload.tpl [16:40] Tiki-KGB tikiwiki [ENH] Set the video title when uploading [16:45] jonnyb phew - ok arildb, first merge from ckeditor4 branch just committed - can you check everything arrived ok please? [16:46] Tiki-KGB tikiwiki 03jonnybradley r46865 10trunk/ 10(10 files in 8 dirs) [16:46] Tiki-KGB tikiwiki [MRG] Phase one of merges from ckeditor4 - initial implementation of inline editing, mostly working... (but more to come from this branch) [16:46] Tiki-KGB tikiwiki ** Warning: Can mess up pages containing wiki plugins! Marked as experimental. [16:46] Tiki-KGB tikiwiki Full commit details here: https://dev.tiki.org/Inline+Editing#Notes_etc [16:46] arildb great! [16:46] arildb checking [16:46] jonnyb my main test page has loads of plugins in, and most of them go badly wrong... so watch out! ;) [16:46] arildb yes I saw the details. One or two words per line. Pretty unreadable...on my side [16:50] Tiki-KGB tikiwiki 03jonnybradley r46866 10branches/ 10(10 files in 7 dirs) [16:50] Tiki-KGB tikiwiki [MRG] Automatic merge, trunk 46854 to 46865 [16:52] Jyhem_laptop joined #tikiwiki [16:54] arildb jonnyb: difficult to test. The inline editor icon is a question mark and doesn't work [16:54] jonnyb yes... um, leagris, how you doing with your fix? ;) [16:55] jonnyb arildb: this http://pastebin.com/9cGFGb5a patches it for me for now... [16:55] arildb checking [17:03] arildb problem is still there [17:03] jonnyb which problem? [17:04] arildb the question marks instead of icons in trunk [17:04] jonnyb joined #tikiwiki [17:04] arildb jonnyb: I think you missed my answer: the question marks instead of icons in trunk [17:06] jonnyb sorry yes - did you clear all caches? [17:10] arildb cleared cache. fixed it. [17:10] arildb testing now [17:10] jonnyb :) [17:11] arildb The Homepage is editable, buit I don't get any toolbar [17:12] jonnyb oh? seems ok here [17:12] jonnyb browser cache maybe? [17:13] arildb doesn't work properly. Added a new page. Activated the inline editor, but not able to edit [17:14] Tiki-KGB tikiwiki 03lphuberdeau r46867 10trunk/ 10(7 files in 6 dirs) [17:14] Tiki-KGB tikiwiki [ENH] Move the OAuth endpoints to services [17:15] arildb tried in opera. The same [17:18] arildb cleared the browser cache in opera. Still the same [17:19] arildb option Wysiwyg editor was off [17:22] arildb still nothing [17:22] arildb cleared the cache again too [17:25] arildb the editor tags are not present in the page, but the inline editor is active [17:26] jonnyb is this on your local? [17:26] jonnyb any js errors? (he always asks ;) ) [17:27] jonnyb i've just committed a fix for plugins in ckeditor4 - think i'll try it on trunk as it makes it less dangerous (and will check my toolbars etc) [17:27] arildb local yes. No JS errors [17:28] Tiki-KGB tikiwiki 03jonnybradley r46868 10branches/ 10(5 files in 5 dirs) [17:28] Tiki-KGB tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable [17:28] jonnyb the toolbars i get in trunk look different - different skin presumably [17:29] jonnyb yes, was kama - changed to default [17:29] arildb I do get an error msg [17:29] arildb Timestamp: 26.07.2013 22:29:11 [17:29] arildb Error: TypeError: Components.classes['@mozilla.org/browser/global-history;2'] is undefined [17:29] arildb Source File: chrome://pdfdownload/content/pdfDownloadOverlay.js [17:29] arildb Line: 375 [17:30] arildb does it make any sense to you? [17:30] marclaporte jonnyb & arild: I will make demo site for exciting WYSIWYG inline. Do I make seperate for inine HTML-WYSIWYG and inline wiki-WYSIWYG ? [17:30] jonnyb hi marclaporte [17:31] jonnyb i wouldn't bother - i generally make a test page for each (by changing the pref in between) [17:31] marclaporte arildb: http://demo.tiki.org/6x/tiki-list_file_gallery.php [17:31] jonnyb they should live happily together (eventually) [17:31] arildb marclaporte: why not just enable inline editing for the existing wysiwyg-* sites. [17:33] marclaporte current WYSIWYG are 11.x [17:33] marclaporte should they be trunk? [17:33] arildb marclaporte: I was sure that fix was included [17:33] arildb marclaporte: yes, they need to be trunk [17:36] Tiki-KGB tikiwiki 03jonnybradley r46869 10trunk/styles/utopias.css [17:36] Tiki-KGB tikiwiki [CSS] utopias: Remove odd float left for span in #page-bar (was messing up comments count and served no apparent use) [17:42] panamaus ricks99: I checked version 11 on the demo wiki, and the file gallery backlinks bug is present there too [17:43] panamaus every time you save a wiki page containing links to file gallery items, the backlinks in the file gallery to that page get updated randomly [17:44] panamaus some backlinks get incremented, some don't [17:44] panamaus removing links from the wiki page do not usually decrement the backlink counts [17:45] panamaus Should I report this bug on dev.tiki.org? I have found in the past that my bug reports can get ignored there [17:47] Jyhem_laptop polom [17:47] * Jyhem_laptop reading history [17:48] Jyhem_laptop jonnyb: <jonnyb> well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation) [17:48] jonnyb hi Jyhem_laptop [17:49] Jyhem_laptop on my sites, the point of major saves is to send mail notifications and minor saves send none. It is not something I would like the system to outguess me [17:49] jonnyb think that's some way down the road yet - getting it working properly first, don't worry [17:50] * Jyhem_laptop stops worring at once :) [17:54] Tiki-KGB tikiwiki 03arildb r46870 10branches/6.x/lib/tikilib.php [17:54] Tiki-KGB tikiwiki [bp/r46608][FIX] order by must handle 1, which is the convertSortMode error return (probably related to r46575) [17:56] arildb marclaporte: http://demo.tiki.org/6x/tiki-list_file_gallery.php works now [17:57] arildb ...except... [17:57] arildb a warning: Warning: tempnam() [function.tempnam]: open_basedir restriction in effect. File() is not within the allowed path(s): (/www/htdocs/w00ec615/:/tmp:/usr/bin:/www/htdocs/w00ec615:/bin:/usr/local/bin:/usr/share/php) in /www/htdocs/w00ec615/6x/lib/init/initlib.php on line 135 [17:58] arildb after refreshing it works better [18:01] marclaporte thanks arildb! [18:01] marclaporte http://demo.tiki.org/wysiwyg-html-trunk/ and http://demo.tiki.org/wysiwyg-wiki-trunk/ ar ready [18:01] arildb thanks marclaporte [18:06] marclaporte I will let you guys configure them :-) [18:07] marclaporte panamaus: yes, you should report there [18:07] marclaporte panamaus: even better is patch, even better is that you commit a fix :-) [18:09] marclaporte panamaus: some changes are coming to the http://tiki.org/Wishlist+Team to make sure no wishes are ignored [18:10] marclaporte They will commit to make sure all issues are triages [18:10] marclaporte triaged [18:10] marclaporte and the easy ones fixed [18:11] marclaporte For tricky ones, submitters will be encouraged to use http://dev.tiki.org/show.tiki.org+Overview [18:11] marclaporte Nelson Ko has committed to making show.tiki.org live by August 1st [18:12] arildb that's going to be interesting to try [18:12] marclaporte yeah, we got a demo at the last webinar [18:13] arildb yes, I saw it [18:13] marclaporte :-) :-) [18:17] arildb jonnyb: I have the problem (here locally) in the debugger now. [18:17] arildb The problem is in var enableWysiwygInlineEditing = function () { [18:17] jonnyb in trunk? [18:18] jonnyb just committed a couple of things to ckeditor4 on that - what do you get? [18:18] Tiki-KGB tikiwiki 03jonnybradley r46871 10branches/ 10experimental/ckeditor4/lib/parser/parserlib.php 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php [18:18] Tiki-KGB tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags) [18:18] arildb $(this).html() seems to be empty, though the page has content [18:18] jonnyb oh? and why is "this"? [18:18] jonnyb i mean what, not why [18:19] arildb ...I lost it in the debugger, but I think it said "br" [18:19] arildb trying again [18:20] jonnyb ah, ok - br wouldn't have any content, html or otherwise [18:20] arildb yes, this = br [18:21] arildb I don't understand any more, but I hoped it helped you. [18:21] jonnyb that shouldn't really be considered for contenteditable - do you have wiki paragraph formatting on? [18:21] arildb checking [18:22] jonnyb i don't think there should be any <br>s at the top level of an html body - should all be inside p's etc [18:22] arildb No, it was off [18:22] arildb enabled now [18:22] jonnyb ah, wysiwyg goes all wrong a lot without that [18:22] jonnyb and the add br one too [18:22] arildb seems to [18:22] jonnyb (should be hard coded on imho) [18:23] arildb yes, maybe better [18:24] jonnyb you might need to resave the page - switch back to wiki and back perhaps [18:24] arildb I also reported a problem about the table tag being on top and having strange effects. Probably caused by the same missing wiki paragraphs [18:24] arildb resaved now [18:26] arildb The page in in wiki format wysiwyg-wiki is active ..... [18:26] arildb trying a page in html format [18:27] jonnyb super - did your toolbars ever turn up? [18:27] arildb not yet [18:28] jonnyb can't seem to get them not to work here for me (on trunk) [18:28] jonnyb merging the last commits from cke4 - better plugin stuff [18:30] Tiki-KGB tikiwiki 03jonnybradley r46872 10branches/ 10(10 files in 8 dirs) [18:30] Tiki-KGB tikiwiki [MRG] Automatic merge, trunk 46865 to 46869 [18:30] arildb for the html page, I can edit in the page, but still no toolbar [18:32] Tiki-KGB tikiwiki 03arildb r46873 10branches/6.x/lib/tikilib.php [18:32] Tiki-KGB tikiwiki dos2unix [18:32] arildb now I get some errors [18:32] arildb "NetworkError: 500 Internal Server Error - http://l5/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA" [18:32] arildb uncaught exception: [CKEDITOR.resourceManager.load] Resource name "inlinecancel" was not found at "/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA". [18:33] arildb jonnyb: the new ckeditor plugins are missing in trunk (it seems) [18:34] jonnyb ah - checking... [18:34] jonnyb they arrived ok for me somehow [18:35] arildb not here [18:35] jonnyb i do remember seeing the merge back to trunk commit seemed to only have the plugin dirs, not the files [18:35] arildb will browse the repository [18:37] arildb the new plugins are missing in the trunk repository [18:37] arildb https://svn.code.sf.net/p/tikiwiki/code/trunk/lib/ckeditor_tiki/plugins [18:38] arildb jonnyb: probably a phpstorm problem ;-) [18:38] Tiki-KGB tikiwiki 03jonnybradley r46874 10(6 files in 6 dirs) [18:38] Tiki-KGB tikiwiki Merged from ckeditor4 [18:38] Tiki-KGB tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable [from revision 46868] [18:38] Tiki-KGB tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags) [from revision 46871] [18:38] jonnyb aha, the toolbars work on wiki pages, but no save of cancel buttons [18:38] jonnyb :D [18:38] * jonnyb usually blames svn [18:40] jonnyb luckily phpstorm has an excellent "compare with branch" function ;) [18:50] jonnyb arildb: missing trunk plugin files on their way in :) [18:50] arildb jonnyb: thanks [18:50] Tiki-KGB tikiwiki 03jonnybradley r46875 10trunk/lib/ckeditor_tiki/plugins/ 10(16 files in 5 dirs) [18:50] Tiki-KGB tikiwiki [MRG] Some missing plugin files from ckeditor4 branch [18:51] jonnyb not sure if it was phpstorm or svn (or me) - fixed here now [18:51] arildb works now [18:51] jonnyb have you tried the tab key while inline? Quite clever! [18:52] arildb I again have a root level table. Does the wiki formatting pick up table tags? If not they should probably also be marked as contenteditable=true [18:52] arildb tab...no..trying [18:52] jonnyb hmm, will try a table [18:53] arildb nice! [18:54] jonnyb hmm, no toolbar on a table (wiki) but can edit [18:55] jonnyb but when i save it with a different save button the table disappears :( [18:56] jonnyb best wrap that in a div too [18:59] * jonnyb updates ckeditor4 branch (expecting tree conflicts, my favourite!) [19:00] Tiki-KGB tikiwiki 03jonnybradley r46876 10trunk/lib/ckeditor_tiki/wysiwyglib.php [19:00] Tiki-KGB tikiwiki [FIX] inline wysiwyg: Add table to the list of elements ckeditor can't handle inline (and wrap it in a div) [19:02] Tiki-KGB tikiwiki 03jonnybradley r46877 10branches/ 10experimental/ckeditor4 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php [19:02] Tiki-KGB tikiwiki [MRG] Automatic merge, trunk 46869 to 46876 [19:02] arildb Should the wysiwyg-admin panel be moved to the "basic" admin display. It is currently in the "advanced" display [19:03] jonnyb Sounds like it, checking... [19:04] jonnyb yes, if it's off it doesn't show up for basic only - needs a basic tag adding [19:05] arildb ok [19:05] jonnyb in trunk i guess [19:05] jonnyb we'll need to be a bit careful about conflicts for a while here... [19:06] jonnyb lots of merges back to experimental should help [19:06] arildb will you handle this one? [19:07] jonnyb if you don't ;) (was going to start looking at making the autosave stuff proper Services) [19:07] arildb I will try to take a look at it [19:07] jonnyb thanks - probably most of the usual wysiwyg prefs should be basic [19:10] jonnyb lphuberdeau: any thoughts about where to put new services for auto_save, preview, wysiwyg etc? Into new ones or add (some) to the wiki one that only has one action? [19:14] arildb jonnyb: There is a feature "ajax_autosave". I assume the inline editing should go under this feature, or? [19:15] jonnyb how do you mean? seems like a wysiwyg dependent feature really (which in turn depends on autosave, or should do) [19:17] arildb I assume ajax_autosave enables the autosave plugin (I assume). The new plugins inlinesave and inlinecancel should they be enabled similarly [19:18] jonnyb that's a ckeditor plugin, they don't have prefs like wiki plugins (if that's what you mean?) [19:19] jonnyb joined #tikiwiki [19:20] arildb no prefs...ok [19:20] jonnyb they're just hooked in (rather messily) in wysiwyglib or toolbars lib when necessary [19:20] jonnyb part of what i'm hoping to clean up for tiki 12 [19:24] Tiki-KGB tikiwiki 03arildb r46878 10trunk/lib/prefs/feature.php [19:24] Tiki-KGB tikiwiki [MOD] feature_wysiwyg moved out of experimental and is now a "basic" feature. [19:56] Tiki-KGB tikiwiki 03leagris r46879 10branches/11.x/ 10lib/init/smarty.php 10lib/headerlib.php [19:56] Tiki-KGB tikiwiki [fix] commit [r46818] introduced bug where empty tiki_cdn was not handled properly and caused Error: directory '' not allowed by security setting [19:56] leagris jonnyb committed fix to 11.x branch (single_cdn). Ill work on trunk new featured multiple_cdn which arbor same bug [19:57] jonnyb should i do a merge from 11 to trunk first (i should think so) [19:57] * jonnyb php doc/devtools/svnbranchupdate.php branches/11.x [19:57] leagris I can do a distinct commit to trunk as the fix is a bit different [19:59] jonnyb have done a merge - there was a conflict but i took the 11.x version [19:59] jonnyb commit just went in... [20:00] Tiki-KGB tikiwiki 03jonnybradley r46880 10trunk/lib/headerlib.php 10trunk/lib/init/smarty.php 10trunk [20:00] Tiki-KGB tikiwiki [MRG] Automatic merge, branches/11.x 46862 to 46879 [20:00] leagris Someone asked to my fix to be backported down to 9.x I would not touch an LTS new, please look at it if it is ok [20:00] arildb jonnyb: Having sections with plugins read-only, works fine I think. The plugins has the "edit button". Works well with together wil inline editing for other sections. [20:01] arildb I am not sure we need to aim for having editable sections with plugins [20:01] jonnyb coo, that's pushing things! amazed it worked (didn't dare click that one ;) ) [20:01] arildb works fine [20:01] jonnyb it may come once plugins are tidied up some - am in the middle of making an autosave service... [20:02] arildb ...I will leave you in peace [20:03] jonnyb thanks for all your help on this, makes a big difference :) [20:03] arildb :) [20:19] arildb I am able to enter <h1>header</h1> in the inline editor (inside a section). No header is created (which is correct). However, the < and > are not stripped! [20:20] arildb once saved in the standard editor, the tags are converted to headers [20:21] jonnyb curious... could be a "feature"? :) [20:21] arildb maybe the htmlpurifier is not applied to the inlinesave? [20:22] Tiki-KGB tikiwiki 03jonnybradley r46881 10branches/ 10(6 files in 5 dirs) [20:22] Tiki-KGB tikiwiki [MOD] autosave: Move to a Service - wiki only so far, wysiwyg next (and tidy up) [20:23] arildb htmlpurifier should be run. I will check my setting [20:26] arildb HTML Purifier was active [20:27] arildb the inline toolbar looks better now, but I miss the style drop-downs [20:28] arildb They would fit n the second row [20:28] jonnyb yes, i'm a bit lost as to what's going on with the toolbar items - seems cke filters out some depending on the element [20:28] arildb yes, it seems to change [20:29] arildb I though it was your commits... [20:30] jonnyb the only bit i did was removing a few block tools from heading - but cke seems to do more [20:31] jonnyb will come back to that one day... [20:31] jonnyb (if arildb doesn't first!) [20:31] arildb hm.m... [20:33] arildb adding <html>ABC</html> for a page in wiki format will result in data loss. The tag part is stripped. [20:34] arildb For HTML pages adding <html></html> works fine, as long as only the inline editor is used. The tag is correctly html encoded in the database after inlinesave [20:36] Telesight joined #tikiwiki [20:40] Tiki-KGB tikiwiki 03jonnybradley r46882 10branches/experimental/ckeditor4/lib/ckeditor_tiki/plugins/autosave/plugin.js [20:40] Tiki-KGB tikiwiki [MOD] autosave: Move to a Service - wysiwyg [21:20] Tiki-KGB tikiwiki 03jonnybradley r46883 10branches/experimental/ckeditor4/lib/ajax/autosave.js [21:20] Tiki-KGB tikiwiki [MOD] autosave: Use html5 data attributes instead of temporary elements and global vars (more) [21:22] Tiki-KGB tikiwiki 03jonnybradley r46884 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php [21:22] Tiki-KGB tikiwiki [MOD] autosave: Change the text for auto saved toggle so the link stays in more or less the same place [21:36] Tiki-KGB tikiwiki 03jonnybradley r46885 10branches/ 10experimental/ckeditor4/templates/styles/mobile/wiki_edit_actions.tpl 10experimental/ckeditor4/lib/ajax/autosave.js 10experimental/ckeditor4/templates/wiki_edit_actions.tpl 10experimental/ckeditor4/templates/tiki-editpage.tpl [21:36] Tiki-KGB tikiwiki [FIX] autosave: Remove a load of code doing timeouts - not needed and probably duplicating server calls [21:38] arildb I have configured the wysiwyg "trunk" test servers for inline editing. [21:38] arildb The HTML installation works OK. See http://demo.tiki.org/wysiwyg-html-trunk/tiki-index.php?page=Inline+editor+test [21:39] arildb The wiki installation does not work. See http://demo.tiki.org/wysiwyg-wiki-trunk/tiki-index.php?page=Inline+editor+test [21:39] jonnyb thanks arildb, will try and remember to check them tomorrow - time to eat now (a while ago) [21:40] arildb ok [21:46] RobertR joined #tikiwiki [21:46] RobertR Hello all [21:56] marclaporte joined #tikiwiki [21:59] RobertR The tool bars on the wikipage editor are not appearing on my local server (latest Xampp on Win 8) running 10.4 [22:00] RobertR Any ideas where to start trouble shooting server configs? [22:04] luciash RobertR: make sure all files transfered correctly [22:05] RobertR Thx luciash...you mean the tiki files right? [22:08] luciash also enabling TPL indication might help to check in the source which template files are used at which place: tiki-admin.php?page=features&cookietab=3 [22:08] luciash RobertR: yes [22:08] luciash RobertR: you said no php errors in server logs, right ? [22:08] RobertR No error in logs [22:09] luciash RobertR: also no error in PHP errors button down there on the page ? [22:09] RobertR Nope [22:10] RobertR Using firebug the php to html output write the <p> tags but not the expected <div> tags [22:13] RobertR i,e, <a class="toolbar qt-filegal...> [22:14] luciash RobertR: is it online somewhere ? [22:15] luciash ah, local, sorry [22:15] RobertR I'll give that file checking a try. Thanks [22:16] luciash if you enable the TPL output comments on that admin page and then clear the cache, you should see if the tpl file is output there and if missing in your filesystem [22:16] luciash Tiki cache I mean [22:17] RobertR Good tip [22:17] luciash it will give you hint of the filename which you can then check if it is there in templates/ or by your theme in templates/styles/themename [22:18] luciash not sure you will see it in firebug but using ctrl+U for sure [22:20] RobertR I'm not quite sure what worked but after clearing the cache, though I had done that before, the tool bars are now there [22:21] RobertR Maybe it just got scared of your suggestions :) [22:33] luciash ROFL [22:33] luciash sorry about that if it sounded scary :) [22:35] RobertR If it always worked like that it would be called the "scare the bugs" out of it. ;) [22:35] RobertR ^technique [22:39] RobertR Thx again luciash. I have to step way for awhile [22:49] leagris Question of style I could not find answer in the sources. Given a preference separator "\n" (unix newline) is it really cross_platform, given the form textarea may be filled within a Windows environment. Should I be prepared to handle "\r\n" "\n\r" "\r" and "\n" as a new line separator? [22:50] leagris I have seen several place in tiki preferences where the separator entry is not used and the final array is obtained by split on "\n". [22:53] leagris Shouldn't it at least filter trim "\r" on array entries to clear out cases of different newline characters left by splitting on "\n"? [22:53] Tiki|bot Recent Bug: - File Gallery backlinks are a dysfunctional mess - http://dev.tiki.org/item4608 [22:53] panamaus marclaporte: there you go ^^ [22:53] panamaus :) [23:13] arildb_ joined #tikiwiki [23:22] luciash leagris: in code generally we use unix line endings only for the consistency and prevent unexpected issues... crlf should be used only in some mail related outputs iirc [23:23] leagris luciash I try tu use arra_filter and declared separator "\n" but it does not handle the split [23:23] leagris array_filter [23:24] luciash leagris: see https://dev.tiki.org/DevTips#Files_content_integrity [23:24] leagris Other preferences using newline as entry separator do a split on "\n" [23:24] luciash leagris: sorry, i am not familiar about array_filter [23:25] leagris The question I have is, When entering a preference form on Windows environment [23:25] leagris will it POST back a string with CRLF? [23:26] luciash oh, i do not know but that should be easy to check, no ? [23:26] leagris Well I have not Windows environment handy ;D [23:26] luciash ah, then, not so easy ;) [23:26] leagris we have this in multi_domain settings [23:27] leagris preference is a textarea with one domain per line [23:27] luciash yup yup [23:27] leagris and the code uses a split on "\n" to fill an array of domains [23:28] luciash i thought there is always \n [23:28] luciash even on win platforms [23:28] leagris Yes but what about \n\r? [23:29] luciash the \r will stay but it will be splitted on \n anyway [23:29] leagris It means some string within the array wil keep prepended \r [23:29] luciash yes [23:29] leagris and then becomes invalid :) [23:30] luciash no idea :) might be possible. would need to check what happens [23:30] leagris \rdomainname would not be good [23:31] luciash wouldn't that \r be ignored as a whitespace character ? [23:31] leagris let say a windows user enter host1.example.com\r\nhost2.example.com\r\n then a split on \n will produce host1.example.com\r ... [23:32] leagris unless some trimming is applied (which isn't) [23:32] aalex_ joined #tikiwiki [23:34] luciash leagris: "When submitting the form, all browsers canonicalize newlines to \r\n (%0D%0A in URL encoding)." [23:35] luciash leagris: source -> http://stackoverflow.com/questions/1155678/javascript-string-newline-character [23:36] luciash leagris: also http://stackoverflow.com/questions/945942/new-lines-and-browser-os-compatability [23:38] luciash leagris: so doing the split on "\r\n" should be fine [23:38] leagris ah yes [23:42] leagris jonnyb suggested I use the preference separator instead of split [23:43] leagris from my tests, I cant't get the preference separator to work for newlines [23:43] leagris Morte to it, I can't semantically separate URI with comma as a comma is a valid URI component ;D [23:48] SkiNut joined #tikiwiki [23:57] SkiNut joined #tikiwiki