#tikiwiki 2013-07-26,Fri

(Click on time to select a line by its url)

Who	What	When
luciash	leagris: i do not think so. afaik nobody is working on that...	[00:11]
....... (idle for 31mn)
marclaporte	joined #tikiwiki	[00:42]
.... (idle for 18mn)
amette_	joined #tikiwiki	[01:00]
marclaporte1	joined #tikiwiki	[01:05]
leagris	Please advise. What should I do if I need new/replace string/key? should I parse all language files and remove corresponding obselete keys?	[01:09]
marclaporte1	leagris: can you give an example?	[01:14]
marclaporte	joined #tikiwiki	[01:15]
arildb	https://dev.tiki.org/ is down and back up again :)	[01:17]
leagris	http://pastie.org/8175897 Here an example diff of tra('key') changed tiki_cdn evolve from sisngle cdn to multiple cdn form field syntax evolve from single line to multiline	[01:18]
marclaporte	ok, look at get_strings.php As you are doing in trunk, just modify what you need in the code, and you don't need to worry about get_strings.php	[01:22]
leagris	ok fine	[01:25]
	done :) Enjoy multi-cdn support	[01:30]
Tiki-KGB	tikiwiki 03leagris r46854 10trunk/lib/ 10headerlib.php 10prefs/tiki.php 10init/smarty.php tikiwiki [ADD] feature multi_cdn	[01:32]
leagris	I have it working on 11.x, and it work as-is without migrating any data. If only one cdn is configured, it uses it.	[01:37]
goj	joined #tikiwiki	[01:45]
..... (idle for 20mn)
Ludo-	joined #tikiwiki	[02:05]
fabricius	polom	[02:09]
Tiki\|bot	joined #tikiwiki	[02:10]
..... (idle for 20mn)
Anzhe	joined #tikiwiki	[02:30]
......... (idle for 41mn)
Tiki\|bot	New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294	[03:11]
goj_killedByISP	joined #tikiwiki	[03:23]
.......... (idle for 49mn)
Anzhe	here's a thought - is there a plug-in or tweak that allows the "Contact Us" form to go to more than one user?	[04:12]
....... (idle for 32mn)
chibaguy	joined #tikiwiki polom	[04:44]
.... (idle for 17mn)
	joined #tikiwiki	[05:01]
Anzhe	joined #tikiwiki	[05:08]
	can someone explain Content Templates to me for a moment? (http://doc.tiki.org/Content+Templates) Regarding wiki pages currently using a template when the template is updated, that link says the pages using the previous template version do not change how then does one go about updating them? must you manually re-apply the template to each page? is there a way to see the pages that use a given template and which are up-to-date?	[05:22]
chibaguy	joined #tikiwiki	[05:24]
luciash	Anzhe: the content templates are useful only as a page content starters Anzhe: once the page is written there is no way to control what other people write and change in it so re-applying the template only adds it again at the beginning or end of the existing page content chibaguy: hi luciash goes off	[05:28]
Anzhe	:luciash, thank you for the tip	[05:34]
..... (idle for 24mn)
binarymutt	joined #tikiwiki	[05:58]
Anzhe	for Wiki History, can someone please explain to me the significance of the Keep versions for __ days config? if I have unlimited versions (Maximum number of versions: 0) what does keeps versions for __ days do?	[05:58]
....... (idle for 30mn)
chibaguy	oops, hi luciash (no longer here).	[06:29]
........... (idle for 54mn)
Tiki\|bot	New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297	[07:23]
....... (idle for 31mn)
	New Forum Posts: Wiki History config - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297 New Forum Posts: New to tiki-devel, Introducing myself to the community - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 New Forum Posts: allow multiple cdn per protocol - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279	[07:54]
	New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297 New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 New Forum Posts: allow multiple cdn per protocol - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279	[08:04]
................. (idle for 1h20mn)
redflo	joined #tikiwiki	[09:24]
.................. (idle for 1h29mn)
arildb	joined #tikiwiki	[10:53]
Jyhem_laptop	joined #tikiwiki	[10:55]
............ (idle for 59mn)
arildb_	joined #tikiwiki	[11:54]
..... (idle for 22mn)
Anzhe_m	joined #tikiwiki	[12:16]
arildb	joined #tikiwiki	[12:21]
jonnyb	joined #tikiwiki poets polom	[12:33]
Tiki\|bot	New Forum Posts: Where to commit [was allow multiple cdn per protocol] - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48300	[12:45]
Anzhe_m	joined #tikiwiki	[12:51]
chibaguy	joined #tikiwiki	[12:57]
arildb	joined #tikiwiki	[13:10]
Tiki\|bot	joined #tikiwiki	[13:17]
arildb	Hi jonnyb	[13:21]
jonnyb	hi arildb been thinking about the branch and the inline stuff	[13:21]
arildb	I updated the write-up + a couple of issued on https://dev.tiki.org/Inline+Editing#Saving_inline_changes. Also added an open question about saving inline comment. Did you have a look at it?	[13:21]
jonnyb	thinking it might be a good time to merge soon if it seems ok to you	[13:22]
arildb	yes, I think it's ready.	[13:22]
jonnyb	after that i'm going to have a go (in that branch) at converting all the old hacky ajax stuff to proper services, which should make it seem all nice and clean and fresh! :)	[13:22]
arildb	sounds good. Will you do the merge, or do you want me to do it?	[13:23]
jonnyb	one main issue i think with getting plugins working is that it's not using the auto_save plugin, and most of the parsing etc for plugins is done by that i'll have a go - phpstorm seems to make that quite civilised	[13:23]
arildb	sounds good to me :-)	[13:24]
jonnyb	btw, i've been meaning to ask, what IDE do you use? I see whatever it is it keeps putting in stinky windows linefeeds :P stuff to do here, bbl	[13:24]
arildb	I use vs.php, which is a PHP project plugin for Visual Studio. Getting the line endings right is a bit nasty. I haven't found a global setting for it :-(	[13:27]
jonnyb	aha, thought i detected the smell of Micro$oft :D	[13:27]
arildb	lol	[13:27]
jonnyb	try phpstorm - we have a license for tiki use must go, bbl	[13:27]
arildb	I might do...one day	[13:27]
...... (idle for 26mn)
jonnyb	joined #tikiwiki	[13:53]
fabricius	joined #tikiwiki	[13:54]
.... (idle for 19mn)
arildb	Hi jonnyb. I updated the section https://dev.tiki.org/Inline+Editing#Saving_inline_changes based on your comment here on IRC	[14:13]
jonnyb	thanks arildb - reading... good points about type of save - i wonder if we can guestimate it - like if more than 50 (?) chars edited then it's a major one?	[14:15]
arildb	I have installations that "prefer" long pages. A correct use pattern becomes more important. I doubt users will follow it. btw. I added a 1000 paragraph test page: Lorem Ipsum. Good for testing large pages I don't quite understand your question	[14:17]
jonnyb	well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation) we need a "you have unsaved changes" thing on leaving the page too... but these can happen in trunk - more eyeballs :O	[14:22]
arildb	yes, you are right	[14:22]
jonnyb	ok, i'm going to do merge #1	[14:23]
arildb	:-)	[14:23]
jonnyb	oops, found some commits from last night :\|	[14:24]
Tiki-KGB	tikiwiki 03jonnybradley r46855 10branches/experimental/ckeditor4/tiki-setup.php tikiwiki [FIX] Don't use inline edit when editing tikiwiki 03jonnybradley r46856 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php tikiwiki [FIX] textarea: Default to having the switcheditor button following logic correction in function.toolbars tikiwiki 03jonnybradley r46857 10branches/ 10(12 files in 8 dirs) tikiwiki [MRG] Automatic merge, trunk 46847 to 46854	[14:26]
jonnyb	all this merging stuff is so much better without 94,000,000 svn externals slowing everything down! :)	[14:34]
	also doing it in phpstorm is so much better - gives you a nice list of commits to merge, you can ignore all the ones that might cause trouble (merge conflicts etc)	[14:39]
arildb	sounds like you have become a fan (as I think Robert was)	[14:40]
jonnyb	for a couple of years now :) http://dev.tiki.org/phpstorm?highlight=phpstorm#Top_10_Reasons_to_Love_PhpStorm	[14:40]
arildb	sounds like a good devenv. I bet it gets the line endings right, too ;-)	[14:43]
jonnyb	:D i have tried about all of them over the years, nothing else comes close for php, especially for tiki (try opening up 4 branches of tiki at once in anything else!)	[14:43]
arildb	is there a windows version?	[14:45]
jonnyb	yes, i think it's available on everything (java based, but not so you'd notice) contact admin@tiki.org for a license key if you decide to continue using it (there's a 30 day trial i believe)	[14:46]
arildb	download site is http://www.jetbrains.com/phpstorm/ it seems	[14:47]
jonnyb	personally i use it for everything, not just open source stuff and am happy to pay them the $40 a year to keep them going, i like rewarding good programming! yy	[14:47]
arildb	yes	[14:47]
jonnyb	ok, have local merge done - checking... what's this fix in tiki-js-sorttable.js? just wrong branch or have i messed up? http://sourceforge.net/p/tikiwiki/code/46779 committed separately	[14:48]
Tiki-KGB	tikiwiki 03jonnybradley r46858 10trunk/lib/tiki-js-sorttable.js tikiwiki [bp/r46779][FIX] Declare variables to avoid JS warnings (backported from experimental/ckeditor4)	[14:52]
arildb	It declares the valiable to avoid JS warnings	[14:52]
jonnyb	yes, but nothing really to do with ckeditor (so merged separately) generally (although it's more dull) when i found non-inline-editing-based fixes i fixed them in trunk then merge into ckeditor4 hence it being handy to keep several tiki branches open at once :)	[14:52]
arildb	It made breaks all the time in the debugge. I have to Firebug to debug javascript.	[14:54]
jonnyb	yes me too - you can always click "ignore" in firebug (each session sadly) i think sorttable has a pref though too so could just be switched off	[14:54]
leagris	Never took the time to set it up properly PhpStorm though I got a licence :)	[15:03]
arildb	leagris: which platform are you usually on, Linux?	[15:06]
leagris	I'll have to give it more attention. Shell vi, grep, perl -p -i -e 's/replace this/with this/g' file, diff, find, are all nice but sharp tools ;D	[15:06]
arildb	yes...seems so	[15:06]
leagris	Ubuntu Linux	[15:06]
jonnyb	um.. is anyone else getting icons replaces by green ? in trunk? the green question marks are what the icon function returns along with an error "title" saying: "Error: directory '' not allowed by security setting" leagris: i'm just wondering if this might be connected to the recent smarty security stuff?	[15:09]
.... (idle for 17mn)
leagris	it is jonnyb did you clear all caches?	[15:30]
Anzhe_m	joined #tikiwiki	[15:31]
jonnyb	yes, clearing every reload - also just did "php temp/composer.phar install" as there was a smarty update... still got little green ? everywhere i added a check for if (!empty($cdn)) around the trusted_uri lines, but still the same	[15:31]
leagris	Crap, ill have to check this if no CDN :)	[15:32]
jonnyb	often a "gotcha" when adding new stuff, testing with it turned off :)	[15:33]
leagris	Do you have empty CDN entries?	[15:33]
jonnyb	jonnyb needs to do that with inline editing yes and i was ending up with ##i as my trusted_uri's but i don't think that's it...	[15:33]
dhazel	joined #tikiwiki	[15:35]
ricks99	joined #tikiwiki	[15:36]
jonnyb	looks like line 360 of /vendor/smarty/smarty/distribution/libs/sysplugins/smarty_security.php now returns false from realpath for img dirs - as they're tikiroot relative now, instead of absolute (like template dirs are) - odd	[15:36]
leagris	What error do you get when hover mouse on question marks?	[15:37]
jonnyb	Error: directory '' not allowed by security setting so an empty path i can't see how your changes could be doing this - just a coincidence maybe	[15:38]
leagris	maybe not Before my change the trusted_uri was non_existant	[15:39]
jonnyb	mmm, i tried unsetting it if empty but no change	[15:40]
leagris	now, when no CDN is used, it get an empty array (so array exists) Fortunately, if you add your site base http://... to cdn the error may dissapear ;D	[15:40]
jonnyb	aha, will try...	[15:42]
leagris	I guess I forgot to add site base URI to trusted_uri ;D	[15:42]
arildb	I am running a composer.phar update. Updating smarty/smarty (v3.1.13 => v3.1.14). Get a question: Discard changes [y,n,v,?]? ... what should I answer?	[15:43]
leagris	v (to see what changes)	[15:44]
jonnyb	yes, composer meets svn weirdness - just discard usually	[15:44]
arildb	lots of files. I can't get to the top of the listing. Here's a section ... documentationja documentationjaappendixes documentationjaappendixesbugs.xml	[15:45]
jonnyb	doesn't always work, if stubborn just remove that dir	[15:45]
arildb	answered y	[15:45]
jonnyb	i tried adding my localhost/tiki/etc as a can and i now get "This is a Content Delivery Network (CDN) to speed up delivery of images, CSS, and javascript files. However, PHP code is not executed." jonnyb goes to hack the database ;) jonnyb notes to self: double check the destination branch __before__ doing a two hour merge from experimental	[15:47]
Anzhe	joined #tikiwiki	[15:52]
jonnyb	by the way - the shelve feature in phpstorm is brilliant for this kind of thing :) leagris: confirmed i'm afraid - without r46854 i have icons, with it - little green question marks everywhere (no other changes in my trunk now)	[15:55]
Tiki-KGB	tikiwiki 03arildb r46859 10trunk/db/tiki_convert_myisam_to_innodb.sql tikiwiki [FIX] Add missing tables in myisam to innodb conversion	[16:04]
leagris	jonny I made a big newbe error, working a fix ;D	[16:09]
jonnyb	no worries - so am i, let's see if we end up with the same stuff :)	[16:10]
leagris	reproduced your bug, so it help same bug on my multi-cdn trunk commit	[16:10]
jonnyb	looks like it's the bit in convert_cdn in headerlib need to test for not empty instead of isset, i reckon	[16:11]
leagris	it is a bug in lib/init/smarty.php	[16:11]
Tiki-KGB	tikiwiki 03arildb r46860 10trunk/db/tiki_convert_myisam_to_innodb.sql tikiwiki [DOC] Add comment about MySQL 5.6 or later, InnoDB then supports fulltext indexes.	[16:12]
leagris	I initialize trusted_uri with regex even if tiki_cdn and tiki_cdn_ssl are empty It always produce a PREG if cdn empdy ;D empty	[16:12]
jonnyb	this seems to fix it for me - http://pastebin.com/9cGFGb5a	[16:13]
leagris	Right, need this fix in headlerlib as a simmilar fix in lib/init/smarty.php to be safe	[16:15]
jonnyb	true did you see my mail about pref separators?	[16:16]
leagris	I would not trust smarty security with trusted_uri of #$#i	[16:16]
jonnyb	agreed, probably would spoil something somewhere	[16:17]
leagris	Yess, seen it but did not look at it so close.	[16:18]
jonnyb	by the way, i don't think you need that $i counter var in /lib/init/smarty.php - just doing "$this->trusted_uri[] = blahblah" will push the value onto the end of the array	[16:18]
leagris	Ah yes the trunk version. good to know I guess PHP is nicer than COBOL with arrays ;D	[16:19]
jonnyb	ha ha, everything is (i'd guess)	[16:20]
leagris	DATA DIVISION (fu#@k) Well, now let me resynk of 11.x and trunk and push some fixes; D	[16:20]
jonnyb	never done COBOL myself - have a friend who had to learn it for a (legacy) job - he called it "Jurassic Code" :)	[16:21]
Tiki-KGB	tikiwiki 03lphuberdeau r46862 10branches/11.x/lib/filegals/filegallib.php tikiwiki [FIX] Uploading as an other user should not be possible by anyone	[16:22]
jonnyb	jonnyb is glad this went into trunk rather than stable after all ;)	[16:22]
leagris	Had to learn GAP2 (IBM36) and then found COBOL a civilized language ;D	[16:22]
jonnyb	:D	[16:23]
leagris	IBM36 such a large impressive gandma furniture cabinet with this surprisingly so small and crappy power switch ;D Much like the WOPR in WarGames, without the fancy blinking led pannels	[16:25]
Tiki-KGB	tikiwiki 03lphuberdeau r46863 10trunk/lib/filegals/filegallib.php 10trunk tikiwiki [MRG] Automatic merge, branches/11.x 46846 to 46862	[16:28]
Anzhe	joined #tikiwiki	[16:33]
marclaporte	joined #tikiwiki	[16:35]
Tiki-KGB	tikiwiki 03lphuberdeau r46864 10trunk/ 10lib/core/Services/File/VimeoController.php 10lib/filegals/vimeolib.php 10templates/vimeo/upload.tpl tikiwiki [ENH] Set the video title when uploading	[16:40]
jonnyb	phew - ok arildb, first merge from ckeditor4 branch just committed - can you check everything arrived ok please?	[16:45]
Tiki-KGB	tikiwiki 03jonnybradley r46865 10trunk/ 10(10 files in 8 dirs) tikiwiki [MRG] Phase one of merges from ckeditor4 - initial implementation of inline editing, mostly working... (but more to come from this branch) tikiwiki ** Warning: Can mess up pages containing wiki plugins! Marked as experimental. tikiwiki Full commit details here: https://dev.tiki.org/Inline+Editing#Notes_etc	[16:46]
arildb	great! checking	[16:46]
jonnyb	my main test page has loads of plugins in, and most of them go badly wrong... so watch out! ;)	[16:46]
arildb	yes I saw the details. One or two words per line. Pretty unreadable...on my side	[16:46]
Tiki-KGB	tikiwiki 03jonnybradley r46866 10branches/ 10(10 files in 7 dirs) tikiwiki [MRG] Automatic merge, trunk 46854 to 46865	[16:50]
Jyhem_laptop	joined #tikiwiki	[16:52]
arildb	jonnyb: difficult to test. The inline editor icon is a question mark and doesn't work	[16:54]
jonnyb	yes... um, leagris, how you doing with your fix? ;) arildb: this http://pastebin.com/9cGFGb5a patches it for me for now...	[16:54]
arildb	checking	[16:55]
	problem is still there	[17:03]
jonnyb	which problem?	[17:03]
arildb	the question marks instead of icons in trunk	[17:04]
jonnyb	joined #tikiwiki	[17:04]
arildb	jonnyb: I think you missed my answer: the question marks instead of icons in trunk	[17:04]
jonnyb	sorry yes - did you clear all caches?	[17:06]
arildb	cleared cache. fixed it. testing now	[17:10]
jonnyb	:)	[17:10]
arildb	The Homepage is editable, buit I don't get any toolbar	[17:11]
jonnyb	oh? seems ok here browser cache maybe?	[17:12]
arildb	doesn't work properly. Added a new page. Activated the inline editor, but not able to edit	[17:13]
Tiki-KGB	tikiwiki 03lphuberdeau r46867 10trunk/ 10(7 files in 6 dirs) tikiwiki [ENH] Move the OAuth endpoints to services	[17:14]
arildb	tried in opera. The same cleared the browser cache in opera. Still the same option Wysiwyg editor was off still nothing cleared the cache again too the editor tags are not present in the page, but the inline editor is active	[17:15]
jonnyb	is this on your local? any js errors? (he always asks ;) ) i've just committed a fix for plugins in ckeditor4 - think i'll try it on trunk as it makes it less dangerous (and will check my toolbars etc)	[17:26]
arildb	local yes. No JS errors	[17:27]
Tiki-KGB	tikiwiki 03jonnybradley r46868 10branches/ 10(5 files in 5 dirs) tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable	[17:28]
jonnyb	the toolbars i get in trunk look different - different skin presumably yes, was kama - changed to default	[17:28]
arildb	I do get an error msg Timestamp: 26.07.2013 22:29:11 Error: TypeError: Components.classes['@mozilla.org/browser/global-history;2'] is undefined Source File: chrome://pdfdownload/content/pdfDownloadOverlay.js Line: 375 does it make any sense to you?	[17:29]
marclaporte	jonnyb & arild: I will make demo site for exciting WYSIWYG inline. Do I make seperate for inine HTML-WYSIWYG and inline wiki-WYSIWYG ?	[17:30]
jonnyb	hi marclaporte i wouldn't bother - i generally make a test page for each (by changing the pref in between)	[17:30]
marclaporte	arildb: http://demo.tiki.org/6x/tiki-list_file_gallery.php	[17:31]
jonnyb	they should live happily together (eventually)	[17:31]
arildb	marclaporte: why not just enable inline editing for the existing wysiwyg-* sites.	[17:31]
marclaporte	current WYSIWYG are 11.x should they be trunk?	[17:33]
arildb	marclaporte: I was sure that fix was included marclaporte: yes, they need to be trunk	[17:33]
Tiki-KGB	tikiwiki 03jonnybradley r46869 10trunk/styles/utopias.css tikiwiki [CSS] utopias: Remove odd float left for span in #page-bar (was messing up comments count and served no apparent use)	[17:36]
panamaus	ricks99: I checked version 11 on the demo wiki, and the file gallery backlinks bug is present there too every time you save a wiki page containing links to file gallery items, the backlinks in the file gallery to that page get updated randomly some backlinks get incremented, some don't removing links from the wiki page do not usually decrement the backlink counts Should I report this bug on dev.tiki.org? I have found in the past that my bug reports can get ignored there	[17:42]
Jyhem_laptop	polom Jyhem_laptop reading history jonnyb: <jonnyb> well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation)	[17:47]
jonnyb	hi Jyhem_laptop	[17:48]
Jyhem_laptop	on my sites, the point of major saves is to send mail notifications and minor saves send none. It is not something I would like the system to outguess me	[17:49]
jonnyb	think that's some way down the road yet - getting it working properly first, don't worry	[17:49]
Jyhem_laptop	Jyhem_laptop stops worring at once :)	[17:50]
Tiki-KGB	tikiwiki 03arildb r46870 10branches/6.x/lib/tikilib.php tikiwiki [bp/r46608][FIX] order by must handle 1, which is the convertSortMode error return (probably related to r46575)	[17:54]
arildb	marclaporte: http://demo.tiki.org/6x/tiki-list_file_gallery.php works now ...except... a warning: Warning: tempnam() [function.tempnam]: open_basedir restriction in effect. File() is not within the allowed path(s): (/www/htdocs/w00ec615/:/tmp:/usr/bin:/www/htdocs/w00ec615:/bin:/usr/local/bin:/usr/share/php) in /www/htdocs/w00ec615/6x/lib/init/initlib.php on line 135 after refreshing it works better	[17:56]
marclaporte	thanks arildb! http://demo.tiki.org/wysiwyg-html-trunk/ and http://demo.tiki.org/wysiwyg-wiki-trunk/ ar ready	[18:01]
arildb	thanks marclaporte	[18:01]
marclaporte	I will let you guys configure them :-) panamaus: yes, you should report there panamaus: even better is patch, even better is that you commit a fix :-) panamaus: some changes are coming to the http://tiki.org/Wishlist+Team to make sure no wishes are ignored They will commit to make sure all issues are triages triaged and the easy ones fixed For tricky ones, submitters will be encouraged to use http://dev.tiki.org/show.tiki.org+Overview Nelson Ko has committed to making show.tiki.org live by August 1st	[18:06]
arildb	that's going to be interesting to try	[18:12]
marclaporte	yeah, we got a demo at the last webinar	[18:12]
arildb	yes, I saw it	[18:13]
marclaporte	:-) :-)	[18:13]
arildb	jonnyb: I have the problem (here locally) in the debugger now. The problem is in var enableWysiwygInlineEditing = function () {	[18:17]
jonnyb	in trunk? just committed a couple of things to ckeditor4 on that - what do you get?	[18:17]
Tiki-KGB	tikiwiki 03jonnybradley r46871 10branches/ 10experimental/ckeditor4/lib/parser/parserlib.php 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags)	[18:18]
arildb	$(this).html() seems to be empty, though the page has content	[18:18]
jonnyb	oh? and why is "this"? i mean what, not why	[18:18]
arildb	...I lost it in the debugger, but I think it said "br" trying again	[18:19]
jonnyb	ah, ok - br wouldn't have any content, html or otherwise	[18:20]
arildb	yes, this = br I don't understand any more, but I hoped it helped you.	[18:20]
jonnyb	that shouldn't really be considered for contenteditable - do you have wiki paragraph formatting on?	[18:21]
arildb	checking	[18:21]
jonnyb	i don't think there should be any <br>s at the top level of an html body - should all be inside p's etc	[18:22]
arildb	No, it was off enabled now	[18:22]
jonnyb	ah, wysiwyg goes all wrong a lot without that and the add br one too	[18:22]
arildb	seems to	[18:22]
jonnyb	(should be hard coded on imho)	[18:22]
arildb	yes, maybe better	[18:23]
jonnyb	you might need to resave the page - switch back to wiki and back perhaps	[18:24]
arildb	I also reported a problem about the table tag being on top and having strange effects. Probably caused by the same missing wiki paragraphs resaved now The page in in wiki format wysiwyg-wiki is active ..... trying a page in html format	[18:24]
jonnyb	super - did your toolbars ever turn up?	[18:27]
arildb	not yet	[18:27]
jonnyb	can't seem to get them not to work here for me (on trunk) merging the last commits from cke4 - better plugin stuff	[18:28]
Tiki-KGB	tikiwiki 03jonnybradley r46872 10branches/ 10(10 files in 8 dirs) tikiwiki [MRG] Automatic merge, trunk 46865 to 46869	[18:30]
arildb	for the html page, I can edit in the page, but still no toolbar	[18:30]
Tiki-KGB	tikiwiki 03arildb r46873 10branches/6.x/lib/tikilib.php tikiwiki dos2unix	[18:32]
arildb	now I get some errors "NetworkError: 500 Internal Server Error - http://l5/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA" uncaught exception: [CKEDITOR.resourceManager.load] Resource name "inlinecancel" was not found at "/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA". jonnyb: the new ckeditor plugins are missing in trunk (it seems)	[18:32]
jonnyb	ah - checking... they arrived ok for me somehow	[18:34]
arildb	not here	[18:35]
jonnyb	i do remember seeing the merge back to trunk commit seemed to only have the plugin dirs, not the files	[18:35]
arildb	will browse the repository the new plugins are missing in the trunk repository https://svn.code.sf.net/p/tikiwiki/code/trunk/lib/ckeditor_tiki/plugins jonnyb: probably a phpstorm problem ;-)	[18:35]
Tiki-KGB	tikiwiki 03jonnybradley r46874 10(6 files in 6 dirs) tikiwiki Merged from ckeditor4 tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable [from revision 46868] tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags) [from revision 46871]	[18:38]
jonnyb	aha, the toolbars work on wiki pages, but no save of cancel buttons :D jonnyb usually blames svn luckily phpstorm has an excellent "compare with branch" function ;)	[18:38]
	arildb: missing trunk plugin files on their way in :)	[18:50]
arildb	jonnyb: thanks	[18:50]
Tiki-KGB	tikiwiki 03jonnybradley r46875 10trunk/lib/ckeditor_tiki/plugins/ 10(16 files in 5 dirs) tikiwiki [MRG] Some missing plugin files from ckeditor4 branch	[18:50]
jonnyb	not sure if it was phpstorm or svn (or me) - fixed here now	[18:51]
arildb	works now	[18:51]
jonnyb	have you tried the tab key while inline? Quite clever!	[18:51]
arildb	I again have a root level table. Does the wiki formatting pick up table tags? If not they should probably also be marked as contenteditable=true tab...no..trying	[18:52]
jonnyb	hmm, will try a table	[18:52]
arildb	nice!	[18:53]
jonnyb	hmm, no toolbar on a table (wiki) but can edit but when i save it with a different save button the table disappears :( best wrap that in a div too jonnyb updates ckeditor4 branch (expecting tree conflicts, my favourite!)	[18:54]
Tiki-KGB	tikiwiki 03jonnybradley r46876 10trunk/lib/ckeditor_tiki/wysiwyglib.php tikiwiki [FIX] inline wysiwyg: Add table to the list of elements ckeditor can't handle inline (and wrap it in a div) tikiwiki 03jonnybradley r46877 10branches/ 10experimental/ckeditor4 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php tikiwiki [MRG] Automatic merge, trunk 46869 to 46876	[19:00]
arildb	Should the wysiwyg-admin panel be moved to the "basic" admin display. It is currently in the "advanced" display	[19:02]
jonnyb	Sounds like it, checking... yes, if it's off it doesn't show up for basic only - needs a basic tag adding	[19:03]
arildb	ok	[19:05]
jonnyb	in trunk i guess we'll need to be a bit careful about conflicts for a while here... lots of merges back to experimental should help	[19:05]
arildb	will you handle this one?	[19:06]
jonnyb	if you don't ;) (was going to start looking at making the autosave stuff proper Services)	[19:07]
arildb	I will try to take a look at it	[19:07]
jonnyb	thanks - probably most of the usual wysiwyg prefs should be basic lphuberdeau: any thoughts about where to put new services for auto_save, preview, wysiwyg etc? Into new ones or add (some) to the wiki one that only has one action?	[19:07]
arildb	jonnyb: There is a feature "ajax_autosave". I assume the inline editing should go under this feature, or?	[19:14]
jonnyb	how do you mean? seems like a wysiwyg dependent feature really (which in turn depends on autosave, or should do)	[19:15]
arildb	I assume ajax_autosave enables the autosave plugin (I assume). The new plugins inlinesave and inlinecancel should they be enabled similarly	[19:17]
jonnyb	that's a ckeditor plugin, they don't have prefs like wiki plugins (if that's what you mean?) joined #tikiwiki	[19:18]
arildb	no prefs...ok	[19:20]
jonnyb	they're just hooked in (rather messily) in wysiwyglib or toolbars lib when necessary part of what i'm hoping to clean up for tiki 12	[19:20]
Tiki-KGB	tikiwiki 03arildb r46878 10trunk/lib/prefs/feature.php tikiwiki [MOD] feature_wysiwyg moved out of experimental and is now a "basic" feature.	[19:24]
....... (idle for 32mn)
	tikiwiki 03leagris r46879 10branches/11.x/ 10lib/init/smarty.php 10lib/headerlib.php tikiwiki [fix] commit [r46818] introduced bug where empty tiki_cdn was not handled properly and caused Error: directory '' not allowed by security setting	[19:56]
leagris	jonnyb committed fix to 11.x branch (single_cdn). Ill work on trunk new featured multiple_cdn which arbor same bug	[19:56]
jonnyb	should i do a merge from 11 to trunk first (i should think so) jonnyb php doc/devtools/svnbranchupdate.php branches/11.x	[19:57]
leagris	I can do a distinct commit to trunk as the fix is a bit different	[19:57]
jonnyb	have done a merge - there was a conflict but i took the 11.x version commit just went in...	[19:59]
Tiki-KGB	tikiwiki 03jonnybradley r46880 10trunk/lib/headerlib.php 10trunk/lib/init/smarty.php 10trunk tikiwiki [MRG] Automatic merge, branches/11.x 46862 to 46879	[20:00]
leagris	Someone asked to my fix to be backported down to 9.x I would not touch an LTS new, please look at it if it is ok	[20:00]
arildb	jonnyb: Having sections with plugins read-only, works fine I think. The plugins has the "edit button". Works well with together wil inline editing for other sections. I am not sure we need to aim for having editable sections with plugins	[20:00]
jonnyb	coo, that's pushing things! amazed it worked (didn't dare click that one ;) )	[20:01]
arildb	works fine	[20:01]
jonnyb	it may come once plugins are tidied up some - am in the middle of making an autosave service...	[20:01]
arildb	...I will leave you in peace	[20:02]
jonnyb	thanks for all your help on this, makes a big difference :)	[20:03]
arildb	:)	[20:03]
.... (idle for 16mn)
	I am able to enter <h1>header</h1> in the inline editor (inside a section). No header is created (which is correct). However, the < and > are not stripped! once saved in the standard editor, the tags are converted to headers	[20:19]
jonnyb	curious... could be a "feature"? :)	[20:21]
arildb	maybe the htmlpurifier is not applied to the inlinesave?	[20:21]
Tiki-KGB	tikiwiki 03jonnybradley r46881 10branches/ 10(6 files in 5 dirs) tikiwiki [MOD] autosave: Move to a Service - wiki only so far, wysiwyg next (and tidy up)	[20:22]
arildb	htmlpurifier should be run. I will check my setting HTML Purifier was active the inline toolbar looks better now, but I miss the style drop-downs They would fit n the second row	[20:23]
jonnyb	yes, i'm a bit lost as to what's going on with the toolbar items - seems cke filters out some depending on the element	[20:28]
arildb	yes, it seems to change I though it was your commits...	[20:28]
jonnyb	the only bit i did was removing a few block tools from heading - but cke seems to do more will come back to that one day... (if arildb doesn't first!)	[20:30]
arildb	hm.m... adding <html>ABC</html> for a page in wiki format will result in data loss. The tag part is stripped. For HTML pages adding <html></html> works fine, as long as only the inline editor is used. The tag is correctly html encoded in the database after inlinesave	[20:31]
Telesight	joined #tikiwiki	[20:36]
Tiki-KGB	tikiwiki 03jonnybradley r46882 10branches/experimental/ckeditor4/lib/ckeditor_tiki/plugins/autosave/plugin.js tikiwiki [MOD] autosave: Move to a Service - wysiwyg	[20:40]
......... (idle for 40mn)
	tikiwiki 03jonnybradley r46883 10branches/experimental/ckeditor4/lib/ajax/autosave.js tikiwiki [MOD] autosave: Use html5 data attributes instead of temporary elements and global vars (more) tikiwiki 03jonnybradley r46884 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php tikiwiki [MOD] autosave: Change the text for auto saved toggle so the link stays in more or less the same place	[21:20]
	tikiwiki 03jonnybradley r46885 10branches/ 10experimental/ckeditor4/templates/styles/mobile/wiki_edit_actions.tpl 10experimental/ckeditor4/lib/ajax/autosave.js 10experimental/ckeditor4/templates/wiki_edit_actions.tpl 10experimental/ckeditor4/templates/tiki-editpage.tpl tikiwiki [FIX] autosave: Remove a load of code doing timeouts - not needed and probably duplicating server calls	[21:36]
arildb	I have configured the wysiwyg "trunk" test servers for inline editing. The HTML installation works OK. See http://demo.tiki.org/wysiwyg-html-trunk/tiki-index.php?page=Inline+editor+test The wiki installation does not work. See http://demo.tiki.org/wysiwyg-wiki-trunk/tiki-index.php?page=Inline+editor+test	[21:38]
jonnyb	thanks arildb, will try and remember to check them tomorrow - time to eat now (a while ago)	[21:39]
arildb	ok	[21:40]
RobertR	joined #tikiwiki Hello all	[21:46]
marclaporte	joined #tikiwiki	[21:56]
RobertR	The tool bars on the wikipage editor are not appearing on my local server (latest Xampp on Win 8) running 10.4 Any ideas where to start trouble shooting server configs?	[21:59]
luciash	RobertR: make sure all files transfered correctly	[22:04]
RobertR	Thx luciash...you mean the tiki files right?	[22:05]
luciash	also enabling TPL indication might help to check in the source which template files are used at which place: tiki-admin.php?page=features&cookietab=3 RobertR: yes RobertR: you said no php errors in server logs, right ?	[22:08]
RobertR	No error in logs	[22:08]
luciash	RobertR: also no error in PHP errors button down there on the page ?	[22:09]
RobertR	Nope Using firebug the php to html output write the <p> tags but not the expected <div> tags i,e, <a class="toolbar qt-filegal...>	[22:09]
luciash	RobertR: is it online somewhere ? ah, local, sorry	[22:14]
RobertR	I'll give that file checking a try. Thanks	[22:15]
luciash	if you enable the TPL output comments on that admin page and then clear the cache, you should see if the tpl file is output there and if missing in your filesystem Tiki cache I mean	[22:16]
RobertR	Good tip	[22:17]
luciash	it will give you hint of the filename which you can then check if it is there in templates/ or by your theme in templates/styles/themename not sure you will see it in firebug but using ctrl+U for sure	[22:17]
RobertR	I'm not quite sure what worked but after clearing the cache, though I had done that before, the tool bars are now there Maybe it just got scared of your suggestions :)	[22:20]
luciash	ROFL sorry about that if it sounded scary :)	[22:33]
RobertR	If it always worked like that it would be called the "scare the bugs" out of it. ;) ^technique Thx again luciash. I have to step way for awhile	[22:35]
leagris	Question of style I could not find answer in the sources. Given a preference separator "n" (unix newline) is it really cross_platform, given the form textarea may be filled within a Windows environment. Should I be prepared to handle "rn" "nr" "r" and "n" as a new line separator? I have seen several place in tiki preferences where the separator entry is not used and the final array is obtained by split on "n". Shouldn't it at least filter trim "r" on array entries to clear out cases of different newline characters left by splitting on "n"?	[22:49]
Tiki\|bot	Recent Bug: - File Gallery backlinks are a dysfunctional mess - http://dev.tiki.org/item4608	[22:53]
panamaus	marclaporte: there you go ^^ :)	[22:53]
..... (idle for 20mn)
arildb_	joined #tikiwiki	[23:13]
luciash	leagris: in code generally we use unix line endings only for the consistency and prevent unexpected issues... crlf should be used only in some mail related outputs iirc	[23:22]
leagris	luciash I try tu use arra_filter and declared separator "n" but it does not handle the split array_filter	[23:23]
luciash	leagris: see https://dev.tiki.org/DevTips#Files_content_integrity	[23:24]
leagris	Other preferences using newline as entry separator do a split on "n"	[23:24]
luciash	leagris: sorry, i am not familiar about array_filter	[23:24]
leagris	The question I have is, When entering a preference form on Windows environment will it POST back a string with CRLF?	[23:25]
luciash	oh, i do not know but that should be easy to check, no ?	[23:26]
leagris	Well I have not Windows environment handy ;D	[23:26]
luciash	ah, then, not so easy ;)	[23:26]
leagris	we have this in multi_domain settings preference is a textarea with one domain per line	[23:26]
luciash	yup yup	[23:27]
leagris	and the code uses a split on "n" to fill an array of domains	[23:27]
luciash	i thought there is always n even on win platforms	[23:28]
leagris	Yes but what about nr?	[23:28]
luciash	the r will stay but it will be splitted on n anyway	[23:29]
leagris	It means some string within the array wil keep prepended r	[23:29]
luciash	yes	[23:29]
leagris	and then becomes invalid :)	[23:29]
luciash	no idea :) might be possible. would need to check what happens	[23:30]
leagris	rdomainname would not be good	[23:30]
luciash	wouldn't that r be ignored as a whitespace character ?	[23:31]
leagris	let say a windows user enter host1.example.comrnhost2.example.comrn then a split on n will produce host1.example.comr ... unless some trimming is applied (which isn't)	[23:31]
aalex_	joined #tikiwiki	[23:32]
luciash	leagris: "When submitting the form, all browsers canonicalize newlines to rn (%0D%0A in URL encoding)." leagris: source -> http://stackoverflow.com/questions/1155678/javascript-string-newline-character leagris: also http://stackoverflow.com/questions/945942/new-lines-and-browser-os-compatability leagris: so doing the split on "rn" should be fine	[23:34]
leagris	ah yes jonnyb suggested I use the preference separator instead of split from my tests, I cant't get the preference separator to work for newlines Morte to it, I can't semantically separate URI with comma as a comma is a valid URI component ;D	[23:38]
SkiNut	joined #tikiwiki	[23:48]
	joined #tikiwiki	[23:57]

←Prev date Next date→ Show only urls

(Click on time to select a line by its url)