marclaporte: joined #tikiwiki Tiki-KGB: 03nkoth r47691 10trunk/lib/ 10cache/cachelib.php 10cache/memcachelib.php
[FIX] Do not try and use memcache even if pref is enabled if memcache is disabled on server, otherwise fatal error
03nkoth r47692 10trunk/lib/core/Tiki/Command/RedactDBCommand.php * [FIX] more redactor fixes
03nkoth r47693 10trunk/lib/core/Tiki/Command/RedactDBCommand.php * [ENH] more redacting chibaguy: joined #tikiwiki marclaporte: joined #tikiwiki fidel: joined #tikiwiki
good morning - i am just realizing that 1 single article in our tiki does not show the categories-tab for a specific user
this never happened before - nor does it happen for this user on other articles
any idea?
its a 9.6 installation?
-? marclaporte: joined #tikiwiki
joined #tikiwiki fidel: solved redflo: joined #tikiwiki pianoliv: joined #tikiwiki Tiki-KGB: 03xavidp r47694 10trunk/templates/wizard/admin_wiki.tpl * [FIX]Missing tr tags and unify string for same link Tiki|bot: New Forum Posts: problem with pictures in file galeery after change version tiki. - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=49283 Tiki-KGB: 03xavidp r47695 10trunk/lang/ca/language.php * [TRA]Conflict resolved and a few strings improved
03xavidp r47696 10trunk/ 10templates/wizard/admin_wysiwyg.tpl 10lib/prefs/wysiwyg.php
[MOD]Show description inside the info popup box to clean the interface, as in other screens. The other strings are kept as such since they are too specific for that screen to choose between to options (showing the differences between the two). redflo: joined #tikiwiki Tiki-KGB: 03xavidp r47697 10trunk/templates/wizard/admin_jcapture.tpl * [FIX]Add missing tr tags jonnyb: joined #tikiwiki Tiki-KGB: 03nkoth r47698 10trunk/lib/core/Tiki/Command/RedactDBCommand.php * [FIX] prevent duplicate key errors xavi: joined #tikiwiki Tiki|bot: New Forum Posts: "require_once(lib/init/initlib.php): failed to open stream" Issues - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=49284 arildb: joined #tikiwiki rodrigoprimo: joined #tikiwiki xavi: arildb ? arildb: Hi xavi xavi: Hi Arild
I've created a User Wizard with a few screens, but I?m missing something (beyond my skills) because the settings are not being stored
I was wondering whether commiting to trunk (it doesn't break anything; it's self contained, etc), or send the files to you first through email so that you can review what may I be missing Tiki-KGB: 03jonnybradley r47699 10trunk/lib/userslib.php * [FIX] users: Missing operators from SQL query xavi: I copied most logic from the equivalent files for user preferences (php & tpl), but I'm unsure about forms: where the data of the form be submitted: to "tiki-wizard_user.php" or to the general "tiki-user_preferences.php" file arildb: Have you set the method isEditable = return true. Otherwise the prefs are not saved xavi: oups, nope :-)
I'll try arildb: That' probably the error xavi: mmmm, not enough
the first screen to set the "Real name" saves nothing arildb: commit it and I will take a look xavi: and in fact, it isn't retrieveing the "System Administrator" name that it contains when you visit the tiki-user_preferences.php
ok, thks
commited
bbl (lunch time) Tiki-KGB: 03xavidp r47700 10trunk/ 10(11 files in 3 dirs)
[NEW]Basic structure to create a User Wizard to allow users set up their basic settings (depending on the general settings enabled in the site). So far, it's not linked from anywhere else. Work in progress (commit early, commit often), to be reviewed by arildb (thanks) Tiki|Log: joined #tikiwiki Topic: for #tikiwikiis now Tiki Wiki CMS Groupware - the only Free Web App with the most built-in features & the most open Open Source software community! Tiki 11.0 (Vega), 10.4, 9.6 & 6.12 LTS is out! Question? Just ask! We log the channel @ http://irc.tiki.org (start line with [off] to exclude message from log) Tiki-KGB: 03jonnybradley r47701 10trunk/lib/ 10userslib.php 10smarty_tiki/modifier.avatarize.php 10core/Services/User/Controller.php
[REF] userinfo: Move code to build the link for the user-info popup into userslib (plus a small comment correction in the controller) rodrigoprimo: joined #tikiwiki chibaguy: joined #tikiwiki arildb: back xavi? xavi: hi arildb, yes arildb: I had a look ... a couple of comments xavi: ok fabricius: joined #tikiwiki arildb: 1) If the page alters any preferences, return true in isEditable
2) >Do not die or redirect from a page handler. Issues should be resolved differently and allow the user to continue xavi: ok
however, I do not know what to do instead to "die", when errors are found arildb: 3) The "structure" is a bit wrong. In onSetupPage, do not set preferences, use {preference=blabla} in the .tpl file. Do saving of "custom values" in the onContinue function. Preferences are saved automatically, as long as isEditable returns true
die will stop the processing without any form of cleanup
In the wizard pages, the user should be allowed to continue
I will commit my (minor) changes xavi: thanks
I got quite lost in ./lib/wizard/user_preferences_info.php attempting to rescue as much logic from the corresponding tiki-user_preferences.php arildb: he he...yes a litlle monster that one xavi: :-)
thanks for your help (limited skills set here, I told you) Tiki-KGB: 03arildb r47702 10trunk/ 10(5 files in 2 dirs)
[ENH] Some alterations to make the new userpages more correct.
The "structure" is a bit wrong. In onSetupPage, do not set preferences, use {preference=blabla} in the .tpl file. Do saving of "custom values" in the onContinue function. Preferences are saved automatically, as long as isEditable returns true.
I have not updated that. xavi: but since the accident, it happens every now and then that I have a few hours per day quite free for things like these arildb: xavi: How do you intent to trigger the user wizard? xavi: no idea yet, step by step arildb: yes xavi: I thought there was already a way to launch it for new users, but I'm wrong, it's only in cases where "user registration" is validated by admins. In such case, there is a preference to seet the url to send the users once their accounts are validated
bbl chkpnt: joined #tikiwiki
Hi. Here is AutoLink enabled. How do I suppress a link to an external page?
thought it is ))...(( but doesn't work xavi: hi chkpnt. In the old days, ]...[ worked for external pages ricks99: )) (( is only for internal pages xavi: in present times, if ]...[ doesn't work for you, you can try (maybe) ~np~ http://example.com ~/np~ ?
hi ricks99 ricks99: hiya xavi
chkpnt: do you want to supress the external link globally? or just for a specific instance? xavi: the other day I thought: "hey, Rick has'nt said anything about the Admin Wizard (yet)". ricks99: lol xavi: ricks99: too busy with the books? ricks99: mixed feelings.love the idea, think it is a step in right direction. but i think i came into the conversation too late. will wait and see
books... sigh jonnyb: joined #tikiwiki chkpnt: ricks99: only one specific link
xavi: thanks. I'll give it a try. ricks99: iirc, will need to use the ~np~ xavi: arildb, I'm checking for instance at user_preferences_notifications.php, and they seem to be not defined. I.e., I set: {preference name=user_wiki_watch_editor} in the tpl, and then I get in the page: "Preference user_wiki_watch_editor is not defined: [Error]" Tiki-KGB: 03jonnybradley r47703 10trunk/ 10lib/core/Services/User/Controller.php 10lib/userprefs/userprefslib.php 10templates/user/info.tpl
[FIX] userinfo: Correct last login and improve label and round distance to nearest metre. chkpnt: left #tikiwiki Tiki-KGB: 03xavidp r47704 10trunk/templates/wizard/user_preferences_notifications.tpl * [FIX]Fixed syntax for preference definition in the wizard
03jonnybradley r47705 10trunk/ 10lib/userslib.php 10lib/smarty_tiki/modifier.userlink.php 10templates/modules/mod-last_visitors.tpl
[ENH] user-info: Use same service for userlink modifier popups as is now on avatars. Still TODO: caching and show "idletime" (if still needed)
03xavidp r47706 10trunk/lib/wizard/pages/user_preferences_info.php * [MOD]Remove the fat and leave file small to improve organically step by step Tiki|bot: New Forum Posts: Running TikiWiki behind a frontend - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=49287 Tiki-KGB: 03xavidp r47707 10trunk/lang/es/language.php * [TRA]Conflict resolved
03jonnybradley r47708 10trunk/templates/vimeo/upload.tpl
[FIX] vimeo: Remove busy modal from upload form before post-processing (in case something goes wrong)
03jonnybradley r47709 10trunk/templates/trackerinput/files.tpl
[FIX] vimeo: Create reference to vimeo file if "uploaded" by entering the URL, and change the label accordingly
03jonnybradley r47710 10trunk/templates/vimeo/upload.tpl
[FIX] vimeo: Another fix for webkit browsers adding uploaded files twice in tracker fields
03jonnybradley r47711 10trunk/lib/filegals/filegallib.php
[FIX] vimeo: Better error reporting on delete (still doesn't delete the filegal object, change the mime-type to remove "orphans" - better solution to come) ricks99: anyone know how to make the images "clickable" when using the {carousel} plugin? arildb: joined #tikiwiki xavi: polom arildb: Hi xavi xavi: hi arild
I still don't get the user wizard to work, after the prefs have been converted to {preference name=value} jonnyb: hi xavi arildb: You have to move all processing to the onContinue method. xavi: hi jonny@irc
I get something like: "Preference user_wiki_watch_editor is not defined: [Error]" arildb: In the onStartup method, only decide what should be shown, e.g. hide some prefs, because they don't apply. xavi: when viewing the page
example: ./lib/wizard/pages/user_preferences_notifications.php (the last one in the user wizard) arildb: hm-m xavi: I'm missing something to check current values
or maybe those user prefs work differently than site prefs arildb: I am not sure, but I believe it's one big prefs space Tiki-KGB: 03jonnybradley r47712 10trunk/lib/filegals/filegallib.php
[MOD] vimeo: If remote delete fails continue to remove the tiki object but report the problem in more detail xavi: mmm, they may go into two different mysql tables, fyi (tiki_preferences vs tiki_user_preferences ?) arildb: In user_preferences_notifications.tpl, the preferences are not defined.
Instead it used input type="checkbox" xavi: svn up arildb: This setting must be saved explicitly in the onContinue method, as I doubt the common prefs saving will work xavi: that was changed in r47704. Ensure you have this revision for this tpl file arildb: updating
yes, different now
checking user_wiki_watch_editor xavi: I confirm that user prefs are stored not in tiki_preferences but in tiki_user_preferences mysql table arildb: xavi user_wiki_watch_editor does nopt seem to behave like a regular pref. So, you must do custom handling
That means..
1) add the input in the .tpl file, e.g <p><input type="checkbox" name="user_wiki_watch_editor" value="true" {if $user_wiki_watch_editor eq 'y'}checked{/if}> {tr}Wiki{/tr}</p>
2) in onContinue, trap $_REQUEST['"user_wiki_watch_editor'] ... and process/save it.
...In onSetupPage you may want to check the existing value, and set the input ch3eckbox to the correct state
undestandable? xavi: ok, I'll try
and I guss I need to include_once ('lib/userprefs/userprefslib.php'); next to the require_once('lib/wizard/wizard.php');
s/guss/guess arildb: You will need to include this whereever needed. Note that onSetupPage and onContinue is called in 2 different "contexts", thus you cannot store values in the Wizard object Telesight: joined #tikiwiki xavi: arildb: I want to include "$tikilib->set_user_preference($user, 'user_calendar_watch_editor', 'y');" in the function onContinue arildb: ok...any problem? xavi: but tiki complains (error 500) that it doesn't know the function set_user_preference (which is defined in lib/tikilib.php
do I need to include lilb&tikilib.php explicitly somewhere? (and if so, where) arildb: Is tikilib defined. try setting either: global $tikilib xavi: ok arildb: the recommended way to is to use TikiLib::lib('tiki') .... but global will work here xavi: ok, error 500 gone, but value not stored yet arildb: so, somethig is still wrong .... can you commit again? xavi: committing
again, I only touched the last screen (Notification preferences), since it kind of the simplest one. Once it works there, I hope I learn how to fix the previous ones Tiki-KGB: 03xavidp r47713 10trunk/ 10templates/wizard/user_preferences_notifications.tpl 10lib/wizard/pages/user_preferences_notifications.php
[MOD]Changed syntax to user prefs again (they work differently than site prefs), and added some logic to catch values in function onContinue. thanks arildb arildb: ok, let me look at the parameter we talked about above
xavi: I think I see the problem xavi: ok arildb: input type="checkbox" name="user_wiki_watch_editor" value="true" checkboxes uses "checked, not value.
Let me make an adjustment and run a test, to verify xavi: ok
thks arildb: seems I was wrong, when value is included in a checkbox input, that seems to be used and not the checkbox state ...
making some more adjustments
This, however means that it always returns true, which is incorrect xavi: mmmm, hey, I managed to make it save values arildb: what did you change? xavi: mmmm, but they are not stored in the right place, it seems (I can't see them when I visit tiki-user_watches.php )
let me commit Tiki-KGB: 03jonnybradley r47714 10trunk/templates/trackerinput/files.tpl
[ENH] vimeo: Add some rudimentary validation for vimeo URLs (error messages still appear in the wrong place if multiple files fields in the form, existing issue to fix soon)
03xavidp r47715 10trunk/lib/wizard/pages/user_preferences_notifications.php
[MOD]Added notification lib, tikilib, and Setup initial wizard screen with their smarty values xavi: ^arildb arildb: running test... will check afterwards xavi: ok arildb: I think I have solved it, but running a new test now. xavi: ok fabricius: joined #tikiwiki arildb: The problem is the $user is (probably) not declared global in onContinue xavi: ah, ok arildb: xavi: Do you have a debugger? xavi: nope, I wish I knew how to set it up and use it arildb: yes, that simplifies things a lot + you get to see trace the execution path xavi: I managed to use a (visual) debug with Fortran a decade ago or so... but I never completed the phpstrom crash-course with success arildb: I am on Windows and uinsg vs.php, a Visual Studio plugin xavi: I can tell you I tried hard, I even helped with the documentation here, and I recorded the video myself from the live remote tutorial by robert Plummer years ago... but, I'm still not able to use it in my computers
http://dev.tiki.org/PhpStorm arildb: The phpstorm page looks good, but I am on Windows for othe rprojects. So, Visual STudio is good for me
xavi: works now
let me commit xavi: great! :-) rodrigoprimo: joined #tikiwiki arildb: I did not test with your latest additions, but I see no conflict xavi: ok arildb: committed Tiki-KGB: 03arildb r47716 10trunk/ 10templates/wizard/user_preferences_notifications.tpl 10lib/wizard/pages/user_preferences_notifications.php * [FIX] A couple of fixes to make the user wizard page save the user prefs xavi: yes, arildb, it works :-) arildb: :-)
then you should have a pattern to work from with the other pages xavi: yes. I'll see how far I can reach without any extra guidance :-) arildb: glad to help xavi: thanks ;-) arildb: xavi: In the onSetupPage you must also set $user as global, I believe xavi: ok, done, thanks
arildb, btw, can I remove the <form> and submit button from the user_preferences_notifications.tpl ? -: xavi confused about how the values are sent somewhere without a "form"; and also confused about which php file they should be sent to (if form is needed: user wizard or tiki-user_notifications.php) arildb: yes, you must. I didn't see that. The form is added in the wizard frame's tpl file xavi: ok, thks Tiki-KGB: 03xavidp r47717 10trunk/ 10templates/wizard/user_preferences_notifications.tpl 10lib/wizard/pages/user_preferences_notifications.php
[FIX]Former form removed and global $user added also at onSetupPage function (thanks arildb)
03yonixxx r47718 10trunk/templates/ 10(26 files) * [ENH]Adding css style instead of inline style
03fmg-sf r47719 10trunk/doc/devtools/experimental/unzip/unzipper.php * [ENH] more versions offered to download
03yonixxx r47720 10trunk/css/admin.css * [ENH]Adding css style for the admin wizard
03yonixxx r47721 10trunk/styles/layout/design.css * [ENH]Adding css style for the user wizard
03yonixxx r47722 10trunk/styles/BiDi/BiDi.css * [ENH]Adding css style so admin and user wizard are rtl compatible
03yonixxx r47723 10trunk/templates/wizard/user_preferences_notifications.tpl * [ENH]Adding css style instead of inline style rodrigoprimo: joined #tikiwiki xavi: arildb (or rodrigoprimo , in fact ;-) ), I don't know how to store the new preferences of daily reports
I managed to fetch the right values at display time
but not to store the new preferences
in fact, they are not user preferences
and they are stored in another mysq table
and this file ./lib/core/reports/Factory.php is not intuitive enough for me arildb: xavi: I am not familiar with daily reports, but I can do a quick check if I see something xavi: so... I'll commit what I have, at least arildb: Is it the setting on the panel: User Watches and preferences, called Use Reports?
called: use_daily_reports ... so, it seems to be right xavi: yes Tiki-KGB: 03xavidp r47724 10trunk/lib/wizard/pages/user_preferences_reports.php * [MOD]Fetch the right values of Daily reports for the user. arildb: xavi: I think the option is set in libcoreReportsUsers.php. Saving does not seem straight forward. Maybe you should send an email to the dev-list for advice
..or you can try to use Reports_Users directly xavi: thanks arildb. In fact, the father of current library is rodrigoprimo . Rodrigo, are you available for some help about how to store user preferences related to Daily Reports? rodrigoprimo: hi xavi
xavi: what are the new preferences? xavi: back
hi rodrigoprimo :-9
s/:-9/:-)
there is a new feature in trunk called Wizards, and we are settnig up a wizard for new users, so that a few preferences are shown to them at once
therefore that means not new preferences for daily reports, but saving the same preferences from another file, the one related to the user wizard
and we noticed that daily reports does not store the choices from the user as a user preference but "somehow differently"
I mean, with user prefs, we can do something like:
if (isset($_REQUEST['user_calendar_watch_editor']) && $_REQUEST['user_calendar_watch_editor'] == 'on') { $tikilib->set_user_preference($user, 'user_calendar_watch_editor', 'y'); }
but with the user choices or daily reports.... no idea how to save the choices the user can make marclaporte: joined #tikiwiki rodrigoprimo: xavi: check tiki-user_reports.php for an example on how to save user reports preferences
xavi: let me know if you need more help xavi: ok, thanks rodrigoprimo. I'll check there Tiki-KGB: 03arildb r47725 10trunk/templates/wizard/admin_jcapture.tpl
[ENH] Make the selected jCapture gallery name bold.
Easier to spot arildb: enough for me today. See you tomorrow marclapo1: joined #tikiwiki Tiki-KGB: 03xavidp r47726 10trunk/lib/wizard/pages/user_preferences_params.php
[MOD]Added missing code borrowed from tiki-user_preferences.php. get values placed at onSetupPage; set values placed at xavi: the commit message should end with: "...at onContinue" fabricius: reverend xavi: rodrigoprimo: so easy. Thanks, that was the file with the magic to save these preferences. It works :-) rodrigoprimo: xavi: great! :) xavi: once you ever test trunk again, you'll see the admin Wizard showing up the first time you log in as admin :-)
something like: https://doc.tiki.org/Admin+Wizard
and we are towards having a basic User Wizard in place also :-)
arildb did the magic with the infraestructure and first working example Emenems: joined #tikiwiki Tiki-KGB: 03xavidp r47727 10trunk/ 10templates/wizard/user_preferences_reports.tpl 10lib/wizard/pages/user_preferences_reports.php * [FIX]Daily report settings are saved properly. Thanks rodrigoprimo xavi: ok, done for the day. cheers
left #tikiwiki Caarrie: joined #tikiwiki Tiki-KGB: 03nkoth r47728 10trunk/ 03lib/core/Tiki/Command/BackupFilesCommand.php 03lib/core/Tiki/Command/DumpDBCommand.php 10console.php * [ENH] Add ability to generate backup and db dump from console fabricius: joined #tikiwiki