←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
Tiki-KGB03jshauk r49876 10branches/experimental/ 10(9 files in 8 dirs)
[PARTIAL FIX] history pages display pages with the parser that was used to create them
[00:02]
...... (idle for 28mn)
03xavidp r49877 10branches/12.x/ 10(6 files in 2 dirs)
[ENH]Make the category filter for the branch dynamically set instead of hardcoded in the template, as in the profile admin panel. Thanks arildb and jonnyb.
03xavidp r49878 10(10 files in 5 dirs) * [MRG] Automatic merge, branches/12.x 49870 to 49877
[00:30]
marclaportejoined #tikiwiki [00:45]
Tiki|botjoined #tikiwiki [00:50]
.... (idle for 16mn)
joined #tikiwiki [01:06]
.......... (idle for 46mn)
chibaguyjoined #tikiwiki [01:52]
.......... (idle for 45mn)
marclaportejoined #tikiwiki [02:37]
................. (idle for 1h23mn)
TomJarvisBye [04:00]
............ (idle for 56mn)
Tiki|botjoined #tikiwiki [04:56]
.............................................................. (idle for 5h9mn)
redflojoined #tikiwiki [10:05]
........ (idle for 36mn)
rodrigoprimojoined #tikiwiki [10:41]
........ (idle for 39mn)
Tiki|botRecent Bug: - Tracker auto-increment field type doesn't auto increment the value - http://dev.tiki.org/item5142 [11:20]
........ (idle for 35mn)
arildbjoined #tikiwiki [11:55]
...... (idle for 25mn)
Telesightjoined #tikiwiki [12:20]
........... (idle for 50mn)
Tiki|botjoined #tikiwiki [13:10]
ricks99joined #tikiwiki [13:10]
......... (idle for 40mn)
Tiki|botjoined #tikiwiki [13:50]
Tiki-KGB03jonnybradley r49879 10branches/12.x/lib/jquery_tiki/tiki-maps.js
[MOD] maps: Add start and stop event triggers for map searches (so external forms know when searching is happening).
Doesn't wait for external map files to load though...
[13:52]
xavijoined #tikiwiki [13:56]
...... (idle for 29mn)
Tiki|botjoined #tikiwiki [14:25]
Recent Bug: - multiple language support in quick edit plugin - http://dev.tiki.org/item5143 [14:32]
lphuberdeaujoined #tikiwiki [14:46]
xavipuff, articles are buggy in Tiki12...
maybe also in earlier versions... :-/
xavi feels lazy about more bug reporting... (maybe he can try to fix them himself at some point in the same time for reporting & reproducing in a show.t.o?)
s/same time for/same time of (and instead)
[14:52]
Tiki-KGB03xavidp r49880 10branches/12.x/lang/ca/language.php * a few fixes and new translations (articles related, mostly) [14:58]
arildbxavi: go for it! [15:12]
xavi:-) [15:12]
Tiki-KGB03lphuberdeau r49881 10trunk/ 10(13 files in 11 dirs)
[NEW] Initial parts of goal - recognition - rewards, obviously still work in progress
[15:14]
fabriciusjoined #tikiwiki [15:21]
lukegleft #tikiwiki [15:23]
jonnybjoined #tikiwiki [15:32]
MagicFab_joined #tikiwiki [15:33]
jonnybpolomolop [15:37]
xavihi jonnyb [15:39]
Tiki|botNew Forum Posts: PluginImg - How to Open Link in Same Window? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=51207 [15:39]
xaviJyhem: are you using articles with wysiwyg in 12x? (Visual Wiki, in fact - compatible wiki mode)
I had one published in Tiki9 (copy pasted from libreoffice, quite ok), and once upgraded to Tiki12, it shows ugly (html codes non parsed, maybe?). When edited, it still displays fine.
bbl
[15:39]
..... (idle for 20mn)
Tiki-KGB03lphuberdeau r49882 10branches/12.x/ 10route.php 10lib/servicelib.php 10lib/jquery_tiki/tiki-jquery.js
[FIX] Action portion in sefurl is not optional anymore, so make sure it does not cause 404 in features that used this option
[16:02]
Jyhemxavi: very early stages of the 9→12 migration of spiral. So no experimenting with articles but it will definitely happen!
still rebuilding the custom plugins. Novelties such as wysiwyg are not yet on the radar :)
[16:07]
..... (idle for 22mn)
Tiki-KGB03lphuberdeau r49883 10trunk/lib/ 10(10 files in 5 dirs) * [MOD] Add native string support in the rating language to simplify some formulas [16:32]
Telesightjoined #tikiwiki [16:32]
ricks99joined #tikiwiki [16:39]
Tiki-KGB03lphuberdeau r49884 10trunk/lib/ 10core/Math/Formula/Function/Str.php 10test/core/Math/Formula/RunnerTest.php * [FIX] Missing condition for native string inside str function [16:40]
xaviback
ok, jyhem. Good luck with the custom-plugin rebuild. :-)
[16:42]
by the way, Jyhem, when you have a chance, have a look at the new homepage of http://r.tiki.org and share your ideas so that we can improve that site, and once day, announce it publicly ;-)
xavi off to dive in tiki articles code a bit
[16:47]
marclaportejoined #tikiwiki [16:50]
...... (idle for 25mn)
Tiki|botjoined #tikiwiki [17:15]
New Forum Posts: Devloping admin-only mobile? - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=51208 [17:20]
Tiki-KGB03lphuberdeau r49885 10trunk/lib/goal/goallib.php
[MOD] Adding common-metric registry, replacement of common filters for goals, evaluation of conditions
[17:26]
Tiki|botjoined #tikiwiki [17:35]
.... (idle for 19mn)
Tiki-KGB03lphuberdeau r49886 10trunk/lib/ 10core/Services/Goal/Controller.php 10goal/goallib.php * [MOD] Limit the availability of of goals to a subset of users [17:54]
Tiki|botjoined #tikiwiki [17:54]
MagicFab_joined #tikiwiki [17:54]
...... (idle for 26mn)
Tiki|botNew Forum Posts: Tiki in Germany's c't magazine - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=51209 [18:20]
kstingelpolom [18:21]
jonnybhi kstingel [18:22]
kstingelhow do I move HomePage from orphans to Top category? [18:22]
lukegjoined #tikiwiki
left #tikiwiki
[18:23]
jonnybhmmm, not sure you can - the top category isn't really a category...
i guess you'd have to make a pseudo-top category and use that?
[18:23]
kstingelthat explains why it deosn't appear in cat listing lol [18:24]
jonnyb:) [18:24]
kstingelyayy ... no orphans now biggrin [18:26]
amettejoined #tikiwiki [18:26]
jonnybwow, "we" won a gold medal! [18:32]
Tiki-KGB03lphuberdeau r49887 10trunk/lib/ 10core/Search/ContentSource/ActivityStreamSource.php 10core/Services/Goal/Controller.php 10goal/goallib.php * [MOD] Add support for group goals [18:34]
...... (idle for 28mn)
dabrightjoined #tikiwiki [19:02]
xavipolom, what shall we do with rating articles in 12x? it seems to call to a non-existing function
lib/smarty_tiki/function.rating.php line 40:
$artlib->vote_comment($id, $user, $value);
but vote_comment is found only in TikiLib::lib('comments'), but not in lib/articles/artlib.php
jonnyb still around? ^
[19:16]
jonnybhi xavi [19:20]
xavixavi confused on what to do [19:20]
jonnybdoes it work using that one? TikiLib::lib('comments')->vote_comment i mean? [19:21]
xavimmm, not sure if the wrong info will be stored (or attempted to store). that comments->vote_comment will do this query:
$query = "update `tiki_comments` set `average` = `points`/`votes` where `threadId`=?";
and this has nothing to do about articles, which might have rating enabled on an article basis, but disabled comments on them
I did search in Tiki9, and it seems similar to Tiki12... I need to checkout some Tiki6 or so to see whether that was different there...
[19:23]
jonnybbut vote_comment sounds like it's about comments, not articles, no? [19:24]
xaviyes, you are right (remember "clean_user"?) [19:25]
jonnyb:) [19:25]
xaviso I do not always rely on the intuitive meaning of the function :-), and that function o articles is called after an if clause to see whether it's an article, etc. [19:25]
jonnybi think most of the comments stuff was in tikilib, so calling it via $artlib->vote_comment would have worked
but probably as it wasn't $tikilib->vote_comment it got mossed in the refactoring (i'm guessing)
[19:26]
xavimaybe lphuberdeau did look at the rating function at some point, even if I wonder if he looked at that for articles... [19:27]
jonnybmossed/missed [19:27]
xaviyes, looks as if it got lost in some refactoring... (KILL KILL KILL addiction)
lphuberdeau: any tip on the best approach to use some sort of rating for articles in Tiki12?
[19:27]
lphuberdeau"User ratings on articles" seem to work
at least, it worked last time I checked
[19:30]
Tiki-KGB03jonnybradley r49888 10branches/12.x/lib/jquery_tiki/tiki-maps.js
[ENH] maps: Extend the number of styling attributes that can be set for vector features (currently in geojson files).
Documentation to come...
03jonnybradley r49889 10(6 files in 5 dirs) * [MRG] Automatic merge, branches/12.x 49877 to 49888
[19:34]
xavilphuberdeau: I do get a page with whiteish backgound (as if css was lost), and no header, side columnss, etc. , plus apache error message: "Fatal error: Call to undefined method ArtLib::vote_comment() in /path/lib/smarty_tiki/function.rating.php on line 40" [19:37]
lphuberdeauyeah, saw that
vote does get recorded however
[19:37]
xaviyes, I wonder where :-)
tiki's magic makes me dizzy...
[19:37]
lphuberdeauit gets recorded by the code handling votes... then it calls a function that does not exist [19:38]
xaviok [19:38]
lphuberdeaulooks like someone tried to duplicate code for no reason at all [19:38]
xaviand forgot to copy the code over, etc.
I'll try onsite to comment out that chunk of non-sense code
[19:38]
Tiki-KGB03lphuberdeau r49890 10branches/12.x/lib/smarty_tiki/function.rating.php
[FIX] Call to function that does not exist, and is not required as record_vote just handled the vote a few lines above...
[19:42]
xavithks lphuberdeau [19:44]
ricks99left #tikiwiki [19:44]
lphuberdeaualways fun when the solution to fixing a bug is removing code [19:44]
xavi:-D
I confirm that commenting out those lines fixes the issue for the end user
[19:45]
lphuberdeauyes, and the rating still works and get saved
not the greatest UI, but that's life
[19:46]
xavi:-)
another question about rating and articles, in case you know: there is a setting when editing article type params: comment_can_rate_article , but when in the comment form, as admin, I see no option to rate the article...
any clue?
in Tiki12, I mean
[19:46]
lphuberdeauthe code for comments indicates that comment ratings are a global feature [19:49]
Tiki|botjoined #tikiwiki [19:50]
lphuberdeauwhich seem to follow the wiki_comments_simple_ratings preference [19:50]
xavicomment_can_rate_article seems to be not used at all, beyond the checkbox definition in the article types :-(
(and the profile install handler)
comment_can_rate_article != comments_vote
[19:54]
lphuberdeauyeah, well, comments were quite copy-pasted and each feature did something differently, yes, some options were killed, but the feature set remains quite complete ... some settings/prefs have not been cleaned out [19:57]
Tiki|botjoined #tikiwiki [20:00]
xavimmm, yes, and it seems that also, comments_vote does nothing on articles, just on forums (according to the usage of "comments_vote"). [20:02]
lphuberdeauhow much do I wish people would test things out before LTS releases... [20:06]
..... (idle for 20mn)
dabrightjoined #tikiwiki [20:26]
kstingelis there a quick and simple way to import (daily updated) data into a set of trackers?
... or would I better served to write a plugin to just read the info direct from additional tables in tiki_db?
[20:40]
lphuberdeauFor imports, I tend to prefer custom import scripts that use Tiki's internals... import formats tend to have quirks and it's easier to handle with a custom script than add an infinite amount of options to Tiki
Services_Tracker_Utilities contains some rather simple to use functions to modify tracker data
[20:43]
kstingelmy data is updated daily prior to import ... so technically, I could just purge and replace each day ... [20:46]
lphuberdeauif it's read-only, additional tables, or even an entirely separate database works fine with the PluginReport [20:46]
kstingelseperate DB sounds good ... since that where I'm currently managing the data, will have a detailed look @ PluginReport ... thanks [20:47]
...... (idle for 28mn)
Tiki|botjoined #tikiwiki [21:15]
........... (idle for 50mn)
joined #tikiwiki [22:05]
xavilphuberdeau: do you mean with http://doc.tiki.org/PluginReport or something else? (doc page doesn't say anything about how to use an entirely separate database... and I would be potentially interested) [22:13]
lphuberdeauthat uses admin DSN...
ah wait... http://doc.tiki.org/PluginDbReport
[22:14]
xaviah, you mean probably the DBReport instead, I guess: http://doc.tiki.org/PluginDBReport :-)
yes, yes, tht's what I thought
so many wiki plugins! :-D
[22:15]
lphuberdeauI don't mind as long as they actually do something different ;) [22:16]
xavi:-)
lphuberdeau: I am considering to add a new perm to manage viewing rating results
so far, I see there is a similar perm for trackers only
right now I need it for articles (to allow anons to see the rating results but only registered can rate them, etc)
shall I add a view rating perm per feature?
I mean, when someone wants to add that type of perm for wiki pages, then they'll need to add another tiki_p_wiki_view_ratings, aside of tiki_p_articles_view_ratings, etc.
on the contrary, for comments, there is something like: 'apply_to' => array('wiki', 'trackers', 'articles', 'blogs'), , for tiki_p_read_comments
and we'll need also a similar perm for forum deliberations (provided that we get the feature finished; I talked already with robertplummer about it)
so, shall we end up adding new per-feature perms to view ratings? (that's the easiest approach for me)
[22:17]
lphuberdeauI would rather see global perms than per-feature perms
to me, rating is a global feature, although it has a history of being per-feature
plus, it reduces the total amount of permissions, which is confusingly high
[22:24]
xaviok, and how can it be applied to different features, a generic tiki_p_rating_view_results ?
and I found the setting to enable rating per comments (it was not in comments admin panel, but in rating admin panel)
[22:30]
lphuberdeauglobal permissions are mostly about naming
use the same permission, no matter which feature they are used for
[22:44]
xaviok, thnks [22:47]
Tiki-KGB03lphuberdeau r49891 10trunk/lib/jquery_tiki/tiki-jquery.js * [FIX] Chosen would be tiny on full width bootstrap .form-control selects
03lphuberdeau r49892 10trunk/ 10(12 files in 8 dirs) * [MOD] Basic management interfaces for goals (work in progress)
[23:00]
..... (idle for 20mn)
Tiki|botjoined #tikiwiki [23:20]

←Prev date Next date→ Show only urls(Click on time to select a line by its url)