Tiki-KGB: [PARTIAL FIX] history pages display pages with the parser that was used to create them
03xavidp r49877 10branches/12.x/ 10(6 files in 2 dirs)
[ENH]Make the category filter for the branch dynamically set instead of hardcoded in the template, as in the profile admin panel. Thanks arildb and jonnyb.
03xavidp r49878 10(10 files in 5 dirs) * [MRG] Automatic merge, branches/12.x 49870 to 49877 marclaporte: joined #tikiwiki Tiki|bot: joined #tikiwiki
joined #tikiwiki chibaguy: joined #tikiwiki marclaporte: joined #tikiwiki TomJarvis: Bye Tiki|bot: joined #tikiwiki redflo: joined #tikiwiki rodrigoprimo: joined #tikiwiki Tiki|bot: Recent Bug: - Tracker auto-increment field type doesn't auto increment the value - http://dev.tiki.org/item5142 arildb: joined #tikiwiki Telesight: joined #tikiwiki Tiki|bot: joined #tikiwiki ricks99: joined #tikiwiki Tiki|bot: joined #tikiwiki Tiki-KGB: 03jonnybradley r49879 10branches/12.x/lib/jquery_tiki/tiki-maps.js
[MOD] maps: Add start and stop event triggers for map searches (so external forms know when searching is happening).
Doesn't wait for external map files to load though... xavi: joined #tikiwiki Tiki|bot: joined #tikiwiki
Recent Bug: - multiple language support in quick edit plugin - http://dev.tiki.org/item5143 lphuberdeau: joined #tikiwiki xavi: puff, articles are buggy in Tiki12...
maybe also in earlier versions... :-/ -: xavi feels lazy about more bug reporting... (maybe he can try to fix them himself at some point in the same time for reporting & reproducing in a show.t.o?) xavi: s/same time for/same time of (and instead) Tiki-KGB: 03xavidp r49880 10branches/12.x/lang/ca/language.php * a few fixes and new translations (articles related, mostly) arildb: xavi: go for it! xavi: :-) Tiki-KGB: 03lphuberdeau r49881 10trunk/ 10(13 files in 11 dirs)
[NEW] Initial parts of goal - recognition - rewards, obviously still work in progress fabricius: joined #tikiwiki lukeg: left #tikiwiki jonnyb: joined #tikiwiki MagicFab_: joined #tikiwiki jonnyb: polomolop xavi: hi jonnyb Tiki|bot: New Forum Posts: PluginImg - How to Open Link in Same Window? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=51207 xavi: Jyhem: are you using articles with wysiwyg in 12x? (Visual Wiki, in fact - compatible wiki mode)
I had one published in Tiki9 (copy pasted from libreoffice, quite ok), and once upgraded to Tiki12, it shows ugly (html codes non parsed, maybe?). When edited, it still displays fine.
bbl Tiki-KGB: 03lphuberdeau r49882 10branches/12.x/ 10route.php 10lib/servicelib.php 10lib/jquery_tiki/tiki-jquery.js
[FIX] Action portion in sefurl is not optional anymore, so make sure it does not cause 404 in features that used this option Jyhem: xavi: very early stages of the 9→12 migration of spiral. So no experimenting with articles but it will definitely happen!
still rebuilding the custom plugins. Novelties such as wysiwyg are not yet on the radar :) Tiki-KGB: 03lphuberdeau r49883 10trunk/lib/ 10(10 files in 5 dirs) * [MOD] Add native string support in the rating language to simplify some formulas Telesight: joined #tikiwiki ricks99: joined #tikiwiki Tiki-KGB: 03lphuberdeau r49884 10trunk/lib/ 10core/Math/Formula/Function/Str.php 10test/core/Math/Formula/RunnerTest.php * [FIX] Missing condition for native string inside str function xavi: back
ok, jyhem. Good luck with the custom-plugin rebuild. :-)
by the way, Jyhem, when you have a chance, have a look at the new homepage of http://r.tiki.org and share your ideas so that we can improve that site, and once day, announce it publicly ;-) -: xavi off to dive in tiki articles code a bit marclaporte: joined #tikiwiki Tiki|bot: joined #tikiwiki
New Forum Posts: Devloping admin-only mobile? - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=51208 Tiki-KGB: 03lphuberdeau r49885 10trunk/lib/goal/goallib.php
[MOD] Adding common-metric registry, replacement of common filters for goals, evaluation of conditions Tiki|bot: joined #tikiwiki Tiki-KGB: 03lphuberdeau r49886 10trunk/lib/ 10core/Services/Goal/Controller.php 10goal/goallib.php * [MOD] Limit the availability of of goals to a subset of users Tiki|bot: joined #tikiwiki MagicFab_: joined #tikiwiki Tiki|bot: New Forum Posts: Tiki in Germany's c't magazine - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=51209 kstingel: polom jonnyb: hi kstingel kstingel: how do I move HomePage from orphans to Top category? lukeg: joined #tikiwiki
left #tikiwiki jonnyb: hmmm, not sure you can - the top category isn't really a category...
i guess you'd have to make a pseudo-top category and use that? kstingel: that explains why it deosn't appear in cat listing lol jonnyb: :) kstingel: yayy ... no orphans now biggrin amette: joined #tikiwiki jonnyb: wow, "we" won a gold medal! Tiki-KGB: 03lphuberdeau r49887 10trunk/lib/ 10core/Search/ContentSource/ActivityStreamSource.php 10core/Services/Goal/Controller.php 10goal/goallib.php * [MOD] Add support for group goals dabright: joined #tikiwiki xavi: polom, what shall we do with rating articles in 12x? it seems to call to a non-existing function
lib/smarty_tiki/function.rating.php line 40:
$artlib->vote_comment($id, $user, $value);
but vote_comment is found only in TikiLib::lib('comments'), but not in lib/articles/artlib.php
jonnyb still around? ^ jonnyb: hi xavi -: xavi confused on what to do jonnyb: does it work using that one? TikiLib::lib('comments')->vote_comment i mean? xavi: mmm, not sure if the wrong info will be stored (or attempted to store). that comments->vote_comment will do this query:
$query = "update `tiki_comments` set `average` = `points`/`votes` where `threadId`=?";
and this has nothing to do about articles, which might have rating enabled on an article basis, but disabled comments on them
I did search in Tiki9, and it seems similar to Tiki12... I need to checkout some Tiki6 or so to see whether that was different there... jonnyb: but vote_comment sounds like it's about comments, not articles, no? xavi: yes, you are right (remember "clean_user"?) jonnyb: :) xavi: so I do not always rely on the intuitive meaning of the function :-), and that function o articles is called after an if clause to see whether it's an article, etc. jonnyb: i think most of the comments stuff was in tikilib, so calling it via $artlib->vote_comment would have worked
but probably as it wasn't $tikilib->vote_comment it got mossed in the refactoring (i'm guessing) xavi: maybe lphuberdeau did look at the rating function at some point, even if I wonder if he looked at that for articles... jonnyb: mossed/missed xavi: yes, looks as if it got lost in some refactoring... (KILL KILL KILL addiction)
lphuberdeau: any tip on the best approach to use some sort of rating for articles in Tiki12? lphuberdeau: "User ratings on articles" seem to work
at least, it worked last time I checked Tiki-KGB: 03jonnybradley r49888 10branches/12.x/lib/jquery_tiki/tiki-maps.js
[ENH] maps: Extend the number of styling attributes that can be set for vector features (currently in geojson files).
Documentation to come...
03jonnybradley r49889 10(6 files in 5 dirs) * [MRG] Automatic merge, branches/12.x 49877 to 49888 xavi: lphuberdeau: I do get a page with whiteish backgound (as if css was lost), and no header, side columnss, etc. , plus apache error message: "Fatal error: Call to undefined method ArtLib::vote_comment() in /path/lib/smarty_tiki/function.rating.php on line 40" lphuberdeau: yeah, saw that
vote does get recorded however xavi: yes, I wonder where :-)
tiki's magic makes me dizzy... lphuberdeau: it gets recorded by the code handling votes... then it calls a function that does not exist xavi: ok lphuberdeau: looks like someone tried to duplicate code for no reason at all xavi: and forgot to copy the code over, etc.
I'll try onsite to comment out that chunk of non-sense code Tiki-KGB: 03lphuberdeau r49890 10branches/12.x/lib/smarty_tiki/function.rating.php
[FIX] Call to function that does not exist, and is not required as record_vote just handled the vote a few lines above... xavi: thks lphuberdeau ricks99: left #tikiwiki lphuberdeau: always fun when the solution to fixing a bug is removing code xavi: :-D
I confirm that commenting out those lines fixes the issue for the end user lphuberdeau: yes, and the rating still works and get saved
not the greatest UI, but that's life xavi: :-)
another question about rating and articles, in case you know: there is a setting when editing article type params: comment_can_rate_article , but when in the comment form, as admin, I see no option to rate the article...
any clue?
in Tiki12, I mean lphuberdeau: the code for comments indicates that comment ratings are a global feature Tiki|bot: joined #tikiwiki lphuberdeau: which seem to follow the wiki_comments_simple_ratings preference xavi: comment_can_rate_article seems to be not used at all, beyond the checkbox definition in the article types :-(
(and the profile install handler)
comment_can_rate_article != comments_vote lphuberdeau: yeah, well, comments were quite copy-pasted and each feature did something differently, yes, some options were killed, but the feature set remains quite complete ... some settings/prefs have not been cleaned out Tiki|bot: joined #tikiwiki xavi: mmm, yes, and it seems that also, comments_vote does nothing on articles, just on forums (according to the usage of "comments_vote"). lphuberdeau: how much do I wish people would test things out before LTS releases... dabright: joined #tikiwiki kstingel: is there a quick and simple way to import (daily updated) data into a set of trackers?
... or would I better served to write a plugin to just read the info direct from additional tables in tiki_db? lphuberdeau: For imports, I tend to prefer custom import scripts that use Tiki's internals... import formats tend to have quirks and it's easier to handle with a custom script than add an infinite amount of options to Tiki
Services_Tracker_Utilities contains some rather simple to use functions to modify tracker data kstingel: my data is updated daily prior to import ... so technically, I could just purge and replace each day ... lphuberdeau: if it's read-only, additional tables, or even an entirely separate database works fine with the PluginReport kstingel: seperate DB sounds good ... since that where I'm currently managing the data, will have a detailed look @ PluginReport ... thanks Tiki|bot: joined #tikiwiki
joined #tikiwiki xavi: lphuberdeau: do you mean with http://doc.tiki.org/PluginReport or something else? (doc page doesn't say anything about how to use an entirely separate database... and I would be potentially interested) lphuberdeau: that uses admin DSN...
ah wait... http://doc.tiki.org/PluginDbReport xavi: ah, you mean probably the DBReport instead, I guess: http://doc.tiki.org/PluginDBReport :-)
yes, yes, tht's what I thought
so many wiki plugins! :-D lphuberdeau: I don't mind as long as they actually do something different ;) xavi: :-)
lphuberdeau: I am considering to add a new perm to manage viewing rating results
so far, I see there is a similar perm for trackers only
right now I need it for articles (to allow anons to see the rating results but only registered can rate them, etc)
shall I add a view rating perm per feature?
I mean, when someone wants to add that type of perm for wiki pages, then they'll need to add another tiki_p_wiki_view_ratings, aside of tiki_p_articles_view_ratings, etc.
on the contrary, for comments, there is something like: 'apply_to' => array('wiki', 'trackers', 'articles', 'blogs'), , for tiki_p_read_comments
and we'll need also a similar perm for forum deliberations (provided that we get the feature finished; I talked already with robertplummer about it)
so, shall we end up adding new per-feature perms to view ratings? (that's the easiest approach for me) lphuberdeau: I would rather see global perms than per-feature perms
to me, rating is a global feature, although it has a history of being per-feature
plus, it reduces the total amount of permissions, which is confusingly high xavi: ok, and how can it be applied to different features, a generic tiki_p_rating_view_results ?
and I found the setting to enable rating per comments (it was not in comments admin panel, but in rating admin panel) lphuberdeau: global permissions are mostly about naming
use the same permission, no matter which feature they are used for xavi: ok, thnks Tiki-KGB: 03lphuberdeau r49891 10trunk/lib/jquery_tiki/tiki-jquery.js * [FIX] Chosen would be tiny on full width bootstrap .form-control selects
03lphuberdeau r49892 10trunk/ 10(12 files in 8 dirs) * [MOD] Basic management interfaces for goals (work in progress) Tiki|bot: joined #tikiwiki