Tiki-KGB: [FIX] Lines not wrapping within wide tables (fix needs to be spread to other templates)
03eromneg r51962 10branches/13.x/ 10(5 files)
[FIX] add another div around the table so that wide tables are not stretched and text is wrapped etc., so they do not need to be scrolled. There may be more .tpl files that this needs to be applied to. lindonb: joined #tikiwiki Tiki-KGB: 03jyhem r51963 10branches/12.x/lib/core/Table/Code/WidgetOptions.php * [FIX] Reduce the chances of empty admin users list nelsonko: left #tikiwiki Tiki-KGB: 03chibaguy r51964 10branches/13.x/ 10(5 files)
[FIX] Class="table" doesn't seem to be necessary; the div itself with no class specified will cause text to wrap (in my tests - roll back if you find the class is actually needed).
03chibaguy r51965 10branches/13.x/ 10(27 files in 4 dirs)
[FIX] Responsive table media query breakpoint was reduced to make width changes smoother; overflow-x was changed from scroll to auto to prevent display of scrollbar unless it is needed by content.
03chibaguy r51966 10branches/13.x/ 10(12 files in 7 dirs) * [FIX] Improve title-background contrast of module titles. fabricius: joined #tikiwiki shizzle: joined #tikiwiki
hi
if i send a newsletter containing an article, links to attached files are wrong... (within the article the links work)
http://www.tiki-download_file.php/?fileId=2512 <- the download link in the newsletter loks like this
any clue how to resolve this? (couldnt find anything on the web - maybe i just couldnt find the right search term)
{FILE( type="gallery" fileId="2512" showicon="y")}Name of the file{FILE} (thats the link in the article) xavi: joined #tikiwiki fabricius: joined #tikiwiki Tiki-KGB: 03eromneg r51967 10branches/13.x/ 10(6 files)
[FIX] another batch of .tpl's omitting the class as per Gary's update: add another div around the table so that wide tables are not stretched and text is wrapped etc., so they do not need to be scrolled. There may be more .tpl files that this needs to be applied to. Tiki|bot: New Forum Posts: TikiWiki 6 and PHP compatiblity - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=52724 jonnyb: joined #tikiwiki
polom xavi: oups, that was a quick visit jonnyb_: joined #tikiwiki Tiki|bot: New Forum Posts: LGPL 2.1 vs 3.0 (compatible with Apache2?) & visjs.org - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52727 Tiki-KGB: 03xavidp r51968 10branches/13.x/templates/wizard/profiles_useful_changes_in_display.tpl
[FIX]Remove from the Profiles Wizard the uneeded "Mobile" profile in Tiki 13.x to have the display adapted automagically to mobile devices Tiki|bot: Recent Bug: - http://dev.tiki.org/item5342 Tiki-KGB: 03jyhem r51969 10branches/12.x/lib/core/Table/Code/WidgetOptions.php * [FIX] Clean fix of empty admin users list bug (better than r51963)
03jonnybradley r51970 10branches/13.x/tiki-wikiplugin_edit.php
[FIX] wysiwyg: Only parse back to wiki if it's the wysiwyg plugin being edited. Possibly should also check for if the page is_html but this stops all pages breaking when plugins are edited.
(following r50752 which i don't fully understand, as even with that change, the wysiwyg plugin still operates in html but somehow wiki syntax seems to get saved) jonnyb_: Jyhem: you there? Jyhem: jonnyb_: somehow (some stuff cooking) Tiki|bot: Recent Bug: - http://dev.tiki.org/item5343 jonnyb_: just wondering - re r51969 or r51963 - how come you can see the user admin page without any users on it? Jyhem: A lot of people have been complaining about this and now I finally got a site which experiences the issue. Just create a group called "Braine l'Alleud" and put one user in it
then the whole user list is empty and your firebug console complains that :
SyntaxError: missing : after property id
'Braine l'Alleud' : function(e, n, f, i) { return /Braine l'Alleud/.te
Digging deeper, you see the complete line : 'Braine l'Alleud' : function(e, n, f, i) { return /Braine l'Alleud/.test(e);},
And then after you have fixed Braine l'Alleud, it breaks on group 'Chão Bom / São Miguel Tarrafal' because of the slash in the regexp.
And you realise this regexp is actually a bad design since you really want a match, not a partial match
Otherwise, looking for group 'Strasbourg' matches both 'Strasbourg' and 'Strasbourg-Campagne' and not the other way round (yuck) jonnyb_: (sorry Jyhem, back) ew, that all doesn't sound good, it should be using group id's i guess Tiki-KGB: 03eromneg r51971 10branches/13.x/ 10(8 files)
[FIX] yet another batch of .tpl's omitting the class as per Gary's update: add another div around the table so that wide tables are not stretched and text is wrapped etc., so they do not need to be scrolled. There may be more .tpl files that this needs to be applied to. jonnyb_: hmm, can't add a group :( i'm getting "Notice: this variable may not be empty: $_POST["username"]" (which usually means there's an unclosed form in col1) Tiki-KGB: 03jonnybradley r51972 10branches/13.x/templates/tiki-admingroups.tpl
[FIX] group admin: Missing closing tag on details form and member list form only closed sometimes - bootstrap casualties
03eromneg r51973 10branches/13.x/templates/tiki-article_types.tpl
[FIX] add another div around the table so that wide tables are not stretched and text is wrapped etc., so they do not need to be scrolled - but for this tpl add a new class so that customisation is possible (eg reduce the font size), since this table can be quite wide even when all text wrapping is achieved. nelsonko: joined #tikiwiki Tiki-KGB: 03jonnybradley r51974 10branches/13.x/lib/core/Table/Code/WidgetOptionsFilter.php
[FIX] tablesorter: Escape single quotes in dropdown filters, as seen on group admin with groups containing a quote char (sort of fore-port of r51969, thanks Jyhem) jonnyb_: polom nelsonko - did you see http://sourceforge.net/p/tikiwiki/code/51970 ? nelsonko: jonny: nope, just got up and have too many things to do today, but looking jonnyb_: it was related to your fix for the wysiwyg plugin using wiki syntax, which i remember you asked about at the time but i wasn't able to investigate properly (although i recall thinking that wasn't enough code to work fully!)
ok, no probs, think i fixed it enough for 13.0 but it's still porbably not quite right nelsonko: so I've been using it and so far it still operates as html yes -: jonnyb hates those underscores jonnyb: not sure how it makes sense parsing to wiki in tiki-wikiplugin_edit.php though?
but i left it in there only when editing that plugin (it was breaking pages with all others) - just seems a bit odd :) nelsonko: seems to make sense. I did not check that tiki-wikiplugin_edit.php was used by other things
but of course it is jonnyb: all the little green jigsaw piece icons ;) nelsonko: yes it is obvious now,
it just didn't click that the wysiwyg plugin was using that to save its contents
sort of mental blocked when I did that jonnyb: yes, i'd forgotten that too (and i wrote it!) nelsonko: maybe it should have it's own way, but I don't know jonnyb: ew, just got a load of conflicts with trunk :(
yes, ideally it should use a service or two nelsonko: right Tiki-KGB: 03lphuberdeau r51975 10branches/12.x/ 10(6 files in 4 dirs)
[FIX] Translation was done at the library level, causing non-site default language administrator editing fields to change the field names to the tranlsated values for everyone (will forward-port adapted fix soon)
03jonnybradley r51976 10(73 files in 24 dirs)
[MRG] Automatic merge, branches/13.x 51955 to 51974
Conflicts occurred during the merge - fixed by hand (table-striped classes added in trunk)
templates/tiki-forums.tpl
templates/tiki-list_blogs.tpl
templates/tiki-list_trackers.tpl
templates/tiki-listpages_content.tpl
03robertplummer r51977 10branches/13.x/ 10(5 files in 5 dirs) * [FIX] Ensure search results with output type of wikiLingo are parsed correctly jonnyb: lunch, bbl Tiki-KGB: 03lphuberdeau r51978 10branches/13.x/ 10(8 files in 5 dirs)
[FIX] Translation was done at the library level, causing non-site default language administrator editing fields to change the field names to the tranlsated values for everyone nelsonko: jonnybradley jonnyb: hi nelsonko nelsonko: jonnyb, looks like if we go ahead to add the <div table="class"> it will cause lots of conflicts Tiki-KGB: 03lphuberdeau r51979 10(14 files in 11 dirs) * [MRG] Automatic merge, branches/13.x 51974 to 51978 -: jonnyb should have actually gone for lunch ;) jonnyb: yes, seems someone's added a load of "striped" classes in trunk - maybe we should backport them first? nelsonko: worth a try
let me reply to that thread o devlist before anyone commits more jonnyb: ok, good plan
i go eat Tiki|bot: New Forum Posts: dev.tiki.org layout - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52729 dabright: joined #tikiwiki fabricius: joined #tikiwiki jonnyb: joined #tikiwiki Tiki|bot: New Forum Posts: LGPL 2.1 vs 3.0 (compatible with Apache2?) & visjs.org - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52733 Tiki-KGB: 03lphuberdeau r51980 03trunk/templates/prefs/multiselector.tpl * [FIX] Missing file
03lphuberdeau r51981 10trunk/lib/ 10userslib.php 10core/Search/ContentSource/GroupSource.php 10setup/events.php * [MOD] Make sure the index is updated when groups are added/updated/removed Tiki|bot: Recent Bug: - http://dev.tiki.org/item5344 Tiki-KGB: 03luciash r51982 10branches/13.x/lib/smarty_tiki/function.query.php
[FIX] to get the correct path from current script using dirname() it is always better to use REQUEST_URI instead of PHP_SELF server var (fixes https://dev.tiki.org/bug5110)
03lphuberdeau r51983 10trunk/ 10(12 files in 9 dirs)
[ENH] Indexing tracker fields as well to make them available through selectors, deploy selectors for tracker field options nelsonko: jonnyb: are you there? can you help geoff with the <div class="table" merge issue? I think he has done a bit but not committed yet (as per his mail to devlist) jonnyb: here, nelsonko - just finishing a call Tiki|bot: New Forum Posts: Opportunity for security audit of your Tiki (respond by 31 July) - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52736 jonnyb: joined #tikiwiki nelsonko: joined #tikiwiki jonnyb: re
nelsonko: have replied to Geoff's query re the conflicts
don't think there's a particularly good way to avoid them nelsonko: uh, ok jonnyb: by the way, did you see that links like https://dev.tiki.org/bug5110 don't work any more? (sawm for https://dev.tiki.org/wish5110)
were they in .htaccess? maybe the customisations didn't get copied across to the new server? nelsonko: interesting, is that plugin alias?
maybe they were htaccess let me cehck jonnyb: yes, think they are nelsonko: I think it's nginx rules
.htaccess is copied over but because we are running nginx the config is elsewhere jonnyb: hmm, not familair with nginx - does it have rewrite rules? nelsonko: nginx needs it's own rules, it does not obey .htaccess jonnyb: wasn't 12.x dev.tiki.org on nginx too? nelsonko: yes but the rules were probably not copied over to the new server (they are in nginx.conf or something like that)
strange can't find them jonnyb: aha, understood (shame we don't have a way of adding stuff to route.php easily yet) nelsonko: strange .htaccess works on the old server jonnyb: hmmm, different versions maybe?
for apache you can set what can be overriden in .htaccess in the main conf file directory definitions, maybe nginx is similar?
when i say "directory definitions" i might mean virtual server thingies... nelsonko: ah apache is running too that's why jonnyb: aha, maybe that's what's making it so slow too? nelsonko: done rules added jonnyb: yay, well done! :)
both bug and wish links back, thanks nelsonko: btw are you still getting those 504s? jonnyb: haven't been on dev much in last hour, but will keep an eye on it
just logged out and in and was fine Tiki-KGB: 03jonnybradley r51984 10branches/13.x/lib/jquery_tiki/tiki-jquery.js
[FIX] comments: Restore "modal" busy indicator while saving comments (sure it use to do that in 12.x?) Telesight: joined #tikiwiki jonnyb: nelsonko: still there? i think the htaccess change has broken the service rewrite rules - try http://dev.tiki.org/tiki-comment-list?type=trackeritem&objectId=5300
gots a 404
(was working before, i was posting comments) nelsonko: let me revert and see
try now
strange, the rule is matching weird jonnyb: yup, comments are back nelsonko: anyway, so far so good jonnyb: and wish1234 seems ok too still
so any idea about http://dev.tiki.org/item5300 - looks quite mysterious to me
and also quite horrifying (hate character encoding bugs!) jonnyb_: joined #tikiwiki Telesight1: joined #tikiwiki nelsonko: I should comment on the bug
you have to change mysql encoding used
but this one not sure
nay thing I can think of is to try the dump and see if can reproduce - but I don't have time to ooh into it
I can get a tiki.org dump...
from the backup svr TomJarvis: joined #tikiwiki nelsonko: hmm, no backup
must be due to the server move
mailed oliver xavi: left #tikiwiki jonnyb: hi nelsonko - sorry, only have irc notification if you mention my nick, thanks for looking into that
have to go now, more tomorrow nelsonko: left #tikiwiki