Tiki-KGB: 03alexandrequessy r51999 10branches/12.x/lib/userslib.php * [ENH] More documentation strings in lib/userslib.php
03alexandrequessy r52000 10branches/12.x/lib/userslib.php * [REVERT] Revert r51999 More documentation strings in lib/userslib.php Jyhem: polom nelsonko: polom Jyhem: I have a fix for convene, https://dev.tiki.org/Where+to+commit says I should commit to 13.x then merge to 12.x
what about trunk? should I merge to trunk or is that some automated thing I'd better not interfere in ? nelsonko: it's still automated
you can run the script if you have a clean trunk around https://dev.tiki.org/Semi-automatic+merging+period
but otherwise someone, usu jonny will probably run int tomorrow Tiki-KGB: 03alexandrequessy r52001 10trunk/ 10permissioncheck/.htaccess 10favicon.png 10favicon.ico 10templates/layouts/social/layout_view.tpl * [ENH] Improve menus in the social layout Jyhem: ok, thanks. I will not since it might bring lots of other stuff nelsonko: right and if there are conflicts you have to solve it Jyhem: exactly, not something I want to start at 2:15 am Tiki-KGB: 03alexandrequessy r52002 10trunk/ 10permissioncheck/.htaccess 10favicon.png 10favicon.ico 10templates/layouts/social/layout_view.tpl * [REVERT] Revert r52001 Improve menus in the social layout nelsonko: alexandre is from montreal actually I think though I have not met him before Jyhem: Hi Alexandre. I don't think I have, either :) nelsonko: he is not on irc, it is just his commits
that appear Tiki-KGB: 03jyhem r52003 10trunk/lib/wiki-plugins/wikiplugin_convene.php * [FIX] Prevent garbage data from disrupting the whole Tiki display Jyhem: That was replacing the whole demo/12 site with an ugly error message :-( Tiki-KGB: 03alexandrequessy r52004 10trunk/lib/userslib.php * [ENH] Improve menus in the social layout Jyhem: just because someone tried to enter garbage in the convene plugin
there we are Tiki-KGB: 03jyhem r52005 10branches/12.x/lib/wiki-plugins/wikiplugin_convene.php * [FIX][bp/r52003] Prevent garbage data from disrupting the whole Tiki display nelsonko: jyhem, you should have committed 13.x
then bp right?
Jyhem, anyway best to bp to 13.x as well then
2.15 :) Jyhem: oups, my mistake :-(
yes, I merge that in 13.x sorry nelsonko: no worries, happens to the best of us especially late at night nelsonko_: joined #tikiwiki Tiki-KGB: 03jyhem r52006 10branches/13.x/lib/wiki-plugins/wikiplugin_convene.php * [FIX][bp/r52003] Prevent garbage data from disrupting the whole Tiki display nelsonko: left #tikiwiki Jyhem: Ohh, I was about to add 13.x to the demoo server, but it says: wrong PHP version 54 but >= 55 necessary Tiki|bot: joined #tikiwiki minger01: left #tikiwiki fcpd: joined #tikiwiki
TikiWiki 12.x: Is there a place to read on how to make the corners rounded like maybe in the Shadow Section or whatever? Thanx TomJarvis: joined #tikiwiki Tiki-KGB: 03eromneg r52007 10branches/13.x/templates/tiki-objectpermissions.tpl
[FIX] missing responsive table div and add another div around the table so that wide tables are not stretched and text is wrapped etc., so they do not need to be scrolled - also for this tpl add a new class so that customisation is possible, since this table can be quite wide even when all text wrapping is achieved. arildb: joined #tikiwiki Tiki|bot: Recent Bug: - http://dev.tiki.org/item5346 nelsonko: joined #tikiwiki Tiki-KGB: 03arildb r52008 10branches/13.x/admin/include_performance.php * [FIX] chart.apis.google.com only supports http
03arildb r52009 10branches/12.x/admin/include_performance.php * [bp/r52008][FIX] chart.apis.google.com only supports http
03arildb r52010 10branches/13.x/admin/include_performance.php * [FIX] WinCache no longer flips the stat values
03arildb r52011 10branches/12.x/admin/include_performance.php * [bp/r52010][FIX] WinCache no longer flips the stat values nelsonko: arildb hi
how are you? arildb: hi nelsonko nelsonko: looking at https://developers.google.com/chart/image/docs/making_charts it seem to suggest it support https arildb: It fails, when I run it
the link on the page works..let me check a little. maybe a url change nelsonko: it is a different domain arildb: Tiki is using: chart.apis.google.com/chart. Google seems to have changed it to chart.googleapis.com nelsonko: right arildb: I will fix it nelsonko: np, thanks!
arildb, btw I am converting (right now) the doc database to innodb using the tiki_convert_myisam_to_innodb.sql script. You've never had a problem have you? I've converted another of my sites and also themes, so far so good
actually it's dev I am doing now, once that is successful I will do doc arildb: the conversion script should be up to date
I have never heard of any problems nelsonko: It should be. I checked when releasing the tiki13 beta
tks Tiki-KGB: 03arildb r52012 10branches/13.x/admin/include_performance.php
[FIX] chart.apis.google.com changed to chart.googleapis.com. https is then supported. Thanks nelsonko
Reverts of r52008
03arildb r52013 10branches/12.x/admin/include_performance.php
[bp/r52012][FIX] chart.apis.google.com changed to chart.googleapis.com. https is then supported. Thanks nelsonko
Reverts of r52008 fabricius: joined #tikiwiki minger0: joined #tikiwiki Tiki-KGB: 03eromneg r52014 10branches/13.x/templates/tiki-admin_security.tpl
[FIX] add another div around various tables so that wide tables are not stretched and text is wrapped etc., so if possible they do not need to be scrolled - and add missing $Id$
03eromneg r52015 10branches/13.x/ 10(5 files)
[FIX] add another div around tables so that wide tables are not stretched and text is wrapped etc., so if possible they do not need to be scrolled - and add a new class so that customisation is possible.
03eromneg r52016 10branches/13.x/ 10templates/tiki-theme_control_objects.tpl 10templates/tiki-theme_control.tpl
[FIX] add another div around tables so that wide tables are not stretched and text is wrapped etc., so if possible they do not need to be scrolled - plus split the assignment row into two to allow for wide obj and category names - and add missing $Id$
03jonnybradley r52017 10(18 files in 9 dirs)
[MRG] Automatic merge, branches/13.x 51987 to 52015
Conflicts occurred during the merge. Fixed...
templates/comment/post.tpl jonnyb: joined #tikiwiki
polom for the weekend
nelsonko: re "spammers targeting tiki-register" we should try setting up the "magic key" thing on tiki.org that i added a while back
means the anyone arriving at tiki-register.php without a "magic word" get param gets a 404 (my hope is that it will persuade the bots to go elsewhere)
fabricius: are you here? nelsonko: jonnyb: well, tiki.org has fail2ban, which works well jonnyb: you think? i also have that running but i really don't think it helps
i get about 3000 bans per day, these bot nets use so many ip's i don't think fail2ban really helps
i dread to think how many tiki.org gets ;) nelsonko: right, maybe the server has more cpu power so it doesn't choke before the people get banned
because I do see cpu spike before th bean happens but it happens fast enough that the server keeps chugging along jonnyb: i don't se much of a performance issue on mine, just lots of wasted bandwidth nelsonko: right, that could be an issue
might be worth trying actually. should mention it to oliver
that reminds me, I have to try the upgrade
to check the greek letters thig jonnyb: incidentally, if you go to tiki-register.php on dev or the other tiki sites you get a 302 "moved temporarily" redirect
i have a feeling a 404 would be a good option for them...
i'll have a go at the structure edit issue
well that's odd - edit structure seems ok now... will try and find the bug report.... nelsonko: maybe someone fixed it jonnyb: no, got it - well, got one of them...
mouseover on the mages not in the structure breaks
pages, not mages ;) Tiki-KGB: 03eromneg r52018 10branches/13.x/templates/tiki-admin_polls.tpl
[FIX] add another div around listing table so that wide tables are not stretched and text is wrapped etc., so if possible they do not need to be scrolled - plus put the categorise.tpl 'include' into a table row (more towards the end) so that the create tab is displayed properly ( the create form could do with some more tidying up - but at least it displays now)
03jonnybradley r52019 10branches/13.x/lib/structures/tiki-edit_structure.js
[FIX] structures: No need to disable sortable on page list items as they're not sortable in the first place (presumably something in jquery-ui draggable has changed?)
03jonnybradley r52020 10branches/12.x/lib/structures/tiki-edit_structure.js
[bp/r52019][FIX] structures: No need to disable sortable on page list items as they're not sortable in the first place (presumably something in jquery-ui draggable has changed?) nelsonko: btw jonnyb I don't see any db out of date message on doc... jonnyb: good point, i forgot to look
so just a dogfood script artefact presumably nelsonko: can you double check? jonnyb: will do
confirmed, no update notice nelsonko: I'll have to check on the next script jonnyb: would errors from it get logged somewhere? i guess if there's a db error form an upgrade schema it do that nelsonko: would not refreshing the search index do it you think?
because the only difference I can see is that, and also instead of running setup.sh manually, I do sh setup.sh -n fix
well i'm trying tiki.org now. I can check without upgrading search index jonnyb: hmm? the db update notice isn't connected with the search index is it? nelsonko: or maybe not clearing cache?
anyway, I will see jonnyb: maybe running the installer on nextdoc and seeing which scripts seem to need running would shed some light
maybe there's some updates that file in the dogfood environment? nelsonko: well nextdoc right now is last night's doc
I'll have to change it to trunk now
I can trigger it now though Tiki-KGB: 03eromneg r52021 10branches/13.x/templates/tiki-sheets.tpl
[FIX] remove superfluous create btn as there is a create tab and put the categorise.tpl 'include' into a table row (more towards the end) so that the create tab is displayed properly ( the create form could do with some more tidying up - but at least it displays now) jonnyb: hmm, nelsonko i have a fix for lib/smarty_tiki/function.query.php but am concerned after the last one's regression - but it's only for ajax commands so i think should be ok if we keep a good eye out for problems... (fix needed for structures) Tiki-KGB: 03jonnybradley r52022 10branches/13.x/lib/core/Services/Wiki/Controller.php
[FIX] structures: Empty $_GET and $_POST as they are used in get_toc and everything gets appended to the links for actions etc, making them fail nelsonko: jonnyb: sure I will have a look at the commit
structures need a rewrite one day...
lol jonnyb: this is odd - on my local self_links are already broken - the directory path is missing on them :(
ha ha, it was http://sourceforge.net/p/tikiwiki/code/51994 after all
(fixing)
hmm, i think my fix makes your fix meaningless, but will commit anyway - not sure what the initial problem with the print link was nelsonko: I wasn't sure but in that case there were two slashes
jonnyb ^ jonnyb: yes, i just checked the bug item - my fix is good then, it was breaking relavite links by adding a slash everytime nelsonko: strange, I thought base name removes the slash in front jonnyb: i think the problem was that for the return from print url it's not the basename there it seems nelsonko: for the print url it was using the absolute_uri
which is needed
But I was referring to your comment that it was breaking relative links by adding a slash everytime jonnyb: anyway, buttons on my http://localhost/tiki/branches/13.x/HomePage were linking to http://localhost/tiki-editpage.php?page=HomePage so it needed some sort of fix Tiki-KGB: 03jonnybradley r52023 10branches/13.x/lib/smarty_tiki/function.query.php
[FIX] Minor fix for r51994 - don't add a starting slash every time as that breaks relative links for tikis in subdirectories nelsonko: ook I was thinking about adding that if myself when I did my commit ...
kind of wondering about that - defensive coding (as in defensive driving) jonnyb: :) nelsonko: sorry, should have gone with my gut Tiki-KGB: 03jonnybradley r52024 10branches/13.x/lib/smarty_tiki/function.query.php
[FIX] ajax: Strip get params from ajax referrers as new ones will be added from the params (leading to double question mark issues etc) jonnyb: ok, here's my fix i'm a bit concerned about, i found the relative button issue while testing it, so i think it's ok... but that query object is mysterious and over-used nelsonko: I'm not even even sure $pos is correct?
I mean doesn't php evaluate the !== first and give you a boolean? jonnyb: i don't think so, i stepped through it a few times - $pos comes out as a number nelsonko: right, ok - the brackers jonnyb: maybe should have done on 2 separate lines i guess nelsonko: it's ok, just not so readable jonnyb: would be clearer nelsonko: so this removes the query string jonnyb: yes, but only for ajax service requests
when you save a structure the links on the icons get all messed up minger0: left #tikiwiki nelsonko: isn't $ret added at the end anyway? jonnyb: yes, so if there was a ?page_ref_id=42 on it already you ended up with two ?'s
trouble is, where else does that sort of thing happen? nelsonko: I think this fix is pretty much always correct for the ajax case
I am now a little concerned about the general case
whether there is a bug elsewhere Tiki-KGB: 03jonnybradley r52025 10branches/13.x/lib/smarty_tiki/function.query.php * [FIX] ajax: Split assignment and test to make things clearer (thanks nelsonko) arildb: joined #tikiwiki Tiki-KGB: 03jonnybradley r52026 10branches/12.x/lib/core/Services/Wiki/Controller.php
[bp/r52022][FIX] structures: Empty $_GET and $_POST as they are used in get_toc and everything gets appended to the links for actions etc, making them fail nelsonko: it looks to me by design that php_self should not have query jonnyb: it does when it's picked up from the referrer (in the case of ajax) nelsonko: in which line does it pick up the query?
$php_self = smarty_function_service( ? jonnyb: 191
hmm, i see what you mean nelsonko: ok so the problem is isolated to there
I would guess the problem is just that it did not occur to the person writ in g that base name include the query string
your fix is good. Someone suggested array_shift(explode('?', basename($url_path)));
as a way to get base name without query string
but you fix achieves the same thing I think jonnyb: that's quite neat nelsonko: (Someone on the php doc on base name I mean) jonnyb: :)
ok, i'm going to backport it to 12 as the problem is there too
i still feel there's an edge case out there somewhere that will break, will keep eyes and ears open :D Tiki-KGB: 03jonnybradley r52027 10branches/ 1012.x/lib/smarty_tiki/function.query.php 1012.x
[bp/r52024][FIX] ajax: Strip get params from ajax referrers as new ones will be added from the params (leading to double question mark issues etc)
[bp/r52025][FIX] ajax: Split assignment and test to make things clearer (thanks nelsonko) nelsonko: jonnyb: so I have test upgraded tiki.org and the greek characters are ok Tiki-KGB: 03jonnybradley r52028 10branches/ 1012.x/templates/admin/include_wysiwyg.tpl 1012.x 1012.x/lib/ckeditor_tiki/wysiwyglib.php 1012.x/lib/prefs/wysiwyg.php
[bp/r51954] Update to ckeditor that needs this coming to 12.x next.
[FIX] wysiwyg: Fix the missing toolbar buttons wish5299.
It seem the ckeditor packages in packagist.org (since v4.3) are the "standard-all" package and previously we have been using the "full" build, and these are now being used by default (even though we specify full zip packages in satis.json...)
Apparently these are actually the same but some of the basic plugins are disabled in "standard-all", so this "fix" adds a pref to restore the plugins we've been using by default.
Thanks Geoff and Nelson for all the testing and feedback! Tiki|bot: Recent Bug: - http://dev.tiki.org/item5347 jonnyb: hmm, ok - what does that mean i wonder... nelsonko: I suppose going to write email to oliver saying to check his db settings,
or check the page before upgrading jonnyb: is it a server issue? (on the new one) nelsonko: I don't know his upgrade process so I am not sure, but it looks like the same server where tiki.org/next.tiki.org is jonnyb: yes, i guess we need to try and get him to do a manual test upgrade and check that page (and the admin page) nelsonko: by ping jonnyb: hmm, even stranger then
maybe utf-8 gets mangled by the upgrade script somehow Tiki-KGB: 03jonnybradley r52029 10branches/12.x/ 10composer.lock 10composer.json
[FIX] wysiwyg: Update ckeditor to 4.3.4 which fixes issues with IE11 particularly (thanks Geoff) nelsonko: jonnyb, also I am seeing a db version error in tiki.org upgrade
but I also get a db error on the upgrade
Error 0 in 20140509_rss_add_categories_tiki
ALTER TABLE tiki_rss_items ADD COLUMN categories TEXT
Duplicate column name 'categories' jonnyb: sounds like the culprit nelsonko: but why it didn't affect doc/dev? jonnyb: it was on doc wasn't it?
i don't remember checking dev nelsonko: I had no problem with doc
(the actual upgrade i.e.) jonnyb: aha, i think nextdoc had the db out of date warning nelsonko: I check nextdoc later, right now trunk isbroken jonnyb: this looks like a new one https://dev.tiki.org/item5347
installer/schema/20140509_rss_add_categories_tiki.sql is the one nelsonko: I did click approve all plugins
but strangely there are still 2 there
duplict signature?
nah jonnyb: looks like the syntax is a bit wrong
{BOX(title="Three steps to a contextual menu" [title="Contextual Menu- Three Steps:],[bg=>b0b8d0],[width=>100]")} nelsonko: maybe that's why
there is another plugin that also did not get approved
on a different page jonnyb: perhaps 12.x ignored it
did oyu set up docold somewhere? or have the old pre-update db around?
i can't imagine how the 12 to 13 update could have mangled this plugin code nelsonko: the old db is still on the old server
set you etc/hosts files jonnyb: looksl ike that bad box plugin goes back to 2010 according to the page history
(which seems a bit buggy, by the way)
http://doc.tiki.org/tiki-pagehistory.php?page=Menu&oldver=53&newver=54 nelsonko: the bad div plugin also has an error
there are tons of div plugins on that page that worked
the one that does not approve has an error
looks like a feature to me :) jonnyb: so the plugin syntax is just a bot tighter now, something for the upgrade notes i guess
indeed, progress! :)
i'll fix the Menu page nelsonko: btw how to fix the installer/schema/20140509_rss_add_categories_tiki.sql problem? jonnyb: i think you can just add IGNORE to ALTER TABLE
as in ALTER IGNORE TABLE nelsonko: nope, it does not work
IGNORE in ALTER only ignores stuff like duplicate keys or something
(from what I read)
sigh http://stackoverflow.com/questions/972922/add-column-to-mysql-table-if-it-does-not-exist jonnyb: yes, think it needs some php
is it becasue the date is wrong on the sql filename? if the column is already in 13.x then why does it need to run that? nelsonko: these things are not based on date right?
it's based on whether the patch's recoded as applied before
let me check if the column is in 12 Tiki|bot: New Forum Posts: Doc.tiki.org upgraded to Tiki 13 - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52769
New Forum Posts: Como modificar un módulo traducido incorrectamente - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=15&comments_parentId=52767
New Forum Posts: Newbie developer questions + Visualization Plugin + Simplified Page Editor - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52759 jonnyb: hmmm, it doesn't apply all the upgrades going back to tiki 3 first time you run the installer, does it?
hmm, maybe it does
brb
there are 92 add columns in the schema dir, and you don't get an error on them all when you update a new tiki... odd Tiki|bot: New Forum Posts: Doc.tiki.org upgraded to Tiki 13 - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52769
New Forum Posts: Como modificar un módulo traducido incorrectamente - http://tiki.org/tiki-view_forum_thread.php?forumId=15&comments_parentId=52767
New Forum Posts: Newbie developer questions + Visualization Plugin + Simplified Page Editor - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52759 Tiki-KGB: 03lphuberdeau r52030 10trunk/ 10lib/smarty_tiki/function.object_selector.php 10lib/jquery_tiki/tiki-jquery.js 10templates/object_selector.tpl * [ENH] Improve the UI on single-object selector
03lphuberdeau r52031 10trunk/templates/object_selector.tpl * [FIX] Initial default selection was lost jonnyb_: joined #tikiwiki Tiki|bot: New Forum Posts: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[52029] branches/12.x - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52782 dhazel: joined #tikiwiki Tiki-KGB: 03lphuberdeau r52032 10trunk/lib/jquery_tiki/ 10mustread.js 10tiki-jquery.js * [FIX] Handle threshold -1 to always display the search controls
03lphuberdeau r52033 10trunk/lib/jquery_tiki/mustread.js * [FIX] Group filter would not work with group names containing spaces Tiki|bot: New Forum Posts: Tiki Community Site Design and Layout - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52784 nelsonko: bbl
actually maybe tomorrow, but I'll try and figure out this 20140509_rss_add_categories_tiki.sql problem befre getting back to oliver
see you later jonnyb, Jyhem etc jonnyb: ok, byee
i'm off too soon nelsonko: left #tikiwiki Tiki|bot: New Forum Posts: Tiki 13: making sure the wysiwyg edit screen is full width - a suggested approach - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52785 nelsonko: joined #tikiwiki Tiki|bot: New Forum Posts: nextinfo.tiki.org - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52786 TomJarvis: joined #tikiwiki fabricius: polom Tiki|bot: New Forum Posts: nextinfo.tiki.org - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52786
New Forum Posts: Tiki 13: making sure the wysiwyg edit screen is full width - a suggested approach - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52785
New Forum Posts: Tiki Community Site Design and Layout - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52784
New Forum Posts: nextinfo.tiki.org - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52786
New Forum Posts: Tiki 13: making sure the wysiwyg edit screen is full width - a suggested approach - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52785
New Forum Posts: Tiki Community Site Design and Layout - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52784 fabricius: joined #tikiwiki
rehi nelsonko: joined #tikiwiki Tiki|bot: New Forum Posts: Tiki 13 - Layout inconsistency - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52787 Tiki-KGB: 03nkoth r52034 10branches/13.x/tiki-index.php
[fp/r51741][FIX] If url_anonymous_page_not_found is set and prefixalias feature is in use, prefixalias does not work for anonymous.
03nkoth r52035 10branches/13.x/tiki-error_simple.php * [REVERT] Revert r48140 as it caused infinite redirect loop
03nkoth r52036 10branches/13.x/tiki-index.php * [FIX] If url_anonymous_page_not_found is set, aliases don't work for anonymous Telesight: joined #tikiwiki Tiki-KGB: 03nkoth r52037 10branches/12.x/tiki-index.php
[bp/r52036][FIX] If url_anonymous_page_not_found is set, aliases don't work for anonymous
03nkoth r52038 10branches/12.x/tiki-error_simple.php * [bp/r48140][REVERT] Revert r48140 as it caused infinite redirect loop nelsonko: left #tikiwiki