[00:07]  diggy joined #tikiwiki
[01:45]  fabricius joined #tikiwiki
[05:15]  lindonb left #tikiwiki
[11:48]  fabricius joined #tikiwiki
[12:24] Tiki-KGB 03chibaguy r52219 10branches/13.x/ 10styles/fivealive/options/kiwi/less/bootstrap-variables.less 10styles/fivealive/options/orange.css 10styles/fivealive/options/orange/less/bootstrap-variables.less 10styles/fivealive/options/kiwi.css
[12:24] Tiki-KGB [FIX} Adjust navbar-inverse background to match the custom color used at Tiki project sites, so the  Social networking layout will have it by default. Todo: the other options.
[12:26] Tiki-KGB 03chibaguy r52220 10branches/13.x/ 10(20 files in 3 dirs)
[12:26] Tiki-KGB [FIX} Add the "please choose a theme option" message to the Social network layout also.
[12:30]  redflo joined #tikiwiki
[14:09]  Caarrie joined #tikiwiki
[14:12]  luciash_ joined #tikiwiki
[14:28]  dabright joined #tikiwiki
[15:39]  jupdyke joined #tikiwiki
[16:10]  nelsonko joined #tikiwiki
[16:22] Tiki-KGB 03chibaguy r52221 10branches/13.x/ 10(14 files in 8 dirs)
[16:22] Tiki-KGB [FIX} Adjust navbar-inverse background similar to the change at Tiki project sites, so the  Social networking layout will have it by default.
[16:32]  fabricius joined #tikiwiki
[16:38] Tiki-KGB 03luciash r52222 10branches/13.x/templates/mail/user_watch_comment_subject.tpl * [FIX] removing the backslashes as they appear in the subject line
[16:41]  nelsonko_ joined #tikiwiki
[16:46] Tiki-KGB 03chibaguy r52223 10branches/13.x/ 10styles/fivealive-lite.css 10styles/fivealive-lite/tiki-selectors.less
[16:46] Tiki-KGB [FIX} Improve vertical spacing in the page-top navbar-inverse in the  Social networking layout.
[17:36]  jonnyb joined #tikiwiki
[17:37] nelsonko polom jonnyb
[17:37] jonnyb 13.polom
[17:38] nelsonko just looking at what final pre-release things need to be done tiki 13
[17:38] jonnyb indeed - just waiting for dev to respond (slow?)
[17:39] jonnyb Execution time: 40.69 secs - huh?
[17:39] nelsonko intermittent
[17:40] jonnyb second time on http://dev.tiki.org/tiki13 was only 11 ("only")
[17:40] jonnyb probably all those stinky trackerlists on there (should be unified {lists}s these days really)
[17:41] jonnyb http://dev.tiki.org/item5355 looks important
[17:41] jonnyb i've seen those stretched images on various pages
[17:42] * jonnyb reviews http://sourceforge.net/p/tikiwiki/code/52064/
[17:47] nelsonko is this problem https://dev.tiki.org/item4868 resolved was it due to the change in local avatar filenames?
[17:48] jonnyb i don't think so - my tiki.org one has been lost a few times
[17:48] nelsonko does it affect doc/dev?
[17:49] jonnyb well they're on intertiki aren;t they - shouldn't they get the one from tiki.org?
[17:49] jonnyb i just checked, i don't have one again on tiki.org :(
[17:50] jonnyb we'd need to check the file system to see what happened to them, but i see on my localhost i don't have one, so will investigate
[17:52] jonnyb maybe they just got removed in a cache flush? they're stored in temp/public these days, aren't they?
[17:53] nelsonko I just uploaded an avatar to dev it's ok
[17:53] nelsonko I'm going to try on tiki.org
[17:53]  Jyhem_laptop joined #tikiwiki
[17:54] nelsonko o rmaybe I don't understand thebug
[17:55] nelsonko they are stored in temp/public
[17:56] nelsonko anyway it's not a blocker, we can move on
[17:57] jonnyb on my local the img tag looks right but it just doesn't show up in user prefs - checking further
[17:57] jonnyb i think the img plugin stretching thing needs fixing
[17:58] nelsonko reading ing plugin stretching thing
[17:58] jonnyb but unfortunately the file needs to be opened to check the proportions, and that's what was causing the initial WSoD bug that you fixed
[17:59] jonnyb so maybe a bit more testing if it's a local file would do the trick - it's mostly for local images i think... (maybe)
[17:59] jonnyb hi Jyhem_laptop
[17:59] nelsonko apparently it's caused by my recent fix
[17:59] nelsonko according to the bug
[18:04] nelsonko jonnyb: are you in there right now?
[18:04] jonnyb no, i'm looking at the avatar thing
[18:05] jonnyb i think it should have been sorted for 12.x at some point...
[18:05] nelsonko ok I will try and see if I can fix the image size thing, I think I might have mis taken into account one possibility
[18:05] jonnyb but on my local 12.x i get WSoD on tiki-user_preferences.php
[18:06] nelsonko the other day I got a wso on tiki-user_preferences.php and it was due to timezone in php5
[18:06] jonnyb ew, it dies on TikiDate::getTimeZoneList
[18:06] nelsonko I thought I fixed on 52207
[18:06] jonnyb yes, i saw your fix, mybe i'm not up to date...
[18:07] jonnyb (hopefully)
[18:08] jonnyb yay, your fix fixes it :)
[18:12] Tiki|bot Recent Bug:  - http://dev.tiki.org/item5400
[18:16] nelsonko jonnyb: problem is that if image sour ce is set to display851, it takes it as a remote image, and does not do resizing
[18:17] nelsonko the thing is that I think the the width/height 1/1 ratio is wrong
[18:18] jonnyb but if the width is set and different to that of the image, and if it doesn't open the image file it can't know what the height is, can it?
[18:21] nelsonko right, I suppose that's why it's set to same as width if height is not set
[18:21]  Telesight joined #tikiwiki
[18:21] nelsonko one solution is to open the images if the src is relative
[18:21] jonnyb i found the avatar problem (line deleted) but now wrestling with mismatched tags on tiki-user_preferences.tpl
[18:22] jonnyb that's what i was thinking - check if relative +1
[18:22] jonnyb should fix most of them
[18:22] jonnyb any that use only width on remote images should be changed to use both width and height (another thing for the release notes) imho
[18:23] nelsonko right ok
[18:32] Tiki-KGB 03nkoth r52224 10branches/13.x/lib/wiki-plugins/wikiplugin_img.php
[18:32] Tiki-KGB [FIX]12.x & 13.x: Images stretched & skewed (in *.t.o sites and LTS production sites on svn)
[18:34] Tiki-KGB 03nkoth r52225 10branches/12.x/lib/wiki-plugins/wikiplugin_img.php
[18:34] Tiki-KGB [bp/r52224][FIX]12.x & 13.x: Images stretched & skewed (in *.t.o sites and LTS production sites on svn)
[18:38] Jyhem hi jonnyb :)
[18:40] jonnyb hi Jyhem
[18:41] * Jyhem found unified-search issue in Tiki12 :-(
[18:43] nelsonko hi Jyhem, what's the issue?
[18:46] Jyhem Well, some user mass-imports a bunch of tracker items. Works fine. Now the indexing queue in Admin → Admin Home → Search → Index maintenance shows  Queue size: 592
[18:46] Jyhem Still all correct
[18:47] Jyhem Now someone edits a page (any page) and saves → Blam! «Fatal error: Maximum execution time of 90 seconds exceeded in /data/root_www/promusa.alsawiki.com/20140801_www.promusa.org/vendor/bombayworks/zendframework1/library/Zend/Search/Lucene/Search/QueryLexer.php on line 348»
[18:47] Jyhem Yet, the page is correctly saved.
[18:47] Jyhem despite the WSOD
[18:48] Jyhem Looks like upon page saving Tiki forgets that it should only unqueue 10 items at a time
[18:49] Jyhem Of course, upping the Maximum execution time only ensures that the error takes a longer time to show up
[18:50] Jyhem Current workaround: tell customers to go  check that the queue is "0" and otherwise process it.
[18:51] Jyhem A workaround which has the easily fixable usability issue that when the queue is empty, it does not say so :-(
[18:51] * Jyhem starts with the low-hanging fruit :-)
[18:52] Tiki|bot Recent Bug:  - http://dev.tiki.org/item5401
[18:56]  Telesight1 joined #tikiwiki
[18:59] nelsonko Jyhem, shouldn't the index process the queue after mass import completes?
[18:59] nelsonko jonnyb: I
[18:59] nelsonko am taking a short lunch break. What's your take on the remaining items on https://dev.tiki.org/Tiki13ReleaseProcess?
[19:00] jonnyb i tihnk i've fixed the prefs page - was really unwell
[19:00] jonnyb reading that page now...
[19:01] jonnyb i can check the JSLint thing, but will be more careful fixing stuff as i messed up something on 12.0
[19:01] jonnyb not sure about the others: "grep external links" and "Remove any out of sync English strings"
[19:02] nelsonko Jyhem, you did Remove any out of sync English strings when tiki 12.2 released right?
[19:03] nelsonko (I mean 12.1). is it easy?
[19:03] Jyhem I definitely spent a bunch of evenings on that, yes
[19:04] Jyhem 50% is very easy, then difficulty goes upwards to a half-dozen I prefered to leave untouched
[19:05] nelsonko Jyhem, ok so should do that before 13.0 right?
[19:06] Tiki-KGB 03jonnybradley r52226 10branches/13.x/templates/tiki-user_preferences.tpl
[19:06] Tiki-KGB [FIX] user prefs: Restore missing avatar image. Also numerous other html fixes - including: duplicate class attribute, extra rogue opening table tag, missing closing form tag and duplicate language id (presumably a bootstrappification casualties)
[19:06] nelsonko and jonnyb: the purpose of Check index.php is to prevent directory browsing
[19:07] jonnyb yup
[19:07] jonnyb presumably has to be a manual search
[19:07] nelsonko Do we have a script for that? Tiki has been refactored quite a bit and there are new directories that must not have index.php now
[19:07] jonnyb i'm not aware of one
[19:08] jonnyb i guess it would be possible with "find" somehow... or grep or something
[19:08] nelsonko the vendor folder does not matter does it?
[19:08] nelsonko (after all we don't have control over that)
[19:08] jonnyb hmmm, true
[19:08] jonnyb no idea
[19:08] jonnyb the web server should be set up properly really
[19:09] jonnyb i don't feel it's a blocker imho (considering)
[19:10] jonnyb i also need to take a break now (feeding cats ;) ) be back soon
[19:10] nelsonko I feel this is a question more for the sysadmin folks...
[19:10] nelsonko (the index.php thing)
[19:10] jonnyb i'd tend to agree - not a coding thing
[19:10] jonnyb unless we need a script writing
[19:23] nelsonko jonnyb: this works I think:  find . -not -path \*\.svn\* -not -path \*vendor\* -type d -exec ls {}/index.php \; | grep "No such file"
[19:31] nelsonko looks like this hasn't been done for a while
[19:33] * Jyhem wonders about all these efforts trying to hide the content of directoriesof *open-source* software... IMO The only unpublished content we should spend time hiding it Tiki-generated content in caches and file gals stores and image stores
[19:37] Jyhem If some of these files should not be accessed, then index.php is useless.
[19:40] nelsonko yes those folders are importnat
[19:42] nelsonko for the open source parts, even if your server is configured to allow directory browsing (really unlikely as I think tiki does not work without a setting to route.php anymore right?) it's really quite pointless as a bot won't typically traverse down there unless you have links anyway (so it does not even has  anti-bot purpose)
[19:42]  fabricius joined #tikiwiki
[19:50] nelsonko Jyhem: since you have "Remove any out of sync English strings" when e released 12.1 there should be nothing if any to do for tiki 13 right? How can I verify quickly?
[19:51] Jyhem My point was, if there is a security issue on a file, the bot will point to the file directly, since we publish the software and so do the third party projects. So preventing directory browsing mainly annoys the incompetent and us, when we trouble shoot
[19:52] Jyhem will look. Waiting for a svn up in trunk. Quite impressive
[19:55] Jyhem grep -v '^//' lang/en/language.php
[19:56] Jyhem In Tiki13, 3 remaining strings I did not dare change
[19:57] Jyhem one is "faq" => "FAQ", on the off-chance "faq" shows up in the database. I do not search-replace strings in the database :-)
[19:57] nelsonko same with e-mail?
[19:57] Jyhem the other two because double-quotes mess my scripts :-(
[19:58] nelsonko so should the other 2 be done?
[19:59] Jyhem Go ahead :-)
[19:59] Jyhem what email ?
[19:59] nelsonko the second one: send it via e-mail, Twitter, Facebook,
[19:59] nelsonko vs send it via email, Twitter, Facebook,
[20:00] nelsonko Jyhem: so once I replaced the texts, do I just comment out the translation (or is that needed?)
[20:01] Jyhem No, I did not do it because my scripts do not search-replace this in all language files
[20:02] Jyhem once you replace in Tiki files (source and templates), you look up the language files which have a translation for theold string, and you make that translation the stranslation of the new string. Since they mean the same thing
[20:03] Jyhem Then you can delete the line in lang/en/language.php
[20:03] Jyhem Sorry, 8pm here, I need a break
[20:17]  diggy joined #tikiwiki
[20:18]  diggy joined #tikiwiki
[20:19]  diggy joined #tikiwiki
[20:29]  diggy joined #tikiwiki
[20:32] Tiki-KGB 03jyhem r52227 10branches/13.x/templates/admin/include_search.tpl * [FIX] Usability fix: empty queue is useful info to display
[20:32] Jyhem Hmm, templates/admin/include_search.tpl is totally out of sync in trunk and in Tiki12. This "commit in trunk for backports in Tiki12" is getting weird
[20:33] jonnyb huh? isn't it commit in 13.x for 12.x backports? (once 13.0 is released)
[20:36] Tiki-KGB 03jyhem r52228 10branches/12.x/templates/admin/include_search.tpl * [FIX][bp/r52227] Usability fix: empty queue is useful info to display
[20:36] Jyhem Stable LTS	branches/12.x	Bug and regression fixes, as well as minor and safe enhancements only. Backport from trunk.
[20:36] Jyhem From https://dev.tiki.org/Where+to+commit
[20:37] Jyhem But yes, in this case, it was unworkable since there seems to be no more queueing info in trunk, so I did from 13.x
[20:38] jonnyb ew, weird (and bad)
[20:38] * jonnyb is actually in a meeting and should concentrate on that :)
[20:38] Jyhem Can I reformat this template in trunk ?
[20:39] * Jyhem is actually wrapping up loose ends trying to call it a day :-/
[20:39] jonnyb if you can deal with the conflicts from merging ;)
[20:39] Jyhem merging in 13?
[20:40] Jyhem sure
[20:52] Tiki-KGB 03jyhem r52229 10trunk/templates/admin/include_search.tpl * [MOD] Style fixing
[20:56] Tiki-KGB 03jyhem r52230 10branches/13.x/templates/admin/include_search.tpl * [MOD][bp/r52229] Style fixing
[21:22] Tiki-KGB 03nkoth r52231 10branches/13.x/ 10(7 files in 7 dirs) * [REL]Remove any out of sync English strings
[21:32] Tiki-KGB 03nkoth r52232 10branches/13.x/ 10(8 files in 8 dirs) * [REL]Remove any out of sync English strings
[22:02] Tiki-KGB 03jyhem r52233 10branches/13.x/templates/admin/include_search.tpl * [MOD] Fixing r52230 style fixing, oops
[22:11]  SkiNut joined #tikiwiki
[22:40] Tiki-KGB 03nkoth r52234 10branches/13.x/ 04templates/tiki-gmap_usermap.tpl 04tiki-gmap_usermap.php 04templates/admin/include_gmap.tpl 10lib/prefs/feature.php * [KIL] Traces of removed google maps feature
[23:18]  SkiNut joined #tikiwiki