| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| diggy | joined #tikiwiki | [00:07] |
| .................... (idle for 1h38mn) | ||
| fabricius | joined #tikiwiki | [01:45] |
| ........................................... (idle for 3h30mn) | ||
| lindonb | left #tikiwiki | [05:15] |
| ............................................................................... (idle for 6h33mn) | ||
| fabricius | joined #tikiwiki | [11:48] |
| ........ (idle for 36mn) | ||
| Tiki-KGB | 03chibaguy r52219 10branches/13.x/ 10styles/fivealive/options/kiwi/less/bootstrap-variables.less 10styles/fivealive/options/orange.css 10styles/fivealive/options/orange/less/bootstrap-variables.less 10styles/fivealive/options/kiwi.css
[FIX} Adjust navbar-inverse background to match the custom color used at Tiki project sites, so the Social networking layout will have it by default. Todo: the other options. 03chibaguy r52220 10branches/13.x/ 10(20 files in 3 dirs) [FIX} Add the "please choose a theme option" message to the Social network layout also. | [12:24] |
| redflo | joined #tikiwiki | [12:30] |
| .................... (idle for 1h39mn) | ||
| Caarrie | joined #tikiwiki | [14:09] |
| luciash_ | joined #tikiwiki | [14:12] |
| .... (idle for 16mn) | ||
| dabright | joined #tikiwiki | [14:28] |
| ............... (idle for 1h11mn) | ||
| jupdyke | joined #tikiwiki | [15:39] |
| ....... (idle for 31mn) | ||
| nelsonko | joined #tikiwiki | [16:10] |
| Tiki-KGB | 03chibaguy r52221 10branches/13.x/ 10(14 files in 8 dirs)
[FIX} Adjust navbar-inverse background similar to the change at Tiki project sites, so the Social networking layout will have it by default. | [16:22] |
| fabricius | joined #tikiwiki | [16:32] |
| Tiki-KGB | 03luciash r52222 10branches/13.x/templates/mail/user_watch_comment_subject.tpl * [FIX] removing the backslashes as they appear in the subject line | [16:38] |
| nelsonko_ | joined #tikiwiki | [16:41] |
| Tiki-KGB | 03chibaguy r52223 10branches/13.x/ 10styles/fivealive-lite.css 10styles/fivealive-lite/tiki-selectors.less
[FIX} Improve vertical spacing in the page-top navbar-inverse in the Social networking layout. | [16:46] |
| ........... (idle for 50mn) | ||
| jonnyb | joined #tikiwiki | [17:36] |
| nelsonko | polom jonnyb | [17:37] |
| jonnyb | 13.polom | [17:37] |
| nelsonko | just looking at what final pre-release things need to be done tiki 13 | [17:38] |
| jonnyb | indeed - just waiting for dev to respond (slow?)
Execution time: 40.69 secs - huh? | [17:38] |
| nelsonko | intermittent | [17:39] |
| jonnyb | second time on http://dev.tiki.org/tiki13 was only 11 ("only")
probably all those stinky trackerlists on there (should be unified {lists}s these days really) http://dev.tiki.org/item5355 looks important i've seen those stretched images on various pages jonnyb reviews http://sourceforge.net/p/tikiwiki/code/52064/ | [17:40] |
| nelsonko | is this problem https://dev.tiki.org/item4868 resolved was it due to the change in local avatar filenames? | [17:47] |
| jonnyb | i don't think so - my tiki.org one has been lost a few times | [17:48] |
| nelsonko | does it affect doc/dev? | [17:48] |
| jonnyb | well they're on intertiki aren;t they - shouldn't they get the one from tiki.org?
i just checked, i don't have one again on tiki.org :( we'd need to check the file system to see what happened to them, but i see on my localhost i don't have one, so will investigate maybe they just got removed in a cache flush? they're stored in temp/public these days, aren't they? | [17:49] |
| nelsonko | I just uploaded an avatar to dev it's ok
I'm going to try on tiki.org | [17:53] |
| Jyhem_laptop | joined #tikiwiki | [17:53] |
| nelsonko | o rmaybe I don't understand thebug
they are stored in temp/public anyway it's not a blocker, we can move on | [17:54] |
| jonnyb | on my local the img tag looks right but it just doesn't show up in user prefs - checking further
i think the img plugin stretching thing needs fixing | [17:57] |
| nelsonko | reading ing plugin stretching thing | [17:58] |
| jonnyb | but unfortunately the file needs to be opened to check the proportions, and that's what was causing the initial WSoD bug that you fixed
so maybe a bit more testing if it's a local file would do the trick - it's mostly for local images i think... (maybe) hi Jyhem_laptop | [17:58] |
| nelsonko | apparently it's caused by my recent fix
according to the bug | [17:59] |
| jonnyb: are you in there right now? | [18:04] | |
| jonnyb | no, i'm looking at the avatar thing
i think it should have been sorted for 12.x at some point... | [18:04] |
| nelsonko | ok I will try and see if I can fix the image size thing, I think I might have mis taken into account one possibility | [18:05] |
| jonnyb | but on my local 12.x i get WSoD on tiki-user_preferences.php | [18:05] |
| nelsonko | the other day I got a wso on tiki-user_preferences.php and it was due to timezone in php5 | [18:06] |
| jonnyb | ew, it dies on TikiDate::getTimeZoneList | [18:06] |
| nelsonko | I thought I fixed on 52207 | [18:06] |
| jonnyb | yes, i saw your fix, mybe i'm not up to date...
(hopefully) yay, your fix fixes it :) | [18:06] |
| Tiki|bot | Recent Bug: - http://dev.tiki.org/item5400 | [18:12] |
| nelsonko | jonnyb: problem is that if image sour ce is set to display851, it takes it as a remote image, and does not do resizing
the thing is that I think the the width/height 1/1 ratio is wrong | [18:16] |
| jonnyb | but if the width is set and different to that of the image, and if it doesn't open the image file it can't know what the height is, can it? | [18:18] |
| nelsonko | right, I suppose that's why it's set to same as width if height is not set | [18:21] |
| Telesight | joined #tikiwiki | [18:21] |
| nelsonko | one solution is to open the images if the src is relative | [18:21] |
| jonnyb | i found the avatar problem (line deleted) but now wrestling with mismatched tags on tiki-user_preferences.tpl
that's what i was thinking - check if relative +1 should fix most of them any that use only width on remote images should be changed to use both width and height (another thing for the release notes) imho | [18:21] |
| nelsonko | right ok | [18:23] |
| Tiki-KGB | 03nkoth r52224 10branches/13.x/lib/wiki-plugins/wikiplugin_img.php
[FIX]12.x & 13.x: Images stretched & skewed (in *.t.o sites and LTS production sites on svn) 03nkoth r52225 10branches/12.x/lib/wiki-plugins/wikiplugin_img.php [bp/r52224][FIX]12.x & 13.x: Images stretched & skewed (in *.t.o sites and LTS production sites on svn) | [18:32] |
| Jyhem | hi jonnyb :) | [18:38] |
| jonnyb | hi Jyhem | [18:40] |
| Jyhem | Jyhem found unified-search issue in Tiki12 :-( | [18:41] |
| nelsonko | hi Jyhem, what's the issue? | [18:43] |
| Jyhem | Well, some user mass-imports a bunch of tracker items. Works fine. Now the indexing queue in Admin → Admin Home → Search → Index maintenance shows Queue size: 592
Still all correct Now someone edits a page (any page) and saves → Blam! «Fatal error: Maximum execution time of 90 seconds exceeded in /data/root_www/promusa.alsawiki.com/20140801_www.promusa.org/vendor/bombayworks/zendframework1/library/Zend/Search/Lucene/Search/QueryLexer.php on line 348» Yet, the page is correctly saved. despite the WSOD Looks like upon page saving Tiki forgets that it should only unqueue 10 items at a time Of course, upping the Maximum execution time only ensures that the error takes a longer time to show up Current workaround: tell customers to go check that the queue is "0" and otherwise process it. A workaround which has the easily fixable usability issue that when the queue is empty, it does not say so :-( Jyhem starts with the low-hanging fruit :-) | [18:46] |
| Tiki|bot | Recent Bug: - http://dev.tiki.org/item5401 | [18:52] |
| Telesight1 | joined #tikiwiki | [18:56] |
| nelsonko | Jyhem, shouldn't the index process the queue after mass import completes?
jonnyb: I am taking a short lunch break. What's your take on the remaining items on https://dev.tiki.org/Tiki13ReleaseProcess? | [18:59] |
| jonnyb | i tihnk i've fixed the prefs page - was really unwell
reading that page now... i can check the JSLint thing, but will be more careful fixing stuff as i messed up something on 12.0 not sure about the others: "grep external links" and "Remove any out of sync English strings" | [19:00] |
| nelsonko | Jyhem, you did Remove any out of sync English strings when tiki 12.2 released right?
(I mean 12.1). is it easy? | [19:02] |
| Jyhem | I definitely spent a bunch of evenings on that, yes
50% is very easy, then difficulty goes upwards to a half-dozen I prefered to leave untouched | [19:03] |
| nelsonko | Jyhem, ok so should do that before 13.0 right? | [19:05] |
| Tiki-KGB | 03jonnybradley r52226 10branches/13.x/templates/tiki-user_preferences.tpl
[FIX] user prefs: Restore missing avatar image. Also numerous other html fixes - including: duplicate class attribute, extra rogue opening table tag, missing closing form tag and duplicate language id (presumably a bootstrappification casualties) | [19:06] |
| nelsonko | and jonnyb: the purpose of Check index.php is to prevent directory browsing | [19:06] |
| jonnyb | yup
presumably has to be a manual search | [19:07] |
| nelsonko | Do we have a script for that? Tiki has been refactored quite a bit and there are new directories that must not have index.php now | [19:07] |
| jonnyb | i'm not aware of one
i guess it would be possible with "find" somehow... or grep or something | [19:07] |
| nelsonko | the vendor folder does not matter does it?
(after all we don't have control over that) | [19:08] |
| jonnyb | hmmm, true
no idea the web server should be set up properly really i don't feel it's a blocker imho (considering) i also need to take a break now (feeding cats ;) ) be back soon | [19:08] |
| nelsonko | I feel this is a question more for the sysadmin folks...
(the index.php thing) | [19:10] |
| jonnyb | i'd tend to agree - not a coding thing
unless we need a script writing | [19:10] |
| nelsonko | jonnyb: this works I think: find . -not -path *.svn* -not -path *vendor* -type d -exec ls {}/index.php ; | grep "No such file" | [19:23] |
| looks like this hasn't been done for a while | [19:31] | |
| Jyhem | Jyhem wonders about all these efforts trying to hide the content of directoriesof *open-source* software... IMO The only unpublished content we should spend time hiding it Tiki-generated content in caches and file gals stores and image stores
If some of these files should not be accessed, then index.php is useless. | [19:33] |
| nelsonko | yes those folders are importnat
for the open source parts, even if your server is configured to allow directory browsing (really unlikely as I think tiki does not work without a setting to route.php anymore right?) it's really quite pointless as a bot won't typically traverse down there unless you have links anyway (so it does not even has anti-bot purpose) | [19:40] |
| fabricius | joined #tikiwiki | [19:42] |
| nelsonko | Jyhem: since you have "Remove any out of sync English strings" when e released 12.1 there should be nothing if any to do for tiki 13 right? How can I verify quickly? | [19:50] |
| Jyhem | My point was, if there is a security issue on a file, the bot will point to the file directly, since we publish the software and so do the third party projects. So preventing directory browsing mainly annoys the incompetent and us, when we trouble shoot
will look. Waiting for a svn up in trunk. Quite impressive grep -v '^//' lang/en/language.php In Tiki13, 3 remaining strings I did not dare change one is "faq" => "FAQ", on the off-chance "faq" shows up in the database. I do not search-replace strings in the database :-) | [19:51] |
| nelsonko | same with e-mail? | [19:57] |
| Jyhem | the other two because double-quotes mess my scripts :-( | [19:57] |
| nelsonko | so should the other 2 be done? | [19:58] |
| Jyhem | Go ahead :-)
what email ? | [19:59] |
| nelsonko | the second one: send it via e-mail, Twitter, Facebook,
vs send it via email, Twitter, Facebook, Jyhem: so once I replaced the texts, do I just comment out the translation (or is that needed?) | [19:59] |
| Jyhem | No, I did not do it because my scripts do not search-replace this in all language files
once you replace in Tiki files (source and templates), you look up the language files which have a translation for theold string, and you make that translation the stranslation of the new string. Since they mean the same thing Then you can delete the line in lang/en/language.php Sorry, 8pm here, I need a break | [20:01] |
| diggy | joined #tikiwiki
joined #tikiwiki joined #tikiwiki | [20:17] |
| joined #tikiwiki | [20:29] | |
| Tiki-KGB | 03jyhem r52227 10branches/13.x/templates/admin/include_search.tpl * [FIX] Usability fix: empty queue is useful info to display | [20:32] |
| Jyhem | Hmm, templates/admin/include_search.tpl is totally out of sync in trunk and in Tiki12. This "commit in trunk for backports in Tiki12" is getting weird | [20:32] |
| jonnyb | huh? isn't it commit in 13.x for 12.x backports? (once 13.0 is released) | [20:33] |
| Tiki-KGB | 03jyhem r52228 10branches/12.x/templates/admin/include_search.tpl * [FIX][bp/r52227] Usability fix: empty queue is useful info to display | [20:36] |
| Jyhem | Stable LTS branches/12.x Bug and regression fixes, as well as minor and safe enhancements only. Backport from trunk.
From https://dev.tiki.org/Where+to+commit But yes, in this case, it was unworkable since there seems to be no more queueing info in trunk, so I did from 13.x | [20:36] |
| jonnyb | ew, weird (and bad)
jonnyb is actually in a meeting and should concentrate on that :) | [20:38] |
| Jyhem | Can I reformat this template in trunk ?
Jyhem is actually wrapping up loose ends trying to call it a day :-/ | [20:38] |
| jonnyb | if you can deal with the conflicts from merging ;) | [20:39] |
| Jyhem | merging in 13?
sure | [20:39] |
| Tiki-KGB | 03jyhem r52229 10trunk/templates/admin/include_search.tpl * [MOD] Style fixing
03jyhem r52230 10branches/13.x/templates/admin/include_search.tpl * [MOD][bp/r52229] Style fixing | [20:52] |
| ...... (idle for 26mn) | ||
| 03nkoth r52231 10branches/13.x/ 10(7 files in 7 dirs) * [REL]Remove any out of sync English strings | [21:22] | |
| 03nkoth r52232 10branches/13.x/ 10(8 files in 8 dirs) * [REL]Remove any out of sync English strings | [21:32] | |
| ....... (idle for 30mn) | ||
| 03jyhem r52233 10branches/13.x/templates/admin/include_search.tpl * [MOD] Fixing r52230 style fixing, oops | [22:02] | |
| SkiNut | joined #tikiwiki | [22:11] |
| ...... (idle for 29mn) | ||
| Tiki-KGB | 03nkoth r52234 10branches/13.x/ 04templates/tiki-gmap_usermap.tpl 04tiki-gmap_usermap.php 04templates/admin/include_gmap.tpl 10lib/prefs/feature.php * [KIL] Traces of removed google maps feature | [22:40] |
| ........ (idle for 38mn) | ||
| SkiNut | joined #tikiwiki | [23:18] |
| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |