dabright: joined #tikiwiki
joined #tikiwiki
joined #tikiwiki fabricius: joined #tikiwiki Tiki|bot: New Forum Posts: Tracker field with different units of measure - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52945 SkiNut: joined #tikiwiki TomJarvis: joined #tikiwiki nelsonko: left #tikiwiki diggy: joined #tikiwiki Jyhem_laptop: joined #tikiwiki redflo: joined #tikiwiki Tiki-KGB: 03manivannans r52235 10branches/13.x/lib/smarty_tiki/modifier.avatarize.php * [FIX] Default avatar image for new user Tiki|bot: Recent Bug: - http://dev.tiki.org/item5403 Tiki-KGB: 03manivannans r52236 10branches/12.x/lib/smarty_tiki/modifier.avatarize.php * [bp/r52235][FIX] Default avatar image for new user Tiki|bot: Recent Bug: - http://dev.tiki.org/item5404 pianoliv: joined #tikiwiki
Hi all
how to get svn commit access for a quick fixes on templates? (or should I ask someone to review and commit?) Tiki|bot: New Forum Posts: caching menu structure - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52948 fabricius: joined #tikiwiki Tiki|bot: New Forum Posts: caching menu structure - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52948
New Forum Posts: Tracker field with different units of measure - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52945
New Forum Posts: Username Pattern - Esperanto Characters (or anything else) - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52934 panamaus: joined #tikiwiki Tiki|bot: New Forum Posts: caching menu structure - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52948
New Forum Posts: Tracker field with different units of measure - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52945
New Forum Posts: Username Pattern - Esperanto Characters (or anything else) - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52934 olinuxx: joined #tikiwiki Jyhem_laptop: joined #tikiwiki jonnyb: joined #tikiwiki
polom polom nelsonko: joined #tikiwiki
hi jonnyb: good morening jonnyb: hi nelsonko nelsonko: I was just looking at Mani's commit regarding the avatarize- he did not know were so close to release jonnyb: yes, i saw that - it is sort of a fix nelsonko: It is an attempt to fix something but I think it is doing more than it should at the moment jonnyb: but i was thinking it would have been better in a library somewhere
does it work? nelsonko: yes but I am worried about the dl part
does dl urls work without sefurl? jonnyb: nope
so that bit should be a call to the sefurl function for sure nelsonko: the other thing is he also "back ported" part from trunk
the $default = '' bit jonnyb: i've not seen that user_default_picture_id pref before, is it s new one? nelsonko: I added it 2011-08-25 jonnyb: yes, doesn't look great - it should all be in TikiLib::get_user_avatar anyway, shouldn't it? nelsonko: right, that makes more sense, but that means the noavatar.png functionality needs to move there also
a bigger fix
I suppose it can wait
I mean, he can roll back this and then after the release we can fix it cleanly
or he could just fix the sefurl part and leave it for now jonnyb: hmm, let me look at it again nelsonko - but as it's not really a 13.0 blocker at all rolling back, fixing better in trunk then re-backporting would be ideal imho
the user_default_picture_id pref bit should really be picked up in get_user_avatar too nelsonko: ok, I told him to rollback jonnyb: maybe we can take the opportunity to get rid of the "bad" avatar methods we're still carrying? nelsonko: yes let's do that, but in trunk like you said jonnyb: for instance, why to we still allow users_serve_avatar_static to be disabled? can't see the advantage in that...
anyway, not a 13.0 thing - i'm doing the JSLint thing now Tiki-KGB: 03jonnybradley r52237 10branches/13.x/lib/language/js/interactive_translation.js * [FIX] JSLint: Missing )
03manivannans r52238 10branches/13.x/lib/smarty_tiki/modifier.avatarize.php * [REVERT]Revert r52235 Default avatar image for new user nelsonko: thanks jonnyb jonnyb: ok, have done the safe JSLint things (thing) - odd regression in interactive_translation.js somehow...
will update the todo page... Tiki-KGB: 03manivannans r52239 10branches/12.x/lib/smarty_tiki/modifier.avatarize.php * Revert: [bp/r52235][FIX] Default avatar image for new user jonnyb: tee hee, found a new bug - in the insert wiki page dialog the autocomplete list of pages is cropped inside the dialog - the joy of dogfood!
nelsonko: looks like this one https://dev.tiki.org/item5341?from=Tiki13 is still an issue on dev
going to create a show instance... nelsonko: must be something on the page? jonnyb: no, i get the problem on the test page in safari
https://dev.tiki.org/test
but not on the show instance i just made
odd
maybe a weird pref somewhere but i checked the CSRF setting and it's the same, and enabled silent sessions Tiki|bot: New Forum Posts: caching menu structure - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52948
New Forum Posts: Tracker field with different units of measure - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52945
New Forum Posts: Username Pattern - Esperanto Characters (or anything else) - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52934 jonnyb: will try the same thing on doc (in fact i think i already did that a few weeks ago, but will retry) nelsonko: is it a safari only problem?
I just successfully rolled back in chrome jonnyb: hmm, Jyhem left a comment saying it was just one firefox profile, so may be nelsonko: let me try safari jonnyb: but i just rolled back a change on http://doc.tiki.org/test in safari, no error
and that's on the same server isn't it?
will try chrome also nelsonko: right, same server
I don't see any errors here
ok, so first I click History? jonnyb: hmm, no error in chrome
yup nelsonko: then I choose a ersion and click the "b"? jonnyb: yup nelsonko: and then I click the rollback button (which one? top/bottom? jonnyb: either i think
but maybe there is a difference? nelsonko: then I get "click here to confirm your action" jonnyb: yup (long winded isn't it!) nelsonko: it works fine for me both buttons jonnyb: curious
i'll try again...
well that's spooky
worked fine, both buttons again
but i had been logged out by trying in chrome, so i guess i got a new session
the last one was probably weeks old - wonder if that makes a difference nelsonko: Jyham can probably confirm if he clears the cookies off his particular firefox profile
or rather if he tries it with that profile before clearing jonnyb: i've enabled remember me on the show instance (for a year) so will try later (maybe) nelsonko: (if it works on different firefox profile, it almost is a session issue)
maybe he got a session from the "old server"
(although I'm not making sense to myself) Tiki|bot: New Forum Posts: caching menu structure - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52948
New Forum Posts: Tracker field with different units of measure - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52945
New Forum Posts: Username Pattern - Esperanto Characters (or anything else) - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=52934 jonnyb: when i had this on my local a year or two ago the session was just not working - i debugged and saw it set the values needed for the ticket check, and then when it came to read it back to verify the ticket thingy the value just wasn't there
eventually i updated php, or apache or something and it went away
assumed it was just localhost weirdness nelsonko: not sure what happens if I present a cookie issued by a different server but same domain jonnyb: well the ticket system uses the session so i don't think the cookie is relevant, as long as the session is preserved (or noT)
anyway, i suggested this (and Jyhem's other one) should be set to not be blockers imho
so i reckon that means we should be able to release 13.0 (queue the fanfares!) nelsonko: what about "Featured profiles missing for 13.x"
https://dev.tiki.org/item5384?from=Tiki13, xavi did comment that the 12.x profiles are fine in 13.
Maybe all it takes is a page change on profiles
I agree with xavi it makes no sense to simply copy them
I will do that
ok, let me queue the fanfares and announce release process is begun?
ok sent, let me start doing the release stuff Tiki|bot: New Forum Posts: 13.x Branch freeze: Tiki 13.0 release in progress - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52953 jonnyb: sorry nelsonko - window got buried (client thing cropped up) nelsonko: np jonnyb: I have started jonnyb: well done :)
so what dod you end up doing for the profiles?
dod/did nelsonko: I just changed the text on the FeaturedProfiles page on profiles.tw.o
xavi has already tested them
so we know they work in 13.x Tiki-KGB: 03nkoth r52240 10branches/13.x/lib/setup/twversion.class.php * [REL] Preparing 13.0 release
03nkoth r52241 10branches/13.x/README * [REL] Update README file for 13.0
03nkoth r52242 10branches/13.x/ 10(52 files in 52 dirs) * [REL] Update language.php files for 13.0 jonnyb: yay, go nelsonko go! Tiki-KGB: 03nkoth r52243 10branches/13.x/changelog.txt * [REL] Update changelog.txt for 13.0
03nkoth r52244 10branches/13.x/copyright.txt * [REL] Update copyright.txt for 13.0
03nkoth r52245 10branches/13.x/db/tiki-secdb_13.0_mysql.sql * [REL] SecDB for 13.0
03nkoth r52246 03tags/13.0 * [REL] Tagging release nelsonko: ok, I have tarballs
who wants to try? jonnyb: ok, can do! -: jonnyb refrains from making some off colour comment about ointment... jonnyb: brb nelsonko: http://dev.citadelrock.com/tikipack/tiki-13.0.7z
http://dev.citadelrock.com/tikipack/tiki-13.0.zip
the bz2 and gz2 are ok here jonnyb: ok, trying the zip
coo, it's big! (65MB) -: jonnyb unzips
jonnyb installs jonnyb: all looks good - upgraded a 12.x database, no errors, all seems fine
well done nelsonko nelsonko: let me try the 7z also.
I also ran the collaborative community and the corporate intranet profiles
ok, time to announce
jonnyb: nothing changes with regards semi-automatic merge until 13.1 right? jonnyb: the 7z archive unzips fine and all looks ok, btw
yes, usually we keep semi-auto merging until x.1 - not sure if we need a special case for this one though?
i guess we keep it going until it gets difficult, then release 13.1? nelsonko: jonnyb: that sounds right jonnyb: well done for carrying all this - shame there aren't more people around :( nelsonko: are we still supporting tiki6 from a security only perspective until tiki 13.1 is released?
I think that's what was intended, which means end of life announcements should go out sometime soon... jonnyb: yes indeed, about time too!
i'm doing a merge to trunk, by the way
and i'll update the version files Tiki|bot: Info: Tiki 13.0 Release - http://info.tiki.org/article228-Tiki-13-0-Release jonnyb: good announce article nelsonko, well done :)
got the balance about right i think (scary, but exciting!) nelsonko: tks Tiki|bot: New Forum Posts: Tiki 13.0 Release - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52955 Tiki-KGB: 03jonnybradley r52247 10(128 files in 88 dirs)
[MRG] Automatic merge, branches/13.x 52197 to 52245
Conflicts occurred during the merge.
lang/en/language.php (resolved using "mine-conflict")
lib/setup/twversion.class.php (resolved manually)
templates/admin/include_search.tpl (resolved by keeping trunk version, hope that was right)
03jonnybradley r52248 10trunk/doc/ 10stable.version 10unstable.version 10regular.cycle * [REL] updating version files (is this correct?) olinuxx: joined #tikiwiki jonnyb: joined #tikiwiki Jyhem: polom. templates/admin/include_search.tpl looks fine. (sorry) jonnyb: hi Jyhem - good hear hear, thanks for checking (there was a huge block of stuff in 13 not in trunk, i see what you mean about it needing a bit of TLC ;) )
good hear hear = good to hear (ay? time to stop working...)
bye all, more tomorrow Jyhem_laptop: bye jonny, thnks diggy: joined #tikiwiki Tiki-KGB: 03nkoth r52249 10trunk/templates/wiki-plugins/wikiplugin_grouplist.tpl
[MOD] Show mdash instead of nothing if group list is empty to avoid user confusion SkiNut: joined #tikiwiki