fabricius: joined #tikiwiki PrezKennedy: joined #tikiwiki
joined #tikiwiki Jyhem_: joined #tikiwiki luciash_: joined #tikiwiki Tiki-KGB: joined #tikiwiki gour: joined #tikiwiki redflo: joined #tikiwiki Tiki-KGB: 03chibaguy r52864 10trunk/themes/base_files/ 10less/tiki-wikipages_and_plugins.less 10css/tiki_base.css * [REF] Use variables for colors (tiki-wikipages_and_plugins.less)
03chibaguy r52865 10trunk/ 10(11 files in 9 dirs) * [MOD] Add icon set information. chibaguy: joined #tikiwiki
polom olinuxx: hi chibaguy chibaguy: hi olinuxx Jyhem_laptop: joined #tikiwiki gour: Jyhem_laptop: morning. in order to learn more about it, i'm doing small research and i always find that HTTP_X_FORWARDED_FOR is used for detecting reverse proxy? jonnyb: joined #tikiwiki Tiki-KGB: 03chibaguy r52866 10trunk/themes/base_files/ 10(13 files in 2 dirs) * [REF] Use variables for colors in tiki_base.css component Less files. jonnyb: pompom chibaguy: The naming scheme for themes has changed from themename.css to themename/css/tiki.css . PhpStorm seems to need a consistent pattern (per project) for naming CSS files compiled from Less files. I set it up to produce our new theme file names. So should theme options also be, for example, themename/options/optioname/css/tiki.css?
This is what will work for PhpStorm, but do people just making CSS theme option files mind if the path is like that?
Or is the inconsistency ok? (That is, jqui/options/element.css is also ok?)
Seems like the path and naming scheme should be consistent, whether the file is compiled or edited by hand.
battery running low. bbl. jonnyb: sorry chibaguy - distracted... (reading) chibaguy: ok jonnyb: sounds like one for art list email?
i think themename/options/optioname/css/tiki.css is best (consistant) chibaguy: maybe so. I'll compose it. Yes, for the consistency, I think so. I'm not really too fond of the less direct way of naming, but I guess it's no big thing.
Anyway, I'll be back later. jonnyb: also
cya gour_: joined #tikiwiki Tiki-KGB: 03jonnybradley r52867 10branches/13.x/ 10lib/core/Services/Connect/Client.php 10lib/core/Tiki/Connect/Abstract.php 10lib/core/Tiki/Connect/Client.php
[FIX] connect: Following r52314 (changing connect data encoding to json_encoding) vote handling needed changing from array to stdClass objects (oops, but ok now)
03gezzzan r52868 10trunk/ 10(5 files in 2 dirs) * [MOD] use icon set for pref shared flags
03jonnybradley r52869 10branches/13.x/lib/comments/commentslib.php * [FIX] forums: Don't parse plugin looking syntax in incoming mails
03jonnybradley r52870 10branches/13.x/ 10templates/comment-body.tpl 10lib/comments/commentslib.php * [FIX] forums: Don't show actions and icons for anonymous posters
03jonnybradley r52871 10(6 files in 5 dirs) * [MRG] Automatic merge, branches/13.x 52861 to 52870 Jyhem_laptop: polom jonnyb: pompom Jyhem_laptop -: Jyhem_laptop reads up on HTTP_X_FORWARDED_FOR reliability for reverse proxy detection Tiki-KGB: 03jonnybradley r52872 10branches/ 1012.x/templates/comment-body.tpl 1012.x 1012.x/lib/comments/commentslib.php
[bp/r52869][FIX] forums: Don't parse plugin looking syntax in incoming mails
[bp/r52870][FIX] forums: Don't show actions and icons for anonymous posters Jyhem_laptop: if HTTP_X_FORWARDED_FOR is reliably set by reverse proxies and not set when there is none, we can avoid an option gour: Jyhem_laptop: every simplification is welcome!! Jyhem_laptop: Not if it breaks production servers !
I check on other such setups I can access gour: of course...still, i'm aiming at simplification of tiki's codebase
(including content of the tiki.org site as well) Jyhem_laptop: I never have any customer complaining about the codebase. They prefer things which work :) gour: Jyhem_laptop: that's true, but i, not have tiki customers (yet), would prefer to have simpler codebase to work with...hopefully it would help you to be more productive as well ;)
am i right that tiki's codebase is not very OOP? Jyhem_laptop: I'm not paid by productivity (number of code lines), but on providing functionality -: gour thinks about time = money, in general gour: moreover, i'm considering that tiki is FLOSS which means one should consider time of those working on it, besides monetary return based on it. otherwise, i the main motivation to work on tiki today is money, then it will slowly/surely decline jonnyb: hi gour - the OOP bits are mostly in collected lib/core - it's a kind of work in progress :) gour: jonnyb: ok, so slow migration/refactoring, right? jonnyb: yes, little by little gour: cool jonnyb: tiki was started a long time ago and almost by design very non-oop, so as new stuff gets added or revamped we try and make it more organised Jyhem_laptop: gour: I'm just more motivated by improving Tiki as a usable software than improving the code just for the code's sake. Personal bias. jonnyb: (moslty) gour: Jyhem_laptop: ok...i'm not thinking about improving code for it's sake, but to prevent spaghetti which no one would like to touch in the future
Jyhem_laptop: but let's try to fix that reverse-proxy issue...there will be time to talk about aesthetics later :-) Jyhem_laptop: We also have OOP sections nobody else than the author ever touches :-( -: gour is curious about the author gour: anyone using vim for php dev?
i wonder if there is some newer script for smarty support than the one from 2007?
Jyhem_laptop: tiki-based consulting is your main business? Jyhem_laptop: I am using vim gour: Jyhem_laptop: what plugins do you use for php/smarty? Jyhem_laptop: gour: yes, but I also spend lots of time unpaid (like just now) gour: :-) Jyhem_laptop: I stopped using plugins because I don't want to waste time configuring vim evey time I'm on another server (some of which are not mine). I just cut-paste my favorite .vimrc
sometimes I instal ctags nelsonko: joined #tikiwiki
hi jonnyb ping good morning/afternoon jonnyb: hi nelsonko - how's it going? Jyhem_laptop: So, I just discussed with a guy who has a start-up providing cloud VMs (appsdeck.eu). He tells me they have HTTP_X_FORWARDED_FOR but it's not reliably configured everywhere. nelsonko: not too bad, just got back from nunavut on saturday and it was our Thanksgiving holiday weekend just past Jyhem_laptop: Meaning, you _should_ set it up but it's not in default configs so some people may not have it set :-(
hi nelsonko. Is nunavut where you go when Montreal weather is too mild ? ^^ nelsonko: Jyhem_laptop: lol, it was not my "choice" to go there, had to conduct some training gour: Jyhem_laptop: ok, i wonder whether it's more suitable than HTTP_X_FORWARDED_PROTO ? Jyhem_laptop: I'll just be extra cautious, using first HTTP_X_FORWARDED_FOR or the permission. If either is set, we'll ignore $_SERVER['SERVER_PORT'] and use defaults or what people provide
or HTTP_X_FORWARDED_PROTO is available.
You already proved that HTTP_X_FORWARDED_PROTO is totally unreliable :-(
but should be used if available -: gour nods chibaguy: joined #tikiwiki
back gour: Jyhem_laptop: i've to go afk for ~2hrs...then i hope to be able to test further if there will be something Jyhem_laptop: np chibaguy: The superfish menus look and work really nicely in the Bootswatch themes, I think. Except for a few details which need fixing.
(Bad contrast in Amelia at least, and the "down" arrows aren't displaying currently.) nelsonko: left #tikiwiki
joined #tikiwiki gour_: joined #tikiwiki Mr_Bubu78: joined #tikiwiki chibaguy: But it's disconcerting to use superfish and bootstrap menus at the same time because of their behavior difference: bootstrap top item needs a click to open the dropdown, but the superfish just needs a hover. jonnyb: chibaguy: i found an add-on library called superclick you can add that makes superfish menus show on click, maybe we should add that? chibaguy: jonnyb, yeah, maybe so. although actually I prefer the open-on-hover, it's not good to be inconsistent. jonnyb: but that's no good for touch screens, hence the general move to click or tap i guess Tiki-KGB: 03chibaguy r52873 10trunk/themes/amelia/css/tiki.css * [REF] Use variables for colors in tiki_base.css component Less files. chibaguy: right Tiki-KGB: 03chibaguy r52874 10trunk/ 10themes/base_files/less/tiki-cssmenus.less 10themes/base_files/css/tiki_base.css 10themes/amelia/less/tiki.less * [FIX] Better variable for suckerfish top menu item color. chibaguy: well, getting closer. jonnyb: bravo chibaguy ! Tiki-KGB: 03gezzzan r52875 10trunk/ 10(7 files in 2 dirs) * [MOD] icon set related changes, adding more icon definitions Jyhem_laptop: hi gour
what was your cut-paste code website again ? gour: Jyhem_laptop: url? Jyhem_laptop: yes, or name of the site for code bits sharing gour: Jyhem_laptop: tiki.sites.djangohosting.ch i pasted my patch at pastebin.com Jyhem_laptop: pastebin, thx
http://pastebin.com/fQJaz17m
Is suggested patch, with param, etc
gour: ^ gour: Jyhem_laptop: that's against 13.0? Tiki-KGB: 03gezzzan r52876 10trunk/ 10templates/trackerinput/articles.tpl 10templates/search_stored/list.tpl 10templates/tracker/edit_field.tpl * [MOD] icon set changes Jyhem_laptop: oups, no, against 12
wait a minute gour: Jyhem_laptop: ok, it does not matter. i can dl v12 Jyhem_laptop: ok -: gour thinks that amongst 17 or so top-level menu items on tiki.org, Download deserves one place :-) gour: Jyhem_laptop: 12.2, right? Jyhem_laptop: 12 svn
latest will do gour: i dl-ed 12.2...btw, that patch is not unified, right? -: Jyhem_laptop Notes that gour has a point about tiki.org, even though there is a huge "download" image
gour still uploads to the server Jyhem_laptop: I think it is unified «svn diff -x -u templates/tiki-install.tpl lib/setup/absolute_urls.php templates/admin/include_login.tpl templates/admin/include_general.tpl > patch.txt »
then again, svn diff -x --unified produces exactly the same output as svn diff gour: i'm not sure 'patch -p1 < patch' will work..let's see -: gour has slow upload :-( gour_: joined #tikiwiki Tiki|bot: Recent Bug: - http://dev.tiki.org/item5486 gour_: ahh, connection broke while i was scp-ing Tiki-KGB: 03jonnybradley r52877 10branches/13.x/lib/smarty_tiki/function.treetable.php
[FIX] treetable: Reset parent node if not setting it.
Should fix group inheritance listing errors on tiki-objectpermissions.php
Also remove redundant $id statement. gour_: Jyhem_laptop: patch to include_general.tpl failed Jyhem_laptop: just the include_general.tplfile ? gour_: Yes
the 1st three applied cleanly gour: patch unexpectedly ends in middle of line
Hunk #1 FAILED at 128. Tiki-KGB: 03jonnybradley r52878 10branches/ 1012.x 1012.x/lib/smarty_tiki/function.treetable.php
[bp/r52877][FIX] treetable: Reset parent node if not setting it.
Should fix group inheritance listing errors on tiki-objectpermissions.php
Also remove redundant $id statement.
03jonnybradley r52879 10trunk/lib/smarty_tiki/function.treetable.php 10trunk * [MRG] Automatic merge, branches/13.x 52870 to 52877 gour: let me check the patch again Jyhem_laptop: weird, there is only 1 line changed
add line {preference name=feature_port_rewriting} under line {preference name=feature_loadbalancer} gour: maybe copy&paste issue Jyhem_laptop: maybe gour: that's how it looks here: http://pastebin.com/NebFnLna
Jyhem_laptop: i'm called for a dinner by family...bbs and resume Telesight: joined #tikiwiki gour: now i see that include_login also failed Tiki|bot: New Forum Posts: IndieWeb & IndieMark - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53686
New Forum Posts: icon style - btn vs link - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53681
New Forum Posts: Gwtting the 404 error "create this page" to display? - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=53679
New Forum Posts: IndieWeb & IndieMark - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53686
New Forum Posts: icon style - btn vs link - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53681
New Forum Posts: Gwtting the 404 error "create this page" to display? - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=53679 gour_: joined #tikiwiki fabricius: joined #tikiwiki gour_: joined #tikiwiki olinuxx: joined #tikiwiki Jyhem_laptop: joined #tikiwiki gour: does http://i18n.tiki.org require another registration besides the main/dev one? fabricius: hello gour: yes Tiki|bot: New Forum Posts: IndieWeb & IndieMark - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53686
New Forum Posts: icon style - btn vs link - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53681
New Forum Posts: Gwtting the 404 error "create this page" to display? - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=53679 fabricius: gour: you need an admin access to be able to translate all strings including admin panels ... you register an d come back here or to the dev-list with your username and apply for becoming admin on i18n
usually somebody reads, login, apply and confirm in 2 to 5 minutes - very rarely nobody sees for longer or for even hours - might depend on timezones aswell
in which language you want to translate? gour: fabricius: thank you. i've found some younger member within our non-profit community who wants to help me with Croatian translation since i don't have so much time for it or, let say, i want to focus on other aspects of tiki.
fabricius: do you recommend that i register on his behalf and give him credentials, or let him do it. problem is he is not hanging here... fabricius: usually that would not be the right way, but it is between you and him - anyway, once the member uses Tiki and wants to translate, there might be situations arising, where he has questions or other occations for direct contact to the community
gour: always best to register the main sourceforge tiki-mailing-lists, register a Tiki community account and getting to use IRC at freenode.net gour: fabricius: i follow mailing lists (via gmane) and have tiki account. now i wonder about i18n... Tiki|bot: New Forum Posts: IndieWeb & IndieMark - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53686
New Forum Posts: icon style - btn vs link - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=53681
New Forum Posts: Gwtting the 404 error "create this page" to display? - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=53679 gour: isn't it possible to just register to br translator for the language and have someone else acting as 'admin'?
i expected something like transifex & co. one person is manager for the language, others are team-members only
my friend would fit into the role of team-member - firing up browser and do the work online
requiring him to follow lists, hang here etc. is too much for his nature :-) fabricius: gour: it IS possible to just register for the translation - although it would be sad (and sometimes dangerous?) to not have any contact to people who translate our software to arbitrary languages. gour: fabricius: do you have some example on your mind? i'm thinking for myself to fill that mediating role for him, if possible, since i anyway plan to get involved with tiki in general
Jyhem_laptop: got my email? fabricius: gour: the Tiki translation on i18n works this way: login as admin - click to any dialogue, string, panel, etc. - press the button "online translation" - click on any (translatable) textstring - translate - save - press the button "online translation" again to be able to move on to another part of the application
gour: the translated files will be committed to the source code on a regular base gour: fabricius: hmm, it looks a bit more user-friendly thatn just plain list of strings at e.g. transflex, launchpad etc.
fabricius: what is the difference if one register 'just for translation? fabricius: yeah gour - you see what you translate exactly in the context of the application
gour: the principle is, that a translator can translate ALL strings - ESPECIALLY the administration panels, which would be important for administrators and webmasters who do not or not well speak English gour: fabricius: if one is no admin, he can't see the context? fabricius: that is why i18n is NOT connected to the other sites via Intertiki and why every interested translator gets an admin account
gour: if one is not admin, he cannot see the admin panel and thus he cannot translate the admin panel gour: fabricius: what he can translate? fabricius: on i18n the translator always IS admin and thus always can translate everything :D gour: i see stats for Croatian - 11.62% done, how much is approx. the whole admin panel? fabricius: gour: we do not mind that a non-admin could find out, how a Tiki admin dialogue might look like and we appreciate admin-translations by average users aswell. similar to demo - on demosites you see admin dialogues aswell - nothing to hide, no secrets
I have no idea how much in % the admin panel is from the whole application strings gour: for the beginning i'm more concerned to have user-end part translated since i'm the one who will do admin work for the site(s) so we need front-end in native language, later we can complete admin panel as service for other Croatian users fabricius: but again: we do not have setup different levels of translators gour: is there possibility for offline work like with E.g. *.po files and then commit later? fabricius: once a person has admin privileges, he/she is still allowed to translate end-user parts first - no obligations what to translate first
you could translate via SVN and commit the language.php for croatian directly to the upstream - in that case the translator best asked Jonny Bradley where to commit (Tiki13 or Tiki Trunk), cause he does the semi-auto-merging
there even could be one person who commits the language.php of a given loanguage which originally was translated by several people - given the committer sorted out to merge translations himself gour: so, one can just use language.php and translate offline? that sounds good in our case. later i can, hopefully review/fix things
good fabricius: gour: do you use SVN? gour: my translator probably does not even know what is SVN...i know, but don't use it - jumped on DVCS bandwagon straight from CVS (first to darcs, today mostly on fossil and bit of git) :-)
fabricius: if i get translated language.php which gets committed, can i review/fix it online 'cause it's easier when one see strings in real context? fabricius: gour: BEFORE you commit it, you check on a local (or personal webserver) installation. So you should check it in context - for translations at least online-context-spot-check wise additionally to file-check gour: fabricius: ohh, that's great. it means i just commit translated file on my developing/testing installation? fabricius: so you make a clean "fresh" installation and then replace the croatian language file with the new version (locally) .. from there you commit to the Tiki svn upstream but make sure not to lose the translations somebody else might have committed since you checked out your translated file gour: sure...can you check from when is the oldest commit for Croatian language, iow. if there is active admin maybe? fabricius: Tell me, what is the language code for croatian? gour: hr fabricius: I do not see the time in the file
http://svn.code.sf.net/p/tikiwiki/code/branches/13.x/lang/hr/language.php
pls ask Jonny or Jyhem about where to commit - I guess 13 better than trunk, but not sure gour: fabricius: ok, considering all this discussion, it seems ok to me to apply for admin account. can i register now and inform you about my username? fabricius: sure gour: fabricius: after submit,form responded with "Search index could not be updated. The site is misconfigured. Contact an administrator." ;)
fabricius: ok, my email is validated, username 'gour'
'hr' is on the list of "Some translation string may have been lost!" fabricius: you are admin now and can translate gour: fabricius: thank you. i activated 'interactive translation'. that's the way? fabricius: yes gour ... move to somewhere, klick the tickbox top left of the browser window, translate, save gour: fabricius: strange enough, but after clicking on that icon, ff was complaining about improper redirecting of the page
after using back button, it's ok fabricius: strange - I did not have this problem - translating myself now gour: fabricius: it happened again - see http://imagebin.org/321734 fabricius: what's the link to the page that causes this message? gour: http://i18n.tiki.org/tiki-interactive_trans.php?interactive_translation_mode=on -: gour --> sleep