Tiki-KGB: [FIX] Printing a tracker item did not support the new vi_tpl parameter for setting a specific template.
wolfganga: Can anyone guide me to how i can add a new pref?
Tiki-KGB: 03walper r53711 10trunk/templates/tiki-view_tracker_item.tpl
[ENH] Removed the trackername as a title from the tracker item view. In most cases, one would like to style the view via a template (and could add there a title if needed). If however most of you feel title should stay i would of cause revert.
lindonb: joined #tikiwiki
wolfganga: joined #tikiwiki
chibaguy: joined #tikiwiki
Tiki-KGB: 03walper r53712 10trunk/ 10(8 files in 3 dirs)
[FIX] Fixed a lot of smarty notices because of undefined variables and indices in the area wiki page, tracker, trackeritems. I really suggest to remove any e_warnings and e_notices by setting defaults etc. This way the debug window only shows useful informations.
03walper r53713 10trunk/lib/core/Table/Code/Abstract.php
[FIX] Added a check to Table/Code/Abstract.php to make sure that the first param is really an array. There is still another bug when listing wiki pages:
Line: 103 File: libcoreTableCodeAbstract.php
Type: Argument 1 passed to Table_Code_Abstract::iterate() must be of the type array, string given, called in libcoreTableCodeWidgetOptionsFilter.php on line 64
wolfganga: lindonb are you there?
lindonb: yes
wolfganga: Great. there is an issue when listing wiki pages
When you have about 15+ pages, and scroll down, the header for the filter overlap
there is an error message in the php error conole
PHP (5.5.1) ERROR (E_RECOVERABLE_ERROR):
libcoreTableCodeAbstract.php
Line: 103
Type: Argument 1 passed to Table_Code_Abstract::iterate() must be of the type array, string given, called in libcoreTableCodeWidgetOptionsFilter.php on line 64
I fixed the array detection in Table_Code_Abstract::iterate()
But i do not know how to fix that one.
Btw. i cleaned up lots of template warnings, so this guys are know visible ;-)
lindonb: yes, saw that - good work
wolfganga: can you have a look into this? It seems you had some work done n Table_Code_Abstract::iterate()
I really do not know how to start to fix this? (And its really really late ...;-))
lindonb: will try to take a look - need 15+ pages to recreate?
wolfganga: You can also resize the browser window
Basically you must be able to scroll down so the filter move to the top
For me that were about 15 pages
lindonb: ok, you mean 15 pages of scrolling, not pagination
wolfganga: Yes
In tiki-listpages.php
lindonb: ok, working on something else now, will try to take a look and see if i can recreate
wolfganga: it shows the issue also when you resize the browser windows so you see for example only 5 pages
and then scroll down so thefilter moves up
Thank you in advance ;-)
* Wolfgang urgently needs sleep
lindonb: don’t thank me yet ;)
have a good noght!
*night*
wolfganga: you too - bb
left #tikiwiki
chibaguy: joined #tikiwiki
polom
lindonb: polom chibaguy
chibaguy: hi lindonb
I like the wiki actions dropdown.
good spot by gezza
lindonb: yes, thought I would try out his idea - i like it too
should apply it in lists as weel, at least for those with more than a couple of actions per item
chibaguy: yep. I guess an "ellipsis" equivalent needs to be specified for other icon sets?
lindonb: for the trackers list, i have 12 action icons per item - a little out of control ;)
yes I created an ellipsis equivalent for each iconset
chibaguy: 12? ;-) I thought I read somewhere that people can only handle a maximum of 7 choices in one place.
(as a general rule of interface design)
(but hard to stick to, I guess)
lindonb: agree, probably some other way to organize to avoid having everything jammed into one list
on the ellipsis, for the legacy set it is a down caret :(
couldn’t find 3 dots so chose one that indicated a dropdown
chibaguy: ok, close enough probably.
lindonb: i think so, glyphicon has a nice ellipsis so no problem there
chibaguy: oh it does? When I switched to glyphicons I got a missing image.
lindonb: hmmm, let me look...
chibaguy: Sorry, I mean when I switched to legacy.
lindonb: i think I chose an famfamfam icon we don’t use - will fix
chibaguy: ok
Tiki-KGB: 03lindonb r53714 10trunk/themes/base_files/iconsets/legacy.php
[FIX] legacy icons - use available icons to avoid missing icons (thanks chibaguy!).
Tiki|bot: New Forum Posts: Porting the business theme to Tiki 13 or 14. - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=54671
New Forum Posts: Header with Streetview - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=54670
New Forum Posts: Apply Profiles - 403 Error - v12.3 - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=54668
New Forum Posts: Porting the business theme to Tiki 13 or 14. - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=54671
New Forum Posts: Header with Streetview - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=54670
New Forum Posts: Apply Profiles - 403 Error - v12.3 - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=54668
fabricius: joined #tikiwiki
chibaguy: joined #tikiwiki
chibaguy_: joined #tikiwiki
Caarrie: joined #tikiwiki
refizul: joined #tikiwiki
gezza: joined #tikiwiki
Tiki|bot: joined #tikiwiki
Tiki-KGB: 03gezzzan r53715 10trunk/templates/tiki-wiki_topline.tpl
[FIX] fix backlinks and simplify some title text (better to avoid using the word "click" because we are not always clicking, eg: on tablets and smartphones we tap)
03gezzzan r53716 10trunk/ 10themes/base_files/iconsets/default.php 10themes/base_files/iconsets/glyphicons.php 10templates/translated-lang.tpl * [FIX] translation icon dropdown and unify icons
fabricius: joined #tikiwiki
joined #tikiwiki
Tiki-KGB: 03gezzzan r53717 10trunk/templates/freetag_list.tpl * [MOD] visual updates for tag listing
Telesight: joined #tikiwiki
Tiki-KGB: 03chibaguy r53718 10trunk/themes/ 10(99 files in 79 dirs)
[REF] Consolidate color-related CSS rules in tiki_base files (non-Bootstrap) into one new file and import it by each theme so the theme can specify the colors. Also completed the move of Didiem to full theme. Todo: theme options and checking.
03gezzzan r53719 10trunk/templates/comment/ 10remove.tpl 10archive.tpl 10list_inner.tpl
[MOD] comment delete, archive and approval moved next to reply and and edit links, made them use simple service and also made related tpls nicer.
lindonb: joined #tikiwiki
Tiki-KGB: 03chibaguy r53720 10trunk/themes/snow/ 10less/snow.less 10css/snow.css * [FIX] FIx path to background images (reorder .less includes in snow.less).
Jyhem_laptop: joined #tikiwiki
Tiki-KGB: 03gezzzan r53721 10trunk/ 10templates/comment/list.tpl 10lib/core/Services/Comment/Controller.php 10templates/comment/unlock.tpl 10templates/comment/lock.tpl
[MOD] comments locking/unlocking use icon set and bootstrap modal. Todo: tooltips dont get initialized on the lock/unlock icons for some reason.
fabricius: joined #tikiwiki
lindonb: chibaguy_: i can’t figure out why the glyphicons ellipsis doesn’t show in wiki topline or quick admin
it seems to be available at http://getbootstrap.com/components/#glyphicons
gezza: do you know by chance?
gezza: hihi
i mean hi :)
lindonb: hi :)
i stole your ellipsis idea!
gezza: yes, and I like it :)
lindonb: me too, great idea
gezza: checking the glyph ellipsis now
lindonb: great, thanks
gezza: i switched to use glyphicons
and "option-horizontal" icon glyph icon appears as expected
lindonb: ok, cool - something on my end
gezza: what is the issue here?
lindonb: for me nothing shows
gezza: which theme?
lindonb: yeti
gezza: i always use default bootstrap for checking things
lindonb: ah ok, let me try that
gezza: yeap, for yeti it is not visible, must be some css thing
lindonb: ok, you’re right, it shows in default bootstrap
gezza: the icons have a huge padding in yet
yeti
lindonb: agree
too huge
gezza: I guess you have checked that styling proposal page on dev page. I am having a hard time coming up with simple rules, if you have any thoughts on them, please update the page
lindonb: ok, will take a look
btw, how do we use the larger sizes (2x, 3x, etc.) using iconsets?
gezza: jonny made a "prepend" and "append" settings, these add classes for all icons
i think you can still define class for each icon
lindonb: ok, then the class definition would upsize the icons for each iconset (or at least for default and glyphicon)?
gezza: you can also make them bigger through css font-size property
per theme
apply it on icon class
1.2 em or similar
lindonb: ok, got it
i’m thinking of areas like wizards where the large legacy icons were used
gezza: that is tricky because of the legacy png images
that is why they are called admin_XXX in the iconsets
lindonb: okay, so admin_XXX goes to the larger icon folder for the legacy png’s?
gezza: yes
lindonb: ok, got it, so probably admin_XXX would work for the wizards area
gezza: if you are working with wizard, can you explore if they can use bootstrap modal? that would make them really look like a wizard
lindonb: yes, wizard area is quite old school - afraid to go there
Tiki-KGB: 03gezzzan r53722 10trunk/templates/permission_link.tpl * [FIX] add a space between icon and text
wolfganga: joined #tikiwiki
Hello
Hi lindonb - are you there?
Tiki-KGB: 03gezzzan r53723 10trunk/tiki-admin.php * [MOD] adding missing descriptions
lindonb: hi wolfganga
wolfganga: Hi lindonb - did you have a time to look into the issue we discussed todays morning?
lindonb: i had a quick look but wasn’t able to recreate
i may not have enough pages in my local trunk
wolfganga: Mhh thats bad. Without being able to recreate it is hard to fix.
i think i know where it fails - its one call where the parm should be an array but its actually empty.
but i do not know WHY its emtpy
chibaguy_: Theme-specific templates don't seem to be used in trunk. (Snow theme's module.tpl has a panel-footer, but it's not showing up.)
Tiki-KGB: 03chibaguy r53724 10trunk/themes/ 10(7 files in 6 dirs) * [FIX] Adjust some backgrounds.
03gezzzan r53725 10trunk/lib/setup/theme.php
[FIX] theme_path got wrong value by usage of get_theme_css, and so theme specific templates were broken
gezza: hi chibaguy
i just made a commit, can you check snow theme custom templates?
credits.tpl seems to be applied
Tiki-KGB: 03chibaguy r53726 10trunk/themes/ 10(84 files in 19 dirs) * [NEW] Re-adding some legacy themes. Work in progress.
chibaguy_: Ok, gezza, snow theme looks complete now.
Tiki-KGB: 03chibaguy r53727 10trunk/themes/strasa/ 03css/strasa.css 03less/strasa.less * [NEW] Re-adding some legacy themes. Work in progress.
gezza: a question: i am working on comments, and noticed that archived comments dont appear becase tiki_base.css sets .comment.archived to display:none. has it always been like this? seems unnecessary to me
chibaguy_: gezza, maybe there was an error when editing the stylesheets. So .comment.archived doesn't need any display rule?
gezza: i think it does not need a rule, but wanted to confirm with someone
the comments_archive pref description says if a comment is archived, it is only visible for admin
currently it is not shown at all because of that display rule
chibaguy_: ok, I can change it in the .less file, but it's late here now so I'll do it tomorrow.
bbl
Tiki-KGB: 03gezzzan r53728 10trunk/templates/comment/list_inner.tpl * [MOD] visual highlight for archived and pending moderation comments
Telesight1: joined #tikiwiki
Tiki-KGB: 03walper r53729 10trunk/templates/ 10tiki-view_tracker_item.tpl 10attachments_tracker.tpl
[FIX] Fixed bug in displaying a tracker item introduced in last commit. Fixed another Smarty notice.
03lindonb r53730 10trunk/themes/ 10(32 files in 32 dirs) * [FIX] fixing differences apparently caused by less compilation issues
lindon: joined #tikiwiki
Tiki-KGB: 03lindonb r53731 10trunk/themes/ 10(34 files in 34 dirs)
[FIX] tablesorter: give header rows solid background colors so that content underneath is hidden when "sticky headers" scrolls the header over the table (thanks wolfganga)
marclaporte: joined #tikiwiki
Tiki|bot: New Forum Posts: Porting the business theme to Tiki 13 or 14. - https://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=54671
New Forum Posts: Header with Streetview - https://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=54670
New Forum Posts: Apply Profiles - 403 Error - v12.3 - https://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=54668
New Forum Posts: Porting the business theme to Tiki 13 or 14. - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=54671
New Forum Posts: Header with Streetview - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=54670
New Forum Posts: Apply Profiles - 403 Error - v12.3 - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=54668