| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| sol__ | joined #tikiwiki | [00:33] |
| .......... (idle for 45mn) | ||
| Tiki-KGB | 03lindonb r54502 10(24 files in 15 dirs) * [MRG] Automatic merge, branches/14.x 54490 to 54500 | [01:18] |
| 03lindonb r54503 10branches/ 10(7 files in 3 dirs)
[FIX] articles: for tiki-read_article page - iconset conversion and add icons to main top buttons; move actions to ellipsis; remove media class and add spacing to article class so that ellipsis dropdown is not cut off. | [01:32] | |
| ..... (idle for 21mn) | ||
| Jyhem_laptop | joined #tikiwiki | [01:53] |
| Tiki-KGB | 03chibaguy r54504 10branches/ 10(43 files in 39 dirs)
[FIX] Renamed layout template to reflect its function better. (Less compiling strangely failed for some theme stylesheets so CSS isn't completely updated yet.) | [01:58] |
| .... (idle for 15mn) | ||
| Gwayne | joined #tikiwiki | [02:13] |
| Tiki-KGB | 03chibaguy r54505 10branches/ 10(5 files in 5 dirs)
[FIX] Theme stylesheets updated manually after less compiling failed for them (layout template renamed to reflect its function better). | [02:20] |
| ................. (idle for 1h20mn) | ||
| 03lindonb r54506 10(57 files in 48 dirs) * [MRG] Automatic merge, branches/14.x 54500 to 54505
03lindonb r54507 10branches/14.x/templates/translated-lang.tpl * [FIX] translation menu: add ability for this to be a submenu 03lindonb r54508 10branches/14.x/templates/tiki-view_articles.tpl [FIX] view articles: iconset conversion and add icons to main top buttons; move actions to ellipsis, including translation menu as a submenu; remove media class and add spacing to article class so that ellipsis dropdown is not cut off. 03lindonb r54509 10branches/14.x/templates/tiki-read_article.tpl * make not published notice a warning and not an error 03lindonb r54510 10branches/14.x/lib/smarty_tiki/block.self_link.php * documentation 03lindonb r54511 10(6 files in 4 dirs) * [MRG] Automatic merge, branches/14.x 54505 to 54510 | [03:40] | |
| Tiki|bot | joined #tikiwiki | [03:44] |
| Tiki-KGB | 03lindonb r54512 10branches/ 10(9 files in 3 dirs)
use "more" instead of "ellipsis" for dropdown icon name in case we want to change it later 03lindonb r54513 10(11 files in 5 dirs) * [MRG] Automatic merge, branches/14.x 54510 to 54512 | [03:54] |
| .......... (idle for 48mn) | ||
| 03lindonb r54514 10branches/ 1014.x/templates/modules/mod-quickadmin.tpl 1014.x/templates/tiki-wiki_topline.tpl
[FIX] bootstrapification: Use submenus for actions in quick admin and wiki topline instead of multiple menus. Can't get submenus to fly out to the side like http://getbootstrap.com/2.3.2/components.html#dropdowns, but still works and better than multiple menus. 03lindonb r54515 10trunk/templates 10trunk/templates/modules/mod-quickadmin.tpl 10trunk 10trunk/templates/tiki-wiki_topline.tpl * [MRG] Automatic merge, branches/14.x 54512 to 54514 | [04:44] | |
| ............. (idle for 1h2mn) | ||
| 03chibaguy r54516 10branches/ 1014.x/themes/base_files/css/tiki_base.css 1014.x/themes/base_files/less/tiki-bootstrap_overrides.less 1014.x/templates/tiki-view_articles.tpl
[REF] For semantics, news articles should be class=media (they contain media-left and media-body elements), but to enable the actions dropdown visibility, a media-overflow-visible class is added. | [05:48] | |
| .................. (idle for 1h29mn) | ||
| Tiki|bot | New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292
New Forum Posts: Fatal error - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 New Forum Posts: i18n question - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55282 | [07:17] |
| New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292
New Forum Posts: Fatal error - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 New Forum Posts: i18n question - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55282 | [07:27] | |
| ........... (idle for 53mn) | ||
| Tiki-KGB | 03lindonb r54517 10(5 files in 5 dirs) * [MRG] Automatic merge, branches/14.x 54514 to 54516
03lindonb r54518 10branches/ 1014.x/templates/translated-lang.tpl 1014.x/templates/article_trailer.tpl * [FIX] html errors and warnings | [08:20] |
| Tiki|bot | New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292
New Forum Posts: Fatal error - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 New Forum Posts: i18n question - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55282 | [08:38] |
| New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292
New Forum Posts: Fatal error - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 New Forum Posts: i18n question - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55282 | [08:48] | |
| chibaguy | joined #tikiwiki
polom | [08:57] |
| I changed the name of a layout template directory and now have been getting a smarty error (missing file) even though I've cleared templates_c and temp/cache, and made sure in the db the layout preference is for an existing tempplate. What else can be done to recover the site? | [09:03] | |
| redflo | joined #tikiwiki | [09:04] |
| chibaguy | ...and cleared browser cache. | [09:04] |
| files in templates_c show the old name of the layout template directory. | [09:09] | |
| .......... (idle for 46mn) | ||
| Loll | joined #tikiwiki | [09:55] |
| chibaguy | Hmm, does anyone else see the switch-theme module with three selectors (when the theme has an option)? -- Theme / Option / "None"
Or two selectors - Theme and "None" - when the theme doesn't have an option. | [09:56] |
| Tiki-KGB | 03lindonb r54519 10branches/ 1014.x/templates/tiki-upload_file_progress.tpl 1014.x/lib/smarty_tiki/modifier.iconify.php 1014.x/templates/browse_file_gallery.tpl
[FIX] file galleries: was showing icon all the time instead of image in the upload window. 03lindonb r54520 10branches/14.x/templates/fgal_context_menu.tpl * [FIX] file galleries: fix context menu formatting for certain items 03lindonb r54521 10(8 files in 4 dirs) * [MRG] Automatic merge, branches/14.x 54516 to 54520 | [10:02] |
| Loll | Hi. I'm using version 12.3. My uploaded images are not shown on a wikipage using {img fileId="13" thumb="y" rel="box[g]"} (only a broken image icon is displayed and by by clicking on it the message "This image failed to load" appears. When I use /tiki-download_file.php?fileId=13 the image is correctly downloaded. Any suggestions? | [10:07] |
| ...... (idle for 27mn) | ||
| Tiki-KGB | 03chibaguy r54522 10branches/ 10(43 files in 41 dirs) * [REF] Expose dropdown title to theme variables for good color contrast, etc. | [10:34] |
| chibaguy | Hi Loll, sorry, I don't have any ideas off-hand. That image syntax works ok in my branch 14 test site (just did a quick check). | [10:46] |
| Telesight | joined #tikiwiki | [10:51] |
| chibaguy | luciash, if you're around, there's a problem with the top and topbar module zones background colors - the situation varies according to the theme. Some have good alignment but with others there are 15px gaps. So sometimes the -15px default for class=row is good and sometimes not. I'm trying to find a global solution; hope we don't need to deal with it theme by theme.
So if you have any ideas ... ;-) | [10:52] |
| .... (idle for 17mn) | ||
| Tiki|bot | New Forum Posts: Images failed to load - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55299 | [11:09] |
| chibaguy | If anyone has any ideas on how to fix a site that's broken due to a file name change, I'd like to hear. I changed a template layout directory and now I have a smarty error as apparently the old location is requested.
Cleared site and browser caches, no help. Checked the database to see that an existing layout template is set as the preference. Why doesn't "smarty" understand the situation? ;-) I could add the old directory name again so smarty can find the file, but does that just delay solving the problem? | [11:18] |
| Ok, I gave up and made that unsolution - copied and renamed a directory to make smarty happy.
Just for closure, I found that in L&F admin, the old layout directory was still set as default, so I could change it and then delete the old directory, which I had reinstated just to get access to L&F admin. I don't know if I was checking the pref in a wrong db. | [11:34] | |
| Tiki-KGB | 03chibaguy r54523 10branches/ 1014.x/themes/base_files/css/tiki_base.css 1014.x/themes/base_files/less/tiki-admin.less * [FIX] Admin box legacy icons (images) were positioned too high. | [11:48] |
| ........ (idle for 38mn) | ||
| 03jonnybradley r54524 10branches/14.x/lib/wiki-plugins/wikiplugin_div.php * [FIX] notices | [12:26] | |
| fabricius | joined #tikiwiki | [12:28] |
| luciash | polom
chibaguy: hi, reading | [12:31] |
| chibaguy | hi luciash
I'm checking the different themes to see if there's a pattern to the problem; a little complicated because of different themes and layouts. The topbar background for example could be adjusted in each theme stylesheet, but it'd be better if there was a global fix somehow. | [12:32] |
| luciash | Loll: make sure your server has gd lib installed which handles thumbnail images generation properly
chibaguy: any examples to see? | [12:34] |
| chibaguy | yes, just a minute. | [12:35] |
| Tiki|bot | Recent Bug: - http://dev.tiki.org/item5596 | [12:36] |
| luciash | chibaguy: about the smarty issue i think it must be defined somewhere to allow smarty (security) to read templates from a newly introduced dir | [12:37] |
| chibaguy | ah yeah. Apparently the problem was that I had a layout template set as default and then removed its files. So user error. | [12:38] |
| luciash | ah i see | [12:38] |
| chibaguy | (I checked the db to change the pref but it didn't change in L&F. I don't know if I was looking at the wrong db.
Ok. http://zukakakina.com . You can switch the themes there. So you can see things line up nicely for the Bootswatch themes, I suppose because there's no border or background around the middle columns, etc. But in themes with backgrounds like Strasa or others, there's a gap at the sides of the topbar. (Also notice the extra selector in the themes-switch module - I'll ask gezza about that.) It seems like maybe there's no universal setting - maybe the topbar side margins just have to be set 0px or -15px depending on the backgrounds and borders of the theme. (Plus I need to check with other layout templates.) | [12:38] |
| .... (idle for 15mn) | ||
| luciash | checking | [13:01] |
| chibaguy: I would really set the negative margins (-15px on class .tiki .topbar) only on the themes which actually need it; so far I can see it only on Strasa and TheNews... not that bad, what do you think? | [13:11] | |
| chibaguy | I guess it has to be like that - set the margins for themes that need it. | [13:12] |
| luciash | +1
btw, I did not notice the extra selector seems ok to me | [13:13] |
| chibaguy | Probably I should make it a variable to put in the themes' variable file. | [13:14] |
| Loll | luciash: Thanks for your suggestion. I will check this . However during tiki installation it was shown that GD is installed.
I had to find out how to check if this works properly | [13:14] |
| luciash | Loll: it might be also mime type handling problem but I do not know on non-apache server how to check | [13:15] |
| chibaguy | Loll, i don't think GD is involved in this problem. | [13:15] |
| luciash | chibaguy: good idea | [13:15] |
| chibaguy | luciash, Loll has a problem with images not displaying in wiki pages - tiki 12.
Although they can be downloaded ok. | [13:15] |
| luciash | chibaguy: i think i got it
chibaguy: not sure he said thumb=y images only or full size ones too Loll: is your server publicly accessible? | [13:16] |
| Loll | In the filegallery the thumnails are well displayed. | [13:17] |
| chibaguy | he posted here: {img fileId="13" thumb="y" rel="box[g]"} | [13:17] |
| luciash | yes, that is thumb generated image | [13:17] |
| Loll | No, unfortunately not accessible through internet | [13:17] |
| luciash | ok, check in your firebug console what error it reports, it might help | [13:17] |
| Loll | OK, I will check this as soon as my php update to 5.5 is finished | [13:19] |
| lindonb | joined #tikiwiki | [13:32] |
| jonnyb | joined #tikiwiki
pompom | [13:37] |
| Loll | Firebug console does not show any errors | [13:39] |
| fabricius | joined #tikiwiki | [13:46] |
| chibaguy | hi jonnyb | [13:53] |
| luciash | jonnyb: polom
Loll: but it should, when the images are broken... weird | [13:54] |
| jonnyb | hi chibaguy, luciash, Loll and all | [13:56] |
| Loll | I'm not sure that the images are broken. They are perhaps not loaded. | [13:56] |
| jonnyb | fabricius: too! :) | [13:56] |
| luciash | Loll: there should be reason why the are not loaded (404, 403, etc. error); do you see this logged in as an admin?
Loll: or logged out visitor? | [13:57] |
| ricks99 | joined #tikiwiki
polom y'all | [13:58] |
| jonnyb | hi ricks99 | [14:00] |
| chibaguy | hi ricks99 | [14:00] |
| luciash | hi rick | [14:02] |
| fabricius | Hi jonnyb, ricks99, chibaguy, luciash, refizul, Loll ... just popping by ... coming back later in the evening | [14:02] |
| luciash | hi fabricius | [14:03] |
| ricks99 | hi all :) | [14:03] |
| chibaguy | hi fabricius. could you bring beers when you return, please? | [14:03] |
| fabricius | chibaguy: will try, but I fear i will be only able to transfer at one of the next TikiFests
luciash, chibaguy: what is the status of the design for the Tiki community websites for the after Tiki14 release period? | [14:04] |
| chibaguy | :-) yeah, I wish I could make it to the central europe tikifest, but probably there's a funds problem.
Oh, the design is getting pretty close, I think. | [14:05] |
| Tiki-KGB | 03jonnybradley r54525 10(47 files in 44 dirs) * [MRG] Automatic merge, branches/14.x 54520 to 54524 | [14:06] |
| fabricius | luciash, chibaguy: do you consider the plan of one-column and two-column landing pages and shouldn't we make a webinar together with ricks99 +X to consider the website layout and structure, which ricks99 and me have been discussiong in recent weeks? I think we should get ideas together. | [14:07] |
| Loll | luciash: I'm log in as admin | [14:08] |
| chibaguy | Yes, sounds like a good idea. Probably post on the dev and or artwork list and see when people can attend. | [14:08] |
| Loll | luciash: i'm trying to install Tiki13 in paralel | [14:09] |
| ricks99 | fabricius & chibaguy +1 | [14:09] |
| fabricius | chibaguy, luciash: I am pretty sure, I cannot make it to CEST this year, cause we have a conference at the same time. Chances are that we do a small one end of August in Bonn. I would be interested to coordinate a bigger TikiFest in Bonn 2016 end of August around FROSCON together with a TikiFest CEST a week before or after, for that some can go for two weeks or so from one to the other FEST, and get some time
to see Europe - maybe a short brake weekend in Berlin and a day in Prague - especially tinking at people from far away to optionally take the partner and see a bit more from Europe that a HackSpace than a HackSpace | [14:12] |
| nelsonko | joined #tikiwiki | [14:17] |
| ricks99 | left #tikiwiki | [14:22] |
| .... (idle for 16mn) | ||
| lindonb | joined #tikiwiki | [14:38] |
| Tiki-KGB | 03chibaguy r54526 10branches/ 10(51 files in 47 dirs)
[FIX] New variables to enable setting top module and topbar module side margins and bottom margin per theme. Thanks to luci for input. | [14:48] |
| chibaguy_ | joined #tikiwiki | [14:55] |
| Loll | luciash: It seems to work in version 13 | [14:56] |
| ...... (idle for 28mn) | ||
| Tiki-KGB | 03chibaguy r54527 10branches/ 1014.x/themes/darkroom/less/tiki-selectors.less 1014.x/templates/layouts/fixed_top_modules/layout_view.tpl 1014.x/themes/darkroom/css/darkroom.css
[FIX] Unneeded container div in layout_view.tpl caused horizontal offset. Appearance of admin navbar improved in Darkroom theme. | [15:24] |
| luciash | re
fabricius: a pity you cannot come, maybe we could change dates still but depends on other people and stuff... maybe Bonn then is a good idea Loll: interesting (I wonder why it wouldn't work in 12) fabricius: Nelson is already interested to take partner to TikiFest CEST ;) | [15:25] |
| Loll | luciash: Is there a way to export the settings of a tiki installation? in this way I could compare settings of both installations | [15:30] |
| luciash | Loll: yes, on Profiles Admin panel the Advanced tab iirc
Loll: or export 12.x db, then use it for the 13.x as upgrade | [15:30] |
| fabricius | joined #tikiwiki | [15:37] |
| arildb | joined #tikiwiki | [15:38] |
| Tiki|bot | Recent Bug: - http://dev.tiki.org/item5597 | [15:47] |
| .... (idle for 17mn) | ||
| Tiki-KGB | 03chibaguy r54528 10branches/ 1014.x/themes/business/less/tiki-selectors.less 1014.x/themes/business/css/business.css * [FIX] Missing borders on horizontal menu links re-added (Business theme). | [16:04] |
| .... (idle for 18mn) | ||
| jonnyb | joined #tikiwiki | [16:22] |
| ..... (idle for 20mn) | ||
| Tiki|bot | New Forum Posts: Images failed to load - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55299
New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292 New Forum Posts: Fatal error - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 | [16:42] |
| jonnyb | hi nelsonko - are you there (and have a moment?) | [16:50] |
| nelsonko | hi jonnyb | [16:51] |
| jonnyb | i've managed to get the sorting and pagination working with the list plugin (most of it was already in there of course), so that's good... | [16:51] |
| Tiki|bot | New Forum Posts: Images failed to load - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55299
New Forum Posts: Composer / could not be resolved to an installable set of packages / jquery - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55292 New Forum Posts: Fatal error - http://tiki.org/tiki-view_forum_thread.php?forumId=6&comments_parentId=55284 | [16:52] |
| nelsonko | jonnyb: sounds like good news. any specific commits I should look at? | [16:53] |
| jonnyb | sry, phone..
but i'm trying to test with two custom_search plugins on a page and there seem to be other issues - just checking that this was the use case you added the forcesortmode param for? | [16:53] |
| and the table.tpl template doesn't really work for custom_search - doesn't know about ajax at all...
ew, looks like full screen edit is quite broken, anotehr thing for the list :( | [17:00] | |
| nelsonko | jonnyb: I think the use case is one custom search + 2 list plugins on a page, but I think the problem will occur if you have one custom search + 1 list as well
(I've not used 2 custom search on the same page) | [17:17] |
| jonnyb | aha, thanks nelsonko - and is that with both using the standard table.tpl? or custom ones? | [17:18] |
| nelsonko | custom tpls
both using custom tpls | [17:18] |
| jonnyb | i'm finding it tricky getting the standard one to work with ajax
i see some code that looks like it's trying to set something up at lib/core/Services/Search/CustomSearchController.php:54 but it doesn't seem to be used anywhere... don't worry, it's all very deep this, i'll keep nagging away at it :) | [17:18] |
| Loll | Are the template in 13.1 different than in 12.3 ?? | [17:27] |
| jonnyb | hi Loll - yes, big changes between 12 and 13 and again in 14 (bootstrap process) | [17:31] |
| ......... (idle for 41mn) | ||
| Tiki-KGB | 03jonnybradley r54529 10branches/ 1014.x/templates/search/list/table.tpl 1014.x/lib/core/Search/Query/WikiBuilder.php 1014.x/lib/core/Search/Formatter/Builder.php 1014.x/lib/wiki-plugins/wikiplugin_list.php
[FIX] list: Make the existing pagination argument options (offset_arg and max) work with the standard table.tpl template. Add a new sort_arg option to pagination (seemed like the best place for it, even though it's not really about pagination) so you can define a separate arg for each list plugin instance, allowing multiple sortable and "pageable" lists per page. E.g. use {pagination offset_arg="offset42"} and {pagination sort_arg="sort_mode42"} to the list plugin to enable. Custom templates may need some updating to use this (thanks nelsonko) | [18:12] |
| Loll | I must say that the Fivealine theme was better in version 12 than 13.... Also the modules aligned better | [18:12] |
| jonnyb | Loll: yes, we know, should be better in 14.x - in the mean time i think fivealive-lite got more attention than the other one in 13.x | [18:14] |
| Tiki-KGB | 03jonnybradley r54530 10(57 files in 53 dirs) * [MRG] Automatic merge, branches/14.x 54524 to 54529 | [18:18] |
| nelsonko | jonnyb: so should allow_sort_replace param be removed from list plugin? | [18:23] |
| jonnyb | i think so, will do it once this has been tested a bit
also think i'm on the way to having multiple custom searches on a page, also not conflicting | [18:24] |
| nelsonko | jonnyb: ok, thanks | [18:25] |
| jonnyb | and now you can set the sort_arg for the lists you don't need that forcesortmode param on custom_search (i think & hope)
have merged it back to trunk in case you can test it there more easily | [18:25] |
| nelsonko | jonnyb: as for the forcesortmode in custom search, I added that in r51341 just in case people wanted the old behaviour back. | [18:29] |
| jonnyb | oh - for me it broke the old behaviour
without that param set my javascript is prevented from changing the sort order | [18:30] |
| nelsonko | Basically, the issue I was facing was that if you set a sort mode within the custom search, and then enter some text search, you get results that are not sorted by relevance, but instead by whatever the sort mode was - so it looks to the user that the searching wasn't working
it seemed unnatural and incorrect. So I changed the behaviour and added the "forcesortmode" parameter such that if you set that on, you will get back the old behavior | [18:31] |
| jonnyb | but now doing customsearch_0.sort_mode has no effect any more, it used to let you change the sort
oh right, so the default is to change the current behaviour? i wasn't expecting that... | [18:32] |
| nelsonko | I had not realized it would prevent changing the sort | [18:33] |
| jonnyb | i'm not sure what you mean by "force" in this context
lib/wiki-plugins/wikiplugin_customsearch.php:397 customsearch.options.forcesortmode defaults to false | [18:33] |
| gezza | joined #tikiwiki | [18:36] |
| nelsonko | as I mentioned, I had not realized it prevents changing the sort | [18:36] |
| jonnyb | when you say "set a sort mode within the custom search" you mean by adding a {sort mode="title_asc"} in the cs plugin definition? why would you want that not to work if you've added it - i don't understand, sorry | [18:38] |
| nelsonko | jonnyb: so adding {sort mode="title_asc"} gives you the default sort, but once people search for something the sort mode should IMO switch to relevance | [18:38] |
| jonnyb | wow, seems very counter intuitive to me i'm afraid
i would consider that a bug | [18:39] |
| nelsonko | jonnyb: I think both use cases are needed
I agree that {sort mode="title_asc"} would want to be preserved but {sort mode="modification_date_desc"} was what I had It depends on whether you are using it as a "filter" or as a "search" proper | [18:39] |
| jonnyb | how do you mean? what's the difference? | [18:41] |
| nelsonko | If you are searching for things, the resulting sort mode should be by relevance, otherwise the user will say hey the search isn't working, | [18:41] |
| jonnyb | for me if i purpoefully set a sort mode it means i want the results to be sorted in that order, i just don't get how you would not want to do that
not necessarily, my client specifically wants users to be able to sort by price, title, date etc | [18:41] |
| nelsonko | What I want (in this use case) is for the sort mode to be a certain way before the user enter a text search, but once the user enters the text it should show by relevance | [18:42] |
| jonnyb | now that's completely ignored and it always sorts by score_desc | [18:43] |
| nelsonko | yes I agree the commit was a bad one | [18:43] |
| jonnyb | wouldn't it be better to add a new "autoload_sort_mode" param or something then? | [18:43] |
| nelsonko | I was worried about it which is why I added the parameter, but the default should have been the old behavior
the forcesortmode parameter i.e. well, something like autoload_sort_mode, but in this use case, there are other filters as well, but not the text filter | [18:44] |
| jonnyb | so maybe it should be called ignoresortparamor something? | [18:45] |
| nelsonko | e.g. checkboxes, categories, etc.
those shouldn't trigger sort by relevance, - only when the user actually search for something , should the sort mode be set to relevance | [18:45] |
| jonnyb | i have to say that sounds like a very obscure use case, don't think i've ever seen a site that works like that | [18:46] |
| nelsonko | in your site, the user can choose his sort mode? | [18:46] |
| jonnyb | maybe more suitable for localised customisation? | [18:47] |
| nelsonko | is "relevance" one of the sort modes the user can choose from? | [18:47] |
| jonnyb | yes
the default | [18:47] |
| nelsonko | when the user goes to the page at first
and there is no search query, what does it sort by? | [18:47] |
| jonnyb | what the sort mode is set to in the plugin | [18:48] |
| nelsonko | relevance?
or title? | [18:48] |
| jonnyb | actually there's not sort set (just checked) | [18:49] |
| leagris | joined #tikiwiki | [18:49] |
| nelsonko | ok, so once you set a sort, the "problem" starts to happen. That's how it happened for me
we set a sort, say modification_date_desc then we received complaints that when they search for things, they don't see relevant results - because it seemed to be all sorted according to date basically this is the problem that I was trying to fix (pretty clumsily I admit) | [18:50] |
| jonnyb | Ok, so why not have bit of custom js on the text search change to set the sort to what that site wants? i don't see it needs to be a part of tiki | [18:52] |
| nelsonko | yeah, now thinking about it that could work. I was trying to fix it for Tiki because it seem like a possible recurring problem for others | [18:53] |
| jonnyb | i guess i get the idea of having one sort for the autoloaded list and another for users searches, but i think having a "sort by" select or something visible on the form would do it too | [18:54] |
| nelsonko | I am thinking perhaps making the search UI parser parse an additional param that says, if this field is updated to have something, or something like that, to set a certain sort mode
something like {input type=text _filter="content" setsort="score_desc" or {input type=text _filter="content" sort="score_desc"} I mean {input type=text _filter="content" _sort="score_desc"} | [18:56] |
| jonnyb | maybe, more understandable than the force thing, imho :) | [18:59] |
| nelsonko | yes, sorry. | [19:00] |
| jonnyb | no, sorry to have given you such a hard time about it ;)
at least i know i can keep my client happy by setting that param in the mean time | [19:00] |
| Tiki-KGB | 03gezzzan r54531 10branches/14.x/templates/admin/include_articles.tpl
[FIX] add button for submissions, cleanup of legends, align and remove some more noise from the screen | [19:04] |
| gezza | hi jonnyb | [19:08] |
| jonnyb | hi gezza
looks like you're busy with the tpls, thanks! :) brb | [19:08] |
| gezza | you were improving structures before, right? i did some improvements and noticed that if a structure is in a menu, and I add a new page to the structure, it wont appear until I clear cache
is it a known thing? maybe it is intentianl intentional ok, I'll be around for a while | [19:09] |
| jonnyb | b
not really intentional, but the structure doesn't necessarily "know" it's being used in a menu, so doesn't know to clear that cache | [19:10] |
| nelsonko | the caching of the menus/modules are intentional for sure, but because ... (was typing then jonny already said it really well - the structure knows not it is in a menu) | [19:11] |
| jonnyb | and it would be not great to clear all the caches every thime a structure gets modified i think | [19:12] |
| gezza | hmmm
i get your point, but still it is confusing | [19:12] |
| jonnyb | i guess it would be a relatively trivial db query to find any menu modules using it, and if found clear the module cache... but still would take time
maybe adding a note to the structure admin page to say that - after the structure's been saved if poss | [19:13] |
| gezza | maybe adda remarksbox about it..but well, I am tring to kill tips and other remarksboxes that should be in documentation | [19:14] |
| jonnyb | i know, i tihnk tiki's geting overloaded with them
the search admin page is terrible now imho | [19:14] |
| gezza | yes, documentation should not be in the source
translation overhead is huuuuuge ok, I try to find out something else also structure alias is weird at tiki-edit_structure.php, I have to reload the page twice to get the renaming shown..I guess that is not intentional :) | [19:14] |
| jonnyb | yeah, i never really understood the alias thing, it was there when i arrived (think it's just confusing) | [19:18] |
| gezza | it makes some sense when you reuse pages in different structures, but well, would be interested to see real use cases for it
i will not touch these, I stick to visual changes :) i mean fixes :P | [19:20] |
| jonnyb | :) | [19:24] |
| Tiki-KGB | 03gezzzan r54532 10branches/14.x/templates/tiki-edit_structure.tpl * [FIX] use remarksboxes and arrangement of adding and categorizing pages | [19:28] |
| 03jonnybradley r54533 10branches/14.x/lib/wiki-plugins/wikiplugin_customsearch.php
[FIX] search: Expose pagination args to the search (so now pagination when using table.tpl works for custom search, sorting to come...) | [19:38] | |
| nelsonko | jonnyb: should I change the default for the "forcesortmode" parameter to on for now to preserve environment (to the Tiki 13 behaviour?), you think? | [19:38] |
| jonnyb | i think so yes, but i'd rather see it replaced by something nicer :)
i set it to on on my dev site and that's now working fine again, so default to 1 should do the trick for now | [19:39] |
| nelsonko | yes I will try and get to it tomorrow and Friday... but for now | [19:39] |
| jonnyb | thanks :) | [19:41] |
| nelsonko | jonnyb: setting the default parameter in the plugin definition does not actually do anything and I actually have to add code to manually defaul t it right? | [19:42] |
| jonnyb | yes sadly, plugins need to sort out their own defaults etc still | [19:43] |
| Tiki-KGB | 03nkoth r54534 10branches/14.x/lib/wiki-plugins/wikiplugin_customsearch.php
[FIX] In r51341, the default behavior was changed when trying to fix another issue, breaking the ability to set the sort_mode via jq before new searches. This sets the default back to the old behavior to avoid regressions. A better fix for the other issue is being worked on, and then this forcesortmode parameter would no longer be needed. | [19:48] |
| jonnyb | trying to work out how to get two custom searches on a page (might give in actually, why would you want to) but i'm looking at the js it produces, nelsonko any idea why clicking on the form sets the offset to 0? lib/wiki-plugins/wikiplugin_customsearch.php:305
thanks for r54534 | [19:48] |
| nelsonko | jonnyb: could it be because when you change the search parameters and re-search, you'd want to start from page 1? | [19:50] |
| Tiki-KGB | 03gezzzan r54535 10branches/14.x/templates/duplicate_file_gallery.tpl * [FIX] bootstrappification | [19:50] |
| jonnyb | yes, but it's bound to clicking anywhere on the form (including whitespace etc)? | [19:50] |
| nelsonko | jonnyb: probably an over aggressive binding
I can't see any reason why clicking on white space etc should trigger that | [19:51] |
| jonnyb | can ignore it, don't think i can get this untangled without significant refactoring
yes, binding to input.change would seem better - anyway, moving on :) | [19:51] |
| nelsonko | are select items "input"? | [19:52] |
| jonnyb | no, same for textareas | [19:53] |
| nelsonko | grrr :) | [19:53] |
| jonnyb | so something like $("input, select, textarea", "#customsearch_0").change(...
but never mind, food and going out time here (soon) | [19:54] |
| nelsonko | :) | [19:54] |
| Tiki-KGB | 03gezzzan r54536 10branches/14.x/templates/tiki-list_file_gallery.tpl * [FIX] remove unnecessary span from comment button | [19:56] |
| 03gezzzan r54537 10branches/14.x/templates/categorize.tpl * [FIX] remove abbreviation and use tips | [20:04] | |
| .... (idle for 16mn) | ||
| 03gezzzan r54538 10branches/14.x/templates/tiki-list_file_gallery.tpl * [FIX] find and search in content form placement | [20:20] | |
| sol__ | joined #tikiwiki | [20:21] |
| Tiki-KGB | 03gezzzan r54539 10branches/14.x/templates/tiki-list_file_gallery.tpl * [FIX] move the less frequently used Edit action to ellipsis too | [20:32] |
| 03gezzzan r54540 10branches/14.x/templates/edit_file_gallery.tpl * [FIX] layout for quota | [20:42] | |
| .... (idle for 19mn) | ||
| Bsfez | joined #tikiwiki | [21:01] |
| .... (idle for 16mn) | ||
| jonnyb | hi Bsfez - and bye, i'm just off to the pub :)
was just going to thanks gezza (again) for all these lovely bootrappy inconifying commits, looking forward to checking it all out! | [21:17] |
| gezza | have a good pint or two jonnyb! | [21:19] |
| jonnyb | thanks, will do - see you tomorrow
cheers | [21:19] |
| Tiki-KGB | 03jonnybradley r54541 10branches/ 1014.x/templates/search/list/table.tpl 1014.x/lib/core/Search/Query/WikiBuilder.php
[FIX] search: Fix sort in custom_search ajax results when using table.tpl (too much login in the tpl sorry, TODO refactor after 14.0) 03jonnybradley r54542 10(11 files in 7 dirs) * [MRG] Automatic merge, branches/14.x 54529 to 54541 | [21:22] |
| ......... (idle for 42mn) | ||
| Telesight | joined #tikiwiki | [22:04] |
| fabricius | joined #tikiwiki | [22:06] |
| ...... (idle for 29mn) | ||
| joined #tikiwiki | [22:35] | |
| nelsonko | left #tikiwiki | [22:44] |
| luciash | joined #tikiwiki | [22:53] |
| ............. (idle for 1h4mn) | ||
| nelsonko_ | joined #tikiwiki | [23:57] |
| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |