#tikiwiki 2015-03-20,Fri

jonnyb

what are we on now?

gezza

3.3.2 I think
they skipped 3.3.3
so we are on the previous release

jonnyb

what do you think?
looks like mostly bug fixes to me
"Fixes for a few significant bugs in the Modal plugin" sounds good for 14.x

gezza

"Fixes for a few significant bugs in the Modal plugin"

[15:32]

jonnyb

[15:32]

gezza

hehe, yes
ok, lets updates and see if soemthing breaks?

[15:32]

jonnyb

i was hoping to convert our autotoc thing to be use ScrollSpy but never got round to it
yes, go for it - sounds ok

[15:33]

gezza

[15:35]

jonnyb

joined #tikiwiki
that was odd - my mac logged me out, think i'll reboot - brb
joined #tikiwiki

[15:35]

joined #tikiwiki
repolom

[15:48]

Jyhem_laptop_

joined #tikiwiki

[15:56]

jonnyb

found an "interesting" combinations of edge cases to play with for a friday afternoon: cookie consent plus silent sessions plus javascript disabled in the browser - not a good combo!

[15:56]

Jyhem_laptop__

joined #tikiwiki

[16:05]

zac2944

joined #tikiwiki

[16:11]

.... (idle for 17mn)

panamaus

joined #tikiwiki

[16:28]

......... (idle for 41mn)

Tiki|bot

New Forum Posts: Menu Icons in Tiki 13 (Where are they?) - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=55316

[17:09]

jonnyb

hi nelsonko - you about?

[17:20]

Tiki-KGB

03jonnybradley r54591 10branches/14.x/lib/tikilib.php * [FIX] notices

[17:30]

.... (idle for 17mn)

nelsonko

jonnyb

[17:47]

jonnyb

hi nelsonko

[17:48]

nelsonko

[17:49]

jonnyb

i remember you did a load of fixes on the javascript detection ages ago, i've just been checking it (need to improve how tiki looks for crawler bots wihtout ajax etc)
anyway, it all seemed quite broken
so i'm hoping to fix it and just wanted to check whether you were ok with that?

[17:49]

nelsonko

hmm
yes sure, if you see anything in particular you wonder what's it bat, feel free to ask

[17:51]

jonnyb

particularly with cookie consent enabled - everything just goes round in cirlcles :(
well, using the tiki cookie functions it uses the session "cookie_jar" so it thinks js is enabled
seems there's no particularly clean way of doing it in php

[17:52]

Jyhem

joined #tikiwiki

[17:53]

Tiki-KGB

03jonnybradley r54592 10branches/ 1014.x/lib/multilingual/multilinguallib.php 1014.x/themes/base_files/other/BiDi/BiDi.css
[FIX] BiDi: CSS file moved, also corrected various CSS errors and warnings (filter: FlipH still shows as 4 errors but possibly still needed?)

[18:06]

.... (idle for 16mn)

03jonnybradley r54593 10branches/ 1014.x/lib/multilingual/multilinguallib.php 1014.x/lib/setup/cookies.php
[MOD] cookies: No need to set "rtl" as a cookie any more, it was only being used in the old show/hide columns in Tiki 12 so have removed that redundant code too.
When the feature is reintroduced we can use $prefs['feature_bidi'] to test for this (thanks luciash)

[18:22]

Telesight

joined #tikiwiki

[18:30]

wolfganga

joined #tikiwiki
hello
two things weher i need help / opnions:

[18:30]

jonnyb

hi wolfganga

[18:32]

wolfganga

1.) login / sessions: when a user logs in, but not out (so simply closes the browser) he cannot login anymore. (at least not until session gabrabe collection.)
debbuging the code, i see 2 sessiosn created.
one regular session and one with an CV suffix.
Questions: Are 2 sessions really needed?

[18:33]

jonnyb

yes, apparently

[18:35]

wolfganga

This is the first app doing this (at least that i know)

[18:35]

jonnyb

something to do with "session clash"
curiously i'm also struggling with similar issues (when both cookies and js are disabled, i.e. for bots)

[18:35]

wolfganga

yes
i need to get this fixed
our first customes can no longer login into the brand new system ... ^^^;-(

[18:36]

sol_

joined #tikiwiki

[18:37]

wolfganga

well if this session clash thing is just a way to reduce the risk for session collisions, then i do net see the reason for two sessions.

[18:37]

jonnyb

is this with rememberme enabled?

[18:38]

wolfganga

jonnyb - i saw the comments in the source aout the the session clash thing, but found it not really plausible.
i cannot confirm wether it has to do with remeber me - but could be

[18:38]

jonnyb

i didn't add it, but it sounded possibly useful
i made a fix on it quite recently as sometimes only one of those cookies were getting set (never worked out quite why)

[18:39]

wolfganga

the session id is (not 100% sure) but in the size of an md5 string.
so even 1million tiki user would ran unlikely in a collsion.
ok will llok into it and do not touch those two sessions - but really - it seems to be not necessary and adds complexetity to also the token auth stuff (and maybe other places)
jonnyb so youl already worked on this?

[18:40]

jonnyb

only a minor fix to start the session and recreate the other cookie if one is present

[18:42]

wolfganga

ok
teh prod system has not the latest changes of trunk - will give it a try
the other one: i am optimizing the number of requests.
for teh javascript part:
is it coorect that the only external script sources come from CDN's if configured?
question behind: the current order is Prio A JS, external JS, Prio B JS, late JS

[18:43]

jonnyb

yes, just jquery ones i think (unless you have your own CDN set up)

[18:45]

wolfganga

if external could be moved to position 1, then A,B,Late can be easily combined
so teh CDN should replace the Prio A script anyway (at least partially)?

[18:45]

jonnyb

You haven't "met" Louis Philippe yet have you, i think that extra cookie was one of his additions and generally he knows what he's doing - but maybe enquire on the dev list about it? He's not doing tiki at the moment but i think still reads it

[18:46]

wolfganga

Yes i will ask on the list

jonnyb

that can't log in thing needs more investigation - sounds bad

wolfganga

its a half authorizaed sessions it seems.

jonnyb

can you reproduce it somewhere? demo.tiki.org of a show instance maybe?
maybe the fix for the missing cookie will fix it?

wolfganga

it further seem to be a regular user account (even if in admin group) than as the admi account itself.
yes i think that could be the case - will try
and if it fails open a demo inszacnce or fix it
* was really busy this week and had less time for tiki dev work *

[18:48]

jonnyb

can't really see the admin user would get treated any differently in this regard

it was https://sourceforge.net/p/tikiwiki/code/54342

about a week ago

[18:49]

wolfganga

it just shows up on user accounts that re part of the admin group and also not part of it. did never show up o admin itself.

[18:50]

jonnyb

weird...

[18:50]

wolfganga

was a customer and an internal employee - have seen it at the employee myself.

[18:51]

jonnyb

so re the CDN thing - not sure what you mean by "Prio A" and B?

[18:51]

wolfganga

i mean the order of inclusion (when creating the script tags)
currently it is: Prio A scripts (like jquery lib and the like), externals (which i suppose are CDNS), standard stuf and then late stuff
so 4 priority levels f inclusion (priority should be reaplaced with order prio - maybe)

[18:53]

jonnyb

will have a look - not familiar with "Prio A"

[18:55]

wolfganga

sry for bad wording
tiki_js depends for eample on jquery
thats why jquery is loaded before tiki.js

[18:55]

jonnyb

do you mean files added usign HeaderLib::add_jsfile_dependancy?

[18:56]

wolfganga

so jquery is prio A, weher tiki.js is prio b
Yes
* should have said this at the beginning - sry for that*

[18:56]

jonnyb

no probs

[18:57]

wolfganga

all i want is: load external before the other stuff. (currently some scripts are load 1st = prio a, and then external is loaded)

[18:57]

jonnyb

so if $prefs['javascript_cdn'] those "dependancy" type files should be empty, as far as ones server from local file system, right?

[18:57]

wolfganga

yes

[18:58]

jonnyb

dull, except for codemirror.js :(

[18:58]

wolfganga

icodemirror.js is for what ever reason special (believe its loaded somehow from temp)

[18:59]

jonnyb

hmm, and jquery-migrate
which we should be able to remoce for tiki 15
remove

[18:59]

wolfganga

i *believe* that the cdn stuff would not really work as it is supposed to anyway, because the files load via cdn would not have to beloaded again local.

[19:00]

jonnyb

possibly both of those files should/could load after jquery
sorry, don't follow you

[19:01]

wolfganga

aggree - cdn stuff would be libraries and the like

[19:01]

jonnyb

cdn seems to have always done what it was supposed to afaict

[19:02]

wolfganga

i meant - when i want load jquery lib from a cdn, then i would not want to load it again from the local installation.
but so far it looks like it CDN would just add to "external"

[19:02]

jonnyb

no, exactly, so it would probably be possible to load everything else after jquery & jquery-ui

[19:04]

wolfganga

in this case it would be safe to load external _before_ all othes, wouldn't it?

[19:04]

jonnyb

sorry, without searching for all the various uses i couldn't say - and need to finish something that i shouldn't have even started several hours ago ;)

[19:05]

wolfganga

sry for bothering so long - i'll check and make sure not to break anything.
but - to come t an end: external should be used for CDN's, correct?

[19:06]

jonnyb

i don't know what the difference is really
by the way i see a php error at lib/headerlib.php:371
var $minify_failed_late not set
wasn;t that what you fixed the other day?

[19:07]

wolfganga

yes
for the CDN thing, iexternal means mostliklly CDN - then it should be safe to put it on top of the JS script tags, wouldn't it?

[19:10]

jonnyb

looks to me like external gets loaded after dependancies

[19:10]

wolfganga

yes they do.
and i would like to put "externals" on top (so before "dependancies")

[19:10]

jonnyb

i don't knwo how extranls get added, so can't tell i'm afraid

[19:11]

wolfganga

this way i can combine all other stuff into one file without loosing the ordering
ok no problem
will try it out with cdns and see how externals get populated

[19:12]

jonnyb

ah, i see some in HeaderLib::add_dracula (such crappy js they can't be minified)
definitely not a good thing to load first imho

[19:13]

wolfganga

[19:13]

jonnyb

would be better removed entiely i reckon ;)

[19:14]

wolfganga

i agree
have not see dracula so far - any idea what feature activates it?
another one #894: add_dracula

[19:15]

jonnyb

not off hand sorry

[19:16]

wolfganga

no problem
but seems "external" is beeing abused at some places
so need to keep the order
thanky you jonnyb

[19:17]

Tiki-KGB

03jonnybradley r54594 10branches/14.x/lib/prefs/session.php
[FIX] cookies: Add a mild warning on session_silent pref as it doesn't interact well with cookie consent and js detection

[19:18]

jonnyb

these things happen, welcome to open source! :)

[19:18]

wolfganga

*smiles*
wow - just a few daya off and 40+ commits - you guys are really busy.. ;-)

[19:18]

jonnyb

there's lots fo fix!

[19:22]

Tiki-KGB

03jonnybradley r54595 10branches/14.x/tiki-setup_base.php
[FIX] cookies: PHP session cookies are required for security reasons so are "tolerated" by the ICO "EU Cookie Law", and the tiki_cookie_jar requires the session to be working so start the session even if cookie consent is not yet granted - otherwise nothing works if javascript is disabled or unavailable (like for web crawlers)
03jonnybradley r54596 10branches/14.x/tiki-setup.php * [FIX] cookies: Better handling for cookie consent when javascript is not enabled
03jonnybradley r54597 10branches/14.x/lib/setup/javascript.php
[FIX] javascript: Rework how js detection occurs to work when cookie consent has not been granted

[19:24]

..... (idle for 22mn)

03walper r54598 10(9 files in 7 dirs) * [MRG] Automatic merge, branches/14.x 54589 to 54597

[19:48]

jonnyb

thanks wolfganga - was just about to do a merge (well, soon ;) )

[20:00]

wolfganga

you are welcome
btw: my trunk is broken after update - no JS anymore.
had enabled compress JS
just investigateing what happend

[20:00]

jonnyb

oh really - something to do with my changes?
let me know...

[20:01]

wolfganga

cleaned also template cache and js cache. proble: no JS loaded anylonger (no minified to be precise)
is this maybe a composer thing again?

[20:02]

jonnyb

will svn up
don't think there have been and composer changes recently

[20:04]

wolfganga

[20:04]

jonnyb

all seems fine here
just cleared caches, cookie etc and have js

[20:05]

Tiki-KGB

03lindonb r54599 10branches/ 1014.x/tiki-browse_categories.php 1014.x/tiki-admin_categories.php 1014.x/templates/filter.tpl * iconset conversion

[20:06]

jonnyb

do you get any errors

[20:06]

wolfganga

no errors - mom - just debugging headerlib to see whats going on

[20:06]

jonnyb

i'll try minify js

[20:07]

wolfganga

ok thx

[20:07]

jonnyb

still ok with minify on

[20:08]

Tiki-KGB

03lindonb r54600 10branches/ 1014.x/templates/tiki-browse_categories.tpl 1014.x/templates/tiki-edit_categories.tpl 1014.x/templates/tiki-admin_categories.tpl * [REF] category pages: iconset conversion, bootstrapification and other cleanup

[20:10]

jonnyb

and javascript_cdn, still ok

[20:10]

wolfganga

mhh strange - xdebug triggers on output_css but() not on output_js() ... still looking

[20:10]

jonnyb

seems the javascript_cdn isn't working any more - it's minified it in a local file
was that to do with the changes you made last week maybe?

[20:12]

wolfganga

it should not
like i said externals are stil kept
but i can look into this

[20:12]

jonnyb

yup, inside my minified file it says [0] => //code.jquery.com/jquery-1.11.2.min.js

[20:13]

wolfganga

ups

[20:14]

jonnyb

and when it's set to use code.jquery.com nothing now works
Uncaught Error: Bootstrap's JavaScript requires jQuery (etc)
curious - when using the google on it's still minified "[0] => http://ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js" but it still works...

[20:16]

wolfganga

btw - while you are looking there: the @media print stuff created by less gows into tiki_base.less . This causes that @media print gets overriden by default.css. In headerlib, should @media print better go into the media print array? (headerlib #648 function output_css_files().

[20:22]

jonnyb

hmm, even less idea about that i'm afraid, best ot ask Gary (chibaguy) when he's around

[20:25]

Tiki-KGB

03lindonb r54601 10(8 files in 3 dirs) * [MRG] Automatic merge, branches/14.x 54597 to 54600

[20:28]

Tiki|bot

New Forum Posts: Menu Icons in Tiki 13 (Where are they?) - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=55316
New Forum Posts: New Tiki Video: Upcoming News Tek_Advocates - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55315
New Forum Posts: Modul-Inhalte auf der Wiki-Startseite für Gäste anzeigen lassen - http://suite.tiki.org/tiki-view_forum_thread.php?forumId=10&comments_parentId=55312

[20:33]

wolfganga

Mhh i know why it is not working - still have no idea why this happend: my $prefs['javascript_enabled'] == "n"
have not disabled javascript - at least i do not remeber to have doen this^^

[20:35]

jonnyb

hmm, that does sound like it's related to what i was fiddling with in 14.x

[20:37]

wolfganga

at least good to hear that - feel a bit strange right now ^^

jonnyb

$prefs['javascript_enabled'] is set on the fly to 'n' if js can't be detected - it all happens in setup/javascript.php

wolfganga

ah ok - was looking in sql by: select * from tiki_preferences where name like "%java%"

jonnyb

did you try clearing your browser cookies?

wolfganga

no
only tiki cache
will do it

jonnyb

do you have a cookie called javascript_enabled?

[20:39]

wolfganga

[20:39]

jonnyb

any cookies at all?

[20:40]

wolfganga

have things like categ, categorize, local_tz etc.
and the phpsessid, phpsessidcv

[20:40]

jonnyb

which browser?

[20:41]

wolfganga

chrome current realaese
release

[20:41]

jonnyb

me too - odd
and js is enabled i guess (in the browser)

[20:41]

wolfganga

yes it is - i disabled the check in headerlib and can work now
with js
aha - something new : cookie: runs_before_js_detect
(deletes my sessiosn)

[20:42]

jonnyb

i just deleted my js enabled cookie, and it doesn't try and recreate it

[20:43]

Tiki|bot

New Forum Posts: Menu Icons in Tiki 13 (Where are they?) - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=55316
New Forum Posts: New Tiki Video: Upcoming News Tek_Advocates - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=55315
New Forum Posts: Modul-Inhalte auf der Wiki-Startseite für Gäste anzeigen lassen - http://tiki.org/tiki-view_forum_thread.php?forumId=10&comments_parentId=55312

[20:43]

jonnyb

and it stops js working for me too

[20:43]

wolfganga

mhh - i only have 3 cookies now: both phpsessionid cookies + runs_berfore_js_detect

[20:44]

jonnyb

hmm, sounds like i need to try again on that then - was worried about this
i remember last time this caused problems (and actually didn't really work properly, but assumed js was always enabled)

[20:45]

wolfganga

i see. btw: i could not really imagine tiki 14 will properly run _without_ js though.

[20:47]

jonnyb

if i delte my session cookies everything comes back right

[20:47]

wolfganga

i just cleard my ones - mom

[20:47]

jonnyb

it'll be ugly but it needs to server out the content properly so bots can crawl it

[20:48]

wolfganga

aha - now i also have one : javascript_enabled = y
the initial load (when cookies are deleted) takes quite a while...

[20:49]

jonnyb

ok, that's good - i think we have to assume when people do a major upgrade everyone gets new sessions (somehow)
doesn't seem slow for me, it's not really doing much other than setting a cookie (if js is enabled)

[20:50]

wolfganga

well now it works here as fast as usal again
do not know what happens
ok will look again in the minify thing

[20:52]

lindonb

lindonb just reminded that all plugins have a hard-coded icon path defined

[20:55]

wolfganga

lindenb - arte they not defined via css?

[20:57]

lindonb

no - in every plugin file an icon is defined in the info array :(

jonnyb

hi lindonb - yes, i spotted those today too

lindonb

depressingâ€¦

jonnyb

they still work ok, i'd leave them for 15.x ;)

wolfganga

but isn't that a "bad design"?

jonnyb

who said Tiki is designed?