←Prev date Next date→ Show only urls(Click on time to select a line by its url)
WhoWhatWhen
Bsfezjoined #tikiwiki [00:30]
jonnybjoined #tikiwiki [00:31]
Tiki-KGB03rjsmelo r60401 10trunk/lib/ 10wiki-plugins/wikiplugin_listexecute.php 03core/Search/Action/FileGalleryChangeFilename.php 04core/Search/Action/FileGalleryRename.php
[EHN] Improve the name of the action, from filegal_rename to filegal_change_filename to specificly state that the intention is to change the filename of the file and not to change the name 		[00:40]
......... (idle for 44mn)
Bsfezjoined #tikiwiki [01:24]
........... (idle for 54mn)
joined #tikiwiki [02:18]
janasullinger_joined #tikiwiki [02:31]
......... (idle for 41mn)
Bsfezjoined #tikiwiki [03:12]
............ (idle for 55mn)
joined #tikiwiki [04:07]
Tiki-KGB03chibaguy r60402 10trunk/templates/ 10layouts/social/layout_view.tpl 10layouts/fixed_top_modules/layout_view.tpl 10layouts/classic/layout_view.tpl
[FIX] Copy code for show hide left and right module zones from Basic layout template to the others, except for the wider side columns layout. CSS still needs to be extended for it. 		[04:20]
.... (idle for 18mn)
03pom2ter r60403 10trunk/themes/ 10(37 files in 37 dirs)
[FIX] remove z-index from the edit menu contextual icons and make them appear on hover 		[04:38]
03pom2ter r60404 10branches/16.x/themes/ 10(36 files in 36 dirs)
[bp/r60403] [FIX] remove z-index from the edit menu contextual icons and make them appear on hover 		[04:46]
03chibaguy r60405 10branches/16.x/ 10templates/layouts/fixed_top_modules/layout_view.tpl 10templates/layouts/social/layout_view.tpl 10templates/layouts/classic/layout_view.tpl
[MRG][FIX] Copy code for show hide left and right module zones from Basic layout template to the others, except for the wider side columns layout. CSS still needs to be extended for this layout (from r60402). 		[04:56]
Bsfezjoined #tikiwiki [05:01]
jonnybjoined #tikiwiki [05:15]
.... (idle for 16mn)
NoteOnjoined #tikiwiki [05:31]
Bsfezjoined #tikiwiki [05:39]
......... (idle for 43mn)
Jyhemjoined #tikiwiki [06:22]
..... (idle for 24mn)
Tiki-KGB03chibaguy r60406 10branches/16.x/themes/ 10base_files/iconsets/glyphicons.php 10base_files/iconsets/legacy.php
[FIX] Specify glyphicon and legacy icons for side column toggle left and right. Todo: fix functionality of legacy icons - each toggle works only once per page refresh.
03chibaguy r60407 10trunk/themes/base_files/iconsets/glyphicons.php 10trunk/themes/base_files/iconsets/legacy.php 10trunk
[MRG][FIX] Specify glyphicon and legacy icons for side column toggle left and right. Todo: fix functionality of legacy icons - each toggle works only once per page refresh. [from revision 60406, branch 16] 		[06:46]
.............. (idle for 1h8mn)
03chibaguy r60408 10branches/16.x/ 10templates 10templates/layouts/header_middle_footer_containers_3-6-3/layout_view.tpl 10themes/base_files/less/tiki-bootstrap_overrides.less
[FIX] Copy code for show hide left and right module zones from Basic layout template to this wider side columns layout; extend CSS to cover these column widths. 		[07:58]
nelsonkoleft #tikiwiki [08:02]
Tiki-KGB03kroky6 r60409 10branches/ 10(24 files in 18 dirs) * Combined backport of core permission system updates (thanks nkoth)
03chibaguy r60410 10branches/16.x/themes/base_files/css/tiki_base.css
[FIX] Copy code for show hide left and right module zones from Basic layout template to this wider side columns layout; extend CSS to cover these column widths. 		[08:06]
03chibaguy r60411 10trunk/templates 10trunk/themes/base_files/less/tiki-bootstrap_overrides.less 10trunk/templates/layouts/header_middle_footer_containers_3-6-3/layout_view.tpl 10trunk
[MRG][FIX]
[FIX] Copy code for show hide left and right module zones from Basic layout template to this wider side columns layout; extend CSS to cover these column widths [from revisions 60408 and 60408]. 		[08:18]
03chibaguy r60412 10trunk/themes/base_files/css/tiki_base.css
[MRG][FIX] Copy code for show hide left and right module zones from Basic layout template to this wider side columns layout; extend CSS to cover these column widths [from revisions 60408 and 60408]. 		[08:30]
chibaguyjoined #tikiwiki [08:39]
...... (idle for 29mn)
polom [09:08]
......... (idle for 44mn)
Bsfezjoined #tikiwiki [09:52]
redflojoined #tikiwiki [09:57]
....... (idle for 33mn)
Tiki-KGB03montefuscolo r60413 10trunk/lib/wiki-plugins/wikiplugin_mouseover.php * [ENH] change cursor icon for elements without url in mouseover plugin [10:30]
.... (idle for 16mn)
03kroky6 r60414 10trunk/lib/ 10core/Tracker/Field/ItemLink.php 10trackers/trackerlib.php
[FIX] ItemLink fix to display ItemsList fields by providing enough context to field_render_value
03kroky6 r60415 10trunk/ 10lib/core/Tracker/Field/ItemsList.php 10lib/core/Services/Tracker/Controller.php 04tiki-tracker_http_request_itemslist.php
[FIX] ItemsList cleanup: move ajax call to tracker services, simplify rendering, make input use output directly for ItemLink field and through ajax for any other matched field (effectively fix input rendering) 		[10:46]
03kroky6 r60416 10branches/ 1016.x/lib/core/Tracker/Field/ItemLink.php 1016.x/lib/trackers/trackerlib.php 1016.x
[bp/60414] [FIX] ItemLink fix to display ItemsList fields by providing enough context to field_render_value
03kroky6 r60417 10branches/ 0416.x/tiki-tracker_http_request_itemslist.php 1016.x/lib/core/Tracker/Field/ItemsList.php 1016.x/lib/core/Services/Tracker/Controller.php 1016.x
[bp/60415] [FIX] ItemsList cleanup: move ajax call to tracker services, simplify rendering, make input use output directly for ItemLink field and through ajax for any other matched field (effectively fix input rendering) 		[10:56]
03kroky6 r60418 10branches/ 1015.x/lib/trackers/trackerlib.php 1015.x/lib/core/Tracker/Field/ItemLink.php 1015.x
[bp/60414] [FIX] ItemLink fix to display ItemsList fields by providing enough context to field_render_value
03kroky6 r60419 10branches/ 1015.x/lib/core/Services/Tracker/Controller.php 0415.x/tiki-tracker_http_request_itemslist.php 1015.x 1015.x/lib/core/Tracker/Field/ItemsList.php
[bp/60415] [FIX] ItemsList cleanup: move ajax call to tracker services, simplify rendering, make input use output directly for ItemLink field and through ajax for any other matched field (effectively fix input rendering) 		[11:04]
......... (idle for 42mn)
xavijoined #tikiwiki [11:48]
............. (idle for 1h4mn)
Tiki-KGB03chibaguy r60420 10branches/16.x/ 10(54 files in 54 dirs) * [FIX] Correct spelling error. [12:52]
03chibaguy r60421 10(55 files in 55 dirs) * [FIX][MRG] Correct spelling error (from revision 60420, branch 16).
03kroky6 r60422 10trunk/lib/wiki-plugins/wikiplugin_trackerlist.php
[FIX] usage of multiple plugin trackerlists with different checkbox settings on one page
03kroky6 r60423 10trunk/lib/core/Tracker/Field/ItemLink.php
[FIX] ItemLink table display checkbox not required option automatically checks all preselected items to allow displaying them in view mode
03kroky6 r60424 10branches/16.x/lib/wiki-plugins/wikiplugin_trackerlist.php
[bp/60422] [FIX] usage of multiple plugin trackerlists with different checkbox settings on one page
03kroky6 r60425 10branches/ 1015.x/lib/wiki-plugins/wikiplugin_trackerlist.php 1015.x
[bp/60422] [FIX] usage of multiple plugin trackerlists with different checkbox settings on one page 		[13:06]
03xavidp r60426 10branches/16.x/lib/core/Tracker/Field/GroupSelector.php
[bp/r60369][FIX] GroupSelector tracker field list only groups user is member of. thanks kroky6
03xavidp r60427 10branches/16.x/lib/core/Tracker/Field/GroupSelector.php
[FIX]Allow full site admins to select any group of users to be notified (like in group watches) 		[13:18]
olinuxxjoined #tikiwiki [13:34]
.... (idle for 19mn)
Jyhem_laptopjoined #tikiwiki [13:53]
...... (idle for 25mn)
nelsonkojoined #tikiwiki [14:18]
.... (idle for 16mn)
Jyhem_laptoppolom [14:34]
jonnybhi Jyhem_laptop [14:34]
Jyhem_laptophi jonnyb, are you convinced by that archiavl/listexecute/renaming thing? It looks like bad design to me but I always wonder if I actually understood what it does [14:37]
jonnybi must say i didn't fully understand it either, but Ricardo is a good coder and he understood our qualms (and i tested renaming a file in a gallery and it keeps the filename as it was, so all's well i think) [14:39]
Jyhem_laptopYes, I get the feeling it changes nothing until one uses listexecute. That's a big elief
*relief
But the scenario Xavi described makes it look like he took shortcuts and does not really have an understanding of how Tiki works for users 		[14:44]
nelsonkojonnyb, Jyhem_laptop - it's a new feature (an action for ListExecute) so it is sound, but somehow I feel like the action could have a better name than FileGalleryRename (I know it means something more like FileGalleryBulkFileRenamingOfNameAndOrFileName but that is too long) [14:47]
xavi:-)
hi all
he renamed the action recently 		[14:47]
jonnybhi nelsonko, thanks :) [14:47]
nelsonkogot to run.
sorry can't stay :( 		[14:47]
Jyhem_laptopMeaning, they design an archiving system which modifies the site's contents as well as archiving, just because they want to use the current archiving tool which is too limited [14:47]
xavifilegal_change_filename [14:47]
nelsonkoleft #tikiwiki [14:48]
Jyhem_laptopI'm concerned we discuss how to write nice code instead of making the code match users expectations
«And if you want th e source file, you can download the source version of that file.» sounds like making users jump through extra loops just to keep the code nice and short. 		[14:49]
xaviJyhem, discussion if you want during the next trm?
I mean the additions from ricardo allow a different use case, which is not the default, and in which users will not want the source file but the renamed
which also includes the name of the former filename at the end, plus extra meaningful info. And that will happen only for the file galleries where the site admin did setup a listexecute plugni to make changes, etc.
everything is fine as far as user expectations are
maybe you didn't still understand the use case, and it can be easily explain (or discussed) into even more detail in the next trm, if needed?
xavi back to finishing other urgent stuff for today 		[14:52]
Jyhem_laptopThe way I understand it, if you archive again next month, the file names get huge because they have last month's name as the new filename
I can wait for the next trm but can Ricardo ? 		[14:56]
Tiki-KGB03jonnybradley r60428 10trunk/themes/base_files/less/tiki-selectors.less 10trunk/themes/base_files/css/tiki_base.css 10trunk/themes/base_files/less/tiki-bootstrap_overrides.less 10trunk
[MRG] Automatic merge, branches/16.x 60397 to 60427
Conflict fixed manually in themes/base_files/less/tiki-selectors.less
Please read https://dev.tiki.org/Where+to+commit and https://dev.tiki.org/Semi-automatic+merging+period 		[14:58]
nelsonkojoined #tikiwiki [14:58]
xavi@ Jyhem_laptop: "the file names get huge because they have last month's name as the new filename" - well, that would be the effects of a bad design with listexecute. But this is up to the sit admin to configure the renaming only when needed, with some status field that changes when renamed, so files are not renamed again, if that is the desired action (like what we do).
so I still don't see the problem in his code at all, nor in tiki user expectations
of course, user expectations can be bad is there is bad design. Like if you set up a cron job to delete all tracker items each month, etc
fyi, you can get an idea of listexecute if you play with "Execute_on_List" profile, which I made (sponsored by Marc) just for this also, to let other users learn the power of that plugin listexecute developed by lph long ago, and we would all benefit if we know how to use it in some cases when we might needed, etc.
hth
s/might needed/might need it 		[15:02]
Jyhem_laptopJyhem_laptop also wishes to get forward on self projects :-( [15:10]
.................. (idle for 1h26mn)
Bsfezjoined #tikiwiki
joined #tikiwiki 		[16:36]
.... (idle for 15mn)
olinuxxjoined #tikiwiki [16:52]
dickographyjoined #tikiwiki [16:57]
.... (idle for 15mn)
jonnybjoined #tikiwiki [17:12]
Bsfezjoined #tikiwiki [17:18]
arildbjoined #tikiwiki [17:21]
Bsfezjoined #tikiwiki [17:34]
................ (idle for 1h18mn)
Tiki-KGB03jonnybradley r60429 10branches/16.x/lib/userslib.php * [FIX] users: Wrong quotes on string (regression from r40017 :) [18:52]
nelsonkojoined #tikiwiki [19:05]
Telesightjoined #tikiwiki [19:16]
Tiki-KGB03jonnybradley r60430 10branches/16.x/lib/userslib.php
[FIX] users: $bindvars needs the plain value to use in the query, not an array of it 		[19:22]
......... (idle for 42mn)
03jonnybradley r60431 10branches/16.x/lib/jquery_tiki/iconsets.js
[FIX] iconsets: Fix setIcon() behaviour for legacy <img> type iconsets (they were losing the surrounding span when swapped)
Thanks chibaguy 		[20:04]
03jonnybradley r60432 10branches/16.x/tiki-ajax_services.php
[FIX] autocomplete: Don't load the whole userlist when finding matching users for the autocomplete feature but filter by the query string (Thanks Nelson, Pat, Bernard and all)
03jonnybradley r60433 10trunk/lib/userslib.php 10trunk/tiki-ajax_services.php 10trunk/lib/jquery_tiki/iconsets.js 10trunk * [MRG] Automatic merge, branches/16.x 60427 to 60432 		[20:16]
...... (idle for 27mn)
nelsonkojoined #tikiwiki [20:43]
Tiki-KGB03luciash r60434 10branches/16.x/themes/ 10base_files/less/tiki-bootstrap_overrides.less 10base_files/css/tiki_base.css
[FIX] layout: wide layout type was overriding the basic layout values - made it more specific for wide layout so it does not conflict and the column toggling works nicely again (thanks jonny) 		[20:54]
......... (idle for 44mn)
redfloleft #tikiwiki [21:38]
Tiki-KGB03luciash r60435 10branches/16.x/themes/ 10(34 files in 34 dirs) * [FIX] themes: fixed wrong paths to glyphicons for some themes and recompiled all [21:52]
jonnybjoined #tikiwiki [22:03]
←Prev date Next date→ Show only urls(Click on time to select a line by its url)