[00:02] Tiki-KGB 03chealer r62713 10trunk/tiki-view_tracker_item.php * [REF] Optimize [00:35] patrickproulx joined #tikiwiki [02:34] patrickproulx joined #tikiwiki [10:13] Padlock joined #tikiwiki [10:13] Padlock Polom y'all [10:13] Padlock I don't have any question at the moment, thought I'd just pop in to say hi :-) [11:02] jonnyb joined #tikiwiki [11:03] Padlock Polom jonnyb ! [11:12] jonnyb moloq Padlock [11:13] redflo joined #tikiwiki [11:38] Tiki-KGB 03yonixxx r62714 10branches/17.x/templates/admin/include_wiki.tpl [11:38] Tiki-KGB [Fix] The wiki_authors_style_by_page pref setting is not dependant of the wiki_authors_style selection so it shouldn't be hidden if None is selected (you can None global and still change style per page basis). Note that even hidden it was applied anyway. [12:08] Tiki-KGB 03jonnybradley r62715 10branches/17.x/lib/ 10jquery_tiki/tiki-toolbars.js 10jquery_tiki/pluginedit.js [12:08] Tiki-KGB [FIX] toolbars: Move function dialogSelectElement as it is needed in tiki-toolbars.js as well as pluginedit.js (but only when used from a toolbar button) [12:19] amette_ joined #tikiwiki [12:19] amette_ polom [12:20] Tiki-KGB 03jonnybradley r62716 10trunk/lib/jquery_tiki/pluginedit.js 10trunk/lib/jquery_tiki/tiki-toolbars.js 10trunk/templates/admin/include_wiki.tpl 10trunk * [MRG] Automatic merge, branches/17.x 62705 to 62715 [12:20] jonnyb pompom amette_ [12:20] amette_ heyho jonnyb [12:20] jonnyb how are your servers today? ;) [12:21] amette_ behaving for a change ;) [12:21] jonnyb super, any chance of getting the next*.t.o servers on 17.x today? [12:21] amette_ I switched to Tiki 17 yesterday, but some next-refreshes failed for various reasons. Looking into that now. [12:21] amette_ yep, there shouldn't be too weird things left any more [12:21] jonnyb super, realised i should have checked first! :) [12:22] jonnyb nextdev looks good... [12:22] amette_ oh, really!? Then I probably got the last issues figured out yesterday already. [12:22] amette_ doc and themes worked last night already, dev was the last one failing (again) [12:23] jonnyb seems ok now... still no svn revision showing (at first glance) [12:23] amette_ nextthemes looks a bit naked...!? and that one worked nicely all day long yesterday.. *sigh* [12:23] olinuxx joined #tikiwiki [12:23] olinuxx joined #tikiwiki [12:23] jonnyb :O [12:25] jonnyb from the nextdev sylv module it looks like it was last refreshed about 15:00 utc yesterday, does that sound rtight amette_ ? [12:25] amette_ ok, php5-sqlite installed, revision showing again [12:26] jonnyb nice :) [12:26] amette_ yep, I triggered a manual backup run yesterday a bit after 1500 utc and that's the backup that the refresh-nxt.sh script used. [12:26] jonnyb see what you mean about https://nextthemes.tiki.org [12:27] amette_ automatic backups happen at 0400 though - just as info for the future [12:27] amette_ no automated full refresh yet, that's why the data is from yesterday 1500 [12:28] jonnyb ok, super duper, thanks bigly! :) [12:29] amette_ you're welcome. I'll have a look at nextthemes and will then reactivate the automagic full refresh. [12:30] jonnyb getting lots of 404's on nextthemes [12:30] jonnyb cache clear maybe? i'll try... [12:30] jonnyb hmmm, WSoD on https://quality.tiki.org/tiki-login.php [12:31] jonnyb when logging in on https://nextthemes.tiki.org/Themes [12:31] jonnyb huh? [12:31] amette_ nice [12:32] jonnyb hmm, well something worked - i went to https://nextthemes.tiki.org/login and got the "problem detecting javascript" and it reloaded and now looks ok for me [12:32] * amette_ scratches his head [12:32] jonnyb i probably had some ancient cookies in my browser... [12:32] jonnyb clearing caches now [12:32] amette_ same here [12:33] jonnyb :D [12:33] jonnyb they'll be extra clean now! [12:33] amette_ virtually shiny! [12:33] amette_ But yeah, nextthemes works now. [12:33] jonnyb now looks fine as anon and logged in [12:34] amette_ ok, I don't understand how it could break "over night", but as long as it works, I'm fine with it. [12:34] jonnyb nice result, many thanks amette_ (now need to do some client work before the US wakes up properly ;) ) [12:35] amette_ hehe, yep, good point. Happy productivity, mate! [13:18] luciash polom [13:19] jonnyb polom luciash [13:19] amette_ hey ho bro [13:20] jonnyb luciash: did you see? amette_ fixed the next*** servers, woo hoo! [13:20] luciash hey jonny and amette! [13:20] luciash jonnyb: w00t! [13:20] luciash amette_: congrats :) [13:20] amette_ :) [13:23] jonnyb :D [13:27] amette_ one more refresh of next sites coming up. this time from cron. If this goes well, I'm satisfied and will write an e-mail to inform people. [13:29] * jonnyb crosses fingers (for the next sites refresh) [13:45] jonnyb amette_: just using nextdoc a bit and thought i should check the elastic index settings and that is also using the same docto_new_ prefix as doc.t.o, shouldn't that be being changed by (magic) somehow to avoid conflicts? [13:46] jonnyb Same for the federated search / extrernal wikis on nextdev i guess, but not sure how you could change them as they're not prefs afaik [13:46] amette_ jonnyb : yes, those are being changed by tiki.ini, which is not being reflected in the admin panels. [13:47] jonnyb oh, shouldn't it be? is that a bug? [13:47] amette_ preferences set in tiki.ini are: unified_elastic_index_prefix, error_reporting_adminonly and error_reporting_level [13:47] amette_ yes, I consider this a bug [13:48] amette_ it should be reflected and greyed out, not possible to change. In an ideal world, it has a tooltip or something to explain why this is so. [13:48] amette_ Actually should be possible to change... but clearly marked, that it won't do anything. [13:48] luciash sounds like regression - they were greyed out or not displayed at all afaicr [13:48] jonnyb yes, they should also be hidden unles you have the unnavailable prefs showing on your filter [13:49] * jonnyb sighs, and wishes he hadn't mentioned it ;) [13:50] amette_ ;) [13:50] amette_ unavailable pref is a good idea !! [13:52] Tiki-KGB 03kroky6 r62717 10branches/17.x/lib/wiki-plugins/wikiplugin_customsearch.php [13:52] Tiki-KGB [FIX] bug introduced by 56741 refactoring - autosearchdelay is now zero and not missing by default which requires a change in its application logic [13:52] Tiki-KGB 03kroky6 r62718 10branches/ 1016.x/lib/wiki-plugins/wikiplugin_customsearch.php 1016.x [13:52] Tiki-KGB [bp/62717] [FIX] bug introduced by 56741 refactoring - autosearchdelay is now zero and not missing by default which requires a change in its application logic [13:52] Tiki-KGB 03kroky6 r62719 10branches/ 1015.x 1015.x/lib/wiki-plugins/wikiplugin_customsearch.php [13:52] Tiki-KGB [bp/62717] [FIX] bug introduced by 56741 refactoring - autosearchdelay is now zero and not missing by default which requires a change in its application logic [13:54] Tiki-KGB 03kroky6 r62720 10trunk/lib/wiki-plugins/wikiplugin_customsearch.php 10trunk * [MRG] Automatic merge, branches/17.x 62715 to 62717 [14:01] chibaguy joined #tikiwiki [14:02] chibaguy polom [14:02] jonnyb moqmoq chibaguy [14:02] jonnyb look what amette_ fixed for us! https://nextthemes.tiki.org [14:03] amette_ heya chibaguy [14:04] chibaguy cool. [14:04] chibaguy hi amette and jonnyb (and all) [14:04] chibaguy er, he amette_ [14:04] chibaguy (one more time: hi, amette_ ) [14:04] amette_ hehe, hi ;) [14:11] chibaguy I figured I'd have to release Tiki 17 versions of the aftermarket themes listed there. I think not so major changes, but just to catch up on details. [14:12] chibaguy and bug fixes in the themes themselves here and there. [14:30] jonnyb joined #tikiwiki [14:31] jonnyb chibaguy: did you fix stuff on nextthemes? Cos the database wil be overwritten tomorrow (i guess you know that but just wanted to check ;) ) [14:31] jonnyb need to feed now, bbl [14:31] chibaguy No, I didn't do anything on nextthemes. [14:31] jonnyb super, just checking :P [14:32] chibaguy thanks [15:08] nelsonko joined #tikiwiki [15:20] jonnyb joined #tikiwiki [15:20] patrickproulx joined #tikiwiki [15:22] jonnyb rere [15:24] Tiki-KGB 03kroky6 r62721 10trunk/lib/core/Tracker/Field/JsCalendar.php * [ENH] add notBefore/notAfter validations to JsCalendar field [15:25] luciash erer [15:27] luciash jonnyb: when you say "Thanks Luci, i see it now" in the bug comment, does it mean you see the issue reproduced or you see the culprit in the code? ;) [15:28] jonnyb hi luciash - sorry, i just see the bug now, as you say it doesn't happen with jquery upload enabled, so i hadn't managed to reproduce it before [15:29] jonnyb it's in the "stack" (sort of, all in my head actually, so remind me when i forget ;) ) [15:38] luciash np, just wanted to know the status of "I see it" ;) [15:38] jonnyb :) [15:39] luciash actually it happens with jQuery upload enabled too, but fails in Trackers only [15:40] luciash not in regular File Gallery upload [16:10] amette_ bbl [16:30] nelsonko joined #tikiwiki [16:42] Tiki-KGB 03jonnybradley r62722 10branches/17.x/lib/ 10prefs/global.php 10tikilib.php [16:42] Tiki-KGB [FIX] registration: Fix function validate_email, which had a missing parameter, and it was only doing the most basic test on the email (effectively testing for not empty). [16:42] Tiki-KGB \I found an extra "useDeepMxCheck" mode which i have implemented as a new option for the validateEmail pref, just in case, and also corrected the pref description. [16:42] Tiki-KGB Will be tested on tiki.org once backported [16:52] Tiki-KGB 03jonnybradley r62723 10branches/17.x/db * [SVN] Ignore ini files in db [16:55] jonnyb amette_: back yet? [17:01] amette_ re [17:01] amette_ jonnyb : just arrived [17:01] jonnyb aha, polom amette_ [17:01] amette_ moloq jonnyb [17:01] jonnyb was just starting an email... [17:02] jonnyb I did some tests and the ini file force of pref values seems to work fine here, and it says "Configuration forced by host." [17:02] jonnyb on 17.x that is [17:02] amette_ right.... [17:02] amette_ ... so... it's not working on the next sites? [17:03] jonnyb just rechecking... [17:03] jonnyb there should be one for the search index prefix and probably the cookie name too, right? [17:03] amette_ cookie name, yeah, maybe, but not necessary [17:04] jonnyb well it doesn't seem to rememberme ;) [17:04] amette_ oh!? :O [17:04] amette_ well, sure, just tell me what to add [17:05] amette_ There is "$system_configuration_file = 'db/tiki.ini';" in db/local.php. [17:05] jonnyb ok, so you have a nexttiki.ini file somewhere and have set... exacto [17:05] jonnyb and the content of tiki.ini is something like "preference.feature_dummy=This a forced value of this preference." [17:05] jonnyb (my test here) [17:06] amette_ and in db/tiki.ini there is a section "[nextdoc.tiki.org]" and then exactly what you said [17:06] amette_ same on dev [17:06] amette_ aaand: the indexes have been created correctly, I had checked that [17:07] amette_ so it's really 'just' the display in the admin panels [17:07] jonnyb so you have something like preference.unified_elastic_index_prefix=docto_next_ [17:07] amette_ hang on, no, the indexes are not created on the new elasticsearch [17:08] amette_ there is: preference.unified_elastic_index_prefix = "tikinextdev_" [17:09] jonnyb it works for me here without the spaces, i'll try that... [17:09] amette_ shouldn't matter in an .ini file [17:10] jonnyb weird - yes, works perfectly here with spaces and quotes too [17:10] jonnyb meh [17:10] ychaouche joined #tikiwiki [17:10] ychaouche hello #tikiwi [17:10] ychaouche oops tikiwiki [17:10] amette_ ok, I removed the section from the ini file, removed the spaces and removed the quotes... nothing makes it work on nextdev [17:10] amette_ hi ychaouche [17:10] ychaouche what's the best way to add a surfing tracker ? i'd like to add gostats so that I can see who accesses my wiki. [17:11] jonnyb amette_: if you rename the file does it bork the site? for me i get a very ugly fail error when the path is wrong [17:11] amette_ ychaouche : that sounds more like a question for the gostats support [17:12] ychaouche the gostats gave me an html code that I should add to every page on the wiki [17:12] amette_ jonnyb : "Configuration file could not be read." [17:12] ychaouche should I add in every template ? [17:12] jonnyb ok, so we have tghe right file :) [17:12] ychaouche the html code contains javascript that's used to track visitors. [17:12] jonnyb hi ychaouche [17:12] ychaouche hello jonnyb [17:12] jonnyb add the html in the custom head pref on look and feel admin, on the customisation tab (in advanced mode) [17:13] jonnyb but be careful! [17:13] amette_ ychaouche : then you could use the custom HTML head pref [17:13] amette_ ychaouche : listen to jonnyb ! [17:13] amette_ ;) [17:13] ychaouche be careful of ? [17:13] * ychaouche searches agian in look and feel [17:14] jonnyb you probably need to surround it with {literal}html bla blal{/literal} if it contains and curly brackets or other chars smarty doesn't like [17:14] ychaouche Ah customisation, overlooked it in first time [17:14] ychaouche at first tiem [17:14] ychaouche time * sigh [17:14] jonnyb easlily done! [17:14] ychaouche oh [17:16] jonnyb do you have access to the database? [17:16] jonnyb because if you get it wrong you might need that as it adds whatever you put in there to every page [17:17] ychaouche I do [17:18] jonnyb can't seem to find any good docs for you, this has a little but nothing very useful https://nextdoc.tiki.org/Customization [17:18] jonnyb (log in with next and next) [17:19] amette_ Or just use doc.tiki.org... ;) [17:19] jonnyb no no, we need testing on the next sites! :D [17:20] amette_ right, sorry, don't listen to me! :P [17:23] jonnyb you worked so hard to get then running, so the more eyeballs on them the better, surely! :) [17:23] jonnyb anyway, thought i'd clear caches on nextdev and got a timeout... did i break it? :P [17:24] amette_ dunno... would be quite some breakage... *g* [17:25] amette_ ... but it's quite a slow machine, so I wouldn't be surprised... though clearing caches shouldn't take that long, right!? [17:25] amette_ did it from cli [17:27] ychaouche It's weired, I can see the javascript there, but the function isn't run [17:27] jonnyb thanks amette_ [17:28] amette_ ychaouche : tried the {literal}your js here{/literal} ? [17:28] jonnyb ychaouche: where did you paste the html? [17:28] ychaouche yep surrounded it with {literal} {/literal} [17:29] ychaouche I did two things : first I've added the HTML before body [17:29] ychaouche I could see my javascript it was added but for some reason the functions defined in the javascript aren't available in firebug [17:29] ychaouche the javascript console for firefox [17:29] ychaouche the gostats counter didn't appear [17:29] jonnyb no js errors? [17:30] ychaouche the console is clean [17:30] jonnyb is this a public site? i could take a look (pm or start the message with [off] if you don't want iot logged here) [17:32] jonnyb amette_: most peculiar, i can't get the ini file pref thing not to work here - even checked the fivealivelite theme just in case... any other ideas? [17:32] amette_ well, it's broken [17:32] amette_ it doesn't seem to work on next either [17:32] ychaouche unfortunately it is not, but if you are familiar with html javascript I could show you a paste of the output HTML ? [17:32] amette_ but why doesn't it work at yours...!? I thought you said earlier it worked...!? [17:33] amette_ ‎[17:01:59] ‎jonnyb‎: I did some tests and the ini file force of pref values seems to work fine here, and it says "Configuration forced by host." [17:33] jonnyb ychaouche: sometimes people put html in the custom javascript pref, and vice versa, which won't work but will appear in the page source [17:33] amette_ ah, you can't get it _not_ to work [17:33] amette_ that was not a typo, that was just being logical [17:33] ychaouche https://gist.githubusercontent.com/ychaouche/bb8a65b9e9e4c1756854fa01c399c10b/raw/b85f2e665629acb5cb6cc944a801d8238bad8a57/gistfile1.txt [17:33] jonnyb it does work here amette_ - i can't get it to __not__ work ;) [17:34] amette_ jonnyb : right, got you ;) [17:35] ychaouche is the javascript ignored if it's put inside a CDATA ? [17:36] jonnyb no, that's normla [17:36] jonnyb normal [17:36] ychaouche now since I have the same problem on a local page I need to sort this out locally first [17:36] jonnyb i see the {literal} tags in there, you don't need {literal} for javascript, but i'm surprised that's not causing a parse error... [17:37] jonnyb that;'s a H of a lot of js by the look of it. Tiki prefs are limited to [17:37] jonnyb oops [17:38] jonnyb was just going to check what they're limited to... but you might be better adding it as a custom.js file in your themes dir and tiki will automagically pick it up and include it (and minify it if you want) [17:38] ychaouche the original js was a just a src to the file on gostats server, as it didn't work I thought I'd dl it from gostats and put the source directly in there. [17:39] ychaouche it's a dirty hack just to debug the thing then put back the src="gostats/custom.js" back [17:39] jonnyb you could just add a