[01:42] fabricius joined #tikiwiki [02:13] fabricius joined #tikiwiki [03:08] fabricius joined #tikiwiki [03:14] fabricius joined #tikiwiki [03:25] fabricius joined #tikiwiki [04:01] fabricius joined #tikiwiki [07:42] gour joined #tikiwiki [07:52] gour_ joined #tikiwiki [09:35] robertokir joined #tikiwiki [10:05] jonnyb joined #tikiwiki [10:33] xavi joined #tikiwiki [10:34] xavi polom [10:34] xavi any bs4 css guru around? (such as luciash ? :-) ) [10:35] * xavi willing to fix once and for all the ugly display of the (currently named) "Upgrade Wizard" in 19.x [10:37] luciash polom! [10:37] luciash hola xavi [10:38] xavi hi luciash [10:38] xavi I need some guidance on what needs to be done to fix the display of the upgrade wizard in 19.x [10:39] luciash xavi: one hint for you might be that in bs4 the div class="row" is mandatory now to avoid wrapping of the col-m-X children [10:39] xavi example of page with wrong display: tiki-wizard_admin.php?&stepNr=12&url=index.php&use-upgrade-wizard=1 [10:40] xavi ok, thanks luciash , I'll have a quick look to the tpl, to see if I can get my head around that [10:40] luciash do you have a link or should I try on my own? [10:40] xavi link: tiki-wizard_admin.php?&stepNr=12&url=index.php&use-upgrade-wizard=1 [10:41] xavi you need admin perms, etc. [10:41] luciash I bet you just need to add a wrapper div class="row" around the col-md-X divs [10:41] xavi oups, we seem to lack also 19.x and trunk here: http://demo.tiki.org/ [10:42] luciash xavi: if that is not already there [10:45] luciash I have my own demo site, let me check that quicky quick [10:48] luciash ok, I guess the div class="media" is missing something [10:49] luciash making it div class="media row" already improves the following page content layout a lot [10:50] luciash but I do not understand in the first plae, why is that header with icon floated left in media class? [10:50] luciash s/plae/place/ [10:50] xavi mmm [10:53] xavi you can see it here for comparison: https://demo.tiki.org/18x/tiki-wizard_admin.php?&stepNr=11&url=index.php&use-upgrade-wizard=1 [10:53] xavi maybe you mean the two icons floated there, associated with each wizard [10:53] luciash yes [10:57] xavi someone added
to surround them , in the profiles wizard [10:57] xavi I'll start trying that (surrounding them with the description line) [10:58] luciash mr-4 means margin-right: 4something [11:06] luciash I think the two icons (because they are two and not one) should be wrapped in a div or something actually [11:07] luciash the example on https://getbootstrap.com/docs/4.1/layout/media-object/ shows only single image assigned next to the media-body [11:08] luciash if we need to use this media object class [11:08] luciash interestingly on the other wizard pages it seems to work just fine [11:08] luciash anyway, adding the row class worked for me [11:10] luciash Can we rename it to the "What's New Wizard" still? [11:12] xavi yes, sure! (but afair, only suggested for Tiki 20+, since tiki 19 was to be released when I last suggested it, etc) [11:13] luciash ok [11:19] luciash bbl [11:33] jonnyb pompom [11:54] luciash re [11:54] luciash hi jonnyb [12:03] gour joined #tikiwiki [12:13] xavi luciash: I run out of time. I'll commit the same fix as in the profiles and admin wizard: icons surrounded by div class="mr-4">, and text moved to within
[12:13] xavi hopefully today (entering a meeting now) [12:13] xavi bbl [12:17] luciash xavi: cool, yes, I noticed the text is in deifferent place too [12:48] Caarrie joined #tikiwiki [14:19] Tiki|bot Recent Bug: - http://dev.tiki.org/item6951-Access-to-load-Google-fonts-fails [14:55] fabricius joined #tikiwiki [16:10] ricks99 joined #tikiwiki [17:19] Tiki|bot Recent Bug: - http://dev.tiki.org/item6952-ListPages-Plugin-Category-Filter-Limited-to-One [18:40] jonnyb joined #tikiwiki