[00:57]  jonnyb joined #tikiwiki
[03:29] trebmuh luciash, ping
[03:30] trebmuh I've svn checkout the branches/19.x
[03:30] trebmuh and I see a difference between the line in trunk and the line in 19.x
[03:30] trebmuh in trunk, it is : $item->setLink($URLPrefix.$data['sefurl']);
[03:30] trebmuh in 19.x it is : $item->setLink($URLPrefix . $data['sefurl']);
[03:31] trebmuh what should I commit here ?
[03:31] trebmuh 1) $item->setLink($URLPrefix.urlencode($data['sefurl']));
[03:31] trebmuh 2) $item->setLink($URLPrefix . urlencode($data['sefurl']));
[03:31] trebmuh ?
[03:33] trebmuh oh no, I'm wrong
[03:33] trebmuh it is the same in trunk and in 19.x
[03:33] trebmuh that's on my install (12.10) which there is no space character
[03:34] trebmuh still, I'm unsure what to commit
[03:34] trebmuh 1) $item->setLink($URLPrefix.urlencode($data['sefurl']));
[03:34] trebmuh or
[03:34] trebmuh 2) $item->setLink($URLPrefix . urlencode($data['sefurl']));
[03:34] trebmuh ?
[03:34] trebmuh I'd guess for 2), but I would appreciate a confirmation before breaking everything :)
[08:50]  fabricius joined #tikiwiki
[08:51]  fabricius joined #tikiwiki
[09:03]  fabricius joined #tikiwiki
[09:48] Jyhem Hi trebmuh. Your guess of 2) is correct
[09:50] Jyhem Both lines do the same anyway. It's just a matter of following our PHP style guide/syntax rules. Nothing would break with 1)
[10:02]  qwebirc1016958 joined #tikiwiki
[10:06]  qwebirc1016958 left #tikiwiki
[10:26]  fabricius joined #tikiwiki
[10:28]  jonnyb joined #tikiwiki
[11:36]  robertokir joined #tikiwiki
[11:40] jonnyb polom
[12:00] robertokir moloq!
[13:22] luciash pompom
[14:24] Jyhem pompompom
[14:42] trebmuh Jyhem, ok, thank you
[15:10] trebmuh ok, I've pushed to 19.x : https://sourceforge.net/p/tikiwiki/code/68543/
[15:10] trebmuh please, knowledgeable people, let me know if something is wrong there
[15:10] trebmuh I'm on the way to backport to 18.x and 15.x too
[15:25] luciash trebmuh: thank you, your change looks good to me
[15:26] * luciash just wonders why we have setLink and then setlink in the next elseif
[15:28] trebmuh backport done to 18.x : https://sourceforge.net/p/tikiwiki/code/68544/
[15:39] trebmuh backport done to 15.x : https://sourceforge.net/p/tikiwiki/code/68545/
[15:46]  fabricius joined #tikiwiki
[15:50] trebmuh and a backport done to 12.x : https://sourceforge.net/p/tikiwiki/code/68545/
[15:50] trebmuh (I know that 12.x is EOL but anyway, the patch is now there for 12.x users if needed)
[15:51] trebmuh luciash, Jyhem and all, I think I'm all good for this fix now, let me know if something else is needed
[15:51] trebmuh thank you for you help, for your support, and for Tiki!
[15:54] trebmuh BTW, don't I need to make the fix goes to trunk as well ?
[16:09] Jyhem trebmuh: you are welcome. Thank you for contributing.
[16:10] Jyhem no, the fix does not go to trunk as we are still in a semi-auto 19⇔trunk synchronisation phase
[16:10] Jyhem so it will be merged some time
[16:14] luciash Jyhem: do you see the setLink and setlink suspicious too?
[16:27] Jyhem Hi luciash. I did not notice, and I'm in the the middle of putting som improvements in production right now
[17:38]  jonnyb joined #tikiwiki
[18:05]  jonnyb joined #tikiwiki
[19:02]  robertokir joined #tikiwiki
[23:06]  jonnyb joined #tikiwiki
[23:32]  fabricius joined #tikiwiki
[23:37]  fabricius1 joined #tikiwiki