[07:34] Tiki|bot Recent Bug:  - My first post of the day in the Tiki forum is never saved - http://dev.tiki.org/item7003-My-first-post-of-the-day-in-the-Tiki-forum-is-never-saved
[08:00]  fabricius joined #tikiwiki
[08:46]  jonnyb joined #tikiwiki
[09:03]  josephzitt joined #tikiwiki
[10:22] luciash jonnyb: hi, good morning!
[10:24] jonnyb polom luciash
[10:26] luciash jonnyb: was trying to debug H5P yesterday and found out some differences in the old .h5p and current .h5p files
[10:29] luciash jonnyb: for example in the simple accordion, currently there is "language":"und" and "license":"U" crap when I download the file from their examples on the site -- is it rendered? by my browser wrongly? old h5p accordion file I had stored somewhere still works nicely when I upload it to Tiki 17/18/19 but these freshly downloaded ones yell just errors on me :(
[10:30] jonnyb sry, later
[10:31] luciash so far I noticed in the old one there was "language":"en" and no "license" entry in the h5p.json file included in the h5p zip
[10:32] luciash but it still doesn't work if I edit and repackage and reupload the file -- it is not giving the errors but is not recognized as h5p lib file anyway
[11:25]  jonnyb joined #tikiwiki
[11:25] jonnyb repolom
[11:27] jonnyb sorry luciash, yes, it looks like H5P have broken backwards compatibility - i'll try and upgrade our version in 19.x but as that was slightly broken before i'm not too hopeful it'll fix everything...
[12:27] luciash jonnyb: thank you! what version do we use? and is there any way to get the old format h5p content files still omehow?
[12:27] luciash s/omehow
[12:27] jonnyb we're on 1.17 and the latest is 1.19 (and 1.18 for the editor)
[12:28] jonnyb No idea about older files, sorry
[12:50] jonnyb ok, i just committed updates for the h5p libraries in 19.x luciash, can you see if that helps with the newer files? Seems to work for me
[13:00] luciash jonnyb: yay, going to update and test right away!
[13:00] jonnyb thanks luciash
[13:07] luciash re-uploaded the agamotto, it appears in the create h5p dropdown now, yay, but...
[13:07] luciash it seems to be stuck on "Loading, please wait..." when I choose it
[13:07] luciash will try another h5p content type
[13:10] * luciash trying chart
[13:11] luciash this look promising: "Success: Added 2 new H5P libraries."
[13:12] luciash darn, again "Loading, please wait..." :(
[13:13] luciash console gives uncaught syntax error
[13:13] luciash browser conole
[13:13] luciash jonnyb: "Uncaught SyntaxError: Invalid regular expression flags at eval (<anonymous>) at Object.ns.libraryRequested (h5peditor.js?ver=19.1svn:78)"
[13:13] luciash at Object.success (h5peditor.js?ver=19.1svn:137)
[13:13] luciash at c (jquery.js?ver=19.1svn:2)
[13:13] luciash at Object.fireWith [as resolveWith] (jquery.js?ver=19.1svn:2)
[13:13] luciash at k (jquery.js?ver=19.1svn:4)
[13:13] luciash at XMLHttpRequest.r (jquery.js?ver=19.1svn:4)
[13:14] jonnyb i've never managed to work out how to debug their code, it just works or it doesn't... let me try some more files...
[13:15] luciash the old format accordion still works though (just for your information) without the JS error
[13:16] luciash jonnyb: thanks, try some which you did not uploaded yet to your file gal
[13:16] jonnyb agamoto seems ok for me
[13:16] jonnyb looks like it hasn't changed - file name still agamotto-80158.h5p
[13:17] jonnyb chart's ok too (doesn't do much though)
[13:18]  ricks99 joined #tikiwiki
[13:19] luciash jonnyb: display works, yes, but create new content?
[13:19] jonnyb coo, even the speech recognition french lesson one works  8)
[13:19] jonnyb Ah no, editing is totally broken
[13:19] jonnyb has been since tiki 16 i think :(
[13:19] luciash old format create or edit works still
[13:20] luciash but these new ones give the JS error I pasted when trying to create
[13:20] jonnyb yes, they changed a load of stuff but couldn't tell me what, i spent hours trying to revese engineer it but failed
[13:21] luciash let me reindex/clear cache/etc. again
[13:21] jonnyb I was focussing on getting uploading and viewing working for Rick mainly
[13:25] luciash is it theirs? the error. or something wrong in our code?
[13:25] luciash fyi: this was in Chrome console
[13:26] luciash I will test in firefox now
[13:28] jonnyb the errors are in their code, but probably caused by our code that initialises the editor which was based on what worked a few (minor) versions ago, think it was 1.15 or 1.16 we started on
[13:28] jonnyb i even read all of their commits to see if i could spot what they had changed but couldn't
[13:29] luciash ah, in Firefox it is a bit different... the "Loading" is not tuck and gets away but in the FF console there is slightly different error message
[13:29] luciash s/tuck/stuck
[13:30] luciash TypeError: metadataSemantics is undefined[Learn More] h5peditor-metadata.js:339:21
[13:30] luciash findField
[13:30] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-metadata.js:339:21
[13:30] luciash MetadataForm
[13:30] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-metadata.js:27:7
[13:30] luciash ns.Form.prototype.processSemantics
[13:30] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-form.js:91:25
[13:30] luciash ns.LibrarySelector.prototype.loadSemantics/<
[13:30] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-library-selector.js:330:7
[13:30] luciash success/<
[13:30] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor.js:181:13
[13:30] luciash ns.libraryRequested/</script.onload
[13:31] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor.js:106:15
[13:31] luciash ...
[13:31] luciash does it ring a bell?
[13:31] luciash ah, sorry, you probably already know this...
[13:32] luciash sorry to hear that even JS guru like you is struggling with H5P code
[13:33] luciash aparently something with metadata semantics according to Firefox :-p
[13:33] jonnyb yes, was looking at the same code, seems metadataSemantics should be stuck on the H5PEditor object, but isn't - probably a clue!
[13:34] luciash jonnyb: interesting that Firefox console is a bit more helpful than Chrome console for debugging
[13:35] jonnyb interesting - i stopped using firefox ages ago as it was so slow (and then they got rid of firebug) - should take another look i guess
[13:48] luciash jonnyb: do you have "show TPL in source" enabled? I am just wondering if that cannot cause some interferrence here for me
[13:48] jonnyb don't think so
[13:48] luciash in this case
[13:48] luciash ok, thanks
[13:49] jonnyb basically they're changed their API but without saying what
[13:49] jonnyb but i have the old WP plugin and the new version so am doing a diff on the main files... (altohugh have to go out, so more later)
[13:51] luciash superb, thanks a lot and see you laterz!
[13:56] jonnyb woo! i think i got it working!
[13:56] jonnyb need to review and will commit when i get back :)
[14:02] luciash w00ty w00t!
[14:02] luciash :)
[14:24]  trebmuh joined #tikiwiki
[14:42] ricks99 @jonnyb still around?
[14:54] luciash hey ricks99 ! :)
[14:55] luciash not anymore, but he will be back ;)
[14:55] ricks99 good morning (afternoon?) luciash
[14:55] ricks99 thx. i'll ping him later. that h5p stuff is for me
[14:56] luciash ricks99: not jut for you ;)
[14:56] luciash s/jut/just/
[14:56] ricks99 true. :)
[14:56] ricks99 all your h5p belong to *me*
[14:57] luciash :D
[15:10]  ricks99 joined #tikiwiki
[15:34]  jonnyb joined #tikiwiki
[15:34] jonnyb moloq
[15:41] jonnyb repolom luciash - try h5p in 19.x with r68753? Seems better here...
[16:41] luciash coolio, will try! need to go out downtown now, will be back later
[17:21]  fabricius joined #tikiwiki
[17:43] luciash re
[18:03]  jonnyb joined #tikiwiki
[18:04] luciash jonnyb: wb!
[18:04] jonnyb :)
[18:04] luciash no luck :( i still get the same error it seems "TypeError: metadataSemantics is undefined"
[18:04] luciash when trying to created/edit
[18:05] jonnyb Have more to coem for h5p, not sure what it will fix but there were lots of new fields in the database tables
[18:05] jonnyb Oh? svn up, caches, composer all updated?
[18:05] luciash you said you got it working, how?
[18:06] luciash yep, did all the updates necessary i believe
[18:06] luciash except index rebuild
[18:06] luciash which i suppose is not necessary
[18:07] luciash did you have to re-upload the h5p content type?
[18:09] luciash I did svn up; sh setup.sh -pphp71 composer; php71 console.php d:u
[18:10] jonnyb yes, index not involved
[18:10] jonnyb hmm, that metadataSemantics was the bug i thought i fixed
[18:11] jonnyb in your browser debugger, do you see lib/core/H5P/editor.js ?
[18:11] jonnyb line 10 should be H5PEditor.metadataSemantics = H5PIntegration.editor.metadataSemantics (which is what fixed it for me)
[18:14] luciash yes, I see that editor.js file referenced
[18:15] luciash let me check the line
[18:16] luciash oh, I do not see that file referenced there actually
[18:16] luciash I see  h5peditor-metadata.js:339:21
[18:17] luciash and then 6 others when I expand the collapsed error:
[18:17] luciash findField
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-metadata.js:339:21
[18:17] luciash MetadataForm
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-metadata.js:27:7
[18:17] luciash ns.Form.prototype.processSemantics
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-form.js:91:25
[18:17] luciash ns.LibrarySelector.prototype.loadSemantics/<
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor-library-selector.js:330:7
[18:17] luciash success/<
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor.js:181:13
[18:17] luciash ns.libraryRequested/</script.onload
[18:17] luciash https://demo.luciash.eu/tiki19x/vendor_bundled/vendor/h5p/h5p-editor/scripts/h5peditor.js:106:15
[18:17] luciash when I open that file you said I can see this:
[18:18] luciash H5PEditor.metadataSemantics = H5PIntegration.editor.metadataSemantics;
[18:18] luciash on line 10
[18:19] luciash that is a stubborn bug :(
[18:20] luciash let me try upload another type
[18:28] luciash nope, sorry, that damn issue is stuck here :-/
[18:28] luciash bbl
[19:45]  jonnyb joined #tikiwiki
[21:30]  Jyhem_laptop joined #tikiwiki
[23:03]  ricks99 joined #tikiwiki