<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>

   Jyhem_laptop_: joined #tikiwiki
   jonnyb: joined #tikiwiki
   luciash: ¡ɯoןod
   <br> still time to commit fixes for 19.1
   <br> ?
   <br> I see, it is cheduled for Monday afternoon... ok
   <br> (s on my keyborad is intermittently refusing to work, orry)
   jonnyb: hi luciash - orry, missed your post earlier, yes, 19.1 should happen tomorrow (europe) afternoon :)
   luciash: hi ho jonnyb :) np
   <br> <u>jonnyb</u>: looking at your CSS issue now
   jonnyb: the jquery-ui one? thanks - it's weird (like i've forgotten how to do css ;) )
   luciash: yep, do you have a demo online or should I try to reproduce somehow
   <br> ui datepicker is on tracker date field?
   <br> ok, added it to my demo tracker
   jonnyb: or in the calendar
   luciash: weird is it has border-bottom-width: 0 (why?) but that is something else
   <br> you want the background, right?
   jonnyb: i know, that also doesnt seem to work (and would look odd imho anyway)
   <br> the border of the selected day should be a different colour from the rest
   luciash: eh, it shows up here with that bottom border removed actually
   jonnyb: maybe background too in some themes (jquery-ui themes)
   <br> oh?
   luciash: using Yeti theme
   jonnyb: let me recheck...
   luciash: it applies the border-bottom-width: 0;
   <br> but background color is #fff
   jonnyb: actually, yes the silly no bottom border does with for me, but the colour doesn't, but now i see an error saying invalid property value:     border: 1px solid #e9ecef #e9ecef #dee2e6;
   <br> only 3 colours defined maybe?
   <br> yup, that's it
   luciash: imho the problem is that the ui-state-default should not be there when it has ui-state-active
   <br> then to override that you would need .ui-state-default.ui-state-active selector
   <br> ah, dunno how it defnes these 3 colors, in the scss I see only border: 1px solid $ui-active-border-color;
   <br> <u>jonnyb</u>: so did you found a fix?
   <br> s/found/find/
   jonnyb: i found the definition in vendor_bundled/vendor/twbs/bootstrap/scss/_variables.scss:630 but that's not helping much ;)
   <br> what does "!default" mean?
   luciash: I don't know, a nonsense?
   <br> or is it special SASS thingy?
   <br> there was only !important in CS, or... ?
   <br> CSS
   <br> I see, it must be SCSS
   <br> but that is for nav-tabs
   <br> how is that related to calendar day?
   <br> <u>jonnyb</u>: what theme are you testing with?
   jonnyb: bootstrap default (but have tried others)
   <br> the problem is that the syntax in the css comes out invalid - border-color: #e9ecef #e9ecef #dee2e6; is ok, but border: 1px solid #e9ecef #e9ecef #dee2e6; is not
   <br> (according to Chrome and PhpStorm)
   luciash: it works for me in hrome code inspector, should I try on the scss and compile?
   <br> s/hrome/Chrome
   <br> I must admit I do not see border: 1px solid #e9ecef #e9ecef #dee2e6; in my Chrome inspector but border: 1px solid rgba(0, 0, 0, 0.1);
   <br> with Yeti theme
   <br> let me swicth to default BS
   jonnyb: i think i have a fix...
   luciash: ah, I see the same with BS default theme
   <br> <u>jonnyb</u>: it seems Yeti has it all right but Default theme doesn't
   jonnyb: hmm, let me try yeti with my fix
   luciash: <u>jonnyb</u>: I think the definition of $ui-active-border-color for the default theme is wrong, but for Yeti it is OK
   jonnyb: aha, ok, yeti has $ui-active-border-color defined as just one colour, other themes seem to use 3 or 4 colours...
   luciash: yep, that is what I mean
   jonnyb: i reckon the no bottom border is intended for tabs, not anything else... will test before committing
   luciash: the other themes maybe try to have slightly different color for each side of the border
   <br> adding the fourth color for them should not hurt
   jonnyb: hmm, seems yeti defines normal and active as the same colour, so a bit hard to tell! :P
   luciash: hehe, true :)
   jonnyb: it doesn't matter how many colours, if there are more than one you need to use border-color explicitly (from what i can tell)
   luciash: <u>jonnyb</u>: ok, the themes who specify 3 or 4 are wrong then
   <br> maybe it was working well in LESS before but during the tranition to SCSS it was left there
   jonnyb: ui-tabs-active seems to be unaffected
   <br> yes, maybe - but i think Gary did a lot of overriding the jquery-ui classes to make it all look more bootstrap-like
   luciash: I don't understand how is your last msg related to what I said but anyway... :)
   <br> I mean if it causes errors, there should be only one color defined, or border-color used explicitly as you said
   jonnyb: i meant it's not just the change from bs3 (less) to bs4 (scss) that has changed
   luciash: sure
   jonnyb: while we're on this luciash, any idea what "prefers-reduced-motion" means? we seem to ahve lots of them and phpstorm shows them all to be an error
   luciash: I meant it was just copy-pasted but maybe not tested well with all the themes
   <br> huh?
   <br> never seen that :)
   jonnyb: e.g. in themes/litera/css/litera.css:3828
   luciash: (because I don't use PHPStorm probably)
   jonnyb: also themes/fivealive-lite/css/fivealive-lite.css:2482
   <br> e.g.  @media screen and (prefers-reduced-motion: reduce) {
   luciash: hmm, sorry, must be something new
   <br> I never heard about that in CSS
   <br> https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
   jonnyb: me neither - it's also in yeti.css a lot
   -: jonnyb reads
   luciash: it is a draft I reckon
   <br> "Media Queries Level 5"
   jonnyb: aha right, yes firefox and safari only
   luciash: supported only by few
   <br> yup yup
   jonnyb: seems a little risky for production/stable then?
   luciash: maybe BS4 guys are too enthusiastic about introducing new fancy CSS features ;)
   <br> or Gary? :)
   <br> gtg, bbl
   <br> bb
   robertokir: joined #tikiwiki
   ricks99: joined #tikiwiki
   robertokir: joined #tikiwiki