tikiwiki: 03sampaioprimo * r20036 10/trunk/ (11 files in 4 dirs): tikiwiki: More tests for TikiImporter tikiwiki: Is now possible to run tests from any directory tikiwiki: validateInput() throws exception when there is a validation erro should I commit bug fixes for PluginSharethis to branches/proposed? New Forum Posts: Articles display on page adjustments - http://tikiwiki.org/tiki-view_forum_thread.php?forumId=&comments_parentId=33897 Notice the Tikiwiki bot New Forum Posts notice: the forumId is missing. This is a recurrent problem in tw.o's forums these days. polom hi chibaguy hi luciash :D is forumId mandatory ? trackerId is not, only the itemId Here's the tiki bot msg: bot New Forum Posts: Articles display on page adjustments - http://tikiwiki.org/tiki-view_forum_thread.php?forumId=&comments_parentId=33897 . If you click on the link, you get an error. ah damn, no error this time... RRR :D before, I got a 404 error clicking on that. i just wasn't quick enough to ty ;) *to try pm Something to keep an eye on. tw.o forum urls seem to be inconsistent with using forumId, and sometimes it causes problems with the url. hmm, yup, i can imagine... i just think forumId should be only necessary when linking to the forum itself... not when there's thread/topic id makes sense so it should work with or without On another topic, I'm looking at trunk's layout.css and would like to make some formatting and other changes but am kind of worried about making it so different from branch 3 layout.css.... ...so was going to try to reduce current differences between trunk and branch 3 layout.css, but there are 48 differences and it's hard to know which should win in each case. This kind of thing makes me wonder how merges are made successfully. i would go with more semantic stuff if any no idea about how merges appear it thought we do nomore merges but proposals to the proposed branch ;) that's right. I was just thinking about merges in general. when you merge and there's a conflict you always have to decide using common sense and resolve "manually" The process since beginning of branch 3 was to make a change in trunk to test, then commit to proposed, and maybe|usually it gets added to branch 3... ...so I wonder what is the reason for so many differences in layout.css. I guess I should take a look at diffs history for some of the lines. tikiwiki: 03mangapower * r20037 10/branches/experimental/ws/ (59 files in 23 dirs): [MOD] Improved remove_ws_objects tikiwiki: 03mangapower * r20038 10/branches/experimental/ws/lib/core/test/ (AllTestsAcceptance.php AllTestsAcceptance.php): [MRG] Automatic merge, trunk 19996 to 20036 dev.tw.o unaccessible amette: ping morning ! tikiwiki: 03axold * r20039 10/branches/experimental/ws/lib/workspaces/ (6 files in 2 dirs): [MOD] Added two new functions to wslib tikiwiki: 03pkdille * r20040 10/trunk/templates/tiki-view_faq.tpl: [MOD] view faqs: indent code - no changes tikiwiki: 03mangapower * r20041 10/branches/experimental/ws/lib/workspaces/ (wslib.php wstools/scriptCreator.php): [MOD] Improved scriptCreator: following the instructions written there it's possible to see a little demo of WS easy way to link any tiki page (not only wiki) to display in "fullscreen" (no header, footer and columns) ? (without the feature fullscreen) @luciash: print page, maybe? is print page the same as tiki-index_p.php? anyway it only works for wiki pages. ricks99_: yes, thought about it but needs the print on and is only for some features like wiki pages and articles :( chibaguy: what is tiki-index_p.php ? I'm not sure what it was made for, but it displays div#wikitext only if you use it like tiki-index_p.php?page=Homepage. ah, cool oh, not just #wikitext, but also page title and last modification date. looks like it was made for printing wiki pages, but they're styled normally, not for print. no, i think it's different than printing page maybe so, luciash. I don't know what was/is the purpose of it. but anyway it's better than using tiki-print.php for what i need, thanks chibaguy unfortunately it only works for wiki pages. what does feature_display_my_to_others ? it gets disabled in 3.1 after saving tiki-admin.php?page=login Is it for displaying my information to others? Like the mouseover? and preference groupTracker get's re-enabled when disbaled because the checkbox gets enabled no matter what preference in db chibaguy: might be... i will check if it moved to tiki-admin.php?page=community chibaguy: hmm, there's only users_prefs_show_mouseover_user_info if it's "my" it should be user preference anyway, nope ? right tikiwiki: 03pkdille * r20042 10/trunk/styles/coelesce.css: [FIX] coelesce.css : fix the suggestion section below a page-bar in list-faqs i guess feature_display_my_to_others is maybe "display my login to others" or something like that, otherwise i have no idea why it was on login administration page display my contributions to others (on my_tiki page?) Where do you see that? under General Preferences tab? (on admin login page) ricks99_: if it is that, then it is missing from tiki-admin.php?page=community not sure.. just guessing. its on admin: general, general settings tab oh ah ROFL I don't see it there. "Miscellaneous" section just below "Highlight group" ricks99_: yes, right, seems it's leftover in login preferences php which causes it to disable again i guess that sets the default, then each user can override from their tiki-user_prefs prob should b moved to admin; community heheh ricks99_: yep, and together with the "Display UserTracker information on the user information page:" damn, why the Skype plugin gets -sanitzed again ? in 3.1 +1 (moving display user tracker...) btw, is trunk in usable shape currently ? tikiwiki: 03sylvieg * r20043 10/trunk/tiki-index.php: notice simple_set_toggle('feature_display_my_to_others'); is in tiki-admin_include_login.php also chibaguy: right, that's what i complained about and in a filter in tiki-user_information.tpl chibaguy: that's why it gets disabled there after save ah Howdy howdy wait.. you can see this message? I just received a RAW error.. anyway, I don't know why the noun is left out in 'feature_display_my_to_others'. "my_What?" :-) authed-only: +r registered users only?.. tikiwiki: 03sylvieg * r20044 10/trunk/tiki-index.php: oops chibaguy: heh, someone got lazy ;) :-) So many problems, so little time. :( FF|Skyrider: what message ? just Howdy 141407:144707:1428 07•›› 07C14hannel authed-only 07(+r07) 07(#tikiwiki07)07:15 Press Control+F2 to retry! That message nope, cannot see that :S FF|Skyrider: because we're all authenticated nicks towards NickServ i guess ;) Usually that error message means I can't say anything in this channel unless I'm authed. i think you cannot pm users but you should be able to talk in public in this channel I just pm'd ricks99_ just fine :) oh, did he reply ? yup *g* tikiwiki: 03sylvieg * r20045 10/trunk/tiki-index.php: notice New Forum Posts: Changing the list of fonts in the WYSIWYG editor - http://tikiwiki.org/tiki-view_forum_thread.php?forumId=&comments_parentId=33904 wow, my wife just reminded me that today is our 5th wedding anniversary :-p well, uhm, i mean not 5th wedding, but 5th year anniversary :-p luciash: congrats! :) thanks bro :) hopefully she wasn't too angry to have to remind you.. ;) nope, all is fine :) good to hear :) rodrigo_sampaio: you got your flight? ;) amette: hi heya :) amette: sure, I got there and there was a big queue waiting for me :) congratulations luci! (was afk, watching Enter the Dragon ;-) ) hehe, alright - perfect timing then ;) amette: yes, and now here I'm with your Swedish friends :P chibaguy: oh, Enter the Dragon ? chibaguy: thx :) rodrigo_sampaio: oh, right - I hope they are treating you well... :P amette and Swedish friends ? hahaha :) 1973 martial arts movie with Bruce Lee luciash knows :D chibaguy: ah, old classics there is a criteria for the two letters we use to represent each language? I'm about to add the translation file for slovenian (as marc asked in the devel list) but the slovenian version of wikipedia is sl.wikipedia.org and the slovenian ccTLD is .si. should we use si or sl? hmm, interesting - seems to be a more general question... "sl" is obsolete: http://www.w3.org/WAI/ER/IG/ert/iso639.htm isn't it like country code versus language code ? like we have cz for country code and cs for language ? yeah, just like pt_PT and pt_BR in locales but still the language codes seem to be reworked - see the link --^ - the ISO 639 goes out of fashion it seems http://en.wikipedia.org/wiki/Language_code yup, full locale name for Czech is cs_CZ in my opinion, http://en.wikipedia.org/wiki/IETF_language_tag is probably best, but it's only an opinion (not community ratified I think) yeah, that IETF best practice... I was just reading the wikipedia page and was going for ISO 639-1, but the IETF thingy seems to be rather "backwards compatible" and much more flexible _aand_ very internet-compatible (IETF/RFCs) +1 for IETF language tag it would have the advantage of corresponding to what browsers use tikiwiki: 03pkdille * r20046 10/trunk/templates/ (tiki-faq_questions.tpl tiki-list_faqs.tpl): [MOD] faqs: odd and even class should be on tr not on td in tables add "corresponding to what browsers use" to internet-compatible-list ;) but at present we use ISO 639-1, right? so sl is the right choice for the slovenian language. just so that I know which one to use to finish the commit :) hmmm... on which wiki-page could that be documented...?!? :P amette: maybe a page in dev, but I think that the most import place to document this is the lang/langmapping.php file nkoth3: btw - you forgot your "I change the world."-shirt in the hotel room... why did you put it up to my clothes?! We talked about the high up place being perfect, because no one except for me would put stuff there! :P it is somewhere... amette: hmm, error I got it.. you can retrieve it at the next TikiFest! ;) ok lang/langmapping.php sounds good... should definitely put a note there.. http://doc.tikiwiki.org/i18n+User ^^ describe the lang abbreviation PO converter for TikiWiki...?!? :O Niiice! :) yes, a po converter for tikiwiki is something really interesting tikiwiki: 03lphuberdeau * r20047 10/trunk/ (145 files in 76 dirs): [MOD] Cleanup database abstraction layer to ease unit testing, cleanup constructors tikiwiki: 03sampaioprimo * r20048 10/trunk/lang/ (langmapping.php sl/ sl/index.php sl/language.php): [NEW] slovenian language file thanks to Ales Cerin tikiwiki: 03lphuberdeau * r20049 10/branches/experimental/perms-take2/: [BRANCH] Creation, trunk 0 to 20048 Do not svn up - the last commit lph did - is bugged.... a lot... tikiwiki: 03sylvieg * r20050 10/trunk/lib/banners/bannerlib.php: [FIX] quote query tikiwiki: 03lphuberdeau * r20051 10/branches/experimental/perms-take2/lib/core/test/ (8 files in 5 dirs): [MOD] Use phpunit xml config file to bootstrap code and get rid of mostly useless AllTests.php tikiwiki: 03sampaioprimo * r20052 10/branches/proposed/lang/ (6 files in 2 dirs): [bp/r20048][NEW] slovenian language file thanks to Ales Cerin tikiwiki: 03sampaioprimo * r20053 10/trunk/lib/importer/ (6 files in 3 dirs): tikiwiki: Tests classes for TikiImporter now extends TikiTestCase tikiwiki: Tests for the TikiImporter_Wiki_Mediawiki::insertPage() lphuberdeau: are you still not receiving the cvs list messages? positive the last commit has problem when you call convertsortmode, $this->servertype is not affecting affected instanes are not propagated correctly and there is also problems in error function decalarations to reproduce - insert a {banner} somewhere kind of expected to have a few snags... no way I could test it all beyond 2 hours of reviewing ok - I svn up -r 20046 and also you changed the defauklt adodb - to pdo .... there are a lot of things missing for other than mysql in pdo... ... you won't get anywhere without mysql anyway found the serverType issue... testing hi, anyone knows if we have a standard way of doing js alerts, or if js alerts are frowned upon in general? sylvieg, fix should be in I'm looking for developer documentation for "How to add a new permission to Tiki", and "How to add changes to db in Tiki". Anyone has written/knows of any? http://dev.tikiwiki.org/tiki-index.php?page=Hello+World#To_introduce_a_new_permission lphuberdeau: still not working sylvieg: thks. is the adding to db/tiki.sql and db/tiki_1.xto1.y.sql mentioned in the doc still the way with our sql patch system? nm,. found http://dev.tikiwiki.org/tiki-index.php?page=DatabaseSchemaUpgrade I will refactor... tiki_1.x.... is no more valid $this->serverType in convertSortMode is still empty :-( tiki-db.php is run before local.php is read no it is soemthing else hmm using PDO or ADODb? both should be set by the global script now reading from $tiki_db tikiwiki: 03lphuberdeau * r20055 10/branches/experimental/perms-take2/lib/core/ (18 files in 7 dirs): [NEW] Permission resolving model $db_tiki, sorry adodb is not set for sure pdo seems to be set 2 times.... *(i have just just a couple of trace..) ah, my bad quite a deep issue... give me 10 mins thanks lphuberdeau (yeh.. seems to be something wrong ion the object definition) tikiwiki: 03lphuberdeau * r20056 10/trunk/db/tiki-db.php: [FIX] Oops, was simpler than I thought let's hope this time is the right one lphuberdeau: TikiTestCase require a file inside the phpunit directory. it is looking for the directory PhpUnit/ but in my machine (ubuntu with phpunit installed using pear) the directory is PHPUnit. it is just a typo and I can fix it or we have different names for the phpunit directory for different installations? no the same... when it arrives in convertsortmode, the serverType is empty my guess is that it's a typo sylvieg, where from? I just checked it after creation rodrigo, the class prefix is PHPUnit_ So the directory should have the same name it does not matter on windows, but unix machines are case sensitive I have a banner the user a sort_mode random - and when in bannerlib it calls convertSortMode('random'), the serverType is empty -> the request becomes order by and nothinf else right lphuberdeau: yeah, I also think that it is a typo. I'm going to change it tikiwiki: 03sampaioprimo * r20057 10/trunk/ (7 files in 4 dirs): TikiImporter: feedback for the user after importation tikiwiki: 03sampaioprimo * r20058 10/trunk/lib/core/test/TikiTestCase.php: [FIX] typo, wrong phpunit directory name lphuberdeau: even with this fix I'm not able to run the tests inside lib/core/test, at least all the ones that I have tried. they all have path errors. do you experience the same problem? any tip for running the those tests? lphuberdeau: will regrets to stop by IRC ;-) regret tikiwiki: 03lphuberdeau * r20059 10/trunk/lib/core/lib/TikiDb.php: [FIX] It really was what I tought I know I said this before, but I think this time it's right ;) :-) rodrigo, yes, alain changed the delimiter to windows one... I fixed it in the perms-take2 branch working :-) Thks lphuberdeau the long term goal is not to get all the libs to extend TikiDb right now, it's only a compat mode as you could say TikiDb::get() always provides the real DB instance lphuberdeau: ok, thanks. I'm going to see your change in this branch. BTW, I was really glad about your commit related to TikiDb. Everything was a mess and it is good to see that there is someone working to organize this subject :) made the lib a few months back it was just rotting in some other branch now that release is not imminent, it felt like a good time to break everything ;) .. I have another bug: http://pastey.net/117332 page are not found with this bug lphuberdeau: Yeah, I have some good compost to pile on soon. tikiwiki: 03sylvieg * r20060 10/trunk/lib/core/lib/TikiDb.php: notice tikiwiki: 03sylvieg * r20061 10/trunk/tiki-index.php: [FIX]page: page was not found - side effect of ??? tikiwiki: 03lphuberdeau * r20062 10/branches/experimental/perms-take2/lib/core/ (lib/Perms.php test/Perms/BaseTest.php): [FIX] Never attempt to get the same resolver twice