tikiwiki: 03chealer * r33947 10/trunk/templates/tiki-admin_include_login.tpl: restore Id comment
tikiwiki: 03chealer * r33948 10/trunk/templates/tiki-export_tracker.tpl: restore Id comment
tikiwiki: 03chealer * r33949 10/trunk/ (403 files in 17 dirs):
tikiwiki: revert r33217 "~MOD~ Remove unused header comment"
tikiwiki: Ref: http://article.gmane.org/gmane.comp.cms.tiki.cvs/63790 (no answer)
tikiwiki: 03chealer * r33950 10/trunk/templates/category_related_objects.tpl: [FIX] HTML special characters encoding
good morning tikiverse
tikiwiki: 03chealer * r33951 10/trunk/lib/logs/logslib.php: [FIX] Logs: cleaning logs with a certain age leaves some older events (r24869 regression)
polom
polom
chibaguy: you about? I have a theme option for Ohia ("Cornflower" - sort of pale blue generally with orange boxes) that's mostly finished for 6.x, but was wondering what to do with it...
hi jonnyb, can it be added to 6.x (proposals) or should it go into trunk and br 7?
well exactly...
i know i could make some rules up here but...
Seems like it could go into 6 since it's an optional extra kind of thing.
it's sort of too late in 7.x for something [NEW], but it can't hurt much
have you changed ohia in 7.x to the new modules stuff?
cos i guess that would need doing for this option...
I think so.
Making the adjustments is pretty quick usually.
i think i might commit to 7.x as it is, merge to trunk, backport it into 6.x and then remove it from 7.x if i (or anyone) don't get time to fix it up properly for 7.0
complicated isn't it! :)
yeah.
I checked ohia.css and it's got the module zone selectors, so if your option css is just the items changed from ohia.css, it should work already in trunk, or nearly so.
well, some class names or elements may need updating, for backgrounds etc.
thanks for checking chibaguy - should be getting there soon... :)
but first, lunch!
tikiwiki: 03jonnybradley * r33952 10/third_party/jquery/ (9 files in 3 dirs): [MOD] update jquery.mobile to 1.0 Alpha 4.1
polom RobertPlummer
polom all
polom jonnyb
Ok, jonnyb spreadsheet?
tikiwiki: 03jonnybradley * r33953 10/trunk/ (12 files in 9 dirs): [MRG] Automatic merge, branches/7.x 33907 to 33946
RobertPlummer: i'm planning on fixing the revisions of the external at some point...
exacto!
you mentioned about doing a synchronised release of sheet
Yes, that is correct.
any date planned?
I need to fix 2 problems with it and then it is golden.
have you branched yet?
Not yet
I've been trying to keep trunk as stable as possible.
ok, sensible
yeah, you wouldn't want junk in the trunk
'I could go ahead and branch though, nothing holding me back.
more for you to maintain though, probably best to leave it as late as possible i guess
what about the other nested externals? jqs5 and the svg thing?
nested externals?
externals within externals?
the externals inside lib/jquery, which is itself an external (always causes me confusion)
(sounds like the movie Inception)
lol
Ideally we'd cut down on how many files are external and only use the ones we need.
For instance, inside jquery.sheet we external jquery ui, with is not needed.
Marc wants me to make some progress with svg-edit today, which is something I need to address with you as well.
tikiwiki: 03jonnybradley * r33954 10/trunk/lib/prefs/mobile.php:
tikiwiki: [FIX] Keep mobile_perspectives preference from setting unexpectedly in the feature admin panel
tikiwiki: [bp/r33907] NB: Changes to prefs.php in 7.x need to also now be made in the separate features lib/prefs/ file so they will appear in 8.x onwards
So in short, would you like me to coordinate with you on when the release happens?
I'd like to do a v2 beta possibly next week.
I think too with the beta, I'm going to be dropping support for xml.
well, just switch the external in 7.x to point to the release branch or tag when it's ready (before 7.0)
json or html only
we use json right?
right
and you use your own version of it.
I'll probably be being yours into trunk and dropping what I have currently....
Less to maintain on your part and myn.
yes, one routine should be enough - i haven't looked at them for ages though, so you know best
On svg-edit, I'm a bit lossed.
The team seems happy to make me one of the commiters, but have yet to follow through, probably much to do like us.
oh? I'm unlikely to be less lost :P
Marc suggested possibly to edit source IN TIKI of svg-edit.
Rather than using an external.
hairy
very very hairy
well you could always make a copy of their stuff in third_party and external link to that, and then modify that pending feeding it back to the project
a dream within a dream stuff again?
:)
Ok, that sounds fine, I'd like to make some headway on that today...
not really - just change the svn:external on lib from http://svg-edit.googlecode.com/svn/trunk/editor/ to https://tikiwiki.svn.sourceforge.net/svnroot/tikiwiki/third_party/svg-edit/
As for the height issue with codemirror jonnyb, how about we do a check at startup if the textarea is larger than a certain size, lets say window.height * 0.8, if it is, we make it's height window.height * 0.8, otherwise we make it autogrow?
tikiwiki: 03sylvieg * r33955 10/branches/7.x/lib/wiki-plugins/wikiplugin_tracker.php: [FIX]TRACKER: case itemId={{itemId}} with no itemId on the url-> exit
I know that is a little left field, but I remember you talking about it, and I'm getting ready to commit what I have here.
well the textarea height should be set by the row attribute
tikiwiki: 03sampaioprimo * r33956 10/trunk/lang/pt-br/language.php: pt-br translations
i think for 7.0 just disable auto-grow, or make it only happen if the TA is empty at the start?
Then what should the height be?
sorry - when it starts?
nm, I tested it inherits from the textarea
ok, we are good.
same hight as the textarea i'd think
:)
have you fixed this thing with the {code} plugin going weird when you have tiki_p_edit on the page?
In read only mode?
Can you give me an example to make sure I have it right?
I will go ahead and commit this, then I will resolve that issue.
1 min - phone
ok in read-only, bad when you can edit
tikiwiki: 03sampaioprimo * r33957 10/trunk/lang/pt-br/language.php: Brazilian Portuguese translations done on i18n.tiki.org
tikiwiki: 03robertplummer * r33958 10/branches/7.x/ (5 files in 4 dirs):
tikiwiki: [ADD] Parameters syntax and codemirror to smarty textarea block
tikiwiki: [MOD] flexibleCodeMirror to only start a codemirror instance if it is forced or textarea parameter "codemirror" = "true"
tikiwiki: [MOD] Added new event binding to document, "plugin_ready", which will fire along with "plugin_##type##_ready"
tikiwiki: 03sampaioprimo * r33959 10/trunk/lang/fr/language.php: French translations done on i18n.tiki.org
tikiwiki: 03sampaioprimo * r33960 10/trunk/lang/de/language.php: German translations done on i18n.tiki.org
tikiwiki: 03sampaioprimo * r33961 10/trunk/lang/hu/language.php: Hungarian translations done on i18n.tiki.org
Do we have a generic way to have a {button} with a confirm when clicking on it?
tikiwiki: 03sampaioprimo * r33962 10/branches/proposals/6.x/ (5 files in 4 dirs): [bp/r33946][FIX] blog posts "disappear" for anonymous when upgrading old installations (<=1.9.x)
tikiwiki: 03jonnybradley * r33963 10/branches/7.x/templates/tiki-share.tpl: [FIX] Don't show user selector menu even if there is only one user (admin) - thanks Bernard
tikiwiki: 03sampaioprimo * r33964 10/branches/7.x/ (6 files in 6 dirs): backporting translations done on i18n.tiki.org
tikiwiki: 03jonnybradley * r33965 10/branches/7.x/ (templates/tiki-share.tpl tiki-share.php): [FIX] share: Use user selector for inter-user messages and some fixes so it actually works
jonnyb, i remove my comment about "share this page" it's working fine now.
thanks Bernard1 - i already crossed it out, so it's fine there for a while
oh you've done it already, cool ;)
ur too fast for me. ;)
:)
tikiwiki: 03jonnybradley * r33966 10/branches/7.x/templates/tiki-objectpermissions.tpl: [FIX] perms: Missing
RobertPlummer: just svn up'ed and the code plugin now still breaks but in a different way - the TA disappears but codemirror doesn't appear
the change highlighter buttons everywhere have gone though, so that's good...
lol
ok
I will fix
:)
Where does it break specifically?
Is js minify on?
on a wiki page when you can edit it
no
Oh, refresh your cache for templates ;)
ah, ok...
Let me know...
will do - in the middle of something else at the mo
ok
thanks buddy!
Nope, it is indeed a bug.
tikiwiki: 03robertplummer * r33967 10/branches/7.x/lib/codemirror_tiki/codemirror_tiki.js: [FIX] Array value for syntax attribute to array in codemirror
tikiwiki: 03jonnybradley * r33968 10/branches/7.x/lib/wiki-plugins/wikiplugin_trackerfilter.php: [FIX] trackerfilter: get filters even if $export_action set
tikiwiki: 03sampaioprimo * r33969 10/trunk/templates/blog_post_status.tpl: proper string handling
hey lphuberdeau - you about?
tikiwiki: 03jonnybradley * r33970 10/branches/7.x/lib/tikilib.php: [FIX] plugin_fingerprint: Previously an empty args array actually had an empty item in it, so simulate that so plugins stay approved after upgrade
ok guys, how can I safely open an image from the file gallery and ensure I'm not breaking any security or anything?
If it is an svg image, I need to obtain the file as a string.
tikiwiki: 03jonnybradley * r33971 10/branches/7.x/styles/jqui.css: [FIX] jqui.css: Better .forum_actions
RobertPlummer: use tiki-download_file.php?
hmm, see what you mean...
curl isn't standard for most php and the fopen thing is bad (so i'm told)
wonder if you should just "include" it somehow and capture the output buffer
messy
polom
hi chealer
hi jonnyb
jonnyb: why is fopen() bad?
any idea how RobertPlummer should get the contents of a file in a filegal?
doesn't is say so on the security admin page?
the allow_url_fopen thing?
nm, I can just use $('').load();
oh yes, in js it's ok
jonnyb: OK for allow_url_fopen in general, but you can use fopen() to open a local file safely
but you need to pass params and run it as a php file, no?
hi RobertPlummer. Can I suggest a jQuery.sheet fix?
sure, you wanna be one of the commiters?
RobertPlummer: as you want, but I don't intend to fix more for now, it's just a one-liner
What is the fix?
RobertPlummer: it's to handle HTML characters in tab names correctly
ah, cool
email me from your address you'd like to gain access to in sheet, and I'll approve it.
RobertPlummer: in addTab, line 2274
RobertPlummer: the content of the a link is not escaped
so change from "jS.sheetTab(true)" to
jQuery('').text(jS.sheetTab(true)).html()
(apparently there's no better way to HTML escape in JavaScript :-/
hey guys, i'm having an issue enabling ajax on a new install of tikiwiki. I recieve a generic error : "Error: the xajax Javascript component could not be included. Perhaps the URL is incorrect? URL: lib/ajax/xajax/xajax_js/xajax_core.js". any thoughts? ajax does not enable at this point.
RobertPlummer: I'm not sure what you mean, what about the address? it should be used as a username? my address is chealer@gmail.com in any case.
kit: which version do you use?
i have installed 6.2 and 6.3, both have the same error in the manner. I am down to server enviornment at this point.
chealer.... added
kit: what is the environment?
iis 7.5
kit: right, I heard about that issue on IIS but was unable to reproduce. check if there's any error fetching that file.
tikiwiki: 03jonnybradley * r33972 10/branches/7.x/lib/tiki-js.js: [FIX] wysiwyg: Fix IE breakage trying to get selection from textarea "using" ckeditor (thanks Geoff)
RobertPlummer: sorry, what was added? the escaping bit?
No you as a commiter to jQuery.sheet
http://code.google.com/p/jquerysheet/
You can actually make the changes in 7 and then when you go to commit svn should detect the external and do what it needs to.
WOOOHOOO! I HAVE SVG-EDIT WORKING!
WOOHOO!
yay!
I just need to make it save and I'll be done, and it'll be ready for 7!
nice going :)
I want to go ahead and commit, and then work on edit.
the tiki way
RobertPlummer: hum, it doesn't seem to commit it
What are you using to commit?
I don't understand how the authentication is supposed to work anyway
lol, I use rabbitvcs, and it handles it fine.
RobertPlummer: Aptana and the svn binary. the svn binary does nothing
Aptana is completely quiet
Ok, navigate to the folder jquery.sheet, and then try to commit
RobertPlummer: good for svg-edit
thanks
Looks like there have been a bunch of improvements since I tried to integrate it last, and there doesn't need to be the same type of changes we needed.
We can do a full scale integration.
RobertPlummer: OK, that does try to commit now, but it fails with Server sent unexpected return value (405 Method Not Allowed) in response to MKACTIVITY request for '/svn/!svn/act/83b3cecb-577f-4161-bce3-b24398f5d83c'
Aye, you need a real mans svn tool...
What OS are you on?
RobertPlummer: Debian testing
look into rabbitvcs, it is awesome.
it is just a ui for svn cli,
I run debian too, and love it.
It is better than any other svn UI I have seen, windows or linux.
RobertPlummer: hum, I'm a KDE guy. and really I don't intend to do more contributions so I would prefer if you could commit it than having to learn new VCS software
I already paid a good SVN toll yesterday
lol
ok, no problem
tikiwiki: 03robertplummer * r33973 10/branches/7.x/ (4 files in 3 dirs): [FIX] draw edit, view only.
For those who'd like to test svn-edit or Tiki draw ;) - svn up, upload file to file gallery, click wrench, click edit.
Make sure it is svg
tikiwiki: 03jonnybradley * r33974 10/branches/proposals/6.x/lib/tiki-js.js: [bp/r33972][FIX] wysiwyg: Fix IE breakage trying to get selection from textarea "using" ckeditor (thanks Geoff)
does somebody know if there is a way to get the fulle url and the sefurl of the current url... seems that some servers give back the sefurl and other the logn one in HTTP_REFERER...
hi sylvieg - not off hand (thought you would know if anyone did)
Can someone tell me something about file gallerys? What is needed to post back to tiki-list_file_gallery.php in order to update a file?
I think thre is code duplication to update a file?
RobertPlummer: probably just a POST to tiki-upload_file.php?
or perhaps it posts there to avaoid code duplication
hmm, RobertPlummer - i get the svg editor (full screen) but no image in there - url is: tiki-edit_draw.php?paramurl=tiki-download_file.php?fileId=27
which is bad as it has two ? in it
the second one should be escaped i think
woops, I forgot to fix something there.
Ok, in tiki-upload_file.php I see fileId, but what request param holds the file data?
even with it escaped as %3F it doesn't show anything (and the file is ok)
$_FILES?
How do I post it to tiki-upload_file.php?
tiki-upload_file.php?fileId=1&files=filedata?
Is that right?
it's an array - userfile[]
How do I set that from a querystring though or an ajax post?
try: tiki-upload_file.php?fileId=1&userfile[0]=filedata
jonnyb: You think you are soo smart....
:)
as a post but you'll need to set the right form type...
:P
enctype="multipart/form-data"
as an attribute on the form
right
jonnyb, for an ajax post, I can't use userfile[0], expecially if the file has non url safe characters.
What other alternatives should I use?
tikiwiki: 03sylvieg * r33975 10/branches/7.x/tiki-switch_lang.php: [FIX]i18n: very dirty patch: avoid to go to a wiki page when switching from a cat1111 (tiki-browse_cvateories.php) - HTTP_REFERER contains the short url not the long one
hmm - try escaping it?
I have to use something like $.post(url, {userfile: data}, successFn);
With javascript?
escape("userfile[0]")
might work...
seems a little "hacky"
comes out as userfile%5B0%5D
ah, got you.
not reaslly - it's urlencoding
probably needs doing to the data too
there's a better encode fn...
encodeURIComponent()
See comment above about jonnyb & smart
jk
Thanks jonnyb , good find!
So this should work to save file? encodeURIComponent('tiki-upload_file.php?fileId=$fileId&userfile[0]=' + data + '&enctype=multipart/form-data')
not sure - that's not really what i meant
i meant just encode the userfile[0] bit
ah
and use ajax as before
trying...
it needs to be a POST i believe
Like this: $.post('tiki-upload_file.php?fileId=$fileId&' + encodeURIComponent('userfile[0]') + '=' + data + '&enctype=multipart/form-data', function() { alert('Success!'); });
Is that right?
no, put the params in an object
oh, ok
You da man
maybe
the php may still not like it...
but i think it happens like that elsewhere
{ fileId: $fileId, encodeURIComponent('userfile[0]'): data, enctype: 'multipart/form-data' } fails
you can't use a function for the start of an object's child name
What do you think jonnyb?
Sorry to pester
um... you need to add the enctype as an attribute of the post
might need the $.ajax fn for that
and just use userfile%5B0%5D as the key
RobertPlummer: hum, I'm following loosely, but I doubt you want to encode userfile[0] if it's a parameter name, you must want to encode the value, data
maybe you don't need the [0] bit at all - good point chealer
See comment above in reference to jonny & smart, reference chealer too.
THanks guys honestly!
kit : are you finding a solution?
New Forum Posts: File Gallery Listing error - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061
New Forum Posts: How to track users vs pages? - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059
New Forum Posts: File Gallery Listing error - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061
New Forum Posts: How to track users vs pages? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059
tikiwiki: 03jonnybradley * r33976 10/branches/7.x/lib/filegals/filegallib.php: [FIX] fgals: catch exception when batch uploading
New Forum Posts: File Gallery Listing error - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061
New Forum Posts: How to track users vs pages? - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059
chealer, jonnyb, I found out why it wasen't working....
you can't upload files with ajax I guess.
odd
usually
bleh
so are you making a