marclaporte: joined #tikiwiki amette_: joined #tikiwiki marclaporte1: joined #tikiwiki leagris: Please advise. What should I do if I need new/replace string/key?
should I parse all language files and remove corresponding obselete keys? marclaporte1: leagris: can you give an example? marclaporte: joined #tikiwiki arildb: https://dev.tiki.org/ is down
and back up again :) leagris: http://pastie.org/8175897
Here an example diff of tra('key') changed
tiki_cdn evolve from sisngle cdn to multiple cdn
form field syntax evolve from single line to multiline marclaporte: ok, look at get_strings.php
As you are doing in trunk, just modify what you need in the code, and you don't need to worry about get_strings.php leagris: ok fine
done :)
Enjoy multi-cdn support Tiki-KGB: tikiwiki 03leagris r46854 10trunk/lib/ 10headerlib.php 10prefs/tiki.php 10init/smarty.php
tikiwiki [ADD] feature multi_cdn leagris: I have it working on 11.x, and it work as-is without migrating any data. If only one cdn is configured, it uses it. goj: joined #tikiwiki Ludo-: joined #tikiwiki fabricius: polom Tiki|bot: joined #tikiwiki Anzhe: joined #tikiwiki Tiki|bot: New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294 goj_killedByISP: joined #tikiwiki Anzhe: here's a thought - is there a plug-in or tweak that allows the "Contact Us" form to go to more than one user? chibaguy: joined #tikiwiki
polom
joined #tikiwiki Anzhe: joined #tikiwiki
can someone explain Content Templates to me for a moment? (http://doc.tiki.org/Content+Templates)
Regarding wiki pages currently using a template
when the template is updated, that link says the pages using the previous template version do not change
how then does one go about updating them?
must you manually re-apply the template to each page? is there a way to see the pages that use a given template and which are up-to-date? chibaguy: joined #tikiwiki luciash: Anzhe: the content templates are useful only as a page content starters
Anzhe: once the page is written there is no way to control what other people write and change in it so re-applying the template only adds it again at the beginning or end of the existing page content
chibaguy: hi -: luciash goes off Anzhe: :luciash, thank you for the tip binarymutt: joined #tikiwiki Anzhe: for Wiki History, can someone please explain to me the significance of the Keep versions for __ days config?
if I have unlimited versions (Maximum number of versions: 0) what does keeps versions for __ days do? chibaguy: oops, hi luciash (no longer here). Tiki|bot: New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297
New Forum Posts: Wiki History config - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297
New Forum Posts: New to tiki-devel, Introducing myself to the community - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294
New Forum Posts: allow multiple cdn per protocol - https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279
New Forum Posts: Wiki History config - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48297
New Forum Posts: New to tiki-devel, Introducing myself to the community - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48294
New Forum Posts: allow multiple cdn per protocol - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48279 redflo: joined #tikiwiki arildb: joined #tikiwiki Jyhem_laptop: joined #tikiwiki arildb_: joined #tikiwiki Anzhe_m: joined #tikiwiki arildb: joined #tikiwiki jonnyb: joined #tikiwiki
poets polom Tiki|bot: New Forum Posts: Where to commit [was allow multiple cdn per protocol] - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48300 Anzhe_m: joined #tikiwiki chibaguy: joined #tikiwiki arildb: joined #tikiwiki Tiki|bot: joined #tikiwiki arildb: Hi jonnyb jonnyb: hi arildb
been thinking about the branch and the inline stuff arildb: I updated the write-up + a couple of issued on https://dev.tiki.org/Inline+Editing#Saving_inline_changes. Also added an open question about saving inline comment. Did you have a look at it? jonnyb: thinking it might be a good time to merge soon if it seems ok to you arildb: yes, I think it's ready. jonnyb: after that i'm going to have a go (in that branch) at converting all the old hacky ajax stuff to proper services, which should make it seem all nice and clean and fresh! :) arildb: sounds good. Will you do the merge, or do you want me to do it? jonnyb: one main issue i think with getting plugins working is that it's not using the auto_save plugin, and most of the parsing etc for plugins is done by that
i'll have a go - phpstorm seems to make that quite civilised arildb: sounds good to me :-) jonnyb: btw, i've been meaning to ask, what IDE do you use? I see whatever it is it keeps putting in stinky windows linefeeds :P
stuff to do here, bbl arildb: I use vs.php, which is a PHP project plugin for Visual Studio. Getting the line endings right is a bit nasty. I haven't found a global setting for it :-( jonnyb: aha, thought i detected the smell of Micro$oft :D arildb: lol jonnyb: try phpstorm - we have a license for tiki use
must go, bbl arildb: I might do...one day jonnyb: joined #tikiwiki fabricius: joined #tikiwiki arildb: Hi jonnyb. I updated the section https://dev.tiki.org/Inline+Editing#Saving_inline_changes based on your comment here on IRC jonnyb: thanks arildb - reading...
good points about type of save - i wonder if we can guestimate it - like if more than 50 (?) chars edited then it's a major one? arildb: I have installations that "prefer" long pages. A correct use pattern becomes more important. I doubt users will follow it.
btw. I added a 1000 paragraph test page: Lorem Ipsum. Good for testing large pages
I don't quite understand your question jonnyb: well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation)
we need a "you have unsaved changes" thing on leaving the page too...
but these can happen in trunk - more eyeballs :O arildb: yes, you are right jonnyb: ok, i'm going to do merge #1 arildb: :-) jonnyb: oops, found some commits from last night :| Tiki-KGB: tikiwiki 03jonnybradley r46855 10branches/experimental/ckeditor4/tiki-setup.php
tikiwiki [FIX] Don't use inline edit when editing
tikiwiki 03jonnybradley r46856 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php
tikiwiki [FIX] textarea: Default to having the switcheditor button following logic correction in function.toolbars
tikiwiki 03jonnybradley r46857 10branches/ 10(12 files in 8 dirs)
tikiwiki [MRG] Automatic merge, trunk 46847 to 46854 jonnyb: all this merging stuff is so much better without 94,000,000 svn externals slowing everything down! :)
also doing it in phpstorm is so much better - gives you a nice list of commits to merge, you can ignore all the ones that might cause trouble (merge conflicts etc) arildb: sounds like you have become a fan (as I think Robert was) jonnyb: for a couple of years now :)
http://dev.tiki.org/phpstorm?highlight=phpstorm#Top_10_Reasons_to_Love_PhpStorm arildb: sounds like a good devenv. I bet it gets the line endings right, too ;-) jonnyb: :D
i have tried about all of them over the years, nothing else comes close for php, especially for tiki (try opening up 4 branches of tiki at once in anything else!) arildb: is there a windows version? jonnyb: yes, i think it's available on everything (java based, but not so you'd notice)
contact admin@tiki.org for a license key if you decide to continue using it (there's a 30 day trial i believe) arildb: download site is http://www.jetbrains.com/phpstorm/ it seems jonnyb: personally i use it for everything, not just open source stuff and am happy to pay them the $40 a year to keep them going, i like rewarding good programming!
yy arildb: yes jonnyb: ok, have local merge done - checking...
what's this fix in tiki-js-sorttable.js? just wrong branch or have i messed up?
http://sourceforge.net/p/tikiwiki/code/46779
committed separately Tiki-KGB: tikiwiki 03jonnybradley r46858 10trunk/lib/tiki-js-sorttable.js
tikiwiki [bp/r46779][FIX] Declare variables to avoid JS warnings (backported from experimental/ckeditor4) arildb: It declares the valiable to avoid JS warnings jonnyb: yes, but nothing really to do with ckeditor (so merged separately)
generally (although it's more dull) when i found non-inline-editing-based fixes i fixed them in trunk then merge into ckeditor4
hence it being handy to keep several tiki branches open at once :) arildb: It made breaks all the time in the debugge. I have to Firebug to debug javascript. jonnyb: yes me too - you can always click "ignore" in firebug (each session sadly)
i think sorttable has a pref though too so could just be switched off leagris: Never took the time to set it up properly PhpStorm though I got a licence :) arildb: leagris: which platform are you usually on, Linux? leagris: I'll have to give it more attention. Shell vi, grep, perl -p -i -e 's/replace this/with this/g' file, diff, find, are all nice but sharp tools ;D arildb: yes...seems so leagris: Ubuntu Linux jonnyb: um.. is anyone else getting icons replaces by green ? in trunk?
the green question marks are what the icon function returns along with an error "title" saying: "Error: directory '' not allowed by security setting"
leagris: i'm just wondering if this might be connected to the recent smarty security stuff? leagris: it is
jonnyb did you clear all caches? Anzhe_m: joined #tikiwiki jonnyb: yes, clearing every reload - also just did "php temp/composer.phar install" as there was a smarty update... still got little green ? everywhere
i added a check for if (!empty($cdn)) around the trusted_uri lines, but still the same leagris: Crap, ill have to check this if no CDN :) jonnyb: often a "gotcha" when adding new stuff, testing with it turned off :) leagris: Do you have empty CDN entries? -: jonnyb needs to do that with inline editing jonnyb: yes
and i was ending up with ##i as my trusted_uri's
but i don't think that's it... dhazel: joined #tikiwiki ricks99: joined #tikiwiki jonnyb: looks like line 360 of /vendor/smarty/smarty/distribution/libs/sysplugins/smarty_security.php now returns false from realpath for img dirs - as they're tikiroot relative now, instead of absolute (like template dirs are) - odd leagris: What error do you get when hover mouse on question marks? jonnyb: Error: directory '' not allowed by security setting
so an empty path
i can't see how your changes could be doing this - just a coincidence maybe leagris: maybe not
Before my change the trusted_uri was non_existant jonnyb: mmm, i tried unsetting it if empty but no change leagris: now, when no CDN is used, it get an empty array (so array exists)
Fortunately, if you add your site base http://... to cdn the error may dissapear ;D jonnyb: aha, will try... leagris: I guess I forgot to add site base URI to trusted_uri ;D arildb: I am running a composer.phar update. Updating smarty/smarty (v3.1.13 => v3.1.14). Get a question: Discard changes [y,n,v,?]? ... what should I answer? leagris: v (to see what changes) jonnyb: yes, composer meets svn weirdness - just discard usually arildb: lots of files. I can't get to the top of the listing. Here's a section ...
documentationja
documentationjaappendixes
documentationjaappendixesbugs.xml jonnyb: doesn't always work, if stubborn just remove that dir arildb: answered y jonnyb: i tried adding my localhost/tiki/etc as a can and i now get "This is a Content Delivery Network (CDN) to speed up delivery of images, CSS, and javascript files. However, PHP code is not executed." -: jonnyb goes to hack the database ;)
jonnyb notes to self: double check the destination branch __before__ doing a two hour merge from experimental Anzhe: joined #tikiwiki jonnyb: by the way - the shelve feature in phpstorm is brilliant for this kind of thing :)
leagris: confirmed i'm afraid - without r46854 i have icons, with it - little green question marks everywhere
(no other changes in my trunk now) Tiki-KGB: tikiwiki 03arildb r46859 10trunk/db/tiki_convert_myisam_to_innodb.sql
tikiwiki [FIX] Add missing tables in myisam to innodb conversion leagris: jonny I made a big newbe error, working a fix ;D jonnyb: no worries - so am i, let's see if we end up with the same stuff :) leagris: reproduced your bug, so it help
same bug on my multi-cdn trunk commit jonnyb: looks like it's the bit in convert_cdn in headerlib
need to test for not empty instead of isset, i reckon leagris: it is a bug in lib/init/smarty.php Tiki-KGB: tikiwiki 03arildb r46860 10trunk/db/tiki_convert_myisam_to_innodb.sql
tikiwiki [DOC] Add comment about MySQL 5.6 or later, InnoDB then supports fulltext indexes. leagris: I initialize trusted_uri with regex even if tiki_cdn and tiki_cdn_ssl are empty
It always produce a PREG if cdn empdy ;D
empty jonnyb: this seems to fix it for me - http://pastebin.com/9cGFGb5a leagris: Right, need this fix in headlerlib as a simmilar fix in lib/init/smarty.php to be safe jonnyb: true
did you see my mail about pref separators? leagris: I would not trust smarty security with trusted_uri of #$#i jonnyb: agreed, probably would spoil something somewhere leagris: Yess, seen it but did not look at it so close. jonnyb: by the way, i don't think you need that $i counter var in /lib/init/smarty.php - just doing "$this->trusted_uri[] = blahblah" will push the value onto the end of the array leagris: Ah yes the trunk version. good to know
I guess PHP is nicer than COBOL with arrays ;D jonnyb: ha ha, everything is (i'd guess) leagris: DATA DIVISION (fu#@k)
Well, now let me resynk of 11.x and trunk and push some fixes; D jonnyb: never done COBOL myself - have a friend who had to learn it for a (legacy) job - he called it "Jurassic Code" :) Tiki-KGB: tikiwiki 03lphuberdeau r46862 10branches/11.x/lib/filegals/filegallib.php
tikiwiki [FIX] Uploading as an other user should not be possible by anyone -: jonnyb is glad this went into trunk rather than stable after all ;) leagris: Had to learn GAP2 (IBM36) and then found COBOL a civilized language ;D jonnyb: :D leagris: IBM36 such a large impressive gandma furniture cabinet with this surprisingly so small and crappy power switch ;D
Much like the WOPR in WarGames, without the fancy blinking led pannels Tiki-KGB: tikiwiki 03lphuberdeau r46863 10trunk/lib/filegals/filegallib.php 10trunk
tikiwiki [MRG] Automatic merge, branches/11.x 46846 to 46862 Anzhe: joined #tikiwiki marclaporte: joined #tikiwiki Tiki-KGB: tikiwiki 03lphuberdeau r46864 10trunk/ 10lib/core/Services/File/VimeoController.php 10lib/filegals/vimeolib.php 10templates/vimeo/upload.tpl
tikiwiki [ENH] Set the video title when uploading jonnyb: phew - ok arildb, first merge from ckeditor4 branch just committed - can you check everything arrived ok please? Tiki-KGB: tikiwiki 03jonnybradley r46865 10trunk/ 10(10 files in 8 dirs)
tikiwiki [MRG] Phase one of merges from ckeditor4 - initial implementation of inline editing, mostly working... (but more to come from this branch)
tikiwiki ** Warning: Can mess up pages containing wiki plugins! Marked as experimental.
tikiwiki Full commit details here: https://dev.tiki.org/Inline+Editing#Notes_etc arildb: great!
checking jonnyb: my main test page has loads of plugins in, and most of them go badly wrong... so watch out! ;) arildb: yes I saw the details. One or two words per line. Pretty unreadable...on my side Tiki-KGB: tikiwiki 03jonnybradley r46866 10branches/ 10(10 files in 7 dirs)
tikiwiki [MRG] Automatic merge, trunk 46854 to 46865 Jyhem_laptop: joined #tikiwiki arildb: jonnyb: difficult to test. The inline editor icon is a question mark and doesn't work jonnyb: yes... um, leagris, how you doing with your fix? ;)
arildb: this http://pastebin.com/9cGFGb5a patches it for me for now... arildb: checking
problem is still there jonnyb: which problem? arildb: the question marks instead of icons in trunk jonnyb: joined #tikiwiki arildb: jonnyb: I think you missed my answer: the question marks instead of icons in trunk jonnyb: sorry yes - did you clear all caches? arildb: cleared cache. fixed it.
testing now jonnyb: :) arildb: The Homepage is editable, buit I don't get any toolbar jonnyb: oh? seems ok here
browser cache maybe? arildb: doesn't work properly. Added a new page. Activated the inline editor, but not able to edit Tiki-KGB: tikiwiki 03lphuberdeau r46867 10trunk/ 10(7 files in 6 dirs)
tikiwiki [ENH] Move the OAuth endpoints to services arildb: tried in opera. The same
cleared the browser cache in opera. Still the same
option Wysiwyg editor was off
still nothing
cleared the cache again too
the editor tags are not present in the page, but the inline editor is active jonnyb: is this on your local?
any js errors? (he always asks ;) )
i've just committed a fix for plugins in ckeditor4 - think i'll try it on trunk as it makes it less dangerous (and will check my toolbars etc) arildb: local yes. No JS errors Tiki-KGB: tikiwiki 03jonnybradley r46868 10branches/ 10(5 files in 5 dirs)
tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable jonnyb: the toolbars i get in trunk look different - different skin presumably
yes, was kama - changed to default arildb: I do get an error msg
Timestamp: 26.07.2013 22:29:11
Error: TypeError: Components.classes['@mozilla.org/browser/global-history;2'] is undefined
Source File: chrome://pdfdownload/content/pdfDownloadOverlay.js
Line: 375
does it make any sense to you? marclaporte: jonnyb & arild: I will make demo site for exciting WYSIWYG inline. Do I make seperate for inine HTML-WYSIWYG and inline wiki-WYSIWYG ? jonnyb: hi marclaporte
i wouldn't bother - i generally make a test page for each (by changing the pref in between) marclaporte: arildb: http://demo.tiki.org/6x/tiki-list_file_gallery.php jonnyb: they should live happily together (eventually) arildb: marclaporte: why not just enable inline editing for the existing wysiwyg-* sites. marclaporte: current WYSIWYG are 11.x
should they be trunk? arildb: marclaporte: I was sure that fix was included
marclaporte: yes, they need to be trunk Tiki-KGB: tikiwiki 03jonnybradley r46869 10trunk/styles/utopias.css
tikiwiki [CSS] utopias: Remove odd float left for span in #page-bar (was messing up comments count and served no apparent use) panamaus: ricks99: I checked version 11 on the demo wiki, and the file gallery backlinks bug is present there too
every time you save a wiki page containing links to file gallery items, the backlinks in the file gallery to that page get updated randomly
some backlinks get incremented, some don't
removing links from the wiki page do not usually decrement the backlink counts
Should I report this bug on dev.tiki.org? I have found in the past that my bug reports can get ignored there Jyhem_laptop: polom -: Jyhem_laptop reading history Jyhem_laptop: jonnyb: <jonnyb> well rather than having two (or maybe any) save buttons perhaps it could auto-detect whether it's a major or minor save (by some admin adjustable calculation) jonnyb: hi Jyhem_laptop Jyhem_laptop: on my sites, the point of major saves is to send mail notifications and minor saves send none. It is not something I would like the system to outguess me jonnyb: think that's some way down the road yet - getting it working properly first, don't worry -: Jyhem_laptop stops worring at once :) Tiki-KGB: tikiwiki 03arildb r46870 10branches/6.x/lib/tikilib.php
tikiwiki [bp/r46608][FIX] order by must handle 1, which is the convertSortMode error return (probably related to r46575) arildb: marclaporte: http://demo.tiki.org/6x/tiki-list_file_gallery.php works now
...except...
a warning: Warning: tempnam() [function.tempnam]: open_basedir restriction in effect. File() is not within the allowed path(s): (/www/htdocs/w00ec615/:/tmp:/usr/bin:/www/htdocs/w00ec615:/bin:/usr/local/bin:/usr/share/php) in /www/htdocs/w00ec615/6x/lib/init/initlib.php on line 135
after refreshing it works better marclaporte: thanks arildb!
http://demo.tiki.org/wysiwyg-html-trunk/ and http://demo.tiki.org/wysiwyg-wiki-trunk/ ar ready arildb: thanks marclaporte marclaporte: I will let you guys configure them :-)
panamaus: yes, you should report there
panamaus: even better is patch, even better is that you commit a fix :-)
panamaus: some changes are coming to the http://tiki.org/Wishlist+Team to make sure no wishes are ignored
They will commit to make sure all issues are triages
triaged
and the easy ones fixed
For tricky ones, submitters will be encouraged to use http://dev.tiki.org/show.tiki.org+Overview
Nelson Ko has committed to making show.tiki.org live by August 1st arildb: that's going to be interesting to try marclaporte: yeah, we got a demo at the last webinar arildb: yes, I saw it marclaporte: :-) :-) arildb: jonnyb: I have the problem (here locally) in the debugger now.
The problem is in var enableWysiwygInlineEditing = function () { jonnyb: in trunk?
just committed a couple of things to ckeditor4 on that - what do you get? Tiki-KGB: tikiwiki 03jonnybradley r46871 10branches/ 10experimental/ckeditor4/lib/parser/parserlib.php 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php
tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags) arildb: $(this).html() seems to be empty, though the page has content jonnyb: oh? and why is "this"?
i mean what, not why arildb: ...I lost it in the debugger, but I think it said "br"
trying again jonnyb: ah, ok - br wouldn't have any content, html or otherwise arildb: yes, this = br
I don't understand any more, but I hoped it helped you. jonnyb: that shouldn't really be considered for contenteditable - do you have wiki paragraph formatting on? arildb: checking jonnyb: i don't think there should be any <br>s at the top level of an html body - should all be inside p's etc arildb: No, it was off
enabled now jonnyb: ah, wysiwyg goes all wrong a lot without that
and the add br one too arildb: seems to jonnyb: (should be hard coded on imho) arildb: yes, maybe better jonnyb: you might need to resave the page - switch back to wiki and back perhaps arildb: I also reported a problem about the table tag being on top and having strange effects. Probably caused by the same missing wiki paragraphs
resaved now
The page in in wiki format wysiwyg-wiki is active .....
trying a page in html format jonnyb: super - did your toolbars ever turn up? arildb: not yet jonnyb: can't seem to get them not to work here for me (on trunk)
merging the last commits from cke4 - better plugin stuff Tiki-KGB: tikiwiki 03jonnybradley r46872 10branches/ 10(10 files in 8 dirs)
tikiwiki [MRG] Automatic merge, trunk 46865 to 46869 arildb: for the html page, I can edit in the page, but still no toolbar Tiki-KGB: tikiwiki 03arildb r46873 10branches/6.x/lib/tikilib.php
tikiwiki dos2unix arildb: now I get some errors
"NetworkError: 500 Internal Server Error - http://l5/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA"
uncaught exception: [CKEDITOR.resourceManager.load] Resource name "inlinecancel" was not found at "/tikitrunk/lib/ckeditor_tiki/plugins/inlinecancel/plugin.js?t=D3NA".
jonnyb: the new ckeditor plugins are missing in trunk (it seems) jonnyb: ah - checking...
they arrived ok for me somehow arildb: not here jonnyb: i do remember seeing the merge back to trunk commit seemed to only have the plugin dirs, not the files arildb: will browse the repository
the new plugins are missing in the trunk repository
https://svn.code.sf.net/p/tikiwiki/code/trunk/lib/ckeditor_tiki/plugins
jonnyb: probably a phpstorm problem ;-) Tiki-KGB: tikiwiki 03jonnybradley r46874 10(6 files in 6 dirs)
tikiwiki Merged from ckeditor4
tikiwiki [FIX] Make inline editing safer with wiki plugins - all elements containing plugins now not contenteditable [from revision 46868]
tikiwiki [FIX] More on inline editing and wiki plugins - restore js used by plugins when not in edit mode and don't re-parse html plugins (was adding extra p tags) [from revision 46871] jonnyb: aha, the toolbars work on wiki pages, but no save of cancel buttons
:D -: jonnyb usually blames svn jonnyb: luckily phpstorm has an excellent "compare with branch" function ;)
arildb: missing trunk plugin files on their way in :) arildb: jonnyb: thanks Tiki-KGB: tikiwiki 03jonnybradley r46875 10trunk/lib/ckeditor_tiki/plugins/ 10(16 files in 5 dirs)
tikiwiki [MRG] Some missing plugin files from ckeditor4 branch jonnyb: not sure if it was phpstorm or svn (or me) - fixed here now arildb: works now jonnyb: have you tried the tab key while inline? Quite clever! arildb: I again have a root level table. Does the wiki formatting pick up table tags? If not they should probably also be marked as contenteditable=true
tab...no..trying jonnyb: hmm, will try a table arildb: nice! jonnyb: hmm, no toolbar on a table (wiki) but can edit
but when i save it with a different save button the table disappears :(
best wrap that in a div too -: jonnyb updates ckeditor4 branch (expecting tree conflicts, my favourite!) Tiki-KGB: tikiwiki 03jonnybradley r46876 10trunk/lib/ckeditor_tiki/wysiwyglib.php
tikiwiki [FIX] inline wysiwyg: Add table to the list of elements ckeditor can't handle inline (and wrap it in a div)
tikiwiki 03jonnybradley r46877 10branches/ 10experimental/ckeditor4 10experimental/ckeditor4/lib/ckeditor_tiki/wysiwyglib.php
tikiwiki [MRG] Automatic merge, trunk 46869 to 46876 arildb: Should the wysiwyg-admin panel be moved to the "basic" admin display. It is currently in the "advanced" display jonnyb: Sounds like it, checking...
yes, if it's off it doesn't show up for basic only - needs a basic tag adding arildb: ok jonnyb: in trunk i guess
we'll need to be a bit careful about conflicts for a while here...
lots of merges back to experimental should help arildb: will you handle this one? jonnyb: if you don't ;) (was going to start looking at making the autosave stuff proper Services) arildb: I will try to take a look at it jonnyb: thanks - probably most of the usual wysiwyg prefs should be basic
lphuberdeau: any thoughts about where to put new services for auto_save, preview, wysiwyg etc? Into new ones or add (some) to the wiki one that only has one action? arildb: jonnyb: There is a feature "ajax_autosave". I assume the inline editing should go under this feature, or? jonnyb: how do you mean? seems like a wysiwyg dependent feature really (which in turn depends on autosave, or should do) arildb: I assume ajax_autosave enables the autosave plugin (I assume). The new plugins inlinesave and inlinecancel should they be enabled similarly jonnyb: that's a ckeditor plugin, they don't have prefs like wiki plugins (if that's what you mean?)
joined #tikiwiki arildb: no prefs...ok jonnyb: they're just hooked in (rather messily) in wysiwyglib or toolbars lib when necessary
part of what i'm hoping to clean up for tiki 12 Tiki-KGB: tikiwiki 03arildb r46878 10trunk/lib/prefs/feature.php
tikiwiki [MOD] feature_wysiwyg moved out of experimental and is now a "basic" feature.
tikiwiki 03leagris r46879 10branches/11.x/ 10lib/init/smarty.php 10lib/headerlib.php
tikiwiki [fix] commit [r46818] introduced bug where empty tiki_cdn was not handled properly and caused Error: directory '' not allowed by security setting leagris: jonnyb committed fix to 11.x branch (single_cdn). Ill work on trunk new featured multiple_cdn which arbor same bug jonnyb: should i do a merge from 11 to trunk first (i should think so) -: jonnyb php doc/devtools/svnbranchupdate.php branches/11.x leagris: I can do a distinct commit to trunk as the fix is a bit different jonnyb: have done a merge - there was a conflict but i took the 11.x version
commit just went in... Tiki-KGB: tikiwiki 03jonnybradley r46880 10trunk/lib/headerlib.php 10trunk/lib/init/smarty.php 10trunk
tikiwiki [MRG] Automatic merge, branches/11.x 46862 to 46879 leagris: Someone asked to my fix to be backported down to 9.x I would not touch an LTS new, please look at it if it is ok arildb: jonnyb: Having sections with plugins read-only, works fine I think. The plugins has the "edit button". Works well with together wil inline editing for other sections.
I am not sure we need to aim for having editable sections with plugins jonnyb: coo, that's pushing things! amazed it worked (didn't dare click that one ;) ) arildb: works fine jonnyb: it may come once plugins are tidied up some - am in the middle of making an autosave service... arildb: ...I will leave you in peace jonnyb: thanks for all your help on this, makes a big difference :) arildb: :)
I am able to enter <h1>header</h1> in the inline editor (inside a section). No header is created (which is correct). However, the < and > are not stripped!
once saved in the standard editor, the tags are converted to headers jonnyb: curious... could be a "feature"? :) arildb: maybe the htmlpurifier is not applied to the inlinesave? Tiki-KGB: tikiwiki 03jonnybradley r46881 10branches/ 10(6 files in 5 dirs)
tikiwiki [MOD] autosave: Move to a Service - wiki only so far, wysiwyg next (and tidy up) arildb: htmlpurifier should be run. I will check my setting
HTML Purifier was active
the inline toolbar looks better now, but I miss the style drop-downs
They would fit n the second row jonnyb: yes, i'm a bit lost as to what's going on with the toolbar items - seems cke filters out some depending on the element arildb: yes, it seems to change
I though it was your commits... jonnyb: the only bit i did was removing a few block tools from heading - but cke seems to do more
will come back to that one day...
(if arildb doesn't first!) arildb: hm.m...
adding <html>ABC</html> for a page in wiki format will result in data loss. The tag part is stripped.
For HTML pages adding <html></html> works fine, as long as only the inline editor is used. The tag is correctly html encoded in the database after inlinesave Telesight: joined #tikiwiki Tiki-KGB: tikiwiki 03jonnybradley r46882 10branches/experimental/ckeditor4/lib/ckeditor_tiki/plugins/autosave/plugin.js
tikiwiki [MOD] autosave: Move to a Service - wysiwyg
tikiwiki 03jonnybradley r46883 10branches/experimental/ckeditor4/lib/ajax/autosave.js
tikiwiki [MOD] autosave: Use html5 data attributes instead of temporary elements and global vars (more)
tikiwiki 03jonnybradley r46884 10branches/experimental/ckeditor4/lib/smarty_tiki/block.textarea.php
tikiwiki [MOD] autosave: Change the text for auto saved toggle so the link stays in more or less the same place
tikiwiki 03jonnybradley r46885 10branches/ 10experimental/ckeditor4/templates/styles/mobile/wiki_edit_actions.tpl 10experimental/ckeditor4/lib/ajax/autosave.js 10experimental/ckeditor4/templates/wiki_edit_actions.tpl 10experimental/ckeditor4/templates/tiki-editpage.tpl
tikiwiki [FIX] autosave: Remove a load of code doing timeouts - not needed and probably duplicating server calls arildb: I have configured the wysiwyg "trunk" test servers for inline editing.
The HTML installation works OK. See http://demo.tiki.org/wysiwyg-html-trunk/tiki-index.php?page=Inline+editor+test
The wiki installation does not work. See http://demo.tiki.org/wysiwyg-wiki-trunk/tiki-index.php?page=Inline+editor+test jonnyb: thanks arildb, will try and remember to check them tomorrow - time to eat now (a while ago) arildb: ok RobertR: joined #tikiwiki
Hello all marclaporte: joined #tikiwiki RobertR: The tool bars on the wikipage editor are not appearing on my local server (latest Xampp on Win 8) running 10.4
Any ideas where to start trouble shooting server configs? luciash: RobertR: make sure all files transfered correctly RobertR: Thx luciash...you mean the tiki files right? luciash: also enabling TPL indication might help to check in the source which template files are used at which place: tiki-admin.php?page=features&cookietab=3
RobertR: yes
RobertR: you said no php errors in server logs, right ? RobertR: No error in logs luciash: RobertR: also no error in PHP errors button down there on the page ? RobertR: Nope
Using firebug the php to html output write the <p> tags but not the expected <div> tags
i,e, <a class="toolbar qt-filegal...> luciash: RobertR: is it online somewhere ?
ah, local, sorry RobertR: I'll give that file checking a try. Thanks luciash: if you enable the TPL output comments on that admin page and then clear the cache, you should see if the tpl file is output there and if missing in your filesystem
Tiki cache I mean RobertR: Good tip luciash: it will give you hint of the filename which you can then check if it is there in templates/ or by your theme in templates/styles/themename
not sure you will see it in firebug but using ctrl+U for sure RobertR: I'm not quite sure what worked but after clearing the cache, though I had done that before, the tool bars are now there
Maybe it just got scared of your suggestions :) luciash: ROFL
sorry about that if it sounded scary :) RobertR: If it always worked like that it would be called the "scare the bugs" out of it. ;)
^technique
Thx again luciash. I have to step way for awhile leagris: Question of style I could not find answer in the sources. Given a preference separator "n" (unix newline) is it really cross_platform, given the form textarea may be filled within a Windows environment. Should I be prepared to handle "rn" "nr" "r" and "n" as a new line separator?
I have seen several place in tiki preferences where the separator entry is not used and the final array is obtained by split on "n".
Shouldn't it at least filter trim "r" on array entries to clear out cases of different newline characters left by splitting on "n"? Tiki|bot: Recent Bug: - File Gallery backlinks are a dysfunctional mess - http://dev.tiki.org/item4608 panamaus: marclaporte: there you go ^^
:) arildb_: joined #tikiwiki luciash: leagris: in code generally we use unix line endings only for the consistency and prevent unexpected issues... crlf should be used only in some mail related outputs iirc leagris: luciash I try tu use arra_filter and declared separator "n" but it does not handle the split
array_filter luciash: leagris: see https://dev.tiki.org/DevTips#Files_content_integrity leagris: Other preferences using newline as entry separator do a split on "n" luciash: leagris: sorry, i am not familiar about array_filter leagris: The question I have is, When entering a preference form on Windows environment
will it POST back a string with CRLF? luciash: oh, i do not know but that should be easy to check, no ? leagris: Well I have not Windows environment handy ;D luciash: ah, then, not so easy ;) leagris: we have this in multi_domain settings
preference is a textarea with one domain per line luciash: yup yup leagris: and the code uses a split on "n" to fill an array of domains luciash: i thought there is always n
even on win platforms leagris: Yes but what about nr? luciash: the r will stay but it will be splitted on n anyway leagris: It means some string within the array wil keep prepended r luciash: yes leagris: and then becomes invalid :) luciash: no idea :) might be possible. would need to check what happens leagris: rdomainname would not be good luciash: wouldn't that r be ignored as a whitespace character ? leagris: let say a windows user enter host1.example.comrnhost2.example.comrn then a split on n will produce host1.example.comr ...
unless some trimming is applied (which isn't) aalex_: joined #tikiwiki luciash: leagris: "When submitting the form, all browsers canonicalize newlines to rn (%0D%0A in URL encoding)."
leagris: source -> http://stackoverflow.com/questions/1155678/javascript-string-newline-character
leagris: also http://stackoverflow.com/questions/945942/new-lines-and-browser-os-compatability
leagris: so doing the split on "rn" should be fine leagris: ah yes
jonnyb suggested I use the preference separator instead of split
from my tests, I cant't get the preference separator to work for newlines
Morte to it, I can't semantically separate URI with comma as a comma is a valid URI component ;D SkiNut: joined #tikiwiki
joined #tikiwiki