Tiki|bot: joined #tikiwiki marclaporte: joined #tikiwiki Tiki-KGB: 03jonnybradley r46977 10trunk/ 10templates/remarksbox.tpl 10tiki-setup_base.php 10templates/tiki-user_preferences.tpl 10lib/smarty_tiki/block.remarksbox.php
[ENH] remarksbox: Remember which rboxes have been closed by the user and keep them closed (reset button in user preferences)
Thanks for the idea luciash, sorry it took so long! :)
03pascalstjean r46978 03trunk/lib/wiki-plugins/wikiplugin_webdocviewer.php
[NEW] New plugin to allow over 20 file types to be viewed inline using Google Document Viewer Anzhe: joined #tikiwiki Anzhe_m: joined #tikiwiki TomJarvis: joined #tikiwiki Tiki-KGB: 03pascalstjean r46979 10trunk/lib/wiki-plugins/wikiplugin_webdocviewer.php * [MOD] Removed Print line used during testing goj_killedByISP: joined #tikiwiki Anzhe: usability question for Tiki Wiki 11 - the Pages section has two tabs, List Wiki Pages & Create a Wiki Page... I find that it "saves state" - the last tab you looked at is the one you'll see next time regardless of your intended action.
In other words, if I List Wiki Pages, and then via the left menu select "Create a Wiki Page", it will take me to Pages and show me the List Wiki Pages screen instead.
This is clearly incorrect.
How do either stop saving state, or override the tab display so that you get the one you intended? marclaporte: joined #tikiwiki
polom
Tiki 11.x rocks Anzhe: polom! marclaporte: :-) Anzhe: marclaporte: if you have a minute, please check the log to see the question I just posted here marclaporte: sure
Anzhe: yes, that tab memory is annoying
Expect for turning off tabs, I don't know of a solution or workaround
I vaguely remember when it was introduced
It was to solve the problem of always having to select tab2 or tab3 when you came back Anzhe: it makes sense in all context except when you select a link to a specific tab
then it's a complete UI failure
in there a way to get rid of the "Titles" button on the Search module?
I can post a photo if that's not a clear question marclaporte: Anzhe: about tabs memory, can you http://dev.tiki.org/Make+a+wish ? I suggest you record a short screencast: http://doc.tiki.org/Screencast#Demo_of_screencast_and_editing_the_video and then, we'll have a community discussion about to resolve
"Titles" button on the Search module -> Yes, there a bunch of module options.
http://demo.tiki.org/11x/tiki-admin_modules.php?edit_assign=18&cookietab=2 check the tabs here
try show_go_button=n
titles used to be go I think :-) Anzhe: there is Titles and Go :-)
but only the Go button has a appearance config option
wait what
that worked
ok hold on!
someone oughta file a bug report
"Show Go Button" toggles the "Titles" button? that's how you give new users headaches! ;-)
marclaporte: do you know how often the Lucene index is updated? marclaporte: On your Tiki site or in general? Anzhe: the default setting
I just turned the search on for our site and forced an index update
but I'm curious how/when it updates itself
for example, a cron queue that is tapped with each page edit... marclaporte: So not all operations are handled by incremental updates. Thus, you need to have a daily cron for a full rebuild.
ex.: when you rename a page, the old page stays in the index and when you click on it, you get an error
"Show Go Button" toggles the "Titles" button -> instead of a bug report, what do you say that I teach you to commit a fix for this?
basically, learning to commit and changing a text label
This will be useful as well when you want to commit translations Anzhe: that would be very kind of you. if you've got time now I've got time, or we can schedule a mentoring session for another date/time? marclaporte: joined #tikiwiki
so... Anzhe: did you not receive my last message?
marclaporte: that would be very kind of you. if you've got time now I've got time, or we can schedule a mentoring session for another date/time? marclaporte: Let's start now
and see how far we get :-) Anzhe: ok marclaporte: 1st thing, you fix locally Anzhe: log it all here or switch to direct messaging? marclaporte: then, after, you learn to commit
log all here, for others to learn as well
So, there is inconsistent label. Which one to keep, which one to change? Anzhe: clearly we keep the button, because the functionality is a Title search
Go means nothing in particular marclaporte: So what exact text do you want to change, and from what to what? Anzhe: ok, on the Search module preferences (having already added it to a page region), under the Module tab, there is an option called "Show Go Button"
below the input also has the text "Show go to page button. Default: "y" (do show go button)" marclaporte: ok, perfect Anzhe: all instances of "go" should be changed to "Titles"
(I'm being exceedingly loquacious for posterity's sake) marclaporte: So, now, you need to grep (search through all) the code to see if it's a unique use
So you don't break something else by making this better. Seems unlikely, but just to be sure Anzhe: one moment, my IDE is still indexing the Tiki11 local install marclaporte: So most text strings are in the templates directory Anzhe: I assume you do active development, just out of curiousity which IDE do you use? marclaporte: I usually commit from the server, no IDE
I just SSH to Linux server, change code, and commit from there Anzhe: you write PHP without an IDE?
are you a wizard? marclaporte: A lot of people here like PHP Storm Anzhe: that's what I've used for a couple of years as well marclaporte: I don't do tricky stuff Anzhe: started with NetBeans but it just ran like... a non-runner
ok, I found 9 instances of "do show go button" in my T11 vanilla install
one is in the modules folder, the rest are localization strings
in the lang folders
mod-func-search.php line 58 has it marclaporte: ok, so there is where you need to modify it Anzhe: yep marclaporte: It will break all the translations, and then you need to decide if that is a good thing or bad thing
Should translations be invalidated? If Yes, you have nothing else to do (but commit) Anzhe: I guess that depends if the translations are obsolete as well
the UK Eng and FR are obviously wrong
so I think they should be invalidated
question
the array itself is misnamed
line 56
'show_go_button'
this array has 6 usages in mod-func-search.php and one in mod-search.tpl
it should be renamed to 'show_titles_button'
shall I go ahead and update all instances in the single commit? marclaporte: For the record, if they should not be invlidated, then, there should be a search & replace to change the original string -> http://dev.tiki.org/mass+spelling+correction
yes, you should commit all this in one commit since it's all related Anzhe: lemme go ahead and make those edits then, one moment marclaporte: But if you change the variable name, it could get more tricky
So you can be lazy/safe and keep variable name and just change labels Anzhe: it's a key within the 'params' array
rather than an independent variable, so I think changing it fully is low-risk marclaporte: What about existing sites that are using it under that name? Anzhe: I don't follow
the commit would not impact existing sites marclaporte: If someone has a wiki page in which he calls that module with show_go_button=n as a param, what will happen? Anzhe: nothing, or it'll throw an error for array key not found marclaporte: So they could have a change of behavior, no? Anzhe: indeed, but clearly calling an apple "potato" for legacy's sake is also not ideal
so I would defer to the developer guidelines
which are...? :-) marclaporte: hehe Anzhe: actually no
first I would find the person who changed "Go" to "Titles" and slap them with a trout
THEN I could consult the developer guidelines marclaporte: hahahahhahaha
The general guideline is to do what you think is best for Tiki Anzhe: it was you, wasn't it? and now you're making me clean up your mess under the guise of a learning exercise! -: Anzhe looks askance at marc marclaporte: :-) :-) :-)
Next lesson will be on svn blame :-) Anzhe: commit comment rage? ;-) marclaporte: I suggest you commit to trunk since there could be a change in behavior and it will be your first commit Anzhe: where is TW's code hosted?
I haven't read up on the dev side of things at all
my apologies marclaporte: and gives others the chance to give feedback. And, if all good, you can backport to 11.x
https://sourceforge.net/p/tikiwiki/code/HEAD/tree/trunk/
See http://dev.tiki.org/Commit+Code
What is your SourceForge username? Anzhe: ok if we're gonna be using soureforge I need to drop offline for a moment and turn on my VPN
SF is blocked in China >_> marclaporte: ok Anzhe: and I'll also make a new SF username
back in 5 minutes I guess
joined #tikiwiki -: Anzhe waves at marc Anzhe: ok, I'm VPN'd and registered Tiki|bot: New Forum Posts: Choosing the size of the RR plugin picture output - https://tiki.org/tiki-view_forum_thread.php?forumId=24&comments_parentId=48427
New Forum Posts: Datachannel Help - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48422
New Forum Posts: PluginSQL Approval - No Change to Plugin - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48420 marclaporte: I need your username Anzhe: anzhe marclaporte: while you read: http://dev.tiki.org/3+Rules PrezKennedy: joined #tikiwiki -: Anzhe has finished reading the 3 Rules and 3 Rules Extended Edition marclaporte: You can commit access: https://sourceforge.net/users/anzhe Tiki|bot: New Forum Posts: Choosing the size of the RR plugin picture output - http://tiki.org/tiki-view_forum_thread.php?forumId=24&comments_parentId=48427
New Forum Posts: Datachannel Help - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48422
New Forum Posts: PluginSQL Approval - No Change to Plugin - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48420 Anzhe: marclaporte: one moment please, subordinate just came in
marclaporte: ok, I'm back. All of my pet projets are on BitBucket, so I have TortoiseHg installed. Do you recommend I add TortoiseSVN or use PHPStorm's internal SVN tools? panamaus: joined #tikiwiki marclaporte: I guess try first with PHPStorm Anzhe: for anyone reading this log post facto, we're taking a break from the exercise while I get my SVN integration in PHPStorm sorted marclaporte: joined #tikiwiki TomJarvis: joined #tikiwiki
polom
I have been following the mentoring session while I wait for a scan to complete. The scan ended so I am shutting down for the night. I will have to see how it ends tomorrow. marclaporte: TomJarvis: you will do your 1st commit as well? TomJarvis: I am interested in the possibility, but I am stuck on tiki 9 (php level problem) so I probably can't participate until I get that fixed.
Someone asked about showing titles in the file galleries slide show. The support for it is in the tpl file, has that been added in Tiki's above 9? marclaporte: I don't know
use demo.tiki.org to check quickly
do you have your commit access yet? TomJarvis: I do not have commit access. marclaporte: ok, let's get that part solved and you can commit later, when you are ready Bert_: joined #tikiwiki
Hi! marclaporte: I just need your SourceForge username
hi Bert_ Bert_: I'm trying to add a link to an image, but when I do, it opens the link on a different window, how do i get it to open in the same window? marclaporte: is the link on same domain? Bert_: yes marclaporte: are you using relative or absolute link? Bert_: absolute marclaporte: try relative Bert_: will do, will report back in a few
Great! It's working Marc marclaporte: super! TomJarvis: My SourceForge username is tomjrvs, at least that is what I put in the "Community members information". I am away from home and I don't find it in my laptop's passwordsafe. marclaporte: Bert_: and it's better if ever you change your domain name in the future Bert_: Another question, I'm trying to add google authorship for differnt users. What's the easiest way to do so. Right now I'm creating a category for each users, and then adding the code through a module and parsing the module by categories. This way is kinda annoying, what's a better solution?
To sum it up, I need a way to add items to a page base on the creator of that page. TomJarvis: Bert: Write a plugin. marclaporte: TomJarvis: you have commit access: https://sourceforge.net/u/tomjrvs/profile/ TomJarvis: I tested file galleries slide show in demo tiki 11. There is no option to request the description in the settings, and it does not display. Bert_: Write a plugin? I wouldn't know where to start lol marclaporte: Bert_: what is "google authorship" ? TomJarvis: I tried the slideshow URL appending caption=d and it does a brief list of the description before the start of the slideshow, but it didn't change the slideshow. Bert_: It shows a pic of the author of the page on google search results https://plus.google.com/authorship marclaporte: So like a more from this author type of thing? TomJarvis: Thank you for the commit access. Bert_: Marc for the picture to show, I need to add a link of that user's 'google' profile for every article they create, i'm not sure how to do that. marclaporte: Bert_: 1st thing, Tiki would need a mapping of Tiki usernames and corresponding Google IDs Bert_: How would I go about doing that?
I'm new to tikiwiki marclaporte: Not sure but
It reminds me a bot of http://doc.tiki.org/Interoperability#Gravatar
bot -> bit Bert_: cool, will look into that, thanks for your help, i'm out, have a nice night/morning lol Anzhe: marclaporte: regarding the impact of changes to the English UI text on other lang files, what is the responsibility of the person changing the UI?
should they update the root lang string in every lang file and let localizers update the result straing
*string TomJarvis: Good night Anzhe: or should they leave the root string as is and there is some sort of auto update tool that handles that?
how does it work marclaporte: Anzhe: there is a script for that (get_strings.php), run at each release.
So you can run anytime and commit if you want, or do nothing and it will happen automagically Anzhe: ok marclaporte: so those now broken translations will fade away Anzhe: interesting marclaporte: And the new one will be added in comments in SVN, so translators know it's there (but these commented out string are deleted at packaging time to save disk space) Anzhe: marclaporte: I'm actually in the office today :-) so I need to focus on some non-Tiki projects for the remainder of the day, thank you for all your help, we'll resume in a day or two
joined #tikiwiki coaboa: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki
joined #tikiwiki
joined #tikiwiki redflo: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki chibaguy: joined #tikiwiki Tiki-KGB: 03xavidp r46980 10mods/trunk/wiki-plugins/r/lib/wiki-plugins/wikiplugin_rr.php
[ENH]Added message and icon to indicate when cached content is displayed and how to force content refresh
03xavidp r46981 10mods/trunk/wiki-plugins/r/lib/wiki-plugins/wikiplugin_rr.php
[FIX]Changed string to indicated that it's 'Cached R' content, and not general wiki page cache Anzhe_m: joined #tikiwiki Anzhe: joined #tikiwiki Anzhe_m: joined #tikiwiki Anzhe: joined #tikiwiki Anzhe_m: joined #tikiwiki chibaguy: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki fabricius: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki
joined #tikiwiki goj_killedByISP: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki Telesight: joined #tikiwiki
joined #tikiwiki Anzhe_m: joined #tikiwiki Telesight: joined #tikiwiki arildb: joined #tikiwiki Telesight: joined #tikiwiki Anzhe: joined #tikiwiki Anzhe_m: joined #tikiwiki
joined #tikiwiki astroo-: joined #tikiwiki
hello people xavi: joined #tikiwiki RobertR: joined #tikiwiki
Hello All astroo-: hello Tiki|bot: joined #tikiwiki RobertR: Looks busy in here :) xavi: left #tikiwiki Tiki|bot: Recent Bug: - Not possible to save page - http://dev.tiki.org/item4612 Tiki-KGB: 03lphuberdeau r46982 10trunk/lib/ 10(46 files in 11 dirs) * [ENH] Move Lucene implementation to be more symetric to elastic and mysql marclaporte: joined #tikiwiki Tiki|bot: New Forum Posts: How do display a banner? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48439 luciash: polom polom astroo-: hello RobertR: Hi luci Tiki|bot: joined #tikiwiki
joined #tikiwiki Telesight: joined #tikiwiki
joined #tikiwiki
joined #tikiwiki aalex: joined #tikiwiki RobertR: Take care all