| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| robertr | bye all | [00:00] |
| ......... (idle for 43mn) | ||
| Tiki|bot | New Forum Posts: Inline editing - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=48771 | [00:43] |
| ........ (idle for 37mn) | ||
| Tiki-KGB | 03arildb r47246 10trunk/lib/jquery_tiki/autoToc.js
[REVERT/r47217][FIX] Add the Tiki license header to autoToc.js (I assume that is fine) | [01:20] |
| .................... (idle for 1h35mn) | ||
| Tiki|bot | Recent Bug: - Switching perspectives should have URL of the home page of that perspective, instead of tiki-index.php - http://dev.tiki.org/item4691 | [02:55] |
| ................................................... (idle for 4h10mn) | ||
| Recent Bug: - t.o 11.x: left column overlapping central column and flip left column is unclickable with Webkit - http://dev.tiki.org/item4692
Recent Bug: - http://i18n.tiki.org/Status shows fatal error - http://dev.tiki.org/item4693 | [07:05] | |
| ....... (idle for 31mn) | ||
| Tiki-KGB | 03xavidp r47247 10trunk/lang/ca/language.php * a few strings translated | [07:36] |
| ............. (idle for 1h2mn) | ||
| Telesight | joined #tikiwiki | [08:38] |
| .............. (idle for 1h7mn) | ||
| changi|lowcon | marclaporte: releae or not release ? | [09:45] |
| changi | changi back to normal connection :) | [09:46] |
| .... (idle for 17mn) | ||
| Robepower | joined #tikiwiki
Hi Can someone help me to apply a profile for my Tiki Wiki page ? I have tried and it works for a little bit but nothing happens | [10:03] |
| ......... (idle for 40mn) | ||
| Tiki-KGB | 03changi67 r47248 10trunk/ 10(28 files in 16 dirs) * no changes - see qa.tiki.org | [10:44] |
| ...... (idle for 28mn) | ||
| eliasp | joined #tikiwiki | [11:12] |
| ..... (idle for 20mn) | ||
| chibaguy | joined #tikiwiki | [11:32] |
| fabricius | joined #tikiwiki | [11:32] |
| ....................... (idle for 1h53mn) | ||
| Tiki|bot | New Forum Posts: Spider Chart? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=48776 | [13:25] |
| .... (idle for 15mn) | ||
| Tiki-KGB | 03changi67 r47249 10trunk/lib/wiki-plugins/wikiplugin_youtube.php * [FIX] Shorter check need a valid regexp too | [13:40] |
| .... (idle for 19mn) | ||
| arildb | joined #tikiwiki | [13:59] |
| ...... (idle for 29mn) | ||
| Tiki-KGB | 03changi67 r47250 10branches/11.x/lib/wiki-plugins/wikiplugin_youtube.php * [ENH] Let's try to di this more rock solid
03changi67 r47251 10trunk/lib/wiki-plugins/wikiplugin_youtube.php 10trunk * [MRG] Automatic merge, branches/11.x 47225 to 47250 | [14:28] |
| 03changi67 r47252 10trunk/lib/test/wiki-plugins/YoutubeTest.php * [ADD] More tests for youtube | [14:40] | |
| .... (idle for 18mn) | ||
| 03jonnybradley r47253 10trunk/templates/modules/mod-quickadmin.tpl
[FIX] quickadmin: Recent prefs menu triangle had disappeared again - seems if class="sf-arrows" is on the UL tag in the page, superfish removes that class so the CSS doesn't apply anymore (sure that was the other way round last time?) | [14:58] | |
| nkoth|nelson | joined #tikiwiki | [15:02] |
| chibaguy | joined #tikiwiki | [15:06] |
| .... (idle for 15mn) | ||
| joined #tikiwiki | [15:21] | |
| nkoth|nelson | joined #tikiwiki | [15:28] |
| Tiki-KGB | 03jonnybradley r47254 10branches/11.x/lib/jquery_tiki/tiki-connect.js
[FIX] connect: Various fixes, mainly $spinner var not found, but added a hasOwnProperty check and some jquery selector optimisations. 03jonnybradley r47255 10branches/11.x/lib/jquery_tiki/tiki-maps.js [FIX] maps: Don't create a marker if you don't know where to put it (e.g. when a location defaults to 0,0,1 somehow) | [15:32] |
| Tiki|bot | joined #tikiwiki | [15:41] |
| Tiki-KGB | 03jonnybradley r47256 10trunk/lib/jquery_tiki/tiki-connect.js 10trunk/lib/jquery_tiki/tiki-maps.js 10trunk * [MRG] Automatic merge, branches/11.x 47250 to 47255 | [15:44] |
| jonnyb | joined #tikiwiki
polom | [15:49] |
| arildb | hi jonnyb | [15:53] |
| jonnyb | hi arildb | [15:54] |
| Tiki-KGB | 03jonnybradley r47257 10branches/11.x/lib/core/Tiki/Connect/Abstract.php * [FIX] connect: Add a few new prefs to the private and protected lists
03jonnybradley r47258 10trunk/lib/core/Tiki/Connect/Abstract.php 10trunk * [MRG] Automatic merge, branches/11.x 47255 to 47257 | [16:00] |
| ............. (idle for 1h2mn) | ||
| arildb | For Location fields in trackers, users can "Search for location". When displaying this location the world map is displayed. I would like it to zoom to the street address I have specified
For this I have prepared the function, and now I need to add the option. Where should I put it? The option is isZoomToFoundLocation. If set, the map will zoom. Otherwise the current behaviour is kept Does that sound correct? Should zooming be the default Should the new option use the "Google Maps" admin panel? | [17:04] |
| Tiki-KGB | 03arildb r47259 10trunk/ 10lib/jquery_tiki/tiki-maps.js 10tiki-setup.php
[ENH] Option for zooming to "Search for location" result. The option itself is still missing. Trying to figure out where to put it. Switch hard-coded in tiki-setup.php. Set to keep current behaviour (world-view) 03arildb r47260 10trunk/lib/jquery_tiki/tiki-maps.js * dos2unix | [17:18] |
| DKR | joined #tikiwiki
Trying to get Geshi running on TikiWiki v11. Cannot find a solution. Currently geshi is installed with 'apt-get install php-geshi'. How can it be activated in TikiWiki, and what is the correct color? | [17:20] |
| Tiki-KGB | 03arildb r47261 10trunk/tiki-setup.php * [FIX] javascript error | [17:28] |
| arildb | DKR, is this Geshi, the graph drawing program? | [17:30] |
| DKR | GeSHi (Generic Syntax Highlighter) | [17:31] |
| arildb | ah, right
sorry, I don't know much about that | [17:31] |
| DKR | I'm just looking for a way to show C++ sourcecode highlighted in the wiki. | [17:32] |
| DarkCalf | joined #tikiwiki | [17:46] |
| DKR | left #tikiwiki | [17:58] |
| Tiki-KGB | 03arildb r47262 10trunk/ 10lib/prefs/geo.php 10templates/admin/include_maps.tpl 10tiki-setup.php
[FIX] Add option geo_zoom_to_found_location. When set "search for location" will center the map and zoom to the result. The default is set to 'n', which keeps the current "world-view" zoom. | [18:00] |
| jonnyb | arildb: seems inline editing is broken - there's a js syntax error in there now... looks like r47244 | [18:06] |
| Telesight | joined #tikiwiki | [18:07] |
| jonnyb | hmm, better fix it then... | [18:13] |
| arildb | jonnyb: checking... | [18:17] |
| jonnyb | is ok, i'm on it | [18:18] |
| arildb | ok | [18:18] |
| jonnyb | you can't set a default for a param in the function definition in js - that's php | [18:18] |
| Tiki-KGB | 03jonnybradley r47263 10trunk/lib/ckeditor_tiki/tiki-ckeditor.js
[FIX] wysiwyg inline: Fix syntax error (js can't have defaults defined in function params like php) and refactor duplicated code | [18:28] |
| arildb | thanks jonnyb ... I get a bit confused between all the languages sometimes .... | [18:29] |
| jonnyb | easily done - maybe it works in some browsers (but not ones i use)? | [18:30] |
| Tiki-KGB | 03jonnybradley r47264 10trunk/ 10styles/layout/design.css 10lib/jquery_tiki/tiki-jquery.js
[ENH] modal: General improvements for $.fn.modal (actually a busy spinner, doesn't need to be modal). Better z-index handling and positioning using more CSS and (a little) less JS | [18:32] |
| 03jonnybradley r47265 10trunk/lib/core/Tiki/Connect/Abstract.php * [FIX] connect: A few more missing prefs from the private list | [18:38] | |
| ..... (idle for 24mn) | ||
| nkoth|nelson | joined #tikiwiki | [19:02] |
| ...... (idle for 26mn) | ||
| Tiki-KGB | 03arildb r47266 10trunk/ 10lib/userslib.php 10tiki-index.php 10lib/ckeditor_tiki/wysiwyglib.php 10templates/tiki-wiki_topline.tpl
[NEW] Permission for inline editing only tiki_p_edit_inline. The existing tiki_p_edit has implicitly tiki_p_edit_inline permissions. | [19:28] |
| 03arildb r47267 10trunk/lib/ckeditor_tiki/tiki-ckeditor.js * [FIX] svn ID | [19:40] | |
| arildb | In trunk my TortoiseSVN tells me that composer.lock is out of date. ..I think I have the latest composer updates installed. Should it be checked in? | [19:40] |
| jonnyb | hmm, don't think anything's change in composer recently... did you run composer.phar update instead of composer.phar install maybe?
just roll it back i guess arildb: i'm finding that inline editing of a normal wiki page now removes all the line ends - sure it was ok a little while ago | [19:43] |
| arildb | looks ok on my side...will make a new test | [19:44] |
| jonnyb | http://sourceforge.net/p/tikiwiki/code/47237 looks a bit wrong to me (wiki pages can have html in them, it's a property of the page and is checked in there somewhere) | [19:44] |
| arildb | I haven't tested that case. The fix is needed for inline editing.
Do you have a good wiki format test page? | [19:46] |
| jonnyb | also http://sourceforge.net/p/tikiwiki/code/47201 looks to me like that autotoc code should be in tiki-index.php, not setup (which is run for every page in tiki, admin etc included) | [19:47] |
| arildb | yes, that's probably better. Let me check it | [19:47] |
| jonnyb | thanks
$is_html is setup (properly i thought) in /lib/setup/editmode.php, r47237 seems to cancel out a lot of that logic, what was the problem it was fixing? | [19:47] |
| arildb | jonnyb: No $is_html not always set correctly. See the case description: http://dev.tiki.org/inline%20editing#HTML_syntax_in_wiki_pages
However, there may be better ways to solve the problem. Try to uncomment the fix and do the steps (if you have time) | [19:52] |
| jonnyb | inline editing doesn't use tiki-editpage.php at all though, so i don't see how it helps that scenario | [19:54] |
| arildb | yes, the error occurs in the conversion when using edit page (as far as I could see)
pages in wiki format have is_html = 1 | [19:55] |
| jonnyb | ok, well that bit should be sorted out in the $_REQUEST['mode_normal'] bit
you code was in the global scope of the page (happening every load) | [19:56] |
| arildb | Let me move the page display options from setup to index first. I will check the is_html case afterwards | [20:05] |
| Tiki-KGB | 03arildb r47268 10trunk/ 10tiki-index.php 10tiki-setup.php
[FIX] Move new page display option processing from tiki-setup to tiki-index to avoid load every time. Only for wiki pages. Thanks jonnyb | [20:14] |
| jonnyb | thank arildb :) | [20:14] |
| Tiki-KGB | 03jonnybradley r47269 10trunk/templates/pagehistory.tpl * [FIX] history: Don't show diff if nothing to show | [20:20] |
| jonnyb | arildb: seems on a simple wiki page the inline edit convert to wiki works sort of ok, just my test page has lots of plugins etc so the effect is magnified
inline should really be using the tikiwiki plugin (and tikiplugin) - but not trivial... | [20:20] |
| arildb | I am using wysiwyg-html, so I don't experience the conversion problems...only when testing | [20:22] |
| jonnyb | jonnyb wonders "how hard can it be..." | [20:23] |
| arildb | What's the benefit of using the plugings tikiwiki and tikiplugin? | [20:24] |
| .... (idle for 18mn) | ||
| jonnyb: I looked some more http://sourceforge.net/p/tikiwiki/code/47237
The problem seems to occur when switching from wysiwyg-html to wiki text format. In tiki_pages wysiwyg=n, but is_html=1...after the conversion. | [20:42] | |
| jonnyb | yes, sounds wrong (that bit used to work)
will test i've just given up on inline plugin editing - think it's possible but too tired now is_html gets set to 0 in the database, so far so good... seems to work fine here (with r47237 commented out) | [20:49] |
| arildb | did you do the steps described on the "inline editing" page? | [20:55] |
| jonnyb | yes, but retrying with feature_wiki_allowhtml disabled | [20:55] |
| arildb | what occurs when switching iis... | [20:56] |
| jonnyb | ah, you're right - disabling feature_wiki_allowhtml means is_html=1 in the data | [20:57] |
| arildb | when the editor swicthes from wysiwyg-html to wiki format, all is good (in memory). is_html is converted to false. However nothing is saved.
So, when tyhe user p�resses save, the is_html value from the stored data is used, which is is_html=1. Thus the converted page gets is_html is 1 The fix should be corrected, as it will "destroy" "allowhtml" settings maybe you have an idea for a better fix? | [20:57] |
| jonnyb | but that would also mess up wiki pages intentionally with html in
(it happens! :) ) | [20:59] |
| .... (idle for 18mn) | ||
| arildb: found it! :) | [21:17] | |
| arildb | great! | [21:17] |
| jonnyb | r47237 probably can go now | [21:17] |
| arildb | please do | [21:17] |
| jonnyb | it wasn't using the allowhtml set in the post request | [21:17] |
| arildb | ok | [21:18] |
| Tiki-KGB | 03jonnybradley r47270 10trunk/tiki-editpage.php
[FIX] html: Use allowhtml sent in request if set - prevents former html wysiwyg pages ending up as html ones (thanks arildb) | [21:18] |
| jonnyb | thought i'd leave that one to you, if this works ;) | [21:18] |
| arildb | ok | [21:18] |
| jonnyb | that processPageDisplayOptions fn looks like it might be better in a library - the wiki one maybe?
just a thought - i'm knackered, so off - back in a week or so | [21:19] |
| arildb | ok jonnyb. see you then
Yes, I can move processPageDisplayOption | [21:21] |
| ..... (idle for 21mn) | ||
| Tiki-KGB | 03arildb r47271 10trunk/tiki-editpage.php
[ROLLBACK][r47237[FIX] HTML syntax in wiki pages could occur with inline editing. Fixed in a better way by r47270. thanks jonnyb | [21:42] |
| 03arildb r47272 10trunk/ 10lib/wiki/wikilib.php 10tiki-index.php * [REF] Move processPageDisplayOptions() from tiki-index to wikilib | [21:56] | |
| ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |