MichaelC: joined #tikiwiki Tiki|bot: joined #tikiwiki joelobrecht: joined #tikiwiki Tiki|bot: joined #tikiwiki sipherdee: joined #tikiwiki Tiki-KGB: 03alexandrequessy r51897 10trunk/lib/userslib.php * [ENH] userslib: copy LDAP email to Tiki users system dabright: joined #tikiwiki Tiki-KGB: 03alexandrequessy r51898 10branches/12.x/lib/userslib.php * [REVERT] Revert r51896: userslib: copy LDAP email to Tiki users system fabricius: joined #tikiwiki Tiki|bot: joined #tikiwiki panamaus: joined #tikiwiki Tiki-KGB: joined #tikiwiki SkiNut: joined #tikiwiki joelobrecht: joined #tikiwiki luciash: joined #tikiwiki refizul: joined #tikiwiki USlacker: joined #tikiwiki dabright: joined #tikiwiki brolin_empey: joined #tikiwiki Jyhem_laptop: joined #tikiwiki diggy128: joined #tikiwiki MichaelC: joined #tikiwiki sipherdee: joined #tikiwiki amette_: joined #tikiwiki Jyhem: joined #tikiwiki MichaelC|Mobile: joined #tikiwiki Caarrie|sleeping: joined #tikiwiki fabricius: joined #tikiwiki redflo: joined #tikiwiki diggy: joined #tikiwiki fabricius: joined #tikiwiki Tiki-KGB: 03chibaguy r51899 10branches/13.x/styles/jqui/ 03options/trontastic/ui-bg_gloss-wave_55_000000_500x100.png 10options/trontastic.css 03options/trontastic/ui-bg_diagonals-small_50_262626_40x40.png
[FIX][NEW] Updated Trontastic theme option for jQui. (This file was edited directly, not produced by the Less pre-compiler; there's no trontastic.less, yet.) Also I added two jquery-ui theme background images from branch 12 (maybe as a temporary workaround) because images in branch 13 aren't correct. minger0: joined #tikiwiki Tiki|bot: Recent Bug: - http://dev.tiki.org/item5311
Recent Bug: - http://dev.tiki.org/item5312
Recent Bug: - http://dev.tiki.org/item5313
Recent Bug: - http://dev.tiki.org/item5314 Tiki-KGB: 03chibaguy r51900 10branches/13.x/styles/jqui/ 10options/didiem/less/tiki-selector-variables.less 10options/didiem.css * [FIX] Top navbar wasn't positioned at the page top. jonnyb: joined #tikiwiki Tiki-KGB: 03chibaguy r51901 10branches/13.x/ 10styles/ohia.css 10styles/ohia/tiki-selectors.less * [FIX] Improvements in Ohia theme details. fabricius: joined #tikiwiki Tiki|bot: Recent Bug: - http://dev.tiki.org/item5315 nelsonko: joined #tikiwiki jonnyb: hi nelsonko - how's things in 13.x? :) nelsonko: hi jonnyb,
I'm just reviewing to see what status we are at in terms of blockers. I saw you fixing a bunch of stuff for geoff jonnyb: i'm still trying to find the missing wysiwyg toolbar buttons, most odd nelsonko: ok this one https://dev.tiki.org/item5299
right? jonnyb: and i think we probably need to deal with the {DIV} plugin validation
yes, 5299 more or less describes it nelsonko: yes, in my understanding wasn't it supposed to be possible to validate only when certain parameters are changed?
I thought I saw that somewhere before... jonnyb: that was the idea, but we all got validation notices for next.tiki.org... maybe that was just dogfooding weirdness?
hm, 504 on dev.t.o :( nelsonko: due to intertiki down I think
if you avoid logging in you can get to pages? jonnyb: yes, was also trying to get to https://tiki.org/forumthread52643 nelsonko: I was thinking I should send out an email about impending releases soon as there are no more blockers (there is only one left) and should be reported in the bug tracker now?
https://dev.tiki.org/item5306 also seems need fixing, if really a problem jonnyb: ew, nasty, but should be fairly trivial
seem to remember i added a little js to get the field list when you pick the tracker - selectors probably need updating (i can check) nelsonko: other then these, there are other regressions reported but they are in lesser used features and I don't think they are blockers
there are a couple of small ones which may be quick fixes though jonnyb: and we've always said 13.0 will be only for The Brave! :) Tiki|bot: joined #tikiwiki nelsonko: this should be a quick fix https://dev.tiki.org/item5309 jonnyb: i'm looking for the user tracker thing - https://dev.tiki.org/item5306 nelsonko: yes thanks, that first jonnyb: one little thing i'd like to fix also for 13.0 is to make it so we only have one popover at a time - sometimes i end up with 5 or 6 of them left all over the page - is that only me? nelsonko: no
Sounds like the same problem as https://dev.tiki.org/item5301
right? jonnyb: i guess so, but both t.o sites seem to be down...
maybe more coffee will help... brb
back (nope)
well that's annoying - gezza fixed the user tracker thing yesterday!
there were two wishes on dev - https://dev.tiki.org/item5306 and http://dev.tiki.org/item5307 (which he updated!)
i bet the double tracker item thing was becasue of the lack of "busy" feedback on service dialogs now... i just made two user trackers for the same reason nelsonko: oops sorry, double tracker happened to me too before
should I try get LP to fix that or is it just a matter of adding a modal? jonnyb: just fixed it
:)
(hopefully)
r51902 Tiki-KGB: 03jonnybradley r51902 10branches/13.x/lib/jquery_tiki/tiki-jquery.js
[FIX] tikiModal: Check z-index is greater than the previously found one so it appears in front of service and modal dialogs (seems "0" evaluates as true these days in javascript) jonnyb: cuiously the multiple popovers being left open all over the place doesn't seem to be happening for me on local now
so i think the "only" blocker (i'm aware of) is the mysterious missing ckeditor buttons... Tiki-KGB: 03jonnybradley r51903 10branches/13.x/ 10styles/layout/less/tiki-toolbars.less 10styles/layout/tiki.css * [FIX] toolbars: Toolbar buttons shouldn't have borders (like btns) nelsonko: gary is fixing the table in middle column stick out to right problem Tiki-KGB: 03chibaguy r51904 10branches/13.x/ 10(26 files in 4 dirs)
[FIX] Make tables in center column responsive (confine to column and add scrollbar). Previous attempt in r51695 wasn't correct. jonnyb: super - another possible bad one i've seen was the plugin editor removing linefeeds from wiki pages - possibly only wysiwyg ones...
nelsonko: do you think we should have a look at upgrading ckeditor for 13.x? we're on 4.3.4 but 4.4.2 is current nelsonko: jonnyb: well not sure coz geoff has done a lot of testing
and not sure if this means upgrading again Tiki-KGB: 03chibaguy r51905 04branches/13.x/styles/feb12/options * [KIL] Remove empty directory. jonnyb: indeed - but i think he reported an IE bug a while back that newer version have fixed nelsonko: if he;s willing to test again (and has time this weekend) ...? jonnyb: was just wondering if it would magically fix the missing buttons thing :) nelsonko: worth a try
if it fixes geoff's problems he might be willing to help test again
bug missing buttons is kinda weird
s/bug/but jonnyb: :P nelsonko: it can also wait till 13.1 if thats better for him. jonnyb: i'll try a local update and see if the buttons are there (somehow i doubt it) nelsonko: the upgrade i.e. jonnyb: but i'll add the new version to satis.json to be ready chibaguy: joined #tikiwiki nelsonko: ok. those versions move quickly... chibaguy: polom nelsonko: http://ckeditor.com/download/releases jonnyb: hi chibaguy chibaguy: hi jonnyb jonnyb: ckeditor 4.4.2 doesn't seem to fix the mysreious missing buttons :( nelsonko: it's not just visibility is it? jonnyb: think i found it - seem their packaging changed and we haven't been getting the full release (just standard)
grrrr
however... how to fix it?
do a minor update to 4.3.5 maybe?
or go for the full excitement of 4.4.2? ;)
4.3.4 is currently only used in 13.x and trunk - i vote to switch that to 4.4.2 full chibaguy: Go for 4.4.2 as far as I know. jonnyb: i have a copy of some of Geoff's WYSIWYG torture pages, so am testing a bit now... 4.4.2 all looking good
hmm, there's a {BOX} plugin needing validation, which it shouldn't... so investigsting that... Tiki-KGB: 03chibaguy r51906 10branches/13.x/styles/jqui/options/trontastic.css * [FIX] Removed toolbar button backgrounds. jonnyb: hmmm, looks like we might be stuck with having to validate div and box plugins as far as i can tell - becasue tehy didn't need validation before, but do now it shows up as needing approval - dull
hey, chibaguy - i think i did a fix for toolbar button borders, in tiki.less (i guess backgrounds need to go too?)
http://sourceforge.net/p/tikiwiki/code/51903 chibaguy: Well, in the Trontastic theme file, I had specified a background for .btn, which is a mistake. That applies the background to link buttons also. jonnyb: fair enough :) chibaguy: I'm just looking at the wiki editor toolbar. It seems ok. fabricius: joined #tikiwiki jonnyb: nelsonko: ckeditor seems fine (distracted by plugins) - i'll commit the ckeditor 4.4.2 update to satis in trunk, then do 13.x/composer.json
then will ask Geoff if he minds retesting ;) nelsonko: jonnyb: ok Tiki-KGB: 03jonnybradley r51907 10trunk/doc/devtools/satis.json
Add ckeditor v 4.4.2 to satis (using the new url for the full zip, previous 4.3.4 one was using the standard package, hence the missing buttons)
03jonnybradley r51908 10branches/13.x/lib/parser/parserlib.php
[FIX] plugins: Plugins with only safe args (or empty body) not validating "all" don't need a fingerprint and therefore don't need validating.
Prevents spurious validation needed for upgraded DIV or BOX plugins which recently have acquired parameters that need validation (CSS)
03jonnybradley r51909 10(46 files in 13 dirs) * [MRG] Automatic merge, branches/13.x 51884 to 51908
03jonnybradley r51910 10branches/13.x/ 10modules/mod-func-cart.php 10lib/wiki-plugins/wikiplugin_addtocart.php 10tiki-setup.php
[FIX] cart: JS needs to be included from tiki-setup.php to avoid loading it during ajax requests (thanks LPH) jonnyb: well that's dull nelsonko - the updated version of ckeditor 4.4.2 in http://composer.tiki.org somehow is the standard package, not the full one (as specified in satis.json) - huh?
somehow it's using git, not a zip... nelsonko: jonnyb huh? jonnyb: indeed - if you look in composer.lock you can see it's been using git for ckeditor downloads for a while (pre-13.x at least) nelsonko: right, but we have been using the zip?
(in satis.json I mean) jonnyb: we've been asking for the zip bit it's been using something else nelsonko: doesn't satis.json determine what is cached? jonnyb: if you look at http://composer.tiki.org the ckeditor entry shows all sorts of dev branches etc
but i can't for the life of me work out where that's coming from nelsonko: yes the link address looks like https://composer.tiki.org/dist/ckeditor-ckeditor-e90a22b1e6957a3c85c097c85a194ecdec4c0e18-zip-b43476.zip jonnyb: maybe it's becasue ckeditor is in packagist now https://packagist.org/packages/ckeditor/ckeditor nelsonko: makes sense jonnyb: but is annoying...
might try "ckeditor/ckeditor": "dev-full/4.4.x"
well that works (all the buttons are there) but it's not a tagged release :( nelsonko: true, tags are not in packagist
wait, they are
4.4.2
"ckeditor/ckeditor": "4.4.2" jonnyb: yes, that's what i think it's using, but that is the "standard" package, not the "full" one we need nelsonko: https://github.com/composer/composer/issues/815 no help
what if we call our version something like 4.4.2-full ? jonnyb: worth a go i guess... will try
ok, have committed a possible fix to satis.json in trunk, need to wait for composer.t.o to update (and i need to go out for a while) so will check back later... Tiki-KGB: 03jonnybradley r51911 10trunk/doc/devtools/satis.json
Trying adding "-full" to the ckeditor zip version because satis (or something) has decided to use the git packages on packagist.org instead of the zip we specify, and the released tags on there seem to be using the standard build, not the "full" one which has all the plugins we need. (might work) jonnyb: ok, bbl Tiki|bot: New Forum Posts: tiki dev site - http://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_parentId=52660 Tiki-KGB: 03lphuberdeau r51912 10trunk/lib/core/Search/Query.php * [ENH] Always allow comma-separated field lists in queries
03lphuberdeau r51913 10trunk/lib/core/Tracker/Field/ItemLink.php
[MOD] Delegate indexing remote to the field handlers so all fields are indexed as they are supposed to be jonnyb: joined #tikiwiki
re
nelsonko: looks like the 4.4.2-full thing didn't work (composer say: Could not parse version constraint 4.4.2-full: Invalid version string "4.4.2-full"_
also composer.t.o seems to have ignored it nelsonko: @jonnyb: okay.... any other ideas? jonnyb: move it into vendor_extra and do it manually (quite dull)
use dev-full/4.4.x (which currently i 4.4.2 but won't always be)
ask LPH ;)
i'll try reading the satis docs again (but didn't spot anything like this last time) Tiki-KGB: 03jonnybradley r51914 10trunk/doc/devtools/satis.json
Adding "-full" to the ckeditor zip version didn't work (invalid version string, apparently) jonnyb: nice to see tiki.org is back! :) nelsonko: yay Telesight: joined #tikiwiki jonnyb: i wonder if adding "packagist": false to the ckeditor/ckeditor repo in satis.json might work - https://getcomposer.org/doc/05-repositories.md#disabling-packagist says you can disable it globally (bad for us) but i wonder if it could apply to just a single package... nelsonko: I think not, according to the https://github.com/composer/composer/issues/815 but that was written some time ago, maybe things have changed or that person got it wrong jonnyb: looks relevant - am re-reading and trying to absorb... fabricius: joined #tikiwiki jonnyb: maybe changing the "require" line for it to "*@stable" or "<=4.4.2" might get it to ignore the newer stuff in packagist...
i reckon "<=4.4.2" is worth a go... trying that Tiki-KGB: 03jonnybradley r51915 10trunk/doc/devtools/satis.json
More on ckeditor: Trying to restrict the required version to be "<=4.4.2" which hopefully will stop satis thinking there's better (newer) versions in packagist via git (suggested on https://github.com/composer/composer/issues/815 thanks nelsonko) nelsonko: jonnybradley: this looks like something that someone might try to "fix"
I mean: is there a way to comment within the json file?
so that well-meaning people (including myself) don't revert that little bit of magic :)
well let's see if it works first jonnyb: no, sadly json doesn't support comments (bad)
composer.t.o has updated but the ckeditor entry looks the same (all the dev branches in there too)
nope, didn't work :(
nelsonko: did you understand the part on that github issue about using "replace" - something like if we make our looks for tiki/ckeditor and then use replace to put it back to ckeditor/ckeditor nelsonko: jonnyb: not really jonnyb: same
ew, just got antoher 504 error on dev (posting a comment) diggy128: joined #tikiwiki jonnyb: think i've worked out why 12.x isn't effected - it's still on v 4.2.3 and ckeditor only arrived on packagist at v 4.3.3 (so that's good) refizul_: joined #tikiwiki jonnyb: nelsonko: do you think this might work (in satis.json)? http://pastebin.com/CBMz22WH luciash: joined #tikiwiki nelsonko: ok using the replace?
I am not sure if this is what the guy was saying in that thread
but sounds like it. let me try digest it again jonnyb: i found this too: http://stackoverflow.com/questions/18882201/how-does-the-replace-property-work-with-composer nelsonko: I think it will work.... Tiki-KGB: 03jonnybradley r51916 10trunk/doc/devtools/satis.json * More on ckeditor: Revert previous... using "<=4.4.2" didn't work jonnyb: worth a go i guess (sorry about the svn noise everyone ;) ) nelsonko: I'm trying to understand this bit about the self.version
I suppose that's not what we want, we want to always use 4.4.2 full even if packagist increments with a new one
so what you have makes more sense Tiki-KGB: 03jonnybradley r51917 10trunk/doc/devtools/satis.json * More on ckeditor: Trying the "replace" method (hope the syntax is correct) aalex: joined #tikiwiki jonnyb: hmm, tedious - doesn't look like the rename thing worked - reverting that last commit...
nelsonko: ^^ nelsonko: grrr Tiki-KGB: 03jonnybradley r51918 10trunk/doc/devtools/satis.json
Revert r51917: More on ckeditor: Trying the "replace" method (hope the syntax is correct) jonnyb: i'm about done for today - the only fix i've found is to set the version to use dev-full/4.4.x
shall we go for that for 13.0 and work out something better for 13.1? (i.e. ask LP ;) ) Tiki-KGB: 03lphuberdeau r51919 10trunk/ 10(7 files in 7 dirs)
[MOD] Add simple object parameters to {object_selector_multi}, activate in admin panels where applicable jonnyb: ok, i need to feed, more later/tomorrow/monday... Tiki-KGB: 03lphuberdeau r51920 10trunk/ 10templates/prefs/shared-flags.tpl 03lib/core/Search/ContentSource/GroupSource.php 10lib/search/searchlib-unified.php 10lib/prefslib.php * [ENH] Including groups in the index to allow them through object selector
03jonnybradley r51921 10branches/13.x/ 10styles/layout/tiki.css 10styles/layout/less/tiki-miscellaneous_global.less * [FIX] ccc: Missing "curly a" (hey, i fixed a LESS bug! :)
03jonnybradley r51922 10branches/13.x/ 10styles/layout/tiki.css 10styles/layout/less/tiki-miscellaneous_global.less * [FIX] ccc: Yay, another (ok, i really should have got that last time, sorry)
03jonnybradley r51923 10branches/13.x/templates/tiki-user_information.tpl * [FIX] userinfo: Remove bogus opening div tag (for a change) fabricius: joined #tikiwiki