Tiki-KGB: 03lindonb r53832 10trunk/templates/antibot.tpl * [FIX] iconset conversion
03chibaguy r53833 10trunk/ 10themes/base_files/css/tiki_base.css 10themes/base_files/less/tiki-blogs.less 10themes/base_files/less/tiki_base.less 10tiki-setup.php
[ENH] Import bootstrap-chosen (http://github.com/alxlit/bootstrap-chosen) Less files into tiki_base.less. Todo: multiple select isn't right yet. panamaus: joined #tikiwiki Tiki-KGB: 03lindonb r53834 10trunk/doc/devtools/satis.json * latest tablesorter version 2.19.0 lindonb: joined #tikiwiki
joined #tikiwiki Tiki-KGB: 03lindonb r53835 10trunk/doc/devtools/satis.json * tablesorter version 2.17.8 no longer needed
03lindonb r53836 10trunk/ 10composer.json 10composer.lock * update to tablesorter 2.19.0
03lindonb r53837 10trunk/doc/devtools/satis.json * remove superseded tablesorter version 2.18.3 not used in any tag release Telesight: joined #tikiwiki fabricius: joined #tikiwiki gilles: joined #tikiwiki wolfganga: joined #tikiwiki luciash: polom wolfganga: hello -: luciash going to work on fivealive-lite improvements now luciash: hi wolfganga ! wolfganga: Hi luciash luciash: any idea why theme options wouldn't work in trunk ?
I have set fivealive-lite but it stayson violet theme option instead of the others
ah I see, I have the theme switcher module enabled :-p Caarrie: joined #tikiwiki luciash: some little emergency here, bbl Jyhem_laptop: joined #tikiwiki gilles: hello wolfganga: hello gilles: with bootstrap I understand how to change column but how to reduce spacec between module ? Jyhem_laptop_: joined #tikiwiki nelsonko: joined #tikiwiki Tiki-KGB: 03nkoth r53838 10trunk/ 10(5 files in 4 dirs)
[REF] Add functionality in new Wikiplugin Alert (ability to store cookie to keep alert dismissed) to remarksbox instead luciash: re
I don't like the new quickadmin in trunk (two clicks instead of one as before) wolfganga: In need some inspiration / direction. I want to optimize the response time when creating a new trackeritem. The problem is that the css and js files are loaded again, although there are already cached
This does not happen, when clickling itemlist in the tracker
It only happens wen creating a new new item (and the the list is passed via xhr i think)
This is also te reason why filing a bug on the official website is so slow / unresponsive. lindonb: joined #tikiwiki luciash: I think it is because tiki-tracker-update_item loads all the css, maybe if it was just raw html (without css) it would be faster... maybe limit to load only the body ? I do not understand why it loads whole html though, maybe there is some reason... wolfganga: I am actually debugging it. I guesst it is because the javascript callback from the xhr-call executes: document.location.reload();
and "document.location.reload();" forces a reload with teh equest header no-cache.
similra to the browser reload button.
i undderstand why the request are made then, but do not understand why its not getting a 304 response instead (like with images...)
This is really painfull when using tiki outside a lan but in a WAN. Tiki-KGB: 03luciash r53839 10trunk/img/tiki/ 03tiki-icon-flat-white.png 03tiki-icon-flat.svg 03tiki-icon-flat-black.png * [NEW] flat tiki black and white icon (including svg version) fabricius: Hi luciash -> I think the new appearance of the quickadmin AND of the wikieditbuttons should be optional - both as independantly settings for module and content page. I use the quickadmin in a bootstrap list element and there it is not accessible anymore (even much worse than the two click issue wolfganga: WOW!!!!
I have it!
This is awesome. fabricius: wolfganga: your issue mentioned above? wolfganga: Yes. fabricius: very cool! wolfganga: Without patch (as it is today). When creating a new trackeritem: fabricius: I started to get stressed out on that myself (especially with the bugtracker)
ah .. listening .. wolfganga: 45 js files to load gzipped 788k + 13 css files gzipped 81.4k + 1 response for content 12kb = sums up to: 59 request for 881,4kb fabricius: ouch wolfganga: with ptach:
patch:
0 js files to load + 0 css files to load + 1 response for content 12kb = sums up to: 1 request for 12kb
so in summary: 59 request with 880kb vs 1 request for 12kb fabricius: WOW wolfganga: I think i should commit it ;-) fabricius: that means about probably the bugtracker will seem to work
can you aswell backport that to 13 pls for that we will get it in the bugtracker asap?
we should not wait til 14 in this case
wolfganga: if you have questions for when commit where and how to backport, there is a wikipage on dev and you could aswell ask jonnyb wolfganga: fabricius - would you be able/willing to do a test against my dev machine?
if it works i can backport fabricius: wolfganga: willing yes, able? :)
-> query wolfganga: A moment - will prepare luciash: cool, just fearing there will be some use case, when this will cause issue... but maybe not. lets give it a try. rollback is always possible fabricius: if issues luciash, maybe optional instead of rollback ... it is running
really fast on a slow server
luciash: you know who committed the new quickadmin apearance? lindon, or gezza or who?
we should rise the issue I think - ask for some chance, respectively optional ... I'll check the module first, but it looks like a new default for ever<thing luciash: fabricius: no idea, I bet on gezza :) fabricius: I try to find in svn logs
do you have the relevant selector(s) off hand? luciash: quickadmin module has its own tpl probably
TPL: /var/www/tikitrunk/templates/modules/mod-quickadmin.tpl fabricius: it was lindon!
[FIX] quick admin: put all single-action options under a dropdown.
lindonb: are you there? This was definitively not a fix Tiki-KGB: 03luciash r53840 10trunk/templates/layouts/social/layout_view.tpl * [MOD] no excuse to use inline style lindonb: fabricius: hello! fabricius: hi lindon lindonb: sorry, what are you referring to? fabricius: I have dropdown for qucikadmin and
page actions lindonb: ok fabricius: /s/qucikadmin/quickadmin
on the one hand I like it, but on the other hand it causes issues for luci and me lindonb: what issues? fabricius: the dropdown uses bootstrap.js so it is dependant on js, which should be optional and not madatory lindonb: hmmm, there are many parts of tiki that won’t work without js now fabricius: it should anyway be optional, as one person likes it in most cases, another person hates the extra click
for most parts - especially basic parts - we still have alternative options in Tiki
for example we still keepo suckerfish and thus have non-js menus
for me personally it would not be so much a problem, but I have to do with people .. groups .. who avoid js and who recommend to have at least the basic navigation non-js capable
I mean there is no problem, if wysiwyg is js only, as we still have plain syntax aswell
and we can expect that s.b. who avoids js for reasons should be prepared to accept a bit less comfort or the need of a minimum of knowledge like syntax lindonb: I thought many parts of Tiki didn’t work without js but could be wrong, never tried it Telesight: joined #tikiwiki fabricius: but that a wikipage edit button for no reason is not accessible without js and I have even not an option to shut that off (maybe in a perspective) is not nice
lindonb: shure, I thought this aswell. I simply have not been aware, but then last year i made a one weeks Tiki workshop with Frank to work with a dataprotection group ...
so there are people out there thinking different - and not using apple Tiki-KGB: 03walper r53841 10trunk/lib/jquery_tiki/tiki-jquery.js
[FIX] Heavily improved response time on new or modified trackeritems (down from 59 requests with 880KB to just 1 request with 12KB). The js callback handler that was called after save and requested the same page for displaying the updated list, was using the reload() method. This methods instructs the browser to update the local cache. This in turn leads to loading ALL js files a
tikiwikind ALL css files again. This patch implements the href atrribute instead of the reload() function. This way the browser behaves like clicking a link, which uses the cached files. Note: You must have a proper webserver setup with valid cache header! wolfganga: If anyone has access to the current bug+wishes tracker - this patch (just one line) would make it respond MUTCH faster on new items. fabricius: anyway ... do you see any way of a bit more improving your enhancement to make it a bit more optional and give back the state of acessibility we had before? Would be great, cause in the end I really like it and see it as an improvement ... IF ... wolfganga: Note: There i still an issure with updating trackeritems (does not work, takes long) i will lokk into this soon. fabricius: last one was for lindonb
wolfganga: somebody must backport and then we need svn up of dev.t.o ... then I will mention to you, as you surely want to test :) wolfganga: Yes very eager to try it on the bug tracker! lindonb: fabricius: not clear to me why we need a non-js option for this one and not all the other features like trackers where you can hardly do anything without js and ajax?
will become harder now with bootstrap
in general, i don’t think we’re maintaining a non-js Tiki overall fabricius: I see trackers more as an advanced feature ... for basic collaboration of techhsavvy people there is still the plain oldstyle direct tracker view ... wikipages easily can be used (edited) without js etc.
lindonb: there is no need to lock the front door just because we might have a few locked rooms inside the house lindonb: it’s becoming less though - I’ve been implementing popup modals to confirm deletions, etc. so that you don’t go to an entirely new page just to click okay
not thinking of making every improvement like that optional fabricius: In case we will go for a Tiki that is only usable with js and non-configurable to be at all usable without js, I'd ask for a poll and agreement in the dev-list lindonb: makes sense - would add ajax as well fabricius: look lindonb I have an intranet with pre-14. I have a bootstrap navbar and in it a quickadmin. Since your commit I cannot use it anymore
I do not like to leave it this way lindonb: if it’s not working with js on that’s a different issue
which should be fixed fabricius: and making JS as default AND non-usable without is a big decition, that includes accessability issues lindonb: I think tiki is more dependent on js and ajax than you realize but if you have a working tiki site with JS truned off then maybe not
in any case it makes sense to have a vote to be sure of the direction wolfganga: If anyone is interested - load time on item updates improved as well - very usable now. ^^ lindonb: way to go wolfganga!
the tracker master! wolfganga: *lol*
^^
btw. the fix for tracker filter from the last days for chosen: is that final? it looks -somehow strange ....
Here a screenshot (i guess the css part for the list is missing) : http://fs2.directupload.net/images/150207/j4ypgpjx.jpg
a minor one for chosen: /themes/base_files/css/chosen-sprite.png Failed to load resource: the server responded with a status of 404 (Not Found)
Edit a comment seems to be broken. The POST rtequest contains the old data instead of the edited one. luciash: anyone fancy to try my inital version of the profile "Hide Fixed Top Nav Bar on Scroll" on trunk ?
just go to your Profiles admin panel and search for "Nav Bar" fabricius: luciash: I'd like to
but does that make sense?
hiding a fixed bar, instead of not making it fixed? luciash: it makes sense when you do not need to see it all the time reading the page while scrolling down - saves space
it gets revealed again on hover or scrolling back to top
lot of room for improvements still, it is just version 0.1 ;)
gotta go now, more tomorrow prolly, bb! fabricius: Hey, just applied ist - it works well - when I deactivate JS, I have no bad effect - so semm to be quite perfect. Thx luciash ! I'd like to recommend it.
joined #tikiwiki Tiki-KGB: 03walper r53842 10trunk/lib/core/Services/Comment/Controller.php
[REF] Removed obsolete code. With the latest changes to save the referer url when using the vi_tpl parameter in tiki-item-view.php, this code is no longer needed.