03jonnybradley r54715 10branches/14.x/lib/setup/javascript.php
[FIX] javascript: Hopefully a fix for js detect following my breaking it in r54597 - will review and test again before 14.0 beta (but committing "early" in case anyone else can test - thanks)
Heh, there's a "Dummy preference" in tiki-admin.php?page=features: "Dummy preference
This is the shorthint.
This is the detail.
This is the hint." I guess a placeholder/model that should have been removed.
(in branch 14)
At first I wondered, "Preference for dummies? Preference about dummies?" :-)
Had to install Tiki branches again locally so a good chance to check things.
Oh, finding regressions in L&F: The full list of theme options is always available, for all themes. (Checking with Firefox on localhost.)
The custom theme URL is always displaying (didn't it used to be hidden unless the custom-url option is chosen?).
(I mean the custom theme URL field.)
Dropdowns (like the quickadmin ellipsis) aren't working here.
03xavidp r54716 10branches/ 1014.x/lib/wiki-plugins/wikiplugin_backlinks.php 1014.x/lib/wiki-plugins/wikiplugin_titlesearch.php
[FIX]Exclude param was not working. There is some warning still, but at least it works as expected for the end user, and param exclude is taken into account and its contents excluded from the list of results shown. Feel free to improve anyone with higer skills than me.
03xavidp r54717 10branches/13.x/ 10lib/wiki-plugins/wikiplugin_titlesearch.php 10lib/wiki-plugins/wikiplugin_backlinks.php
[bp/r54716][FIX]Exclude param was not working. There is some warning still, but at least it works as expected for the end user, and param exclude is taken into account and its contents excluded from the list of results shown. Feel free to improve anyone with higer skills than me.
03xavidp r54718 10branches/12.x/ 10lib/wiki-plugins/wikiplugin_backlinks.php 10lib/wiki-plugins/wikiplugin_titlesearch.php
[bp/r54716][FIX]Exclude param was not working. There is some warning still, but at least it works as expected for the end user, and param exclude is taken into account and its contents excluded from the list of results shown. Feel free to improve anyone with higer skills than me.
hi chibaguy
i was wondering if css rules regarding breadcrumb should be in tiki_base.css or on a per theme basis
i kindof like bootstraps default
no italics, full length
I like flexibility, too, so per theme would be good. I used italic because of the Tiki legacy style, and didn't like the block style when the breadcrumb is short, but that's just my personal opinion.
I like the method of making a variable for styles like that, so it's easier to change than looking through all the css.
So I'll do that with the breadcrumbs.
Ok. What I mean by that is to follow the Bootstrap pattern (or Less pattern) of putting a variable name in a CSS rule and then defining that variable in a separate file.
But I also intend to write up some doc pages about this kind of thing.
polom
chibaguy: i see form the irc log you were having js troubles, not just that old opera browser after all i guess - did http://sourceforge.net/p/tikiwiki/code/54715 fix it for you?
oops, I don't know what happened, but I clicked an external link by mistake (one of the doc.t.o. links on the branch14 default home page) and then tried the dropdowns again and now they don't work.
For my localhost branch 14, each page when it loads needs to have the cookie removed. dropdowns then work until I go to another page.
doc.t.o is WSOD for me too.
hmm, that's changed (and is a bit wrong) - doing a fresh install when i leave the installer i get a page saying "Your account has been validated. You have to choose a password to use this account." and the change password form, not the right message :(
ah, found it - stupid mistake, sorry
03jonnybradley r54720 10branches/14.x/lib/setup/javascript.php
[FIX] javascript: Another fix for js detect - thanks gezza and chibaguy for the feedback (and apologies)
by the way, bootstrap seems to be decidedly non-noscript friendly - menus, login popup, quick admin all don't work (so wouldn't work for screen readers etc) making us less accessible than pre-bootstrap
cool, thanks chibaguy
trouble is there can be lots of ways this breaks, but hopefully this is good enough for 14.0 beta
yes, i'm not expecting tiki in noscript mode to be at all pretty, but it should be functional to an extent
there are lots of clients that have to have accessible sites by law (gov, edu etc)
i thought bootstrap did all that stuff?
like even the standard app menu 42 is unusable
anyway, if this fix is good for gezza too i'll re-release 14.0 beta
certainly search engine crawler bots are noscript
hmm, the accessilbity thing maybe doesn't need js according to http://stackoverflow.com/q/21235312/2459703 anyway, chibaguy and gezza and all, ok to go for 14.0 beta? (i need to get on with other stuff ;) )
interesting link there, thanks jonnyb! "As of 2012, the percentage of screen-reader users who report browsing without JavaScript, according to the WebAIM survey was 1.4%. That number is consistent with, if not lower than, the percentage of all users browsing with JavaScript disabled."
03jonnybradley r54722 10branches/14.x/db/tiki-secdb_14.0_mysql.sql * [REL] SecDB for 14.0beta
03jonnybradley r54723 04tags/14.0beta * [REL] Deleting tag 'tags/14.0beta' in order to create a new one
03jonnybradley r54724 03tags/14.0beta * [REL] Tagging release
chibaguy, jonnyb, gezza I agree aswell, that Tiki should work to an extend (ot necessarily looking pretty) when noscript is on - and there are use cases or communities which are kind of picky towards JS - like dataprotection hack groups ...
fabricius, I agree that this needs to be discussed. But I don't know if we can expect Tiki to function completely without Javascript. Also I don't know what the expectation is for other web applications. Seems like Javascript is woven into just about everything at a low level these days.
But it's good to discuss.
chibaguy, imho there should always be some kind of a basic working navigation for anonymous users and basic content like wikipage, forum, articles etc.
I mean we have a lot of features that require javascript like jQuerySheet or draggable tables in WikiStructures administration etc. - If there are accessible solutions for disabled persons, either their screen readers are JS capaple or we have fallbacks, I do not mind to expect too much no-script consideration, but atleast some basic navigation
I do not like the idea, that a user withno-script active comes to Tiki sites and even cannot navigate to an information page or browse articles.
JS is for extending usability and not for losing
Jyhem_laptop: you have a moment? If so could you have a look in the error_log for doc.t.o and see what's casusing the WSoD when logged in on a wiki page please?
have cleared the caches
anyway, we should discuss over time and as open, that enough people have chances to contribute their concerns. If there is a broad consensus and good arguments and the handicapped people are considered as much as possible, I am fine to accept the desicions of the majority ... just not easily change massive parts without a way back or optionality without consent of the team
Tiki caches are cleared on doc.tiki.org aswell
still WSoD, but not on admin areas
03jonnybradley r54725 10branches/ 1013.x/modules/mod-func-since_last_visit_new.php 1013.x
[bp/r54489][FIX] sylv: Move the modifier include out of the "if comments added" statement and replace with the smarty loadPlugin function (thanks Xavi)
(should fix WSoD on doc.tiki.org hopefully)
03jonnybradley r54726 10branches/ 1012.x 1012.x/modules/mod-func-since_last_visit_new.php
[bp/r54725][bp/r54489][FIX] sylv: Move the modifier include out of the "if comments added" statement and replace with the smarty loadPlugin function (thanks Xavi)
03jonnybradley r54727 10branches/14.x/doc/devtools/tikirelease.sh
[FIX] release: Filter out the ambiguous class warnings from the composer output in the build section
When I click the wrench on tiki-listpages.php, to show the page tools, it tends to stay open. I try clicking on it or outside of it or anywhere, and it stays open.
was thinking of adding some sort of timeout for them, but hopefully i'll be fixed in bootstrap eventually
i fond it mostly on user links info popups (on wiki pages etc)
found
ah, I can dismiss it by hover on another link with a popup.
Like on tiki listpages, dismiss the wrench popup by hovering over the page link.
but if there's no other link, then (in weeks past, anyway) the popup stayed up until I left the page.
chibaguy I feel, that this behaviour changes over times unexpectedly (to me) I do not see, how it should be and if there is a direction to have it consistent, I do not even know, if that is browser-dependant, situation-dependant, item-dependant
chibaguy, in case a functionality is sorted in a template and we have a guide for the standard Tiki legacy themes, anyone is free to change things in an individual theme
chibaguy, jonnyb, gezza we could then consider how strict we want to be with guidelines for pre-shipped (legacy?) themes and to offer a download page for non-guideline individual themes
why not let people offer themes for download on themes.tiki.org which are more customised - we have been discussing this last year anyway and selfcontained themes are optimal for that
(bootstrap functionality I guess)
Yes, that's completely open to people if they want to do that.
And I hope they do want to submit new themes, with all kinds of creative implementations if they like.
another thing jonnyb (mainly?) et al: I have found severe bug in a trunk site when I create tracker items - on saving a NEW tracker item I get a "The connection was reset" error and between one and four identical tracker items are created (see them when I go back) .. when I edit, I have the same error on saving, but no additional items
i tried t come up with some style guideline proposals, but could not really come up with simple rules, so I kindof stuck with this. You can see the draft here, maybe you can help to improve: http://dev.tiki.org/Tiki14StylingProposals
Jyhem_laptop: i've already re-built and uploaded the tarballs so all done
Jyhem_laptop: an svn up on doc.t.o would be nice :)
fabricius: no sorry, was talking to Jyhem_laptop
no idea, I never spent time to understand this server config. i just have access for emergencies
maybe WSoD requires additianal steps ? Let's wait for jonny's return
nelsonko, Jyhem what do you think could be the cause, if tracker-creation on save causes "The connection was reset" error and after the JS/Ajax loaded a while, more than one identical items are created (Trunk)
hehe loool
Tracker item save - error: "The connection was reset" - plus several identical items created
number of identical items depends on the time Ajax loads
average is 3 to 4 items
in Chrome if site is fast or if you quickly enough press the "back" button, you canhave luck and get only one item
trunk for sure
do not want to upgrade the other site
I have two productive collaboration platforms for to associations
one is 14 and one is trunk
in the 14 I do not have (yet), but no recent svn made
ouch - u guide me to the apache logs? it is share hosting with some ssh access
never had any problems server side with this provider for years
very standard and very up to date
both sites (14 and trunk amongst others) on the same server by the way
I am very pretty much sure, that it was not before mid of February, I would say max 2 weeks or so
but a few days ... last week I did sleep every two days due to pressure in projects and thus every 1/2 day postponed the bug report
so just today take time on such things like community info, bug reprt etc.
wondering if it was a fix i did to do with validation, i finally managed to get the tracker edit form to scroll to the validation error (cos on a long form when clicking save the form just stayed there and you had to guess what had happened)
you have jquery validation on?
03jonnybradley r54730 10branches/ 1013.x/templates/admin/include_search.tpl 1013.x 1013.x/templates/tiki-admin.tpl 1013.x/templates/database-connection-error.tpl
[bp/r54729][FIX] multitiki: Show correct console.php command for multitiki sites
(include_search.tpl changed manually as that code has moved to rebuild.tpl in 14.x)
coding's a funny thing, i quoted a client half an hour or so to add a checkbox to make another load of checkboxes toggle - it's more or less a jquery one-liner, and an hour later is still don't have it working!
must be that sort of day! :)
because in the templates/tiki-view_tracker.tpl I only see {icon name="import"} {tr}Import{/tr} and {icon name="export"} {tr}Export{/tr}
abstraction layer wins again :-(
ha ha, they're actually aliasses for download and upload, but the wrong way round :)
for future reference they'ree in themes/base_files/iconsets/default.php
Thanks Jonny, yes, firebug was pretty much showing their real names (download & upload), so I thought I'd find them easily
Am I the only one who can not use drop-down menus on http://demo.tiki.org/14x/ ?
all the icon sets have different names for things, so we need a layer inbetween tiki and the current set, it's a pretty simple abstration really :)
ah, logged in on http://demo.tiki.org/14x/ it fails
looks like the js detect bug, is it up to date?
although i have the javascript_enabled cookie
no jquery :(
possibly it need the fix i made this morning in 14.x?
yes, it needs svn up, it's on 54715 and the fix was in 54720
03xavidp r54733 10branches/ 1014.x/templates/wizard/admin_look_and_feel.tpl 1014.x/templates/wizard/upgrade_new_in_14.tpl 1014.x/templates/wizard/upgrade_new_in_13.tpl 1014.x/lib/wizard/pages/admin_look_and_feel.php
[FIX]Update the options shown in the configuration and upgrade wizards to match current options in Tiki14 (and remove the former ones shown in what's new in Tiki13) to select theme and options, etc. Thumbnail display of the selected theme in real time has been disabled in the wizard because it was not working at all and I couldn't manage to fix it. Some spaces converted to tabs.
one (horrible) way ot do it is to render the contents in a smarty capture and if it's empty don't do anything - but capture is very poor for performance
:)
the alternative is to check all the same things the menu checks, also horrible and duplicates lots of logic
wonder if there's a clever css3 way of doing it - like a "no children" selector
i was thinking about have a Reload or something that is always visible, but does not feel right
like in listings it easy, we can put there "view" action, that should be always available
on one site i did i used the body.grp_Registered class to hide those for anon
hmmm, dummy menu item doesn't really help that much, and this is a problem in quite a few places, not just trackers
unbelievable - 2 hours for 3 lines of jquery - lovely!
yes, i was wondering about a js fix - not great but the otehr options are all nesty too
nasty :)
just for the record, this seems to work to hide empty ellipsis for wikiactions: .icons.btn-group { visibility: hidden;} .icons.btn-group li { visibility: visible;}
but maybe we could introduce a special class for these
instead of using .icons.btn-group