←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
Who | What | When |
---|---|---|
jonnyb | joined #tikiwiki | [00:57] |
............................... (idle for 2h32mn) | ||
trebmuh | luciash, ping
I've svn checkout the branches/19.x and I see a difference between the line in trunk and the line in 19.x in trunk, it is : $item->setLink($URLPrefix.$data['sefurl']); in 19.x it is : $item->setLink($URLPrefix . $data['sefurl']); what should I commit here ? 1) $item->setLink($URLPrefix.urlencode($data['sefurl'])); 2) $item->setLink($URLPrefix . urlencode($data['sefurl'])); ? oh no, I'm wrong it is the same in trunk and in 19.x that's on my install (12.10) which there is no space character still, I'm unsure what to commit 1) $item->setLink($URLPrefix.urlencode($data['sefurl'])); or 2) $item->setLink($URLPrefix . urlencode($data['sefurl'])); ? I'd guess for 2), but I would appreciate a confirmation before breaking everything :) | [03:29] |
................................................................ (idle for 5h16mn) | ||
fabricius | joined #tikiwiki
joined #tikiwiki | [08:50] |
joined #tikiwiki | [09:03] | |
.......... (idle for 45mn) | ||
Jyhem | Hi trebmuh. Your guess of 2) is correct
Both lines do the same anyway. It's just a matter of following our PHP style guide/syntax rules. Nothing would break with 1) | [09:48] |
qwebirc1016958 | joined #tikiwiki
left #tikiwiki | [10:02] |
..... (idle for 20mn) | ||
fabricius | joined #tikiwiki | [10:26] |
jonnyb | joined #tikiwiki | [10:28] |
.............. (idle for 1h8mn) | ||
robertokir | joined #tikiwiki | [11:36] |
jonnyb | polom | [11:40] |
..... (idle for 20mn) | ||
robertokir | moloq! | [12:00] |
................. (idle for 1h22mn) | ||
luciash | pompom | [13:22] |
............. (idle for 1h2mn) | ||
Jyhem | pompompom | [14:24] |
.... (idle for 18mn) | ||
trebmuh | Jyhem, ok, thank you | [14:42] |
...... (idle for 28mn) | ||
ok, I've pushed to 19.x : https://sourceforge.net/p/tikiwiki/code/68543/
please, knowledgeable people, let me know if something is wrong there I'm on the way to backport to 18.x and 15.x too | [15:10] | |
.... (idle for 15mn) | ||
luciash | trebmuh: thank you, your change looks good to me
luciash just wonders why we have setLink and then setlink in the next elseif | [15:25] |
trebmuh | backport done to 18.x : https://sourceforge.net/p/tikiwiki/code/68544/ | [15:28] |
backport done to 15.x : https://sourceforge.net/p/tikiwiki/code/68545/ | [15:39] | |
fabricius | joined #tikiwiki | [15:46] |
trebmuh | and a backport done to 12.x : https://sourceforge.net/p/tikiwiki/code/68545/
(I know that 12.x is EOL but anyway, the patch is now there for 12.x users if needed) luciash, Jyhem and all, I think I'm all good for this fix now, let me know if something else is needed thank you for you help, for your support, and for Tiki! BTW, don't I need to make the fix goes to trunk as well ? | [15:50] |
.... (idle for 15mn) | ||
Jyhem | trebmuh: you are welcome. Thank you for contributing.
no, the fix does not go to trunk as we are still in a semi-auto 19⇔trunk synchronisation phase so it will be merged some time | [16:09] |
luciash | Jyhem: do you see the setLink and setlink suspicious too? | [16:14] |
Jyhem | Hi luciash. I did not notice, and I'm in the the middle of putting som improvements in production right now | [16:27] |
............... (idle for 1h11mn) | ||
jonnyb | joined #tikiwiki | [17:38] |
...... (idle for 27mn) | ||
joined #tikiwiki | [18:05] | |
............ (idle for 57mn) | ||
robertokir | joined #tikiwiki | [19:02] |
................................................. (idle for 4h4mn) | ||
jonnyb | joined #tikiwiki | [23:06] |
...... (idle for 26mn) | ||
fabricius | joined #tikiwiki | [23:32] |
fabricius1 | joined #tikiwiki | [23:37] |
←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |