←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
jonnybjoined #tikiwiki [00:57]
............................... (idle for 2h32mn)
trebmuhluciash, ping
I've svn checkout the branches/19.x
and I see a difference between the line in trunk and the line in 19.x
in trunk, it is : $item->setLink($URLPrefix.$data['sefurl']);
in 19.x it is : $item->setLink($URLPrefix . $data['sefurl']);
what should I commit here ?
1) $item->setLink($URLPrefix.urlencode($data['sefurl']));
2) $item->setLink($URLPrefix . urlencode($data['sefurl']));
?
oh no, I'm wrong
it is the same in trunk and in 19.x
that's on my install (12.10) which there is no space character
still, I'm unsure what to commit
1) $item->setLink($URLPrefix.urlencode($data['sefurl']));
or
2) $item->setLink($URLPrefix . urlencode($data['sefurl']));
?
I'd guess for 2), but I would appreciate a confirmation before breaking everything :)
[03:29]
................................................................ (idle for 5h16mn)
fabriciusjoined #tikiwiki
joined #tikiwiki
[08:50]
joined #tikiwiki [09:03]
.......... (idle for 45mn)
JyhemHi trebmuh. Your guess of 2) is correct
Both lines do the same anyway. It's just a matter of following our PHP style guide/syntax rules. Nothing would break with 1)
[09:48]
qwebirc1016958joined #tikiwiki
left #tikiwiki
[10:02]
..... (idle for 20mn)
fabriciusjoined #tikiwiki [10:26]
jonnybjoined #tikiwiki [10:28]
.............. (idle for 1h8mn)
robertokirjoined #tikiwiki [11:36]
jonnybpolom [11:40]
..... (idle for 20mn)
robertokirmoloq! [12:00]
................. (idle for 1h22mn)
luciashpompom [13:22]
............. (idle for 1h2mn)
Jyhempompompom [14:24]
.... (idle for 18mn)
trebmuhJyhem, ok, thank you [14:42]
...... (idle for 28mn)
ok, I've pushed to 19.x : https://sourceforge.net/p/tikiwiki/code/68543/
please, knowledgeable people, let me know if something is wrong there
I'm on the way to backport to 18.x and 15.x too
[15:10]
.... (idle for 15mn)
luciashtrebmuh: thank you, your change looks good to me
luciash just wonders why we have setLink and then setlink in the next elseif
[15:25]
trebmuhbackport done to 18.x : https://sourceforge.net/p/tikiwiki/code/68544/ [15:28]
backport done to 15.x : https://sourceforge.net/p/tikiwiki/code/68545/ [15:39]
fabriciusjoined #tikiwiki [15:46]
trebmuhand a backport done to 12.x : https://sourceforge.net/p/tikiwiki/code/68545/
(I know that 12.x is EOL but anyway, the patch is now there for 12.x users if needed)
luciash, Jyhem and all, I think I'm all good for this fix now, let me know if something else is needed
thank you for you help, for your support, and for Tiki!
BTW, don't I need to make the fix goes to trunk as well ?
[15:50]
.... (idle for 15mn)
Jyhemtrebmuh: you are welcome. Thank you for contributing.
no, the fix does not go to trunk as we are still in a semi-auto 19⇔trunk synchronisation phase
so it will be merged some time
[16:09]
luciashJyhem: do you see the setLink and setlink suspicious too? [16:14]
JyhemHi luciash. I did not notice, and I'm in the the middle of putting som improvements in production right now [16:27]
............... (idle for 1h11mn)
jonnybjoined #tikiwiki [17:38]
...... (idle for 27mn)
joined #tikiwiki [18:05]
............ (idle for 57mn)
robertokirjoined #tikiwiki [19:02]
................................................. (idle for 4h4mn)
jonnybjoined #tikiwiki [23:06]
...... (idle for 26mn)
fabriciusjoined #tikiwiki [23:32]
fabricius1joined #tikiwiki [23:37]

←Prev date Next date→ Show only urls(Click on time to select a line by its url)