←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
ricks99joined #tikiwiki [00:09]
........ (idle for 38mn)
Jyhem_laptop_joined #tikiwiki [00:47]
.......................................................................................................................................... (idle for 11h28mn)
jonnybjoined #tikiwiki [12:15]
................. (idle for 1h21mn)
luciash¡ɯoןod
still time to commit fixes for 19.1
?
I see, it is cheduled for Monday afternoon... ok
(s on my keyborad is intermittently refusing to work, orry)
[13:36]
.................................................. (idle for 4h5mn)
jonnybhi luciash - orry, missed your post earlier, yes, 19.1 should happen tomorrow (europe) afternoon :) [17:44]
luciashhi ho jonnyb :) np
jonnyb: looking at your CSS issue now
[17:56]
jonnybthe jquery-ui one? thanks - it's weird (like i've forgotten how to do css ;) ) [17:57]
luciashyep, do you have a demo online or should I try to reproduce somehow
ui datepicker is on tracker date field?
[18:00]
ok, added it to my demo tracker [18:10]
jonnybor in the calendar [18:10]
luciashweird is it has border-bottom-width: 0 (why?) but that is something else
you want the background, right?
[18:10]
jonnybi know, that also doesnt seem to work (and would look odd imho anyway)
the border of the selected day should be a different colour from the rest
[18:11]
luciasheh, it shows up here with that bottom border removed actually [18:12]
jonnybmaybe background too in some themes (jquery-ui themes)
oh?
[18:12]
luciashusing Yeti theme [18:13]
jonnyblet me recheck... [18:13]
luciashit applies the border-bottom-width: 0;
but background color is #fff
[18:14]
jonnybactually, yes the silly no bottom border does with for me, but the colour doesn't, but now i see an error saying invalid property value: border: 1px solid #e9ecef #e9ecef #dee2e6;
only 3 colours defined maybe?
yup, that's it
[18:15]
luciashimho the problem is that the ui-state-default should not be there when it has ui-state-active
then to override that you would need .ui-state-default.ui-state-active selector
ah, dunno how it defnes these 3 colors, in the scss I see only border: 1px solid $ui-active-border-color;
jonnyb: so did you found a fix?
s/found/find/
[18:17]
jonnybi found the definition in vendor_bundled/vendor/twbs/bootstrap/scss/_variables.scss:630 but that's not helping much ;)
what does "!default" mean?
[18:22]
luciashI don't know, a nonsense?
or is it special SASS thingy?
there was only !important in CS, or... ?
CSS
I see, it must be SCSS
but that is for nav-tabs
how is that related to calendar day?
jonnyb: what theme are you testing with?
[18:23]
jonnybbootstrap default (but have tried others)
the problem is that the syntax in the css comes out invalid - border-color: #e9ecef #e9ecef #dee2e6; is ok, but border: 1px solid #e9ecef #e9ecef #dee2e6; is not
(according to Chrome and PhpStorm)
[18:30]
luciashit works for me in hrome code inspector, should I try on the scss and compile?
s/hrome/Chrome
I must admit I do not see border: 1px solid #e9ecef #e9ecef #dee2e6; in my Chrome inspector but border: 1px solid rgba(0, 0, 0, 0.1);
with Yeti theme
let me swicth to default BS
[18:32]
jonnybi think i have a fix... [18:36]
luciashah, I see the same with BS default theme
jonnyb: it seems Yeti has it all right but Default theme doesn't
[18:37]
jonnybhmm, let me try yeti with my fix [18:38]
luciashjonnyb: I think the definition of $ui-active-border-color for the default theme is wrong, but for Yeti it is OK [18:40]
jonnybaha, ok, yeti has $ui-active-border-color defined as just one colour, other themes seem to use 3 or 4 colours... [18:40]
luciashyep, that is what I mean [18:40]
jonnybi reckon the no bottom border is intended for tabs, not anything else... will test before committing [18:41]
luciashthe other themes maybe try to have slightly different color for each side of the border
adding the fourth color for them should not hurt
[18:41]
jonnybhmm, seems yeti defines normal and active as the same colour, so a bit hard to tell! :P [18:42]
luciashhehe, true :) [18:43]
jonnybit doesn't matter how many colours, if there are more than one you need to use border-color explicitly (from what i can tell) [18:43]
luciashjonnyb: ok, the themes who specify 3 or 4 are wrong then
maybe it was working well in LESS before but during the tranition to SCSS it was left there
[18:44]
jonnybui-tabs-active seems to be unaffected
yes, maybe - but i think Gary did a lot of overriding the jquery-ui classes to make it all look more bootstrap-like
[18:45]
luciashI don't understand how is your last msg related to what I said but anyway... :)
I mean if it causes errors, there should be only one color defined, or border-color used explicitly as you said
[18:51]
jonnybi meant it's not just the change from bs3 (less) to bs4 (scss) that has changed [18:54]
luciashsure [18:54]
jonnybwhile we're on this luciash, any idea what "prefers-reduced-motion" means? we seem to ahve lots of them and phpstorm shows them all to be an error [18:55]
luciashI meant it was just copy-pasted but maybe not tested well with all the themes
huh?
never seen that :)
[18:55]
jonnybe.g. in themes/litera/css/litera.css:3828 [18:55]
luciash(because I don't use PHPStorm probably) [18:55]
jonnybalso themes/fivealive-lite/css/fivealive-lite.css:2482
e.g. @media screen and (prefers-reduced-motion: reduce) {
[18:55]
luciashhmm, sorry, must be something new
I never heard about that in CSS
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
[18:56]
jonnybme neither - it's also in yeti.css a lot
jonnyb reads
[18:58]
luciashit is a draft I reckon
"Media Queries Level 5"
[18:58]
jonnybaha right, yes firefox and safari only [18:59]
luciashsupported only by few
yup yup
[18:59]
jonnybseems a little risky for production/stable then? [18:59]
luciashmaybe BS4 guys are too enthusiastic about introducing new fancy CSS features ;)
or Gary? :)
gtg, bbl
bb
[18:59]
...................................... (idle for 3h9mn)
robertokirjoined #tikiwiki [22:11]
....... (idle for 32mn)
ricks99joined #tikiwiki [22:43]
............ (idle for 59mn)
robertokirjoined #tikiwiki [23:42]

←Prev date Next date→ Show only urls(Click on time to select a line by its url)