lhtseng: joined #tikiwiki
fabricius: joined #tikiwiki
xavi: joined #tikiwiki
left #tikiwiki
trebmuh: joined #tikiwiki
robertokir: joined #tikiwiki
Tiki|bot: Recent Bug: - JavaScript spelling - http://dev.tiki.org/item7022-JavaScript-spelling
jonnyb: joined #tikiwiki
ricks99: joined #tikiwiki
RadoS: joined #tikiwiki
luciash: polom!
we should probably use these "shims" for people upgrading from FontAwesome v4 to v5: https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#shims
may I add it to the trunk?
jonnyb: pompom luciash
luciash: in lib/setup/theme.php:65 prolly
jonnyb: i thought we'd done most of the re-mapping by now, no?
luciash: no
jonnyb: really, we still have broken ones?
luciash: sadly it does not cover icons like line-chart or file-text-o which are used in wiki pages etc.
jonnyb: i'm just a little against adding these "migration" things as we al;ways get stuck with them (like the jquery one we really should get rid of)
luciash: they are chart-line and text-alt in v5
jonnyb: isn't it better to correct the pages, rather than just cover it up?
luciash: heheh, yep, that is true :) we get stuck with them forever ;)
it is lot of manual replacing overhead
jonnyb: i noticed pom2ter added a bunch of aliasses to themes/base_files/iconsets/default.php - i suppose this means they could go
luciash: maybe a pref for people who migrate and remove it in next LTS?
jonnyb: up to you, i suppose i'm -½ but not too bothered really ;)
could be, i guess it will add a bit more to the page payload, so a pref would be nice
meanwhile, i need lunch, bbl :)
luciash: bon eppetit
jonnyb: ta
luciash: OK, maybe if I just add the aliases there too, that can work as well
jonnyb: joined #tikiwiki
ricks99: joined #tikiwiki
jonnyb: joined #tikiwiki
giesen: joined #tikiwiki
jonnyb: joined #tikiwiki