[00:21] fabricius joined #tikiwiki
[08:03] gour joined #tikiwiki
[08:27] trebmuh joined #tikiwiki
[08:37] robertokir joined #tikiwiki
[08:57] gour morning all
[09:48] luciash polom
[09:48] luciash hi gour
[09:49] gour hello luciash
[09:54] luciash gour: to compile the scss just run php71 console.php to see list of the available commands
[09:54] luciash iirc the command is scss:compile
[09:54] gour luciash: ok, i'm wondering whether i should add style to _variables.scss?
[09:55] luciash hmm, is it a variable?
[09:55] gour nope, but there is no _custom.scss?
[09:57] gour or just in default.scss?
[09:57] luciash I think you can add it to where the current blockquote style rules are or _tiki-miscellaneous_global.scss
[09:57] luciash let me grep
[09:58] luciash seems there is none
[09:58] luciash so add it to the misc global I guess
[09:59] gour ok
[10:00] luciash then run: php71 console.php scss:compile base_files
[10:01] luciash (or php if that is your command line php 7.1 command)
[10:01] luciash seems blockquote is not styled by default in BS4
[10:02] * gour nods
[10:02] luciash that is why in Tiki 19/20.x it is so
[10:03] gour ok, it looks i've to clone the whole repo to get 20.x branch
[10:04] luciash gour: hmm, just do git fetch 20.x no?
[10:04] luciash to switch to that branch
[10:04] luciash ah, you got only master?
[10:04] luciash cloned?
[10:04] gour yep
[10:05] luciash ok, keep it like you have it on master if that is an issue
[10:05] luciash I guess fabio can handle that by cherry-picking or something when merging (I will leave it to him ;))
[10:05] gour i wonder why 20.x is not shown although the whole repo is 3.4G, it should contain everything
[10:05] luciash yeah
[10:06] luciash gour: it shows 20.x to me in your clone here -> https://gitlab.com/gour/tiki
[10:06] gour luciash: ok, i'll sort it out
[10:07] luciash a typo?
[10:08] gour you're correct, all the branches are there, but why not shown in my local repo
[10:12] luciash gour: you need to checkout it first?
[10:13] luciash git checkout 20.x
[10:29] gour i'm finding my way through git as well being long-time fossil user
[10:29] gour luciash: btw, have you seen markdown-extra using parsedown lib?
[10:54] luciash yes
[10:55] gour it should be, imho, enhanced to allow passing parameters for the parsing instance
[10:56] luciash good poc it works but it must really be done through packages, not adding it to satis.json - Tiki cannot grow indefinitely
[10:57] gour my idea is that parsedown is already listed and has, afaict, good coverage of CommonMark and by adding parsedown-extra, we get support of 'Extra' markup as well
[10:58] luciash i thought you said it is already in Tiki but I have seen from the git commit you added both parsedown and parsedown-extra there
[10:58] luciash what do you mean by "already listed" ?
[10:59] luciash it was not listed in satis afaic
[10:59] luciash s
[11:07] gour it's in composer.json
[11:07] gour *it was
[11:12] luciash indeed, weird it is not in satis.json then...
[11:14] gour that's above my head atm :-)
[11:14] * luciash wonders where in Tiki it is actually used when it was added there
[11:15] luciash gour: btw, why did you change from beta-5 to beta-4?
[11:16] gour luciash: i see it's listed here - requires (dev): https://packagist.org/packages/league/commonmark
[11:16] gour requirement for parsedown-extra - https://packagist.org/packages/erusev/parsedown-extra#dev-master
[11:16] luciash gour: ahhh, then it is actually used by the phpleague commonpark integration of PluginMarkdown it seems?
[11:17] gour hopefully there will be new parsedown release soon to sort out those deps
[11:17] luciash s/commonpark/commonmark
[11:21] luciash as far as i understand it it is only required for dev (development?) of the league/commonmark
[11:22] luciash why don't we just add the https://packagist.org/packages/league/commonmark-extras then? (for the extra features?)
[11:23] luciash ah, because there are only 4 extensions?
[11:27] gour luciash: there is no support for e.g. adding classes to images and https://packagist.org/packages/webuni/commonmark-attributes-extension has some strange dep issues...otoh, parsedown(-extra) "just works" , it's fast and used by many CMS-es
[11:27] luciash I must admit I'm slowly getting lost in all those markdown extras and flavors :-/
[11:27] gour :-)
[11:29] luciash many CMS-es you mean only those obscure named ones listed here? -> https://packagist.org/packages/erusev/parsedown-extra
[11:29] luciash :)
[11:29] gour markdown-extra is mature flavour within PHP community and parsedown does good support of commonmark, it's used a lot and parsedown-extra brings additional features without fiddling with too many extension packages which, imho, makes everything very clear. plugin should just have an option to enable 'extra'
[11:30] luciash October CMS, Bolt CMS, Kirby CMS, Grav CMS, Statamic CMS
[11:30] gour take a look here: https://packagist.org/packages/erusev/parsedown
[11:31] gour i'd say that Grav, Kirby, Statamic, Ovtober are quite popular, some are even commercial
[11:31] * gour is working on SCSS issue
[11:36] * luciash never heard about them (feels outdated and old :D)
[11:36] gour luciash: don't forget that most of old CMS-es do not support markdown, it's mostly feature of new (flat-file etc.) ones
[11:36] luciash gour: good luck!
[11:39] luciash gour: if you feel erusev is more mature choice than phpleague, please just replace before final 20.x release otherwise we need to stick with what we have now (at least for Tiki 20.x)
[11:39] luciash i should be working on something else to pay my bills now (running out of time, sorry)
[11:40] luciash and update the doc and dev pages of PluginMarkdown pls
[11:47] gour luciash: here is the shot of new 'blockquote' - i'll update my server soon https://pasteboard.co/IjcK1cY.png
[11:48] gour luciash: ok, i'll try. do you do Tiki-stuff for your 'bills'
[11:49] gour should i do PR?
[11:51] luciash gour: yep, some Tiki, some Graphics/static sites and some Prestashop
[11:52] luciash gour: that paste looks good t!
[11:52] luciash *to me!
[11:52] gour đź‘Ť
[11:53] luciash yup, please do PR
[11:53] luciash or update the current one
[11:59] gour i did a new one not being sure how to update the old one
[11:59] * gour still has to learn a lot
[12:02] luciash just commit and push should add to it
[12:03] luciash iirc
[12:03] luciash till the PR is open and your branch exists
[12:06] gour ok. i did commit and pushed - it's visible at gitlab
[13:53] fabricius joined #tikiwiki
[15:19] gour luciash: i've done some investigation about PHP parser libs and I got info that your choice - thephpleague/commonmark might be the best option - people say "incredibly well written code". moreover, when looking further i found the following issue: https://github.com/thephpleague/commonmark/issues/309 and the answer clicked in my mind, iow. "If you really wanted full control over the HTML attributes, I'd
[15:19] gour recommend simply including that HTML inside your Markdown..." which would also solve my issue of passing parameters, e.g. i'd just use:
[15:21] gour however for that to work, the parameter 'html_input' => 'escape' should be removed so that one can use HTML along with Markdown. i can confirm that it works with the quotes (https://dev.tiki.org/item7089-Markdown-plugin-does-not-parse-quoted-text-properly?highlight=quote+plugin), but wonder about possible security-issues?
[15:23] gour CommonMark package doc says: "If you’re developing an application which renders user-provided Markdown from potentially untrusted users...", so wonder whether we should take care about it within Tiki administration or within plugin itself?
[15:24] gour by letting one using HTML (iow. not escaping HTML), we could get 'extra' features for free without using additional packages. what do you think?
[15:25] gour maybe, the plugin can have options to enable/disable html_input & allow_unsafe_links params from within admin area?
[16:06] gour_ joined #tikiwiki
[16:48] gour ahh, now i recall that escaping html_input was required for other reasons... :-(
[17:15] robertokir joined #tikiwiki
[17:21] gour actually, without 'html_input' => 'escape' it looks good, i only have some problems on my localhost
[17:23] robertokir joined #tikiwiki
[17:57] gour luciash: if you can give 'green light' for plugin not to use 'html_input' => 'escape' i can start working on migrating my sites to Tiki, since that allows me to use HTML directly in markdown markup
[19:22] Tiki|bot Recent Bug: - Expand Table feature in LIST Plugin conflicts with jqDoubleScroll - http://dev.tiki.org/item7096-Expand-Table-feature-in-LIST-Plugin-conflicts-with-jqDoubleScroll
[21:09] fabricius joined #tikiwiki