gour: joined #tikiwiki trebmuh: joined #tikiwiki robertokir: joined #tikiwiki gour: morning all luciash: polom
hi gour gour: hello luciash luciash: gour: to compile the scss just run php71 console.php to see list of the available commands
iirc the command is scss:compile gour: luciash: ok, i'm wondering whether i should add style to _variables.scss? luciash: hmm, is it a variable? gour: nope, but there is no _custom.scss?
or just in default.scss? luciash: I think you can add it to where the current blockquote style rules are or _tiki-miscellaneous_global.scss
let me grep
seems there is none
so add it to the misc global I guess gour: ok luciash: then run: php71 console.php scss:compile base_files
(or php if that is your command line php 7.1 command)
seems blockquote is not styled by default in BS4 -: gour nods luciash: that is why in Tiki 19/20.x it is so gour: ok, it looks i've to clone the whole repo to get 20.x branch luciash: gour: hmm, just do git fetch 20.x no?
to switch to that branch
ah, you got only master?
cloned? gour: yep luciash: ok, keep it like you have it on master if that is an issue
I guess fabio can handle that by cherry-picking or something when merging (I will leave it to him ;)) gour: i wonder why 20.x is not shown although the whole repo is 3.4G, it should contain everything luciash: yeah
gour: it shows 20.x to me in your clone here -> https://gitlab.com/gour/tiki gour: luciash: ok, i'll sort it out luciash: a typo? gour: you're correct, all the branches are there, but why not shown in my local repo luciash: gour: you need to checkout it first?
git checkout 20.x gour: i'm finding my way through git as well being long-time fossil user
luciash: btw, have you seen markdown-extra using parsedown lib? luciash: yes gour: it should be, imho, enhanced to allow passing parameters for the parsing instance luciash: good poc it works but it must really be done through packages, not adding it to satis.json - Tiki cannot grow indefinitely gour: my idea is that parsedown is already listed and has, afaict, good coverage of CommonMark and by adding parsedown-extra, we get support of 'Extra' markup as well luciash: i thought you said it is already in Tiki but I have seen from the git commit you added both parsedown and parsedown-extra there
what do you mean by "already listed" ?
it was not listed in satis afaic
s gour: it's in composer.json
*it was luciash: indeed, weird it is not in satis.json then... gour: that's above my head atm :-) -: luciash wonders where in Tiki it is actually used when it was added there luciash: gour: btw, why did you change from beta-5 to beta-4? gour: luciash: i see it's listed here - requires (dev): https://packagist.org/packages/league/commonmark
requirement for parsedown-extra - https://packagist.org/packages/erusev/parsedown-extra#dev-master luciash: gour: ahhh, then it is actually used by the phpleague commonpark integration of PluginMarkdown it seems? gour: hopefully there will be new parsedown release soon to sort out those deps luciash: s/commonpark/commonmark
as far as i understand it it is only required for dev (development?) of the league/commonmark
why don't we just add the https://packagist.org/packages/league/commonmark-extras then? (for the extra features?)
ah, because there are only 4 extensions? gour: luciash: there is no support for e.g. adding classes to images and https://packagist.org/packages/webuni/commonmark-attributes-extension has some strange dep issues...otoh, parsedown(-extra) "just works" , it's fast and used by many CMS-es luciash: I must admit I'm slowly getting lost in all those markdown extras and flavors :-/ gour: :-) luciash: many CMS-es you mean only those obscure named ones listed here? -> https://packagist.org/packages/erusev/parsedown-extra
:) gour: markdown-extra is mature flavour within PHP community and parsedown does good support of commonmark, it's used a lot and parsedown-extra brings additional features without fiddling with too many extension packages which, imho, makes everything very clear. plugin should just have an option to enable 'extra' luciash: October CMS, Bolt CMS, Kirby CMS, Grav CMS, Statamic CMS gour: take a look here: https://packagist.org/packages/erusev/parsedown
i'd say that Grav, Kirby, Statamic, Ovtober are quite popular, some are even commercial -: gour is working on SCSS issue
luciash never heard about them (feels outdated and old :D) gour: luciash: don't forget that most of old CMS-es do not support markdown, it's mostly feature of new (flat-file etc.) ones luciash: gour: good luck!
gour: if you feel erusev is more mature choice than phpleague, please just replace before final 20.x release otherwise we need to stick with what we have now (at least for Tiki 20.x)
i should be working on something else to pay my bills now (running out of time, sorry)
and update the doc and dev pages of PluginMarkdown pls gour: luciash: here is the shot of new 'blockquote' - i'll update my server soon https://pasteboard.co/IjcK1cY.png
luciash: ok, i'll try. do you do Tiki-stuff for your 'bills'
should i do PR? luciash: gour: yep, some Tiki, some Graphics/static sites and some Prestashop
gour: that paste looks good t!
*to me! gour: 👍 luciash: yup, please do PR
or update the current one gour: i did a new one not being sure how to update the old one -: gour still has to learn a lot luciash: just commit and push should add to it
iirc
till the PR is open and your branch exists gour: ok. i did commit and pushed - it's visible at gitlab fabricius: joined #tikiwiki gour: luciash: i've done some investigation about PHP parser libs and I got info that your choice - thephpleague/commonmark might be the best option - people say "incredibly well written code". moreover, when looking further i found the following issue: https://github.com/thephpleague/commonmark/issues/309 and the answer clicked in my mind, iow. "If you really wanted full control over the HTML attributes, I'd
recommend simply including that HTML inside your Markdown..." which would also solve my issue of passing parameters, e.g. i'd just use: <img src="/everything-is-awesome.png" class="img-responsive" alt="Description of my image">
however for that to work, the parameter 'html_input' => 'escape' should be removed so that one can use HTML along with Markdown. i can confirm that it works with the quotes (https://dev.tiki.org/item7089-Markdown-plugin-does-not-parse-quoted-text-properly?highlight=quote+plugin), but wonder about possible security-issues?
CommonMark package doc says: "If you’re developing an application which renders user-provided Markdown from potentially untrusted users...", so wonder whether we should take care about it within Tiki administration or within plugin itself?
by letting one using HTML (iow. not escaping HTML), we could get 'extra' features for free without using additional packages. what do you think?
maybe, the plugin can have options to enable/disable html_input & allow_unsafe_links params from within admin area? gour_: joined #tikiwiki gour: ahh, now i recall that escaping html_input was required for other reasons... :-( robertokir: joined #tikiwiki gour: actually, without 'html_input' => 'escape' it looks good, i only have some problems on my localhost robertokir: joined #tikiwiki gour: luciash: if you can give 'green light' for plugin not to use 'html_input' => 'escape' i can start working on migrating my sites to Tiki, since that allows me to use HTML <img> directly in markdown markup Tiki|bot: Recent Bug: - Expand Table feature in LIST Plugin conflicts with jqDoubleScroll - http://dev.tiki.org/item7096-Expand-Table-feature-in-LIST-Plugin-conflicts-with-jqDoubleScroll fabricius: joined #tikiwiki