←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
Who | What | When |
---|---|---|
*** | kiilo has quit IRC (Ping timeout: 248 seconds) | [00:04] |
............ (idle for 58mn) | ||
Tiki|bot has joined #tikiwiki | [01:02] | |
.... (idle for 17mn) | ||
kiilo has joined #tikiwiki | [01:19] | |
kiilo has quit IRC (Ping timeout: 240 seconds)
lindonb has joined #tikiwiki | [01:25] | |
Caarrie|away is now known as Caarrie|sleeping | [01:34] | |
....... (idle for 30mn) | ||
coaboa_ has joined #tikiwiki
coaboa has quit IRC (Ping timeout: 246 seconds) | [02:04] | |
........ (idle for 37mn) | ||
daevermann has joined #tikiwiki
daevermann_ has quit IRC (Ping timeout: 246 seconds) | [02:41] | |
lindonb has quit IRC (Quit: lindonb) | [02:49] | |
.......... (idle for 46mn) | ||
CIA-126 | tikiwiki: 03chealer * r33947 10/trunk/templates/tiki-admin_include_login.tpl: restore Id comment | [03:35] |
tikiwiki: 03chealer * r33948 10/trunk/templates/tiki-export_tracker.tpl: restore Id comment | [03:40] | |
................... (idle for 1h33mn) | ||
tikiwiki: 03chealer * r33949 10/trunk/ (403 files in 17 dirs):
tikiwiki: revert r33217 "~MOD~ Remove unused header comment" tikiwiki: Ref: http://article.gmane.org/gmane.comp.cms.tiki.cvs/63790 (no answer) | [05:13] | |
..... (idle for 21mn) | ||
tikiwiki: 03chealer * r33950 10/trunk/templates/category_related_objects.tpl: [FIX] HTML special characters encoding | [05:34] | |
*** | JoernOtt has joined #tikiwiki | [05:42] |
dthacker has quit IRC (Remote host closed the connection) | [05:55] | |
..... (idle for 24mn) | ||
coaboa_ | good morning tikiverse | [06:19] |
CIA-126 | tikiwiki: 03chealer * r33951 10/trunk/lib/logs/logslib.php: [FIX] Logs: cleaning logs with a certain age leaves some older events (r24869 regression) | [06:20] |
*** | dthacker has joined #tikiwiki | [06:25] |
JoernOtt has quit IRC (Ping timeout: 260 seconds) | [06:38] | |
....... (idle for 33mn) | ||
daevermann has quit IRC (Ping timeout: 240 seconds)
daevermann has joined #tikiwiki | [07:11] | |
.......... (idle for 45mn) | ||
chealer has quit IRC (Remote host closed the connection) | [07:56] | |
....... (idle for 32mn) | ||
chealer has joined #tikiwiki
chealer has quit IRC (Changing host) chealer has joined #tikiwiki | [08:28] | |
...... (idle for 27mn) | ||
Wilkins has joined #tikiwiki | [08:55] | |
....... (idle for 31mn) | ||
JoernOtt has joined #tikiwiki | [09:26] | |
....... (idle for 33mn) | ||
chibaguy has joined #tikiwiki
ChanServ sets mode: +o chibaguy | [09:59] | |
chibaguy | polom | [09:59] |
......... (idle for 42mn) | ||
*** | Caarrie|sleeping is now known as Caarrie|away | [10:41] |
ricks99 has joined #tikiwiki | [10:49] | |
....... (idle for 32mn) | ||
LordVan has joined #tikiwiki | [11:21] | |
ricks99_ has joined #tikiwiki
ricks99 has quit IRC (Remote host closed the connection) ricks99_ is now known as ricks99 | [11:33] | |
ricks99 has quit IRC (Remote host closed the connection) | [11:42] | |
jonnyb has joined #tikiwiki | [11:52] | |
jonnyb | polom | [11:54] |
chibaguy: you about? I have a theme option for Ohia ("Cornflower" - sort of pale blue generally with orange boxes) that's mostly finished for 6.x, but was wondering what to do with it... | [11:59] | |
*** | kiilo has joined #tikiwiki | [11:59] |
chibaguy | hi jonnyb, can it be added to 6.x (proposals) or should it go into trunk and br 7? | [12:10] |
jonnyb | well exactly...
i know i could make some rules up here but... | [12:10] |
chibaguy | Seems like it could go into 6 since it's an optional extra kind of thing. | [12:11] |
jonnyb | it's sort of too late in 7.x for something [NEW], but it can't hurt much
have you changed ohia in 7.x to the new modules stuff? cos i guess that would need doing for this option... | [12:11] |
chibaguy | I think so.
Making the adjustments is pretty quick usually. | [12:12] |
jonnyb | i think i might commit to 7.x as it is, merge to trunk, backport it into 6.x and then remove it from 7.x if i (or anyone) don't get time to fix it up properly for 7.0
complicated isn't it! :) | [12:13] |
*** | SDuensin has left "Leaving" | [12:13] |
chibaguy | yeah. | [12:14] |
I checked ohia.css and it's got the module zone selectors, so if your option css is just the items changed from ohia.css, it should work already in trunk, or nearly so.
well, some class names or elements may need updating, for backgrounds etc. | [12:20] | |
*** | JoernOtt has quit IRC (Ping timeout: 252 seconds) | [12:21] |
..... (idle for 22mn) | ||
jonnyb | thanks for checking chibaguy - should be getting there soon... :)
but first, lunch! | [12:43] |
CIA-126 | tikiwiki: 03jonnybradley * r33952 10/third_party/jquery/ (9 files in 3 dirs): [MOD] update jquery.mobile to 1.0 Alpha 4.1 | [12:52] |
.... (idle for 19mn) | ||
*** | nkoth has joined #tikiwiki
nkoth has quit IRC (Client Quit) nkoth_ has joined #tikiwiki nkoth_ has quit IRC (Client Quit) nkoth has joined #tikiwiki nkoth has quit IRC (Client Quit) nkoth has joined #tikiwiki nkoth has quit IRC (Client Quit) nkoth has joined #tikiwiki | [13:11] |
radek82 has joined #tikiwiki
sylvieg has quit IRC (Ping timeout: 246 seconds) | [13:24] | |
sylvieg has joined #tikiwiki
ChanServ sets mode: +o sylvieg ricks99 has joined #tikiwiki | [13:34] | |
ricks99 has quit IRC (Remote host closed the connection)
RobertPlummer has joined #tikiwiki | [13:41] | |
jonnyb | polom RobertPlummer | [13:42] |
*** | ricks99 has joined #tikiwiki | [13:43] |
RobertPlummer | polom all
polom jonnyb Ok, jonnyb spreadsheet? | [13:44] |
CIA-126 | tikiwiki: 03jonnybradley * r33953 10/trunk/ (12 files in 9 dirs): [MRG] Automatic merge, branches/7.x 33907 to 33946 | [13:45] |
jonnyb | RobertPlummer: i'm planning on fixing the revisions of the external at some point...
exacto! you mentioned about doing a synchronised release of sheet | [13:45] |
RobertPlummer | Yes, that is correct. | [13:45] |
jonnyb | any date planned? | [13:46] |
RobertPlummer | I need to fix 2 problems with it and then it is golden. | [13:46] |
jonnyb | have you branched yet? | [13:48] |
RobertPlummer | Not yet
I've been trying to keep trunk as stable as possible. | [13:51] |
jonnyb | ok, sensible | [13:52] |
radek82 | yeah, you wouldn't want junk in the trunk | [13:52] |
RobertPlummer | 'I could go ahead and branch though, nothing holding me back. | [13:52] |
jonnyb | more for you to maintain though, probably best to leave it as late as possible i guess
what about the other nested externals? jqs5 and the svg thing? | [13:53] |
RobertPlummer | nested externals?
externals within externals? | [13:58] |
jonnyb | the externals inside lib/jquery, which is itself an external (always causes me confusion) | [13:59] |
RobertPlummer | (sounds like the movie Inception)
lol Ideally we'd cut down on how many files are external and only use the ones we need. For instance, inside jquery.sheet we external jquery ui, with is not needed. Marc wants me to make some progress with svg-edit today, which is something I need to address with you as well. | [13:59] |
CIA-126 | tikiwiki: 03jonnybradley * r33954 10/trunk/lib/prefs/mobile.php:
tikiwiki: [FIX] Keep mobile_perspectives preference from setting unexpectedly in the feature admin panel tikiwiki: [bp/r33907] NB: Changes to prefs.php in 7.x need to also now be made in the separate features lib/prefs/ file so they will appear in 8.x onwards | [14:01] |
RobertPlummer | So in short, would you like me to coordinate with you on when the release happens?
I'd like to do a v2 beta possibly next week. I think too with the beta, I'm going to be dropping support for xml. | [14:05] |
jonnyb | well, just switch the external in 7.x to point to the release branch or tag when it's ready (before 7.0) | [14:05] |
RobertPlummer | json or html only | [14:05] |
jonnyb | we use json right? | [14:06] |
RobertPlummer | right
and you use your own version of it. I'll probably be being yours into trunk and dropping what I have currently.... Less to maintain on your part and myn. | [14:06] |
jonnyb | yes, one routine should be enough - i haven't looked at them for ages though, so you know best | [14:07] |
RobertPlummer | On svg-edit, I'm a bit lossed.
The team seems happy to make me one of the commiters, but have yet to follow through, probably much to do like us. | [14:09] |
jonnyb | oh? I'm unlikely to be less lost :P | [14:10] |
RobertPlummer | Marc suggested possibly to edit source IN TIKI of svg-edit.
Rather than using an external. hairy very very hairy | [14:10] |
jonnyb | well you could always make a copy of their stuff in third_party and external link to that, and then modify that pending feeding it back to the project | [14:11] |
RobertPlummer | a dream within a dream stuff again?
:) Ok, that sounds fine, I'd like to make some headway on that today... | [14:12] |
jonnyb | not really - just change the svn:external on lib from http://svg-edit.googlecode.com/svn/trunk/editor/ to https://tikiwiki.svn.sourceforge.net/svnroot/tikiwiki/third_party/svg-edit/ | [14:14] |
*** | LordVan has quit IRC (Quit: Leaving) | [14:18] |
RobertPlummer | As for the height issue with codemirror jonnyb, how about we do a check at startup if the textarea is larger than a certain size, lets say window.height * 0.8, if it is, we make it's height window.height * 0.8, otherwise we make it autogrow? | [14:30] |
CIA-126 | tikiwiki: 03sylvieg * r33955 10/branches/7.x/lib/wiki-plugins/wikiplugin_tracker.php: [FIX]TRACKER: case itemId={{itemId}} with no itemId on the url-> exit | [14:31] |
RobertPlummer | I know that is a little left field, but I remember you talking about it, and I'm getting ready to commit what I have here. | [14:32] |
jonnyb | well the textarea height should be set by the row attribute | [14:32] |
CIA-126 | tikiwiki: 03sampaioprimo * r33956 10/trunk/lang/pt-br/language.php: pt-br translations | [14:32] |
jonnyb | i think for 7.0 just disable auto-grow, or make it only happen if the TA is empty at the start? | [14:32] |
RobertPlummer | Then what should the height be? | [14:37] |
jonnyb | sorry - when it starts? | [14:37] |
RobertPlummer | nm, I tested it inherits from the textarea
ok, we are good. | [14:38] |
jonnyb | same hight as the textarea i'd think
:) have you fixed this thing with the {code} plugin going weird when you have tiki_p_edit on the page? | [14:38] |
RobertPlummer | In read only mode?
Can you give me an example to make sure I have it right? I will go ahead and commit this, then I will resolve that issue. | [14:39] |
jonnyb | 1 min - phone
ok in read-only, bad when you can edit | [14:44] |
CIA-126 | tikiwiki: 03sampaioprimo * r33957 10/trunk/lang/pt-br/language.php: Brazilian Portuguese translations done on i18n.tiki.org | [14:46] |
tikiwiki: 03robertplummer * r33958 10/branches/7.x/ (5 files in 4 dirs):
tikiwiki: [ADD] Parameters syntax and codemirror to smarty textarea block tikiwiki: [MOD] flexibleCodeMirror to only start a codemirror instance if it is forced or textarea parameter "codemirror" = "true" tikiwiki: [MOD] Added new event binding to document, "plugin_ready", which will fire along with "plugin_##type##_ready" | [14:53] | |
tikiwiki: 03sampaioprimo * r33959 10/trunk/lang/fr/language.php: French translations done on i18n.tiki.org
tikiwiki: 03sampaioprimo * r33960 10/trunk/lang/de/language.php: German translations done on i18n.tiki.org tikiwiki: 03sampaioprimo * r33961 10/trunk/lang/hu/language.php: Hungarian translations done on i18n.tiki.org | [14:59] | |
sylvieg | Do we have a generic way to have a {button} with a confirm when clicking on it? | [15:08] |
*** | rodrigo_sampaio has joined #tikiwiki
marclaporte has joined #tikiwiki ChanServ sets mode: +o marclaporte ricks99 has quit IRC (Remote host closed the connection) | [15:11] |
radek82 has quit IRC (Quit: Leaving) | [15:21] | |
CIA-126 | tikiwiki: 03sampaioprimo * r33962 10/branches/proposals/6.x/ (5 files in 4 dirs): [bp/r33946][FIX] blog posts "disappear" for anonymous when upgrading old installations (<=1.9.x) | [15:22] |
*** | marclaporte has quit IRC (Read error: Connection reset by peer) | [15:32] |
CIA-126 | tikiwiki: 03jonnybradley * r33963 10/branches/7.x/templates/tiki-share.tpl: [FIX] Don't show user selector menu even if there is only one user (admin) - thanks Bernard | [15:34] |
*** | chibaguy has quit IRC (Ping timeout: 276 seconds)
nkoth has quit IRC (Quit: nkoth) | [15:44] |
CIA-126 | tikiwiki: 03sampaioprimo * r33964 10/branches/7.x/ (6 files in 6 dirs): backporting translations done on i18n.tiki.org | [15:55] |
*** | radek82 has joined #tikiwiki
Bernard1 has joined #tikiwiki radek82 has quit IRC (Quit: Leaving) | [16:02] |
CIA-126 | tikiwiki: 03jonnybradley * r33965 10/branches/7.x/ (templates/tiki-share.tpl tiki-share.php): [FIX] share: Use user selector for inter-user messages and some fixes so it actually works | [16:08] |
Bernard1 | jonnyb, i remove my comment about "share this page" it's working fine now. | [16:12] |
jonnyb | thanks Bernard1 - i already crossed it out, so it's fine there for a while | [16:13] |
Bernard1 | oh you've done it already, cool ;)
ur too fast for me. ;) | [16:13] |
jonnyb | :) | [16:14] |
CIA-126 | tikiwiki: 03jonnybradley * r33966 10/branches/7.x/templates/tiki-objectpermissions.tpl: [FIX] perms: Missing </div> | [16:14] |
*** | radek82 has joined #tikiwiki | [16:20] |
jonnyb | RobertPlummer: just svn up'ed and the code plugin now still breaks but in a different way - the TA disappears but codemirror doesn't appear
the change highlighter buttons everywhere have gone though, so that's good... | [16:21] |
*** | Wilkins has quit IRC (Ping timeout: 250 seconds) | [16:30] |
RobertPlummer | lol
ok I will fix | [16:42] |
jonnyb | :) | [16:42] |
RobertPlummer | Where does it break specifically?
Is js minify on? | [16:44] |
jonnyb | on a wiki page when you can edit it
no | [16:45] |
RobertPlummer | Oh, refresh your cache for templates ;) | [16:45] |
jonnyb | ah, ok... | [16:46] |
RobertPlummer | Let me know... | [16:46] |
jonnyb | will do - in the middle of something else at the mo | [16:46] |
RobertPlummer | ok
thanks buddy! | [16:46] |
*** | chealer has quit IRC (Remote host closed the connection) | [16:49] |
RobertPlummer | Nope, it is indeed a bug. | [16:50] |
*** | Bernard1 has quit IRC (Ping timeout: 252 seconds) | [16:50] |
CIA-126 | tikiwiki: 03robertplummer * r33967 10/branches/7.x/lib/codemirror_tiki/codemirror_tiki.js: [FIX] Array value for syntax attribute to array in codemirror | [17:03] |
tikiwiki: 03jonnybradley * r33968 10/branches/7.x/lib/wiki-plugins/wikiplugin_trackerfilter.php: [FIX] trackerfilter: get filters even if $export_action set | [17:08] | |
tikiwiki: 03sampaioprimo * r33969 10/trunk/templates/blog_post_status.tpl: proper string handling | [17:22] | |
*** | majmos has joined #tikiwiki | [17:25] |
jonnyb | hey lphuberdeau - you about? | [17:25] |
*** | majmos has quit IRC (Client Quit)
majmos has joined #tikiwiki majmos has left majmos has joined #tikiwiki chealer has joined #tikiwiki chealer has quit IRC (Changing host) chealer has joined #tikiwiki | [17:27] |
CIA-126 | tikiwiki: 03jonnybradley * r33970 10/branches/7.x/lib/tikilib.php: [FIX] plugin_fingerprint: Previously an empty args array actually had an empty item in it, so simulate that so plugins stay approved after upgrade | [17:34] |
*** | ricks99 has joined #tikiwiki
marclaporte has joined #tikiwiki ChanServ sets mode: +o marclaporte | [17:39] |
RobertPlummer | ok guys, how can I safely open an image from the file gallery and ensure I'm not breaking any security or anything?
If it is an svg image, I need to obtain the file as a string. | [17:45] |
CIA-126 | tikiwiki: 03jonnybradley * r33971 10/branches/7.x/styles/jqui.css: [FIX] jqui.css: Better .forum_actions | [17:45] |
jonnyb | RobertPlummer: use tiki-download_file.php?
hmm, see what you mean... curl isn't standard for most php and the fopen thing is bad (so i'm told) | [17:46] |
*** | chealer has quit IRC (Remote host closed the connection)
chealer has joined #tikiwiki chealer has quit IRC (Changing host) chealer has joined #tikiwiki | [17:48] |
jonnyb | wonder if you should just "include" it somehow and capture the output buffer
messy | [17:48] |
chealer | polom | [17:48] |
jonnyb | hi chealer | [17:52] |
chealer | hi jonnyb
jonnyb: why is fopen() bad? | [17:52] |
jonnyb | any idea how RobertPlummer should get the contents of a file in a filegal?
doesn't is say so on the security admin page? the allow_url_fopen thing? | [17:52] |
RobertPlummer | nm, I can just use $('<div />').load(); | [17:54] |
jonnyb | oh yes, in js it's ok | [17:54] |
chealer | jonnyb: OK for allow_url_fopen in general, but you can use fopen() to open a local file safely | [17:55] |
jonnyb | but you need to pass params and run it as a php file, no? | [17:55] |
chealer | hi RobertPlummer. Can I suggest a jQuery.sheet fix? | [17:57] |
RobertPlummer | sure, you wanna be one of the commiters? | [17:58] |
chealer | RobertPlummer: as you want, but I don't intend to fix more for now, it's just a one-liner | [17:58] |
RobertPlummer | What is the fix? | [17:59] |
chealer | RobertPlummer: it's to handle HTML characters in tab names correctly | [18:00] |
RobertPlummer | ah, cool
email me from your address you'd like to gain access to in sheet, and I'll approve it. | [18:00] |
*** | kit has joined #tikiwiki | [18:01] |
chealer | RobertPlummer: in addTab, line 2274
RobertPlummer: the content of the a link is not escaped so change from "jS.sheetTab(true)" to jQuery('<div />').text(jS.sheetTab(true)).html() (apparently there's no better way to HTML escape in JavaScript :-/ | [18:05] |
kit | hey guys, i'm having an issue enabling ajax on a new install of tikiwiki. I recieve a generic error : "Error: the xajax Javascript component could not be included. Perhaps the URL is incorrect? URL: lib/ajax/xajax/xajax_js/xajax_core.js". any thoughts? ajax does not enable at this point. | [18:06] |
chealer | RobertPlummer: I'm not sure what you mean, what about the address? it should be used as a username? my address is chealer@gmail.com in any case.
kit: which version do you use? | [18:10] |
kit | i have installed 6.2 and 6.3, both have the same error in the manner. I am down to server enviornment at this point. | [18:12] |
RobertPlummer | chealer.... added | [18:12] |
chealer | kit: what is the environment? | [18:13] |
kit | iis 7.5 | [18:14] |
chealer | kit: right, I heard about that issue on IIS but was unable to reproduce. check if there's any error fetching that file. | [18:15] |
CIA-126 | tikiwiki: 03jonnybradley * r33972 10/branches/7.x/lib/tiki-js.js: [FIX] wysiwyg: Fix IE breakage trying to get selection from textarea "using" ckeditor (thanks Geoff) | [18:18] |
chealer | RobertPlummer: sorry, what was added? the escaping bit? | [18:20] |
RobertPlummer | No you as a commiter to jQuery.sheet
http://code.google.com/p/jquerysheet/ You can actually make the changes in 7 and then when you go to commit svn should detect the external and do what it needs to. WOOOHOOO! I HAVE SVG-EDIT WORKING! WOOHOO! | [18:20] |
jonnyb | yay! | [18:21] |
RobertPlummer | I just need to make it save and I'll be done, and it'll be ready for 7! | [18:22] |
jonnyb | nice going :) | [18:22] |
RobertPlummer | I want to go ahead and commit, and then work on edit.
the tiki way | [18:23] |
chealer | RobertPlummer: hum, it doesn't seem to commit it | [18:23] |
RobertPlummer | What are you using to commit? | [18:23] |
chealer | I don't understand how the authentication is supposed to work anyway | [18:23] |
RobertPlummer | lol, I use rabbitvcs, and it handles it fine. | [18:23] |
chealer | RobertPlummer: Aptana and the svn binary. the svn binary does nothing
Aptana is completely quiet | [18:24] |
RobertPlummer | Ok, navigate to the folder jquery.sheet, and then try to commit | [18:24] |
chealer | RobertPlummer: good for svg-edit | [18:24] |
RobertPlummer | thanks
Looks like there have been a bunch of improvements since I tried to integrate it last, and there doesn't need to be the same type of changes we needed. We can do a full scale integration. | [18:24] |
chealer | RobertPlummer: OK, that does try to commit now, but it fails with Server sent unexpected return value (405 Method Not Allowed) in response to MKACTIVITY request for '/svn/!svn/act/83b3cecb-577f-4161-bce3-b24398f5d83c' | [18:26] |
RobertPlummer | Aye, you need a real mans svn tool...
What OS are you on? | [18:26] |
chealer | RobertPlummer: Debian testing | [18:26] |
RobertPlummer | look into rabbitvcs, it is awesome.
it is just a ui for svn cli, I run debian too, and love it. It is better than any other svn UI I have seen, windows or linux. | [18:27] |
chealer | RobertPlummer: hum, I'm a KDE guy. and really I don't intend to do more contributions so I would prefer if you could commit it than having to learn new VCS software
I already paid a good SVN toll yesterday | [18:31] |
RobertPlummer | lol
ok, no problem | [18:31] |
CIA-126 | tikiwiki: 03robertplummer * r33973 10/branches/7.x/ (4 files in 3 dirs): [FIX] draw edit, view only. | [18:34] |
RobertPlummer | For those who'd like to test svn-edit or Tiki draw ;) - svn up, upload file to file gallery, click wrench, click edit.
Make sure it is svg | [18:36] |
*** | marclaporte has quit IRC (Read error: Connection reset by peer) | [18:39] |
CIA-126 | tikiwiki: 03jonnybradley * r33974 10/branches/proposals/6.x/lib/tiki-js.js: [bp/r33972][FIX] wysiwyg: Fix IE breakage trying to get selection from textarea "using" ckeditor (thanks Geoff) | [18:43] |
jonnyb | jonnyb svn up's | [18:57] |
sylvieg | does somebody know if there is a way to get the fulle url and the sefurl of the current url... seems that some servers give back the sefurl and other the logn one in HTTP_REFERER... | [18:57] |
jonnyb | hi sylvieg - not off hand (thought you would know if anyone did) | [19:00] |
RobertPlummer | Can someone tell me something about file gallerys? What is needed to post back to tiki-list_file_gallery.php in order to update a file? | [19:00] |
sylvieg | I think thre is code duplication to update a file? | [19:01] |
jonnyb | RobertPlummer: probably just a POST to tiki-upload_file.php? | [19:02] |
sylvieg | or perhaps it posts there to avaoid code duplication | [19:02] |
*** | Bernard1 has joined #tikiwiki | [19:05] |
jonnyb | hmm, RobertPlummer - i get the svg editor (full screen) but no image in there - url is: tiki-edit_draw.php?paramurl=tiki-download_file.php?fileId=27
which is bad as it has two ? in it the second one should be escaped i think | [19:06] |
RobertPlummer | woops, I forgot to fix something there.
Ok, in tiki-upload_file.php I see fileId, but what request param holds the file data? | [19:08] |
jonnyb | even with it escaped as %3F it doesn't show anything (and the file is ok) | [19:09] |
sylvieg | $_FILES? | [19:09] |
RobertPlummer | How do I post it to tiki-upload_file.php?
tiki-upload_file.php?fileId=1&files=filedata? Is that right? | [19:09] |
jonnyb | it's an array - userfile[] | [19:10] |
RobertPlummer | How do I set that from a querystring though or an ajax post? | [19:10] |
jonnyb | try: tiki-upload_file.php?fileId=1&userfile[0]=filedata | [19:10] |
RobertPlummer | jonnyb: You think you are soo smart....
:) | [19:10] |
jonnyb | as a post but you'll need to set the right form type...
:P enctype="multipart/form-data" as an attribute on the form | [19:10] |
RobertPlummer | right | [19:11] |
*** | JoernOtt has joined #tikiwiki | [19:14] |
RobertPlummer | jonnyb, for an ajax post, I can't use userfile[0], expecially if the file has non url safe characters.
What other alternatives should I use? | [19:21] |
CIA-126 | tikiwiki: 03sylvieg * r33975 10/branches/7.x/tiki-switch_lang.php: [FIX]i18n: very dirty patch: avoid to go to a wiki page when switching from a cat1111 (tiki-browse_cvateories.php) - HTTP_REFERER contains the short url not the long one | [19:21] |
jonnyb | hmm - try escaping it? | [19:22] |
RobertPlummer | I have to use something like $.post(url, {userfile: data}, successFn);
With javascript? | [19:22] |
jonnyb | escape("userfile[0]")
might work... | [19:22] |
RobertPlummer | seems a little "hacky" | [19:23] |
jonnyb | comes out as userfile%5B0%5D | [19:23] |
RobertPlummer | ah, got you. | [19:23] |
jonnyb | not reaslly - it's urlencoding
probably needs doing to the data too there's a better encode fn... encodeURIComponent() | [19:23] |
RobertPlummer | See comment above about jonnyb & smart
jk Thanks jonnyb , good find! | [19:24] |
jonnyb | jonnyb refers to his previous simley | [19:25] |
*** | marclaporte has joined #tikiwiki
ChanServ sets mode: +o marclaporte | [19:30] |
RobertPlummer | So this should work to save file? encodeURIComponent('tiki-upload_file.php?fileId=$fileId&userfile[0]=' + data + '&enctype=multipart/form-data') | [19:38] |
*** | ricks99 has quit IRC (Quit: Now available, the first and only Tiki book. Get it at http://twessentials.keycontent.org) | [19:38] |
jonnyb | not sure - that's not really what i meant
i meant just encode the userfile[0] bit | [19:39] |
RobertPlummer | ah | [19:39] |
jonnyb | and use ajax as before | [19:39] |
RobertPlummer | trying... | [19:39] |
jonnyb | it needs to be a POST i believe | [19:40] |
RobertPlummer | Like this: $.post('tiki-upload_file.php?fileId=$fileId&' + encodeURIComponent('userfile[0]') + '=' + data + '&enctype=multipart/form-data', function() { alert('Success!'); });
Is that right? | [19:41] |
jonnyb | no, put the params in an object | [19:42] |
RobertPlummer | oh, ok
You da man | [19:42] |
jonnyb | maybe
the php may still not like it... but i think it happens like that elsewhere | [19:42] |
RobertPlummer | { fileId: $fileId, encodeURIComponent('userfile[0]'): data, enctype: 'multipart/form-data' } fails
you can't use a function for the start of an object's child name What do you think jonnyb? Sorry to pester | [19:46] |
jonnyb | um... you need to add the enctype as an attribute of the post
might need the $.ajax fn for that and just use userfile%5B0%5D as the key | [19:47] |
chealer | RobertPlummer: hum, I'm following loosely, but I doubt you want to encode userfile[0] if it's a parameter name, you must want to encode the value, data | [19:49] |
jonnyb | maybe you don't need the [0] bit at all - good point chealer | [19:50] |
RobertPlummer | See comment above in reference to jonny & smart, reference chealer too.
THanks guys honestly! | [19:51] |
marclaporte | kit : are you finding a solution? | [20:00] |
Tiki|bot | New Forum Posts: File Gallery Listing error - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061 New Forum Posts: How to track users vs pages? - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059 | [20:14] |
New Forum Posts: File Gallery Listing error - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061 New Forum Posts: How to track users vs pages? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059 | [20:24] | |
*** | marclaporte has quit IRC (Read error: Connection reset by peer) | [20:26] |
CIA-126 | tikiwiki: 03jonnybradley * r33976 10/branches/7.x/lib/filegals/filegallib.php: [FIX] fgals: catch exception when batch uploading | [20:32] |
*** | JoernOtt has quit IRC () | [20:34] |
..... (idle for 21mn) | ||
Tiki|bot | New Forum Posts: File Gallery Listing error - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061 New Forum Posts: How to track users vs pages? - https://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059 | [20:55] |
RobertPlummer | chealer, jonnyb, I found out why it wasen't working....
you can't upload files with ajax I guess. odd | [21:02] |
jonnyb | usually
bleh so are you making a <form>? | [21:02] |
Tiki|bot | New Forum Posts: File Gallery Listing error - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41066
New Forum Posts: Forum posts only displaying "new" icon - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41061 New Forum Posts: How to track users vs pages? - http://tiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=41059 | [21:05] |
RobertPlummer | yuo
yup seems to work better anyway. More fluid When you are done editing a file, you'd want to go back to the gallery. | [21:05] |
jonnyb | true
btw; does the svg-edit need to be full page? or is it a bug? (safari) | [21:06] |
RobertPlummer | Yea, full page only at this time.
Ok, input type="file" produces a file selector, how to I inject the value into the input's value? This is driving me nuts. | [21:13] |
jonnyb | .value(data) ? | [21:15] |
CIA-126 | tikiwiki: 03jonnybradley * r33977 10/branches/7.x/templates/tiki-admin_categories.tpl: [FIX] categs: Rogue </b> | [21:15] |
RobertPlummer | Forget it, I'm just going to write me own sql. | [21:15] |
jonnyb | you're into new territory there RobertPlummer :)
don't forget permissions checking... not trivial... | [21:15] |
RobertPlummer | I'm just going to edit one of the file gallery pages, and use the existing stuff. | [21:16] |
jonnyb | at least use the lib function
please :) _actionHandler_uploadFile() i think these days - via $filegallib->action_handler() sorry - make that: $filegallib->actionHandler( 'uploadFile', $uploadParams ) | [21:16] |
RobertPlummer | So does $_FILES become the actual file or just an array of file locations? | [21:23] |
There is just so much that needs to change, I'm almost at a loss.
is there a function where I can just check if a file is uploadable? then just write my own function? | [21:28] | |
jonnyb | use the actionHandler thing i think | [21:29] |
CIA-126 | tikiwiki: 03sylvieg * r33978 10/branches/7.x/templates/tiki-user_menu.tpl: [FIX]menu: a class to be able to custom the option as in the css menu | [21:31] |
jonnyb | i'd really recommend using tiki-upload_file.php if you can though | [21:31] |
RobertPlummer | So just go right below line 167 and start with my own method?
of file tiki-upload_file.php? I just want to make sure follow what you guys have done. | [21:33] |
jonnyb | why do you need a new method? | [21:34] |
*** | majmos has quit IRC (Quit: Page closed) | [21:35] |
jonnyb | maybe you just need to massage the uploadParams? | [21:35] |
RobertPlummer | Well extending is what I'd do, but there isn't anything as far as I can see to upload a file from a parameter.
Everything looks like it is file from $_FILE or directory on my system. | [21:36] |
jonnyb | you need to get $_FILES['userfiles'] set up somehow
you might be able to write to it somehow | [21:36] |
RobertPlummer | $_FILES['userfiles'] accepts directories | [21:37] |
jonnyb | (a bit hacky) | [21:37] |
RobertPlummer | I want to upload a whole file
Right? | [21:37] |
jonnyb | yup
but it's just a string really, so you can pass it in $_REQUEST and add an exception on line 2696 and set $aFiles['userfile'] to whatever works just an array need to bypass is_uploaded_file too | [21:38] |
RobertPlummer | so $aFiles['userfile'] is the actual file?
or a path? | [21:42] |
jonnyb | and move_uploaded_file on line 2847
it's an array saying where the file is etc | [21:42] |
RobertPlummer | I don't know, if you navigate through that function it really isn't designed for what we're doing.... | [21:42] |
jonnyb | also file_put_contents needs an or...
getting messy | [21:43] |
RobertPlummer | But if I start modding all that stuff, it is core.
I shouldn't mess with core stuff on an experimental, no? | [21:43] |
jonnyb | but probable better then duplicating all that code
true i think it's possible to make a form to submit the data in the usual way less mess | [21:43] |
RobertPlummer | How would you suggest?
I've tried copying the form directly, no good. | [21:47] |
jonnyb | can't you do something like: $("<form action=xx enctype=yy>).append(stuff).submit() | [21:47] |
RobertPlummer | That is what I'm doing...
Shall I commit? | [21:48] |
jonnyb | you'll need to make the <input type=file /> too | [21:48] |
RobertPlummer | ok, but that is still supposed to be a path as a value, I don't see how I gain any ground doing that. | [21:49] |
jonnyb | well, i can't get a file to open yet... might be handy :P | [21:49] |
RobertPlummer | ok | [21:49] |
jonnyb | oh right - hmm | [21:49] |
sylvieg | sylvieg not sure to follow - but will be pleased with whatver you come with - /me doing fgal tracker field and has the same problem | [21:49] |
jonnyb | hi sylvieg | [21:49] |
sylvieg | hello guys | [21:50] |
CIA-126 | tikiwiki: 03robertplummer * r33979 10/branches/7.x/ (3 files in 2 dirs): [FIX] More fixes for tiki draw | [21:50] |
RobertPlummer | Ok, clear cache, should work fine with svg images.
for viewing only, | [21:50] |
jonnyb | i'd suggest google next... | [21:51] |
RobertPlummer | hey sylvieg
I mean polom sylvieg I'm gonna get dinner on, jonny let me know if you come up with a theory. | [21:51] |
sylvieg | sylvieg is in the dark side with trackers now - doing custom code - because too painful to develop for 6 and for 7 - I hate not to commit | [21:53] |
jonnyb | sounds harsh | [21:53] |
sylvieg | btw did somebody connect a trackerfilter with the newsletter / or mail plugin ? need to connect both | [21:55] |
jonnyb | sounds like fun :P might work | [21:56] |
*** | radek82 has quit IRC (Quit: Leaving) | [21:56] |
jonnyb | RobertPlummer: http://goo.gl/jcoQZ has some promising looking hits | [22:03] |
*** | Tiki|bot has quit IRC (Ping timeout: 250 seconds)
Tiki|bot has joined #tikiwiki jonnyb has quit IRC (Quit: I am going outside... I may be some time...) | [22:04] |
..... (idle for 22mn) | ||
kit has quit IRC (Quit: Page closed) | [22:29] | |
Tiki|bot | Recent Bug: Tracker item: #3850 - - userlist wiki plugin paramaters sort and group can't be used together - http://dev.tiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=3850 | [22:38] |
*** | RobertPlummer has quit IRC (Ping timeout: 252 seconds) | [22:49] |
..... (idle for 24mn) | ||
Bernard1 | about tracker, i want to use them to display list of companies. i would like to manage data but the display should be nice (formatting, company name, bold, logo, etc). I don't want to change the rest of the tracker in the site. Is there a way to apply a specific css on a tracker plugin ? or it should be done using something else ? | [23:13] |
..... (idle for 20mn) | ||
*** | Bernard1 has quit IRC (Quit: Leaving.)
daevermann has quit IRC (Remote host closed the connection) | [23:33] |
lindonb has joined #tikiwiki | [23:42] | |
rodrigo_sampaio has quit IRC (Ping timeout: 260 seconds) | [23:54] |
←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |