←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
Who | What | When |
---|---|---|
ricks99 | joined #tikiwiki | [00:09] |
........ (idle for 38mn) | ||
Jyhem_laptop_ | joined #tikiwiki | [00:47] |
.......................................................................................................................................... (idle for 11h28mn) | ||
jonnyb | joined #tikiwiki | [12:15] |
................. (idle for 1h21mn) | ||
luciash | ¡ɯoןod
still time to commit fixes for 19.1 ? I see, it is cheduled for Monday afternoon... ok (s on my keyborad is intermittently refusing to work, orry) | [13:36] |
.................................................. (idle for 4h5mn) | ||
jonnyb | hi luciash - orry, missed your post earlier, yes, 19.1 should happen tomorrow (europe) afternoon :) | [17:44] |
luciash | hi ho jonnyb :) np
jonnyb: looking at your CSS issue now | [17:56] |
jonnyb | the jquery-ui one? thanks - it's weird (like i've forgotten how to do css ;) ) | [17:57] |
luciash | yep, do you have a demo online or should I try to reproduce somehow
ui datepicker is on tracker date field? | [18:00] |
ok, added it to my demo tracker | [18:10] | |
jonnyb | or in the calendar | [18:10] |
luciash | weird is it has border-bottom-width: 0 (why?) but that is something else
you want the background, right? | [18:10] |
jonnyb | i know, that also doesnt seem to work (and would look odd imho anyway)
the border of the selected day should be a different colour from the rest | [18:11] |
luciash | eh, it shows up here with that bottom border removed actually | [18:12] |
jonnyb | maybe background too in some themes (jquery-ui themes)
oh? | [18:12] |
luciash | using Yeti theme | [18:13] |
jonnyb | let me recheck... | [18:13] |
luciash | it applies the border-bottom-width: 0;
but background color is #fff | [18:14] |
jonnyb | actually, yes the silly no bottom border does with for me, but the colour doesn't, but now i see an error saying invalid property value: border: 1px solid #e9ecef #e9ecef #dee2e6;
only 3 colours defined maybe? yup, that's it | [18:15] |
luciash | imho the problem is that the ui-state-default should not be there when it has ui-state-active
then to override that you would need .ui-state-default.ui-state-active selector ah, dunno how it defnes these 3 colors, in the scss I see only border: 1px solid $ui-active-border-color; jonnyb: so did you found a fix? s/found/find/ | [18:17] |
jonnyb | i found the definition in vendor_bundled/vendor/twbs/bootstrap/scss/_variables.scss:630 but that's not helping much ;)
what does "!default" mean? | [18:22] |
luciash | I don't know, a nonsense?
or is it special SASS thingy? there was only !important in CS, or... ? CSS I see, it must be SCSS but that is for nav-tabs how is that related to calendar day? jonnyb: what theme are you testing with? | [18:23] |
jonnyb | bootstrap default (but have tried others)
the problem is that the syntax in the css comes out invalid - border-color: #e9ecef #e9ecef #dee2e6; is ok, but border: 1px solid #e9ecef #e9ecef #dee2e6; is not (according to Chrome and PhpStorm) | [18:30] |
luciash | it works for me in hrome code inspector, should I try on the scss and compile?
s/hrome/Chrome I must admit I do not see border: 1px solid #e9ecef #e9ecef #dee2e6; in my Chrome inspector but border: 1px solid rgba(0, 0, 0, 0.1); with Yeti theme let me swicth to default BS | [18:32] |
jonnyb | i think i have a fix... | [18:36] |
luciash | ah, I see the same with BS default theme
jonnyb: it seems Yeti has it all right but Default theme doesn't | [18:37] |
jonnyb | hmm, let me try yeti with my fix | [18:38] |
luciash | jonnyb: I think the definition of $ui-active-border-color for the default theme is wrong, but for Yeti it is OK | [18:40] |
jonnyb | aha, ok, yeti has $ui-active-border-color defined as just one colour, other themes seem to use 3 or 4 colours... | [18:40] |
luciash | yep, that is what I mean | [18:40] |
jonnyb | i reckon the no bottom border is intended for tabs, not anything else... will test before committing | [18:41] |
luciash | the other themes maybe try to have slightly different color for each side of the border
adding the fourth color for them should not hurt | [18:41] |
jonnyb | hmm, seems yeti defines normal and active as the same colour, so a bit hard to tell! :P | [18:42] |
luciash | hehe, true :) | [18:43] |
jonnyb | it doesn't matter how many colours, if there are more than one you need to use border-color explicitly (from what i can tell) | [18:43] |
luciash | jonnyb: ok, the themes who specify 3 or 4 are wrong then
maybe it was working well in LESS before but during the tranition to SCSS it was left there | [18:44] |
jonnyb | ui-tabs-active seems to be unaffected
yes, maybe - but i think Gary did a lot of overriding the jquery-ui classes to make it all look more bootstrap-like | [18:45] |
luciash | I don't understand how is your last msg related to what I said but anyway... :)
I mean if it causes errors, there should be only one color defined, or border-color used explicitly as you said | [18:51] |
jonnyb | i meant it's not just the change from bs3 (less) to bs4 (scss) that has changed | [18:54] |
luciash | sure | [18:54] |
jonnyb | while we're on this luciash, any idea what "prefers-reduced-motion" means? we seem to ahve lots of them and phpstorm shows them all to be an error | [18:55] |
luciash | I meant it was just copy-pasted but maybe not tested well with all the themes
huh? never seen that :) | [18:55] |
jonnyb | e.g. in themes/litera/css/litera.css:3828 | [18:55] |
luciash | (because I don't use PHPStorm probably) | [18:55] |
jonnyb | also themes/fivealive-lite/css/fivealive-lite.css:2482
e.g. @media screen and (prefers-reduced-motion: reduce) { | [18:55] |
luciash | hmm, sorry, must be something new
I never heard about that in CSS https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion | [18:56] |
jonnyb | me neither - it's also in yeti.css a lot
jonnyb reads | [18:58] |
luciash | it is a draft I reckon
"Media Queries Level 5" | [18:58] |
jonnyb | aha right, yes firefox and safari only | [18:59] |
luciash | supported only by few
yup yup | [18:59] |
jonnyb | seems a little risky for production/stable then? | [18:59] |
luciash | maybe BS4 guys are too enthusiastic about introducing new fancy CSS features ;)
or Gary? :) gtg, bbl bb | [18:59] |
...................................... (idle for 3h9mn) | ||
robertokir | joined #tikiwiki | [22:11] |
....... (idle for 32mn) | ||
ricks99 | joined #tikiwiki | [22:43] |
............ (idle for 59mn) | ||
robertokir | joined #tikiwiki | [23:42] |
←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |